coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[M] Change in coreboot[main]: drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC
by YH Lin (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Bob Moragues, Bora Guvendik, Cliff Huang, Hannah Williams, Jérémy Compostella, Poornima Tom, Ravishankar Sarawadi, Subrata Banik, dinesh.sharma(a)intel.com. YH Lin has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/81790?usp=email ) Change subject: drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC ...................................................................... Patch Set 3: (1 comment) File src/include/sar.h: https://review.coreboot.org/c/coreboot/+/81790/comment/ab955cee_56e440c4?us… : PS2, Line 65: __packed > any reason for using `packed`? I think this maps to the SAR file format therefore packed is needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/81790?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie76794825f1a0104d199c078aa4ffc714aa95b17 Gerrit-Change-Number: 81790 Gerrit-PatchSet: 3 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dinesh.sharma(a)intel.com Gerrit-CC: Bob Moragues <moragues(a)google.com> Gerrit-CC: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-CC: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: dinesh.sharma(a)intel.com Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Comment-Date: Wed, 26 Jun 2024 01:49:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[M] Change in coreboot[main]: drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC
by Jérémy Compostella (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Bob Moragues, Bora Guvendik, Cliff Huang, Hannah Williams, Poornima Tom, Ravishankar Sarawadi, dinesh.sharma(a)intel.com. Jérémy Compostella has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/81790?usp=email ) Change subject: drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Hi Huang, […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/81790?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie76794825f1a0104d199c078aa4ffc714aa95b17 Gerrit-Change-Number: 81790 Gerrit-PatchSet: 3 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dinesh.sharma(a)intel.com Gerrit-CC: Bob Moragues <moragues(a)google.com> Gerrit-CC: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: dinesh.sharma(a)intel.com Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Comment-Date: Wed, 26 Jun 2024 01:47:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Poornima Tom <poornima.tom(a)intel.com> Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com>

1 0

[S] Change in coreboot[main]: drivers/wifi: Support Wi-Fi 7 11be Enablement
by Jérémy Compostella (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Dinesh Sharma, Paul Menzel, Ravishankar Sarawadi. Jérémy Compostella has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/82207?usp=email ) Change subject: drivers/wifi: Support Wi-Fi 7 11be Enablement ...................................................................... Patch Set 11: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/82207?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa1482d7511f48f5138d4c68566f07ce79f37a7a Gerrit-Change-Number: 82207 Gerrit-PatchSet: 11 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 26 Jun 2024 01:46:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: drivers/wifi: Support Bluetooth Regulator Domain Settings
by Jérémy Compostella (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Subrata Banik, YH Lin. Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83200?usp=email ) Change subject: drivers/wifi: Support Bluetooth Regulator Domain Settings ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/83200?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iebe95815c944d045f4cf686abcd1874a8a45e209 Gerrit-Change-Number: 83200 Gerrit-PatchSet: 4 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 26 Jun 2024 01:46:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: lib/malloc.c: Move heap as part of BSS
by Julius Werner (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Arthur Heymans, Jakub Czapiga, Patrick Rudolph. Julius Werner has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/82421?usp=email ) Change subject: lib/malloc.c: Move heap as part of BSS ...................................................................... Patch Set 4: (1 comment) File tests/lib/malloc-test.c: https://review.coreboot.org/c/coreboot/+/82421/comment/f20553f1_50a10b24?us… : PS4, Line 34: TEST_SYMBOL(heap, _test_heap); I'm not really sure there's a point for any of these four lines in this test. TEST_SYMBOL() and TEST_REGION() are only necessary when you need to mock a particular linker script symbol name because the coreboot code under test directly accesses that symbol. In this test I think all they needed was a local byte array. And now, that you have the byte array in malloc.c already, I think the test can just use it? I think all you need to do here is have `setup_test()` reinitialize the three globals to point to the full array again. -- To view, visit https://review.coreboot.org/c/coreboot/+/82421?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I62ad87624220399796ab2f50ce398b9ed4a4b729 Gerrit-Change-Number: 82421 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 26 Jun 2024 01:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: lib/*stage_cache: Don't save BSS in stage cache
by Julius Werner (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Felix Held, Fred Reitberger, Jakub Czapiga, Jason Glenesk, Jérémy Compostella, Matt DeVillier, Patrick Rudolph, Ronak Kanabar. Julius Werner has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/82419?usp=email ) Change subject: lib/*stage_cache: Don't save BSS in stage cache ...................................................................... Patch Set 12: (3 comments) File src/include/program_loading.h: https://review.coreboot.org/c/coreboot/+/82419/comment/363587ce_1713f56c?us… : PS12, Line 106: flen prog_set_fsize? File src/lib/cbfs.c: https://review.coreboot.org/c/coreboot/+/82419/comment/76a0991d_e6f3d0f7?us… : PS12, Line 576: prog_set_area(pstage, (void *)(uintptr_t)be64toh(sattr->loadaddr), be32toh(sattr->memlen)); Unclear why you remove the line break here? It looks like it doesn't fit 96 chars... (or are we doing 100 chars now? I might have missed that memo). File src/lib/rmodule.c: https://review.coreboot.org/c/coreboot/+/82419/comment/048791a6_b54a49c3?us… : PS12, Line 71: return module->header->bss_begin; I think(?) this should technically be `module->header->bss_begin - module->header->module_link_start_address`, even though the latter may always be 0 in practice (cf. `rmodule_entry_offset()`). -- To view, visit https://review.coreboot.org/c/coreboot/+/82419?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I45404caaa6cd1bc5d19998bce4b564c939d50996 Gerrit-Change-Number: 82419 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 26 Jun 2024 01:36:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC
by Jérémy Compostella (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Bob Moragues, Bora Guvendik, Cliff Huang, Hannah Williams, Jérémy Compostella, Poornima Tom, Ravishankar Sarawadi. Jérémy Compostella has uploaded a new patch set (#3) to the change originally created by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/81790?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by Bora Guvendik, Verified+1 by build bot (Jenkins) Change subject: drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC ...................................................................... drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC Add support for the configuration of 320MHz Bandwidth per MCC based on countries. The implementation follows document #559910 Intel Connectivity Platforms BIOS Guidelines revision 8.3. BUG=b:333804562 BRANCH=firmware-rex-15709.B TEST=WBEM method is added to the CNVW device and return the data supplied by the SAR binary blob Change-Id: Ie76794825f1a0104d199c078aa4ffc714aa95b17 Signed-off-by: Poornima Tom <poornima.tom(a)intel.com> Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/drivers/wifi/generic/acpi.c M src/include/sar.h M src/vendorcode/google/chromeos/sar.c 3 files changed, 49 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/81790/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81790?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie76794825f1a0104d199c078aa4ffc714aa95b17 Gerrit-Change-Number: 81790 Gerrit-PatchSet: 3 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bob Moragues <moragues(a)google.com> Gerrit-CC: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com>

1 0

[S] Change in coreboot[main]: commonlib/device_tree: Improve node and property allocation speed
by Julius Werner (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Maximilian Brune, Patrick Rudolph, Raul Rangel, Reka Norman. Julius Werner has posted comments on this change by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/83208?usp=email ) Change subject: commonlib/device_tree: Improve node and property allocation speed ...................................................................... Patch Set 2: (1 comment) File src/commonlib/device_tree.c: https://review.coreboot.org/c/coreboot/+/83208/comment/93a726c1_cf76889b?us… : PS2, Line 37: 2000 > nit: `#define` the constants Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83208?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0f4d80a8b750febfb069b32ef47304ccecdc35af Gerrit-Change-Number: 83208 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Wed, 26 Jun 2024 01:11:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>

1 0

[S] Change in coreboot[main]: commonlib/device_tree: Improve node and property allocation speed
by Julius Werner (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Julius Werner, Maximilian Brune, Patrick Rudolph, Raul Rangel, Reka Norman. Hello Maximilian Brune, Patrick Rudolph, Raul Rangel, Reka Norman, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83208?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by Raul Rangel, Verified+1 by build bot (Jenkins) Change subject: commonlib/device_tree: Improve node and property allocation speed ...................................................................... commonlib/device_tree: Improve node and property allocation speed Now that the device tree code has been made available in libpayload, we should reintroduce the node and property allocation optimization for libpayload's memory allocator that was originally dropped when porting this code from depthcharge to coreboot. On a Qualcomm SC7180 unflattening a normal ChromeOS kernel device tree, this saves roughly ~145ms. The total scratch space used is about ~1350 nodes and ~5200 properties, so we leave a little room to grow with the constants hardcoded here. Change-Id: I0f4d80a8b750febfb069b32ef47304ccecdc35af Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/commonlib/device_tree.c 1 file changed, 41 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/83208/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/83208?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0f4d80a8b750febfb069b32ef47304ccecdc35af Gerrit-Change-Number: 83208 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: mb/google/lotso: Add hid report address for gt7986u
by Kun Liu (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Varshit Pandya. Kun Liu has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83201?usp=email ) Change subject: mb/google/lotso: Add hid report address for gt7986u ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83201/comment/e75ea59b_5fc4dbbc?us… : PS1, Line 7: lotso > "mb/google/lotso" Done https://review.coreboot.org/c/coreboot/+/83201/comment/b246232c_2f53eef1?us… : PS1, Line 10: > It would be good to mention the datasheet name and version which was used or any place from where th […] This information is provided by the manufacturer,please refer to the following comments for details https://partnerissuetracker.corp.google.com/issues/342932183#comment4 -- To view, visit https://review.coreboot.org/c/coreboot/+/83201?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I464c2691505083314528519f608108c8a31e6cc0 Gerrit-Change-Number: 83201 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Jun 2024 01:02:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit Pandya <pandyavarshit(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024