coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[S] Change in coreboot[main]: drivers/wifi: Support Wi-Fi 7 11be Enablement
by Jérémy Compostella (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Dinesh Sharma, Paul Menzel, Ravishankar Sarawadi. Jérémy Compostella has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/82207?usp=email ) Change subject: drivers/wifi: Support Wi-Fi 7 11be Enablement ...................................................................... Patch Set 11: (8 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82207/comment/64de1704_936e7586?us… : PS8, Line 12: 320 MHz > Dose Wi-Fi 7 also support other frequencies? I don't know why the 320 MHz frequency was referenced here. This feature is about overall Wi-Fi 7 (aka. 802.11be) enable/disable. Commit Message: https://review.coreboot.org/c/coreboot/+/82207/comment/f75ba460_7bde43e0?us… : PS9, Line 12: Wi-Fi 7 320 MHz is disabled default in some countries like Japan. > 802. […] Done https://review.coreboot.org/c/coreboot/+/82207/comment/28391023_8e6453dd?us… : PS9, Line 13: enable > enable/disable? Done https://review.coreboot.org/c/coreboot/+/82207/comment/11d59f3d_2cf93e88?us… : PS9, Line 17: None > shouldn't this point to the rex fw branch ? Done https://review.coreboot.org/c/coreboot/+/82207/comment/699ea9c7_b3334666?us… : PS9, Line 18: To test on Rex/Screebo > can you please add a meaningful TEST statement ? like how about DSD/DSM dump w/w. […] Done File src/drivers/wifi/generic/acpi.c: https://review.coreboot.org/c/coreboot/+/82207/comment/cd2d039e_f95044c6?us… : PS8, Line 148: * 0 - 11BE disabled for China Mainland : * 1 - 11BE enabled for China Mainland : * : * Bit 1 : * 0 - 11BE disabled for South Korea : * 1 - 11BE enabled for South Korea > The commit message only says something about Japan. Done File src/drivers/wifi/generic/acpi.c: https://review.coreboot.org/c/coreboot/+/82207/comment/37daca57_26ac9cca?us… : PS9, Line 147: 11BE > `802. […] Done https://review.coreboot.org/c/coreboot/+/82207/comment/53137ceb_a1ab4d75?us… : PS9, Line 161: dsm_11be_enable > nit: `wifi_dsm_11be_country_enablement` Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82207?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa1482d7511f48f5138d4c68566f07ce79f37a7a Gerrit-Change-Number: 82207 Gerrit-PatchSet: 11 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 25 Jun 2024 17:54:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: drivers/wifi: Support Wi-Fi 7 11be Enablement
by Jérémy Compostella (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Dinesh Sharma, Jérémy Compostella, Ravishankar Sarawadi. Jérémy Compostella has uploaded a new patch set (#11) to the change originally created by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/82207?usp=email ) Change subject: drivers/wifi: Support Wi-Fi 7 11be Enablement ...................................................................... drivers/wifi: Support Wi-Fi 7 11be Enablement Add 802.11be (aka. Wi-Fi 7) enable/disable support based on document 559910 Intel Connectivity Platforms BIOS_Guidelines revision 8.3. There are countries where Wi-Fi 7 should be disabled by default. This adds capability for OEM to enable or disable by updating the board specific Specific Absorption Rate (SAR) binary. BUG=b:348345300 BRANCH=firmware-rex-15709.B TEST=SSDT dump shows that the _DSM method returns the value supplied by the SAR binary for function 12 Change-Id: Ifa1482d7511f48f5138d4c68566f07ce79f37a7a Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/drivers/wifi/generic/acpi.c M src/include/sar.h 2 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/82207/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/82207?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa1482d7511f48f5138d4c68566f07ce79f37a7a Gerrit-Change-Number: 82207 Gerrit-PatchSet: 11 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>

1 0

[S] Change in coreboot[main]: drivers/wifi: Support Wi-Fi 7 11be Enablement
by Subrata Banik (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Dinesh Sharma, Jérémy Compostella, Ravishankar Sarawadi. Subrata Banik has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/82207?usp=email ) Change subject: drivers/wifi: Support Wi-Fi 7 11be Enablement ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82207?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa1482d7511f48f5138d4c68566f07ce79f37a7a Gerrit-Change-Number: 82207 Gerrit-PatchSet: 10 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 17:51:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/google/fatcat: Add minimal code support for fatcat
by Nick Vaccaro (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Subrata Banik, YH Lin. Nick Vaccaro has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83197?usp=email ) Change subject: mb/google/fatcat: Add minimal code support for fatcat ...................................................................... Patch Set 5: (2 comments) Patchset: PS5: Looks good, just one last nit. File src/mainboard/google/fatcat/variants/fatcat/gpio.c: https://review.coreboot.org/c/coreboot/+/83197/comment/7ca973fc_e1e1dbdf?us… : PS5, Line 10: #include <boardid.h> NIT - This should be between line 12 and 13 (i.e. above <soc/gpio.h>) -- To view, visit https://review.coreboot.org/c/coreboot/+/83197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad78aec51b2f0f240991c9c35842764a60be988e Gerrit-Change-Number: 83197 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 17:50:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: drivers/wifi: Support Wi-Fi 7 11be Enablement
by Jérémy Compostella (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Dinesh Sharma, Jérémy Compostella, Ravishankar Sarawadi. Jérémy Compostella has uploaded a new patch set (#10) to the change originally created by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/82207?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: drivers/wifi: Support Wi-Fi 7 11be Enablement ...................................................................... drivers/wifi: Support Wi-Fi 7 11be Enablement Add 802.11be (aka. Wi-Fi 7) enable/disable support based on document 559910 Intel Connectivity Platforms BIOS_Guidelines revision 8.3. There are countries where Wi-Fi 7 should be disabled by default. This adds capability for OEM to enable or disable by updating SAR binary. BUG=b:348345300 BRANCH=firmware-rex-15709.B TEST=SSDT dump shows that the _DSM method returns the value supplied by the SAR binary for function 12 Change-Id: Ifa1482d7511f48f5138d4c68566f07ce79f37a7a Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> --- M src/drivers/wifi/generic/acpi.c M src/include/sar.h 2 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/82207/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/82207?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa1482d7511f48f5138d4c68566f07ce79f37a7a Gerrit-Change-Number: 82207 Gerrit-PatchSet: 10 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp: Add acpigen_write_pci_root_port
by Patrick Rudolph (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Arthur Heymans, Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Shuo Liu, Tim Chu. Patrick Rudolph has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/82252?usp=email ) Change subject: soc/intel/xeon_sp: Add acpigen_write_pci_root_port ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/xeon_sp/acpi.c: https://review.coreboot.org/c/coreboot/+/82252/comment/e28ce2e7_51632f32?us… : PS4, Line 194: acpigen_write_BBN missing _SEG -- To view, visit https://review.coreboot.org/c/coreboot/+/82252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I434fea7880a463c2027abfa22ba2b3bb985815c0 Gerrit-Change-Number: 82252 Gerrit-PatchSet: 4 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 16:30:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/brask/var/bujia: enable UART1
by Subrata Banik (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Shon Wang. Subrata Banik has posted comments on this change by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/83205?usp=email ) Change subject: mb/google/brask/var/bujia: enable UART1 ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83205/comment/aede0801_4e60e9e9?us… : PS4, Line 7: enable UART1 Configure Serial IO UARTs Mode This patch configures Serial IO UARTs mode as below UART0 and UART1 in PCI mode and keep UART2 disable as per hardware design. -- To view, visit https://review.coreboot.org/c/coreboot/+/83205?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5617331aaf505b97e25a717b145fb70dc53f5a38 Gerrit-Change-Number: 83205 Gerrit-PatchSet: 4 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 16:12:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/brox/lotso: Add Fn key scancode
by Karthik Ramasubramanian (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Shelley Chen, Wen Zhang. Karthik Ramasubramanian has posted comments on this change by Wen Zhang. ( https://review.coreboot.org/c/coreboot/+/83204?usp=email ) Change subject: mb/google/brox/lotso: Add Fn key scancode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83204?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I999627f0ea9db1d79376150a04920ac877a48447 Gerrit-Change-Number: 83204 Gerrit-PatchSet: 1 Gerrit-Owner: Wen Zhang <zhangwen6(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wen Zhang <zhangwen6(a)huaqin.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 16:11:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: lotso: Update board type to BOARD_TYPE_ULT_ULX
by Felix Held (Code Review) 25 Jun '24

25 Jun '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83191?usp=email ) Change subject: lotso: Update board type to BOARD_TYPE_ULT_ULX ...................................................................... lotso: Update board type to BOARD_TYPE_ULT_ULX Update board type to BOARD_TYPE_ULT_ULX BUG=b:348147663 BRANCH=none TEST=Built and compare the results of command 'dmidecode --type 17 | grep Speed' [Before] Speed: 8400 MT/s Configured Memory Speed: 6400 MT/s [After] Speed: 8400 MT/s Configured Memory Speed: 5200 MT/s Change-Id: I049d7c19424f41e83480f4b80bafd6ef8b9e30f6 Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83191 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Shelley Chen <shchen(a)google.com> Reviewed-by: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brox/variants/lotso/memory.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Shelley Chen: Looks good to me, approved build bot (Jenkins): Verified Jian Tong: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/brox/variants/lotso/memory.c b/src/mainboard/google/brox/variants/lotso/memory.c index 0765d5e..84b9f4a 100644 --- a/src/mainboard/google/brox/variants/lotso/memory.c +++ b/src/mainboard/google/brox/variants/lotso/memory.c @@ -3,6 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <gpio.h> +#include <soc/romstage.h> static const struct mb_cfg baseboard_memcfg = { .type = MEM_TYPE_LP5X, @@ -64,6 +65,8 @@ .LpDdrDqDqsReTraining = 1, .ect = 1, /* Early Command Training */ + + .UserBd = BOARD_TYPE_ULT_ULX, }; const struct mb_cfg *variant_memory_params(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/83191?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I049d7c19424f41e83480f4b80bafd6ef8b9e30f6 Gerrit-Change-Number: 83191 Gerrit-PatchSet: 3 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: lotso: Add hid report address for gt7986u
by Karthik Ramasubramanian (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Kun Liu. Karthik Ramasubramanian has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83201?usp=email ) Change subject: lotso: Add hid report address for gt7986u ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83201?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I464c2691505083314528519f608108c8a31e6cc0 Gerrit-Change-Number: 83201 Gerrit-PatchSet: 1 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 15:44:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024