coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[L] Change in coreboot[main]: mb/google/fatcat: Add minimal code support for fatcat
by Subrata Banik (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Nick Vaccaro, YH Lin. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83197?usp=email ) Change subject: mb/google/fatcat: Add minimal code support for fatcat ...................................................................... Patch Set 4: (11 comments) File src/mainboard/google/fatcat/Kconfig: https://review.coreboot.org/c/coreboot/+/83197/comment/af306157_8cc8b698?us… : PS3, Line 52: select GBB_FLAG_FORCE_DEV_BOOT_USB > NIT - Given these are alphabetical, this should be moved up 1 line Acknowledged https://review.coreboot.org/c/coreboot/+/83197/comment/e3ad6113_32b2838a?us… : PS3, Line 94: DRIVER_TPM_I2C_ADDR > NIT - should this be above DRIVER_TPM_I2C_BUS to be in alphabetical order, or should it stay here gi […] Acknowledged File src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/ec.h: https://review.coreboot.org/c/coreboot/+/83197/comment/e580d7c9_22397060?us… : PS3, Line 8: #include <baseboard/gpio.h> > NIT - alphabetically, this should be first Done https://review.coreboot.org/c/coreboot/+/83197/comment/d7b7f1d6_f88a4e2a?us… : PS3, Line 11: (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_LOW) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX)) > NIT - should these be alphabetized? Acknowledged https://review.coreboot.org/c/coreboot/+/83197/comment/a627ff36_f08a5f09?us… : PS3, Line 47: EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_SHUTDOWN)) : > NIT - alphabetize? Acknowledged https://review.coreboot.org/c/coreboot/+/83197/comment/29fc8c77_3eec7528?us… : PS3, Line 51: EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_HANG_DETECT)) > NIT - alphabetize? Acknowledged https://review.coreboot.org/c/coreboot/+/83197/comment/d40e0dab_1a2206f1?us… : PS3, Line 55: (EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_SHUTDOWN) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_SHUTDOWN) |\ : EC_HOST_EVENT_MASK(EC_HOST_EVENT_PANIC)) > NIT - alphabetize? Acknowledged https://review.coreboot.org/c/coreboot/+/83197/comment/163693a0_29fd6ee3?us… : PS3, Line 68: #define EC_ENABLE_LID_SWITCH : #define EC_ENABLE_WAKE_PIN GPE_EC_WAKE : /* Enable EC backed PD MCU device in ACPI */ : #define EC_ENABLE_PD_MCU_DEVICE : #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ : #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ : #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ : : #define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */ : #define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ > NIT - alphabetize? Acknowledged File src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/gpio.h: https://review.coreboot.org/c/coreboot/+/83197/comment/8f9e5612_1c18d2f7?us… : PS3, Line 11: #define GPIO_PCH_WP 0 : /* GPIO IRQ for tight timestamps / wake support */ : #define EC_SYNC_IRQ 0 : /* eSPI virtual wire reporting */ : #define EC_SCI_GPI 0 : > NIT - alphabetize? Acknowledged File src/mainboard/google/fatcat/variants/baseboard/fatcat/memory.c: https://review.coreboot.org/c/coreboot/+/83197/comment/0efdeb69_fbf0839b?us… : PS3, Line 22: variant_is_half_populated(void) : { > Does PTL have two channels? My understanding is that WCL will only have 1, in which case I wouldn't think this would be needed, but not sure about PTL. PTL has two channel same as MTL File src/mainboard/google/fatcat/variants/fatcat/gpio.c: https://review.coreboot.org/c/coreboot/+/83197/comment/8cea4440_62bdcf2a?us… : PS3, Line 12: #include <soc/gpio.h> > NIT - alphabetize Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/83197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad78aec51b2f0f240991c9c35842764a60be988e Gerrit-Change-Number: 83197 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 11:13:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com>

1 0

[L] Change in coreboot[main]: mb/google/fatcat: Add minimal code support for fatcat
by Subrata Banik (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Subrata Banik, YH Lin. Hello Nick Vaccaro, YH Lin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83197?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by YH Lin, Verified+1 by build bot (Jenkins) Change subject: mb/google/fatcat: Add minimal code support for fatcat ...................................................................... mb/google/fatcat: Add minimal code support for fatcat This patch adds initial code block required to build google/fatcat board with Intel Meteor Lake Silicon. Later after the initial board power-on is successful, we shall switch to Panther Lake silicon to build the google/fatcat reference design. BUG=b:347669091 TEST=Able to build the google/fatcat and able to hit power-on reset using Intel Meteor Lake SoC platform. Change-Id: Iad78aec51b2f0f240991c9c35842764a60be988e Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- A src/mainboard/google/fatcat/Kconfig A src/mainboard/google/fatcat/Kconfig.name A src/mainboard/google/fatcat/Makefile.mk A src/mainboard/google/fatcat/board_info.txt A src/mainboard/google/fatcat/bootblock.c A src/mainboard/google/fatcat/chromeos-debug-fsp.fmd A src/mainboard/google/fatcat/chromeos.c A src/mainboard/google/fatcat/chromeos.fmd A src/mainboard/google/fatcat/dsdt.asl A src/mainboard/google/fatcat/ec.c A src/mainboard/google/fatcat/mainboard.c A src/mainboard/google/fatcat/romstage.c A src/mainboard/google/fatcat/smihandler.c A src/mainboard/google/fatcat/variants/baseboard/fatcat/Makefile.mk A src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb A src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/ec.h A src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/gpio.h A src/mainboard/google/fatcat/variants/baseboard/fatcat/memory.c A src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h A src/mainboard/google/fatcat/variants/fatcat/Makefile.mk A src/mainboard/google/fatcat/variants/fatcat/gpio.c A src/mainboard/google/fatcat/variants/fatcat/include/variant/ec.h A src/mainboard/google/fatcat/variants/fatcat/include/variant/gpio.h 23 files changed, 713 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/83197/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/83197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad78aec51b2f0f240991c9c35842764a60be988e Gerrit-Change-Number: 83197 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>

1 0

[L] Change in coreboot[main]: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
by Ronald Claveau (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Felix Singer. Ronald Claveau has posted comments on this change by Ronald Claveau. ( https://review.coreboot.org/c/coreboot/+/83104?usp=email ) Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge) ...................................................................... Patch Set 13: (1 comment) This change is ready for review. File src/mainboard/dell/xps_8300/devicetree.cb: https://review.coreboot.org/c/coreboot/+/83104/comment/c41fe9a4_9544d9e0?us… : PS12, Line 5: device domain 0x0 on > All of the devices use the same subsystem ID. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83104?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059 Gerrit-Change-Number: 83104 Gerrit-PatchSet: 13 Gerrit-Owner: Ronald Claveau <sousmangoosta(a)aliel.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:28:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[L] Change in coreboot[main]: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
by Ronald Claveau (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Elyes Haouas, Paul Menzel, Ronald Claveau. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83104?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge) ...................................................................... mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge) Mainboard is identified as 0Y2MRG. The version tested is with Nvidia dGPU (gfx 560ti). The flash is a 4MiB Winbond W25Q32BVSIG. It can be flashed internally with flashrom. Add a strap on the service mode pin of the mainboard for internal flash. Tested working: - SeaBIOS - All USB ports - SATA - dGPU - Ethernet - Environnement control - GPIOs - S3 Sleep mode Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059 Signed-off-by: Ronald Claveau <sousmangoosta(a)aliel.fr> --- A src/mainboard/dell/xps_8300/Kconfig A src/mainboard/dell/xps_8300/Kconfig.name A src/mainboard/dell/xps_8300/Makefile.mk A src/mainboard/dell/xps_8300/acpi/ec.asl A src/mainboard/dell/xps_8300/acpi/platform.asl A src/mainboard/dell/xps_8300/acpi/superio.asl A src/mainboard/dell/xps_8300/board.fmd A src/mainboard/dell/xps_8300/board_info.txt A src/mainboard/dell/xps_8300/devicetree.cb A src/mainboard/dell/xps_8300/dsdt.asl A src/mainboard/dell/xps_8300/early_init.c A src/mainboard/dell/xps_8300/gpio.c A src/mainboard/dell/xps_8300/hda_verb.c A src/mainboard/dell/xps_8300/mainboard.c A src/mainboard/dell/xps_8300/smihandler.c 15 files changed, 480 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83104/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/83104?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059 Gerrit-Change-Number: 83104 Gerrit-PatchSet: 13 Gerrit-Owner: Ronald Claveau <sousmangoosta(a)aliel.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Ronald Claveau <sousmangoosta(a)aliel.fr>

1 0

[M] Change in coreboot[main]: Wifi: Support 320Mhz Bandwidth Enablement per MCC
by Subrata Banik (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Bob Moragues, Bora Guvendik, Cliff Huang, Hannah Williams, Poornima Tom, Ravishankar Sarawadi. Subrata Banik has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/81790?usp=email ) Change subject: Wifi: Support 320Mhz Bandwidth Enablement per MCC ...................................................................... Patch Set 2: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81790/comment/a2fc2962_6d4e52b6?us… : PS2, Line 7: Wifi driver/wifi? File src/drivers/wifi/generic/acpi.c: https://review.coreboot.org/c/coreboot/+/81790/comment/4889658e_39304f71?us… : PS2, Line 486: WiFi320MHzPerMcc avoid camelcase File src/include/sar.h: https://review.coreboot.org/c/coreboot/+/81790/comment/f299209c_a094616a?us… : PS2, Line 64: WiFi320MHzPerMcc avoid camel case https://review.coreboot.org/c/coreboot/+/81790/comment/c514ebea_05c3a708?us… : PS2, Line 65: __packed any reason for using `packed`? File src/vendorcode/google/chromeos/sar.c: https://review.coreboot.org/c/coreboot/+/81790/comment/bebf59a4_61e0cd45?us… : PS2, Line 219: * don't delete please -- To view, visit https://review.coreboot.org/c/coreboot/+/81790?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie76794825f1a0104d199c078aa4ffc714aa95b17 Gerrit-Change-Number: 81790 Gerrit-PatchSet: 2 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bob Moragues <moragues(a)google.com> Gerrit-CC: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:25:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb: source site-local mainboard Kconfig.name and Kconfig files
by Michael Niewöhner (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Alexander Couzens, David Hendricks, Evgeny Zinoviev, Felix Held, Felix Singer, Jeremy Soller, Jonathon Hall, Martin L Roth, Matt DeVillier, Michał Żygowski, Philipp Hug, Piotr Król, Ron Minnich, Sean Rhodes, Tim Crawford. Michael Niewöhner has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83119?usp=email ) Change subject: mb: source site-local mainboard Kconfig.name and Kconfig files ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: Not sure if I really like having a such include/source just PS2: > I like this idea, but does it need to be applied broadly? Maybe it's best to keep the added `source` […] Not sure if I really like having a such include/source for every board while maybe just a few really use it -- To view, visit https://review.coreboot.org/c/coreboot/+/83119?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4106fea7197c979e6648ebbbbaa107070c916727 Gerrit-Change-Number: 83119 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:24:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com>

1 0

[S] Change in coreboot[main]: drivers/wifi: Support Wi-Fi 7 11be Enablement
by Subrata Banik (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Dinesh Sharma, Jérémy Compostella, Ravishankar Sarawadi. Subrata Banik has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/82207?usp=email ) Change subject: drivers/wifi: Support Wi-Fi 7 11be Enablement ...................................................................... Patch Set 9: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82207/comment/06425a37_be45aff2?us… : PS9, Line 12: Wi-Fi 7 320 MHz is disabled default in some countries like Japan. 802.11be ? https://review.coreboot.org/c/coreboot/+/82207/comment/f0fb8608_e3b3480f?us… : PS9, Line 13: enable enable/disable? https://review.coreboot.org/c/coreboot/+/82207/comment/9fac7336_d79b65ea?us… : PS9, Line 17: None shouldn't this point to the rex fw branch ? https://review.coreboot.org/c/coreboot/+/82207/comment/ca31714d_b0c1717e?us… : PS9, Line 18: To test on Rex/Screebo can you please add a meaningful TEST statement ? like how about DSD/DSM dump w/w.o this CL? -- To view, visit https://review.coreboot.org/c/coreboot/+/82207?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa1482d7511f48f5138d4c68566f07ce79f37a7a Gerrit-Change-Number: 82207 Gerrit-PatchSet: 9 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:21:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: drivers/wifi: Support Wi-Fi 7 11be Enablement
by Subrata Banik (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Dinesh Sharma, Jérémy Compostella, Ravishankar Sarawadi. Subrata Banik has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/82207?usp=email ) Change subject: drivers/wifi: Support Wi-Fi 7 11be Enablement ...................................................................... Patch Set 9: (2 comments) File src/drivers/wifi/generic/acpi.c: https://review.coreboot.org/c/coreboot/+/82207/comment/4fb85749_b625b9af?us… : PS9, Line 147: 11BE `802.11be` where `be` should be in smaller case https://review.coreboot.org/c/coreboot/+/82207/comment/a47a34f6_4479b418?us… : PS9, Line 161: dsm_11be_enable nit: `wifi_dsm_11be_country_enablement` -- To view, visit https://review.coreboot.org/c/coreboot/+/82207?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa1482d7511f48f5138d4c68566f07ce79f37a7a Gerrit-Change-Number: 82207 Gerrit-PatchSet: 9 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:19:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: skl mainboards/dt: Move serirq setting into LPC device scope
by Michael Niewöhner (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Felix Singer, Frans Hendriks, Jeremy Soller, Jonathon Hall, Michał Żygowski, Piotr Król, Tim Crawford. Michael Niewöhner has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83188?usp=email ) Change subject: skl mainboards/dt: Move serirq setting into LPC device scope ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83188?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I84da5365907664ce223dec4adb22a8f1a6e2a144 Gerrit-Change-Number: 83188 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:14:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: skl mainboards/dt: Move SATA related settings into SATA device scope
by Michael Niewöhner (Code Review) 25 Jun '24

25 Jun '24

Attention is currently required from: Felix Singer, Frans Hendriks, Jonathon Hall, Michał Żygowski, Nico Huber, Piotr Król. Michael Niewöhner has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83179?usp=email ) Change subject: skl mainboards/dt: Move SATA related settings into SATA device scope ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83179?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I50706d7a077767d2295d6d5f209c30109d607277 Gerrit-Change-Number: 83179 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:14:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024