coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[S] Change in coreboot[main]: acpi: Add support for DRHD size reporting
by Angel Pons (Code Review) 26 Jun '24

26 Jun '24

Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, Cliff Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jeff Daly, Jincheng Li, Johnny Lin, Jonathan Zhang, Kapil Porwal, Lance Zhao, Lean Sheng Tan, Nick Vaccaro, Nico Huber, Patrick Rudolph, Paul Menzel, Sean Rhodes, Shuo Liu, Subrata Banik, Tarun, Tim Chu, Tim Wawrzynczak, Vanessa Eusebio, Werner Zeh. Angel Pons has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/82429?usp=email ) Change subject: acpi: Add support for DRHD size reporting ...................................................................... Patch Set 17: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82429?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49dd5de2eca257a5f6240e36d05755cabca96d1c Gerrit-Change-Number: 82429 Gerrit-PatchSet: 17 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Comment-Date: Wed, 26 Jun 2024 08:45:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: treewide/azalia: Make codec_detect() common and use it
by Angel Pons (Code Review) 26 Jun '24

26 Jun '24

1 0

[M] Change in coreboot[main]: treewide/azalia: Make codec_detect() common and use it
by Angel Pons (Code Review) 26 Jun '24

26 Jun '24

Attention is currently required from: Elyes Haouas, Eric Lai. Angel Pons has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83214?usp=email ) Change subject: treewide/azalia: Make codec_detect() common and use it ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83214/comment/d1a2f82b_3bfbf1f6?us… : PS3, Line 7: treewide/azalia: Make codec_detect() common and use it I'd appreciate if you could make three separate changes, as this one removes three implementations at once: - sb/intel/i82801ix - sb/intel/lynxpoint - soc/intel/common (used by Bay Trail) File src/device/azalia_device.c: https://review.coreboot.org/c/coreboot/+/83214/comment/a71231b7_0df1e033?us… : PS3, Line 55: i82801ix does more stuff here: ``` if (azalia_enter_reset(base) < 0) goto no_codec; ``` https://review.coreboot.org/c/coreboot/+/83214/comment/f16e45fe_30bf1979?us… : PS3, Line 59: if (CONFIG(AZALIA_LOCK_DOWN_R_WO_GCAP)) { This is only selected through `SOC_INTEL_COMMON_BLOCK_HDA_VERB`, which is only selected by some mainboards. File src/southbridge/intel/lynxpoint/Kconfig: https://review.coreboot.org/c/coreboot/+/83214/comment/ecc703f3_710a085a?us… : PS3, Line 10: select AZALIA_LOCK_DOWN_R_WO_GCAP This is wrong. The original code is also wrong. CB:51645 is what actually locks GCAP on these platforms. -- To view, visit https://review.coreboot.org/c/coreboot/+/83214?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib7be3c0b1a90a766c5bb0f950c4dbac31a87c20f Gerrit-Change-Number: 83214 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 26 Jun 2024 08:43:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: treewide/azalia: Make codec_detect() common and use it
by Elyes Haouas (Code Review) 26 Jun '24

26 Jun '24

Attention is currently required from: Angel Pons, Elyes Haouas, Eric Lai. Hello Angel Pons, Eric Lai, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83214?usp=email to look at the new patch set (#4). Change subject: treewide/azalia: Make codec_detect() common and use it ...................................................................... treewide/azalia: Make codec_detect() common and use it Change-Id: Ib7be3c0b1a90a766c5bb0f950c4dbac31a87c20f Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/device/azalia_device.c M src/include/device/azalia_device.h M src/northbridge/intel/haswell/minihd.c M src/soc/intel/baytrail/hda.c M src/soc/intel/broadwell/minihd.c M src/soc/intel/broadwell/pch/Makefile.mk M src/soc/intel/broadwell/pch/hda.c M src/soc/intel/common/hda_verb.c M src/soc/intel/common/hda_verb.h M src/southbridge/intel/i82801gx/azalia.c M src/southbridge/intel/i82801ix/azalia.c M src/southbridge/intel/i82801jx/azalia.c M src/southbridge/intel/ibexpeak/azalia.c M src/southbridge/intel/lynxpoint/Kconfig M src/southbridge/intel/lynxpoint/Makefile.mk M src/southbridge/intel/lynxpoint/azalia.c D src/southbridge/intel/lynxpoint/hda_verb.c D src/southbridge/intel/lynxpoint/hda_verb.h 18 files changed, 8 insertions(+), 210 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/83214/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/83214?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib7be3c0b1a90a766c5bb0f950c4dbac31a87c20f Gerrit-Change-Number: 83214 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: mb/google/lotso: Add hid report address for gt7986u
by Kun Liu (Code Review) 26 Jun '24

26 Jun '24

Kun Liu has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83201?usp=email ) Change subject: mb/google/lotso: Add hid report address for gt7986u ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83201/comment/6388a4d1_0901db40?us… : PS2, Line 9: Add hid report address for gt7986u > add . […] Done https://review.coreboot.org/c/coreboot/+/83201/comment/45cbf871_6a69530c?us… : PS2, Line 13: TEST=Verify touchscreen work normal > add . […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83201?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I464c2691505083314528519f608108c8a31e6cc0 Gerrit-Change-Number: 83201 Gerrit-PatchSet: 3 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 26 Jun 2024 08:35:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/lotso: Add hid report address for gt7986u
by Kun Liu (Code Review) 26 Jun '24

26 Jun '24

Attention is currently required from: Kun Liu. Hello Eric Lai, Karthik Ramasubramanian, Shelley Chen, Varshit Pandya, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83201?usp=email to look at the new patch set (#3). Change subject: mb/google/lotso: Add hid report address for gt7986u ...................................................................... mb/google/lotso: Add hid report address for gt7986u Add hid report address for gt7986u. BUG=b:342932183 BRANCH=None TEST=Verify touchscreen work normal. Change-Id: I464c2691505083314528519f608108c8a31e6cc0 Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brox/variants/lotso/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/83201/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/83201?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I464c2691505083314528519f608108c8a31e6cc0 Gerrit-Change-Number: 83201 Gerrit-PatchSet: 3 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[master]: device/azalia_device.c: Add option to lock down GCAP
by Angel Pons (Code Review) 26 Jun '24

26 Jun '24

Attention is currently required from: Patrick Rudolph. Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/50794?usp=email ) Change subject: device/azalia_device.c: Add option to lock down GCAP ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/50794/comment/ef3c8f29_50c4befe?us… : PS8, Line 9: On Intel 6-series PCHs Did I ever make a change to select this option on these PCHs? -- To view, visit https://review.coreboot.org/c/coreboot/+/50794?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70bab20816fb6c0bf7bff35c3d2f5828cd96172d Gerrit-Change-Number: 50794 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Wed, 26 Jun 2024 08:33:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: soc/intel: Adapt crashlog IP to also support 64-bit
by Subrata Banik (Code Review) 26 Jun '24

26 Jun '24

Attention is currently required from: Angel Pons, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Nick Vaccaro, Paul Menzel, Pratikkumar V Prajapati, Sowmya Aralguppe, Tarun. Subrata Banik has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83106?usp=email ) Change subject: soc/intel: Adapt crashlog IP to also support 64-bit ...................................................................... Patch Set 22: (2 comments) Patchset: PS22: > I think it's fine but I don't know crashlog well enough to be sure. Thanks Angel PS22: @sowmya.aralguppe@intel.com: can you please check below prints w/ and w/o your CL? w/o this CL ``` [DEBUG] m_cpu_crashLog_size : 0x4000 bytes [DEBUG] CPU crashLog present. [DEBUG] CPU crash data size: 0x4000 bytes in 0x5 region(s). [DEBUG] CPU crashlog storage_off asserted [DEBUG] CPU crashlog re_arm asserted [DEBUG] crashlog size:pmc-0x1050, cpu-0x4000 [DEBUG] crashlog size:pmc-0x1050, cpu-0x4000 [DEBUG] crashlog size:pmc-0x1050, cpu-0x4000 ``` w/ this CL ``` [DEBUG] m_cpu_crashLog_size : 0x824C bytes [DEBUG] CPU crashLog present. [DEBUG] CPU crash data size: 0x824C bytes in 0x5 region(s). [DEBUG] CPU crashlog storage_off asserted [DEBUG] CPU crashlog re_arm asserted [DEBUG] crashlog size:pmc-0x1050, cpu-0x824c [DEBUG] crashlog size:pmc-0x1050, cpu-0x824c [DEBUG] crashlog size:pmc-0x1050, cpu-0x824c ``` I felt the CPU crashlog size is always higher with your CL. -- To view, visit https://review.coreboot.org/c/coreboot/+/83106?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I552257d3770abb409e2dcd8a13392506b5e7feb7 Gerrit-Change-Number: 83106 Gerrit-PatchSet: 22 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Jun 2024 08:32:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[M] Change in coreboot[main]: treewide/azalia: Make codec_detect() common and use it
by Elyes Haouas (Code Review) 26 Jun '24

26 Jun '24

Attention is currently required from: Angel Pons, Elyes Haouas, Eric Lai. Hello Angel Pons, Eric Lai, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83214?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Eric Lai Change subject: treewide/azalia: Make codec_detect() common and use it ...................................................................... treewide/azalia: Make codec_detect() common and use it Change-Id: Ib7be3c0b1a90a766c5bb0f950c4dbac31a87c20f Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/device/azalia_device.c M src/include/device/azalia_device.h M src/northbridge/intel/haswell/minihd.c M src/soc/intel/baytrail/hda.c M src/soc/intel/broadwell/minihd.c M src/soc/intel/broadwell/pch/Makefile.mk M src/soc/intel/broadwell/pch/hda.c M src/soc/intel/common/hda_verb.c M src/soc/intel/common/hda_verb.h M src/southbridge/intel/i82801ix/azalia.c M src/southbridge/intel/lynxpoint/Kconfig M src/southbridge/intel/lynxpoint/Makefile.mk M src/southbridge/intel/lynxpoint/azalia.c D src/southbridge/intel/lynxpoint/hda_verb.c D src/southbridge/intel/lynxpoint/hda_verb.h 15 files changed, 8 insertions(+), 135 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/83214/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/83214?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib7be3c0b1a90a766c5bb0f950c4dbac31a87c20f Gerrit-Change-Number: 83214 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: mb/google/brox/var/lotso: GPP_B14 used for buzzer
by Eric Lai (Code Review) 26 Jun '24

26 Jun '24

Attention is currently required from: Jian Tong, Kun Liu, Subrata Banik. Eric Lai has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/83147?usp=email ) Change subject: mb/google/brox/var/lotso: GPP_B14 used for buzzer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83147?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If924f9f27f229420e78015f418a97b2d5daf62e5 Gerrit-Change-Number: 83147 Gerrit-PatchSet: 1 Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 26 Jun 2024 08:21:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024