coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[XS] Change in coreboot[main]: lotso: Add hid report address for gt7986u
by Jian Tong (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Kun Liu, Paul Menzel. Jian Tong has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83139?usp=email ) Change subject: lotso: Add hid report address for gt7986u ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83139?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8b18e0a2925e6fd36e3a470bde9910661b7558b8 Gerrit-Change-Number: 83139 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 21 Jun 2024 03:08:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/brya/var/nivviks: Add fw_config fields for wifi6 and wifi7
by Eric Lai (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Poornima Tom, Poornima Tom, Pranava Y N, V Sowmya. Eric Lai has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83074?usp=email ) Change subject: mb/google/brya/var/nivviks: Add fw_config fields for wifi6 and wifi7 ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83074/comment/9505123d_c3a92347?us… : PS6, Line 7: brya > Directory path is still `src/mainboard/google/brya/variants/nivviks` but we decide put the really mb name instead the path, since many projects under brya -- To view, visit https://review.coreboot.org/c/coreboot/+/83074?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4b218f772405bdb1b741b4d5e640d7b4f145cd76 Gerrit-Change-Number: 83074 Gerrit-PatchSet: 6 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 21 Jun 2024 02:46:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>

1 0

[S] Change in coreboot[main]: util/ifdtool: Add Panther Lake platform support under IFDv2
by Eric Lai (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Dinesh Gehlot, Lean Sheng Tan, Pranava Y N, Saurabh Mishra, Subrata Banik. Eric Lai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83141?usp=email ) Change subject: util/ifdtool: Add Panther Lake platform support under IFDv2 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83141?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id261898932f11f4c9066453bce18fd889996e171 Gerrit-Change-Number: 83141 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 21 Jun 2024 02:45:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: lotso: Add hid report address for gt7986u
by Kun Liu (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Jian Tong, Paul Menzel. Kun Liu has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83139?usp=email ) Change subject: lotso: Add hid report address for gt7986u ...................................................................... Patch Set 2: (1 comment) This change is ready for review. File src/mainboard/google/brox/variants/lotso/overridetree.cb: https://review.coreboot.org/c/coreboot/+/83139/comment/b0ed6b53_4b3cc435?us… : PS2, Line 374: register "hid_report_addr" = "0x22c8c" > Please document in the commit message, where you got this value from. This value is provided by the manufacturer,please refer to the following comments for details https://partnerissuetracker.corp.google.com/issues/342932183#comment4 -- To view, visit https://review.coreboot.org/c/coreboot/+/83139?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8b18e0a2925e6fd36e3a470bde9910661b7558b8 Gerrit-Change-Number: 83139 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 21 Jun 2024 02:20:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/google/trulo/var/orisa: Configure SEN_MODE_EC_PCH_INT_ODL as input
by Kapil Porwal (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Amanda Hwang, Dinesh Gehlot, Nick Vaccaro, Subrata Banik. Kapil Porwal has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83142?usp=email ) Change subject: mb/google/trulo/var/orisa: Configure SEN_MODE_EC_PCH_INT_ODL as input ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83142?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic678b77e5489f56d8ff92b265a6ca5852c0f7e8d Gerrit-Change-Number: 83142 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 21 Jun 2024 02:13:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8188: Respect ARM64_BL31_OPTEE_WITH_SMC option
by Yu-Ping Wu (Code Review) 20 Jun '24

20 Jun '24

Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83128?usp=email ) Change subject: soc/mediatek/mt8188: Respect ARM64_BL31_OPTEE_WITH_SMC option ...................................................................... soc/mediatek/mt8188: Respect ARM64_BL31_OPTEE_WITH_SMC option Since BL31_MAKEARGS is already handled in arm64/Makefile.mk, remove the duplication from mt8188/Makefile.mk. In addition, reserve the memory range for running OP-TEE only if ARM64_BL31_OPTEE_WITH_SMC is enabled. BUG=b:347851571 TEST=emerge-geralt coreboot BRANCH=geralt Change-Id: I88a9a07a685a6c9fe9739b6101ccb8a5ce23fd8b Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83128 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- M src/soc/mediatek/mt8188/Makefile.mk M src/soc/mediatek/mt8188/soc.c 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Julius Werner: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/soc/mediatek/mt8188/Makefile.mk b/src/soc/mediatek/mt8188/Makefile.mk index 11c3ca88..f67c827 100644 --- a/src/soc/mediatek/mt8188/Makefile.mk +++ b/src/soc/mediatek/mt8188/Makefile.mk @@ -59,9 +59,7 @@ ramstage-y += ../common/tps65132s.c ramstage-y += ../common/usb.c usb.c -BL31_MAKEARGS += PLAT=mt8188 SPD=opteed -BL31_MAKEARGS += OPTEE_ALLOW_SMC_LOAD=1 PLAT_XLAT_TABLES_DYNAMIC=1 -BL31_MAKEARGS += CROS_WIDEVINE_SMC=1 +BL31_MAKEARGS += PLAT=mt8188 CPPFLAGS_common += -Isrc/soc/mediatek/mt8188/include CPPFLAGS_common += -Isrc/soc/mediatek/common/dp/include diff --git a/src/soc/mediatek/mt8188/soc.c b/src/soc/mediatek/mt8188/soc.c index e7124ba..f2911ae 100644 --- a/src/soc/mediatek/mt8188/soc.c +++ b/src/soc/mediatek/mt8188/soc.c @@ -21,7 +21,8 @@ { if (CONFIG(MTK_DFD)) bootmem_add_range(DFD_DUMP_ADDRESS, DFD_DUMP_SIZE, BM_MEM_RESERVED); - bootmem_add_range(OPTEE_ADDRESS, OPTEE_SIZE, BM_MEM_RESERVED); + if (CONFIG(ARM64_BL31_OPTEE_WITH_SMC)) + bootmem_add_range(OPTEE_ADDRESS, OPTEE_SIZE, BM_MEM_RESERVED); } static void soc_read_resources(struct device *dev) -- To view, visit https://review.coreboot.org/c/coreboot/+/83128?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I88a9a07a685a6c9fe9739b6101ccb8a5ce23fd8b Gerrit-Change-Number: 83128 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: arch/arm64: Add Kconfig option ARM64_BL31_OPTEE_WITH_SMC
by Yu-Ping Wu (Code Review) 20 Jun '24

20 Jun '24

Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83111?usp=email ) Change subject: arch/arm64: Add Kconfig option ARM64_BL31_OPTEE_WITH_SMC ...................................................................... arch/arm64: Add Kconfig option ARM64_BL31_OPTEE_WITH_SMC Add a new Kconfig option ARM64_BL31_OPTEE_WITH_SMC to control whether to build the OP-TEE dispatcher for BL31. This config also enables the BL31 build option OPTEE_ALLOW_SMC_LOAD, which allows loading the OP-TEE image after boot via a Secure Monitor Call (SMC). For ChromeOS devices, CROS_WIDEVINE_SMC is also enabled to allow passing secrets from firmware to OP-TEE. BUG=b:347851571 TEST=emerge-geralt coreboot BRANCH=geralt Change-Id: I4dcf82d47b537146d71ce3cd2050ec597ed0734f Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83111 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- M src/arch/arm64/Kconfig M src/arch/arm64/Makefile.mk 2 files changed, 18 insertions(+), 0 deletions(-) Approvals: Julius Werner: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/arch/arm64/Kconfig b/src/arch/arm64/Kconfig index 2d71067..af5050b 100644 --- a/src/arch/arm64/Kconfig +++ b/src/arch/arm64/Kconfig @@ -46,6 +46,15 @@ default n depends on ARCH_RAMSTAGE_ARM64 && ARM64_CURRENT_EL = 3 +config ARM64_BL31_OPTEE_WITH_SMC + bool "Build OP-TEE dispatcher for BL31 and allow loading via an SMC" + default n + depends on ARM64_USE_ARM_TRUSTED_FIRMWARE + help + This option adds support for building the OP-TEE Secure Payload Dispatcher + (SPD) for BL31, and allows loading the OP-TEE image via a Secure Monitor Call + (SMC). + config ARM64_BL31_EXTERNAL_FILE string "Path to external BL31.ELF (leave empty to build from source)" depends on ARM64_USE_ARM_TRUSTED_FIRMWARE diff --git a/src/arch/arm64/Makefile.mk b/src/arch/arm64/Makefile.mk index 6499283..cb43897 100644 --- a/src/arch/arm64/Makefile.mk +++ b/src/arch/arm64/Makefile.mk @@ -185,6 +185,15 @@ # Set a consistent build timestamp: the same coreboot has BL31_MAKEARGS += BUILD_MESSAGE_TIMESTAMP='"$(shell sed -n 's/^.define COREBOOT_BUILD\>.*"$.*$".*/\1/p' $(obj)/build.h)"' +ifeq ($(CONFIG_ARM64_BL31_OPTEE_WITH_SMC),y) +BL31_MAKEARGS += SPD=opteed +BL31_MAKEARGS += OPTEE_ALLOW_SMC_LOAD=1 +BL31_MAKEARGS += PLAT_XLAT_TABLES_DYNAMIC=1 +ifeq ($(CONFIG_CHROMEOS),y) +BL31_MAKEARGS += CROS_WIDEVINE_SMC=1 +endif +endif # CONFIG_ARM64_BL31_OPTEE_WITH_SMC + BL31_CFLAGS := -fno-pic -fno-stack-protector -Wno-deprecated-declarations -Wno-unused-function BL31_LDFLAGS := -Wl,--emit-relocs -- To view, visit https://review.coreboot.org/c/coreboot/+/83111?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4dcf82d47b537146d71ce3cd2050ec597ed0734f Gerrit-Change-Number: 83111 Gerrit-PatchSet: 5 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: drivers/{crb,pc80/tpm}: Drop conflicting tpm_config_t typedef
by Angel Pons (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Christian Walter, Felix Held, Jérémy Compostella, Michał Żygowski. Angel Pons has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/82057?usp=email ) Change subject: drivers/{crb,pc80/tpm}: Drop conflicting tpm_config_t typedef ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82057/comment/c5ee6ad5_8df8177b?us… : PS2, Line 7: drivers/crb,pc80/tpm: Add crb and pc80 prefixes to chip configs > Done *marks as resolved* -- To view, visit https://review.coreboot.org/c/coreboot/+/82057?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id41717e265362303a17745303a907c9c8f4f4e12 Gerrit-Change-Number: 82057 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 01:28:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[S] Change in coreboot[main]: libpayload/include/endian.h: Add 64 bit enc/dec
by Angel Pons (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Felix Held, Felix Singer, Jakub Czapiga, Julius Werner, Lean Sheng Tan, Martin L Roth, Maximilian Brune. Angel Pons has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83082?usp=email ) Change subject: libpayload/include/endian.h: Add 64 bit enc/dec ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83082?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5dba9a7f41147a511ba1250786e7c51ce623e70a Gerrit-Change-Number: 83082 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 00:55:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: libpayload/include/endian.h: Add 64 bit enc/dec
by Maximilian Brune (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Angel Pons, Felix Held, Felix Singer, Jakub Czapiga, Julius Werner, Lean Sheng Tan, Martin L Roth. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83082?usp=email ) Change subject: libpayload/include/endian.h: Add 64 bit enc/dec ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83082/comment/6b61b029_02eee8a2?us… : PS1, Line 9: be64dec > Could you add the rest of the 64-bit functions, please? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83082?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5dba9a7f41147a511ba1250786e7c51ce623e70a Gerrit-Change-Number: 83082 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 00:20:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024