coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[XS] Change in coreboot[main]: mb/google/nissa/var/nivviks: Update config for CNVi
by Poornima Tom (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Poornima Tom, Subrata Banik, V Sowmya. Hello Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, Subrata Banik, V Sowmya, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83138?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+2 by Kapil Porwal, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) Change subject: mb/google/nissa/var/nivviks: Update config for CNVi ...................................................................... mb/google/nissa/var/nivviks: Update config for CNVi Add wake configuration and set 'add_acpi_dma_property'=true for CNVi. BUG=b:345596420 BRANCH=NONE TEST=SSDT dump showed below: Scope (\_SB.PCI0.RP01.WF00) { Name (_PRW, Package (0x02) // _PRW: Power Resources for Wake { 0x23, 0x03 }) Name (_DSD, Package (0x02) // _DSD: Device-Specific Data { ToUUID ("70d24161-6dd5-4c9e-8070-705531292865"), Package (0x01) { Package (0x02) { "DmaProperty", One } } Change-Id: If04539fe8dceb5c2edfc06a324ede11147b78b6d Signed-off-by: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> --- M src/mainboard/google/brya/variants/nivviks/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/83138/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/83138?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If04539fe8dceb5c2edfc06a324ede11147b78b6d Gerrit-Change-Number: 83138 Gerrit-PatchSet: 4 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/nivviks: Add fw_config fields for wifi6 and wifi7
by Poornima Tom (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, Pranava Y N, Subrata Banik, V Sowmya. Hello Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, Pranava Y N, Subrata Banik, V Sowmya, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83074?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by Eric Lai, Code-Review+2 by Kapil Porwal, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) Change subject: mb/google/nissa/var/nivviks: Add fw_config fields for wifi6 and wifi7 ...................................................................... mb/google/nissa/var/nivviks: Add fw_config fields for wifi6 and wifi7 Add a new fw config field for wifi category as WIFI_6, which is CNVi based and WIFI_7, which is PCIe based. Also, enable WIFI_6 for existing CNVi based wifi port as well as bluetooth port. BUG=b:345596420 BRANCH=NONE TEST=Verified Wifi6 module detection Change-Id: I4b218f772405bdb1b741b4d5e640d7b4f145cd76 Signed-off-by: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> --- M src/mainboard/google/brya/variants/nivviks/overridetree.cb 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/83074/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/83074?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4b218f772405bdb1b741b4d5e640d7b4f145cd76 Gerrit-Change-Number: 83074 Gerrit-PatchSet: 7 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/nivviks: Enable wifi7 on pcie root port
by Poornima Tom (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, Subrata Banik, V Sowmya. Hello Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, Subrata Banik, V Sowmya, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83075?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+2 by Kapil Porwal, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: mb/google/nissa/var/nivviks: Enable wifi7 on pcie root port ...................................................................... mb/google/nissa/var/nivviks: Enable wifi7 on pcie root port Enable pcie based, discreete wifi7 on root port4. BUG=b:345596420 BRANCH=NONE TEST=Verified Wifi7 module detection based on cbi settings Change-Id: I8c2f4a750a1cb00c587bce21bc83ee583d0f4341 Signed-off-by: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> --- M src/mainboard/google/brya/variants/nivviks/overridetree.cb 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/83075/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/83075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c2f4a750a1cb00c587bce21bc83ee583d0f4341 Gerrit-Change-Number: 83075 Gerrit-PatchSet: 7 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/nivviks: Enable Bluetooth for PCIE
by Poornima Tom (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, Poornima Tom, Subrata Banik, V Sowmya. Hello Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, Subrata Banik, V Sowmya, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83076?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-Review+2 by Eric Lai, Code-Review+2 by Kapil Porwal, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: mb/google/nissa/var/nivviks: Enable Bluetooth for PCIE ...................................................................... mb/google/nissa/var/nivviks: Enable Bluetooth for PCIE PCIe based Bluetooth is on port8. This cl enables bluetooth for PCIe based Wifi7 module. BUG=b:345596420 BRANCH=NONE TEST=With proper FW config enabled, BT gets detected on port8 Change-Id: I989cf6122f2555cc89f622e4ce5d21b574d0458e Signed-off-by: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> --- M src/mainboard/google/brya/variants/nivviks/overridetree.cb 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/83076/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/83076?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I989cf6122f2555cc89f622e4ce5d21b574d0458e Gerrit-Change-Number: 83076 Gerrit-PatchSet: 8 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/nivviks: Enable PCIe Wifi GPIOs based on fw_config
by Poornima Tom (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, Subrata Banik, V Sowmya. Hello Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, Subrata Banik, V Sowmya, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83077?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code-Review+1 by Eric Lai, Code-Review+2 by Kapil Porwal, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) Change subject: mb/google/nissa/var/nivviks: Enable PCIe Wifi GPIOs based on fw_config ...................................................................... mb/google/nissa/var/nivviks: Enable PCIe Wifi GPIOs based on fw_config PCIe based GPIOs of Wifi7 module are enabled based on firmware config. BUG=b:345596420 BRANCH=NONE TEST= Based on fw config configured, wifi6 or wifi7 along with bluetooth ports are detected. Change-Id: If0584e91b5143c6df742961657d242c046409b3a Signed-off-by: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> --- M src/mainboard/google/brya/variants/nivviks/fw_config.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/83077/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/83077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0584e91b5143c6df742961657d242c046409b3a Gerrit-Change-Number: 83077 Gerrit-PatchSet: 11 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[S] Change in coreboot[main]: mb/google/brya: Create tereid variant
by Paul Menzel (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Nick Vaccaro, V Sowmya. Paul Menzel has posted comments on this change by V Sowmya. ( https://review.coreboot.org/c/coreboot/+/83145?usp=email ) Change subject: mb/google/brya: Create tereid variant ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83145/comment/02bb84d8_d4ca48a4?us… : PS2, Line 9: lake Lake https://review.coreboot.org/c/coreboot/+/83145/comment/054e440b_ef77eff0?us… : PS2, Line 9: lake Ditto. -- To view, visit https://review.coreboot.org/c/coreboot/+/83145?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I052c3ba93d00e2df7e205c3127210bacaa956ca0 Gerrit-Change-Number: 83145 Gerrit-PatchSet: 2 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 21 Jun 2024 08:12:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/brya: Create tereid variant
by Subrata Banik (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Nick Vaccaro, Paul Menzel, V Sowmya. Subrata Banik has posted comments on this change by V Sowmya. ( https://review.coreboot.org/c/coreboot/+/83145?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/brya: Create tereid variant ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83145/comment/e5d635b5_15758363?us… : PS2, Line 9: This patch creates a new tereid variant, which is a Twin lake platform. This variant uses Nereid board mounted with the Twin lake SOC and hence the plan is to reuse the existing nereid variant code. wrap up text -- To view, visit https://review.coreboot.org/c/coreboot/+/83145?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I052c3ba93d00e2df7e205c3127210bacaa956ca0 Gerrit-Change-Number: 83145 Gerrit-PatchSet: 2 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 21 Jun 2024 07:54:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/brya: Create tereid variant
by V Sowmya (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Nick Vaccaro, Paul Menzel. V Sowmya has posted comments on this change by V Sowmya. ( https://review.coreboot.org/c/coreboot/+/83145?usp=email ) Change subject: mb/google/brya: Create tereid variant ...................................................................... Patch Set 2: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83145/comment/e9c7bca5_2d817df9?us… : PS1, Line 7: a > Remove. Done https://review.coreboot.org/c/coreboot/+/83145/comment/2487c14c_a442a6b0?us… : PS1, Line 9: Twinlake > Twin Lake Done https://review.coreboot.org/c/coreboot/+/83145/comment/9629acb6_dec5a868?us… : PS1, Line 11: Twinlake > Twin Lake Done https://review.coreboot.org/c/coreboot/+/83145/comment/1146c065_7b90d524?us… : PS1, Line 9: This patch creates a new tereid variant, which is a Twinlake : platform. This variant uses Nivviks board mounted with the : Twinlake SOC and hence the plan is to reuse the existing : nivviks variant code. > Please use 72 characters per line. Done https://review.coreboot.org/c/coreboot/+/83145/comment/1422b89b_f4353132?us… : PS1, Line 15: Genearte > Generate Done https://review.coreboot.org/c/coreboot/+/83145/comment/23edcbce_638e89da?us… : PS1, Line 15: TEST= Genearte > Please remove the space after =. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83145?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I052c3ba93d00e2df7e205c3127210bacaa956ca0 Gerrit-Change-Number: 83145 Gerrit-PatchSet: 2 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 21 Jun 2024 07:51:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: mb/google/brya: Create tereid variant
by V Sowmya (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Nick Vaccaro, V Sowmya. Hello Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83145?usp=email to look at the new patch set (#2). Change subject: mb/google/brya: Create tereid variant ...................................................................... mb/google/brya: Create tereid variant This patch creates a new tereid variant, which is a Twin lake platform. This variant uses Nereid board mounted with the Twin lake SOC and hence the plan is to reuse the existing nereid variant code. BUG=b:346442939 TEST=Generate the Tereid firmware builds and verify with boot check. Change-Id: I052c3ba93d00e2df7e205c3127210bacaa956ca0 Signed-off-by: Sowmya V <v.sowmya(a)intel.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/83145/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83145?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I052c3ba93d00e2df7e205c3127210bacaa956ca0 Gerrit-Change-Number: 83145 Gerrit-PatchSet: 2 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[L] Change in coreboot[main]: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
by Ronald Claveau (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Felix Singer, Paul Menzel. Ronald Claveau has posted comments on this change by Ronald Claveau. ( https://review.coreboot.org/c/coreboot/+/83104?usp=email ) Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge) ...................................................................... Patch Set 12: (8 comments) Patchset: PS12: Thanks for your review, I understand more and more File src/mainboard/dell/xps_8300/devicetree.cb: https://review.coreboot.org/c/coreboot/+/83104/comment/ff2b7790_f06c20e5?us… : PS11, Line 1: chip northbridge/intel/sandybridge > ```suggestion […] Done https://review.coreboot.org/c/coreboot/+/83104/comment/1aa7ea86_793e4596?us… : PS11, Line 6: register "gen1_dec" = "0x003c0a01" > Move this into the scope of the LPC controller Done https://review.coreboot.org/c/coreboot/+/83104/comment/695a3222_9f7a86b3?us… : PS11, Line 8: register "sata_interface_speed_support" = "0x3" : > Move these into the scope of the SATA controller Done https://review.coreboot.org/c/coreboot/+/83104/comment/53ad017b_ecbe69f8?us… : PS11, Line 30: # Management Engine Interface 1 > These comments duplicate the alias names. Remove them as well. Done https://review.coreboot.org/c/coreboot/+/83104/comment/8c6324ba_59f5d305?us… : PS11, Line 33: off > Remove all devices which are turned off. They are disabled in the chipset devicetree. Done File src/mainboard/dell/xps_8300/dsdt.asl: https://review.coreboot.org/c/coreboot/+/83104/comment/fc30fa48_0f9ae07b?us… : PS11, Line 5: > nit: Remove one blank line Done File src/mainboard/dell/xps_8300/early_init.c: https://review.coreboot.org/c/coreboot/+/83104/comment/78c899df_8842624d?us… : PS11, Line 3: > nit: Remove one blank line Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83104?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059 Gerrit-Change-Number: 83104 Gerrit-PatchSet: 12 Gerrit-Owner: Ronald Claveau <sousmangoosta(a)aliel.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 21 Jun 2024 07:36:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024