coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[XS] Change in coreboot[main]: acpigen_ps2_keybd: Support a Do Not Disturb key
by Aseda Aboagye (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Aseda Aboagye, Cliff Huang, Lance Zhao, Tim Wawrzynczak. Hello Caveh Jalali, Cliff Huang, Forest Mittelberg, Lance Zhao, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82997?usp=email to look at the new patch set (#3). Change subject: acpigen_ps2_keybd: Support a Do Not Disturb key ...................................................................... acpigen_ps2_keybd: Support a Do Not Disturb key This commit simply adds support for a Do Not Disturb key. HUTRR94 added support for a new usage titled "System Do Not Disturb" which toggles a system-wide Do Not Disturb setting. BUG=b:342467600 TEST=Build and flash a board that generates a scancode for a Do Not Disturb key. Verify that KEY_DO_NOT_DISTURB is generated in the Linux kernel with patches[0] that add this new event code using `evtest`. [0] - https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?id=22d6… Change-Id: I26e719bbde5106305282fe43dd15833a3e48e41e Signed-off-by: Aseda Aboagye <aaboagye(a)google.com> --- M src/acpi/acpigen_ps2_keybd.c M src/ec/google/chromeec/ec_acpi.c M src/include/acpi/acpigen_ps2_keybd.h 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/82997/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/82997?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I26e719bbde5106305282fe43dd15833a3e48e41e Gerrit-Change-Number: 82997 Gerrit-PatchSet: 3 Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>

1 0

[L] Change in coreboot[main]: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
by Felix Singer (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Paul Menzel, Ronald Claveau. Felix Singer has posted comments on this change by Ronald Claveau. ( https://review.coreboot.org/c/coreboot/+/83104?usp=email ) Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge) ...................................................................... Patch Set 12: (7 comments) File src/mainboard/dell/xps_8300/devicetree.cb: https://review.coreboot.org/c/coreboot/+/83104/comment/8ac4b72a_644bad36?us… : PS11, Line 1: chip northbridge/intel/sandybridge > ```suggestion […] Done https://review.coreboot.org/c/coreboot/+/83104/comment/97207727_aa497562?us… : PS11, Line 6: register "gen1_dec" = "0x003c0a01" > Move this into the scope of the LPC controller Done https://review.coreboot.org/c/coreboot/+/83104/comment/65f9af9a_0aac2e19?us… : PS11, Line 8: register "sata_interface_speed_support" = "0x3" : > Move these into the scope of the SATA controller Done https://review.coreboot.org/c/coreboot/+/83104/comment/3c1b78c6_ecec6cf0?us… : PS11, Line 30: # Management Engine Interface 1 > These comments duplicate the alias names. Remove them as well. Done https://review.coreboot.org/c/coreboot/+/83104/comment/aa1d92b1_4b63464c?us… : PS11, Line 33: off > Remove all devices which are turned off. They are disabled in the chipset devicetree. Done File src/mainboard/dell/xps_8300/dsdt.asl: https://review.coreboot.org/c/coreboot/+/83104/comment/9edbdd9d_e5197c51?us… : PS11, Line 5: > nit: Remove one blank line Done File src/mainboard/dell/xps_8300/early_init.c: https://review.coreboot.org/c/coreboot/+/83104/comment/deb1b014_97539e07?us… : PS11, Line 3: > nit: Remove one blank line Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83104?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059 Gerrit-Change-Number: 83104 Gerrit-PatchSet: 12 Gerrit-Owner: Ronald Claveau <sousmangoosta(a)aliel.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ronald Claveau <sousmangoosta(a)aliel.fr> Gerrit-Comment-Date: Thu, 20 Jun 2024 22:42:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[M] Change in coreboot[main]: soc/intel: Enable crashlog IP for both 32-bit and 64-bit architectures
by Angel Pons (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Pratikkumar V Prajapati, Sowmya Aralguppe, Subrata Banik, Tarun. Angel Pons has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83106?usp=email ) Change subject: soc/intel: Enable crashlog IP for both 32-bit and 64-bit architectures ...................................................................... Patch Set 19: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83106/comment/2a09481d_b71ca4ff?us… : PS19, Line 14: tested Could you please elaborate on what was tested? As per my review comments, I doubt that reading CrashLog data from the PMC works on the current patchset. File src/soc/intel/common/block/crashlog/crashlog.c: https://review.coreboot.org/c/coreboot/+/83106/comment/f6381258_59323eb6?us… : PS15, Line 321: sizeof(uintptr_t) > > I have changed dest_addr to be u32 *,IMHO that is right solution > > isn't `u32 *dest_addr` also 8-byte in 64-bit arch? It's a pointer type, but what matters is that it points to 32-bit values. Incrementing the pointer will increment it by `sizeof(u32)`. What I prefer in these cases is to make the pointer const (`u32 *const dest_addr`) and treat it like an array (`dest_addr[i]`). > if we decide to do DW by DW copy then we need to ensure that both src and dest addr are getting incremented by 4-bytes post copy. > > Looking at `dest_addr` i felt this is okay as the declaration and increment both would be 4-bytes irrespective of 32-bit vs 64bit arch. > > but looks like `src_addr` is not using fixed data type. > > 32-bit systems: uintptr_t is 32 bits (4 bytes) > 64-bit systems: uintptr_t is 64 bits (8 bytes) > > Let's say src_addr initially holds the value 0x1000. > > 32-bit: After src_addr += sizeof(uintptr_t);, it will hold the value 0x1004. > 64-bit: After src_addr += sizeof(uintptr_t);, it will hold the value 0x1008. > > can you please fix this problem? +1, my original comment still applies. This needs to use 32-bit accesses because it's reading from the PMC's address space. -- To view, visit https://review.coreboot.org/c/coreboot/+/83106?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I552257d3770abb409e2dcd8a13392506b5e7feb7 Gerrit-Change-Number: 83106 Gerrit-PatchSet: 19 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 22:36:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: include/device_tree.h: Fix function name fdt_node_name
by Felix Singer (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Maximilian Brune. Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83084?usp=email ) Change subject: include/device_tree.h: Fix function name fdt_node_name ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Good question. There is another implementation in src/lib/device_tree.c. […] Sorry, I was confused... I had something else in mind. I don't know. That's concerning, yes. -- To view, visit https://review.coreboot.org/c/coreboot/+/83084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I527146df26264a0c3af1ad01c21644d751b80236 Gerrit-Change-Number: 83084 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 22:34:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[XS] Change in coreboot[main]: include/device_tree.h: Fix function name fdt_node_name
by Felix Singer (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Maximilian Brune. Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83084?usp=email ) Change subject: include/device_tree.h: Fix function name fdt_node_name ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > Okay but then why doesn't the build fail? This should've resulted in an undefined reference linker e […] Good question. There is another implementation in src/lib/device_tree.c. Maybe that one is used? I didn't look into the build artifacts. File src/include/device_tree.h: https://review.coreboot.org/c/coreboot/+/83084/comment/f278ddd1_d9681eef?us… : PS1, Line 130: int fdt_next_node_name(const void *blob, uint32_t node_offset, const char **name); The exact same function declaration is here. -- To view, visit https://review.coreboot.org/c/coreboot/+/83084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I527146df26264a0c3af1ad01c21644d751b80236 Gerrit-Change-Number: 83084 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 22:29:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[M] Change in coreboot[main]: region: Turn region_end() into an inclusive region_last()
by Julius Werner (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Jakub Czapiga, Jérémy Compostella, Nico Huber, Werner Zeh. Julius Werner has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/79946?usp=email ) Change subject: region: Turn region_end() into an inclusive region_last() ...................................................................... Patch Set 7: Code-Review+2 (1 comment) File src/commonlib/region.c: https://review.coreboot.org/c/coreboot/+/79946/comment/809fc0ef_3341705b?us… : PS5, Line 16: if (region_last(c) < region_offset(p)) > Restored the original check. […] Yeah let's just take this overlap check out then when the API already guarantees that regions cannot overlap. -- To view, visit https://review.coreboot.org/c/coreboot/+/79946?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4bd6eced638745b7e845504da74542e4220554a Gerrit-Change-Number: 79946 Gerrit-PatchSet: 7 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 21:53:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[M] Change in coreboot[main]: region: Introduce region_create() functions
by Julius Werner (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Andrey Petrov, Felix Singer, Jérémy Compostella, Martin L Roth, Nico Huber, Ronak Kanabar. Julius Werner has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/79905?usp=email ) Change subject: region: Introduce region_create() functions ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4ae3e6274c981c9ab4fb1263c2a72fa68ef1c32b Gerrit-Change-Number: 79905 Gerrit-PatchSet: 7 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 21:45:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: include/device_tree.h: Fix function name fdt_node_name
by Julius Werner (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Felix Singer, Maximilian Brune. Julius Werner has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83084?usp=email ) Change subject: include/device_tree.h: Fix function name fdt_node_name ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Jenkins only does build tests. […] Okay but then why doesn't the build fail? This should've resulted in an undefined reference linker error for `fdt_node_name()` (because the prototype was still there but the definition was already renamed). -- To view, visit https://review.coreboot.org/c/coreboot/+/83084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I527146df26264a0c3af1ad01c21644d751b80236 Gerrit-Change-Number: 83084 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 21:44:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[L] Change in coreboot[main]: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
by Ronald Claveau (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Paul Menzel, Ronald Claveau. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83104?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge) ...................................................................... mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge) Mainboard is identified as 0Y2MRG. The version tested is with Nvidia dGPU (gfx 560ti). The flash is a 4MiB Winbond W25Q32BVSIG. It can be flashed internally with flashrom. Add a strap on the service mode pin of the mainboard for internal flash. Tested working: - SeaBIOS - All USB ports - SATA - dGPU - Ethernet WIP/Not working: Implement ITE support especially for power led and S3 support. Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059 Signed-off-by: Ronald Claveau <sousmangoosta(a)aliel.fr> --- A src/mainboard/dell/xps_8300/Kconfig A src/mainboard/dell/xps_8300/Kconfig.name A src/mainboard/dell/xps_8300/Makefile.mk A src/mainboard/dell/xps_8300/acpi/ec.asl A src/mainboard/dell/xps_8300/acpi/platform.asl A src/mainboard/dell/xps_8300/acpi/superio.asl A src/mainboard/dell/xps_8300/board_info.txt A src/mainboard/dell/xps_8300/devicetree.cb A src/mainboard/dell/xps_8300/dsdt.asl A src/mainboard/dell/xps_8300/early_init.c A src/mainboard/dell/xps_8300/gpio.c A src/mainboard/dell/xps_8300/hda_verb.c A src/mainboard/dell/xps_8300/mainboard.c 13 files changed, 387 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83104/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/83104?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059 Gerrit-Change-Number: 83104 Gerrit-PatchSet: 12 Gerrit-Owner: Ronald Claveau <sousmangoosta(a)aliel.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ronald Claveau <sousmangoosta(a)aliel.fr>

1 0

[S] Change in coreboot[main]: drivers/wifi: Support Wi-Fi 7 11be Enablement
by Paul Menzel (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Dinesh Sharma, Ravishankar Sarawadi, Ravishankar Sarawadi. Paul Menzel has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/82207?usp=email ) Change subject: drivers/wifi: Support Wi-Fi 7 11be Enablement ...................................................................... Patch Set 8: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82207/comment/d4c70a12_e59984ba?us… : PS8, Line 12: 320 MHz Dose Wi-Fi 7 also support other frequencies? File src/drivers/wifi/generic/acpi.c: https://review.coreboot.org/c/coreboot/+/82207/comment/61223eb6_13668d4e?us… : PS8, Line 148: * 0 - 11BE disabled for China Mainland : * 1 - 11BE enabled for China Mainland : * : * Bit 1 : * 0 - 11BE disabled for South Korea : * 1 - 11BE enabled for South Korea The commit message only says something about Japan. -- To view, visit https://review.coreboot.org/c/coreboot/+/82207?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa1482d7511f48f5138d4c68566f07ce79f37a7a Gerrit-Change-Number: 82207 Gerrit-PatchSet: 8 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 21:15:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024