coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[S] Change in coreboot[main]: treewide: Move device_tree to commonlib
by Julius Werner (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Alper Nebi Yasak, Felix Held, Felix Singer, Jakub Czapiga, Maximilian Brune, Philipp Hug, Ron Minnich. Julius Werner has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/77970?usp=email ) Change subject: treewide: Move device_tree to commonlib ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/77970?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I990d74d9fff06b17ec8a6ee962955e4b0df8b907 Gerrit-Change-Number: 77970 Gerrit-PatchSet: 10 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 20 Jun 2024 21:14:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: acpigen_ps2_keybd: Support an Accessibility key
by Paul Menzel (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Aseda Aboagye, Cliff Huang, Forest Mittelberg, Lance Zhao, Tim Wawrzynczak. Paul Menzel has posted comments on this change by Aseda Aboagye. ( https://review.coreboot.org/c/coreboot/+/82996?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: acpigen_ps2_keybd: Support an Accessibility key ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82996/comment/f2ab2c2b_1d4a09ed?us… : PS2, Line 9: This commit simply adds support Add support … https://review.coreboot.org/c/coreboot/+/82996/comment/2301aa25_730fc816?us… : PS2, Line 16: evtest Paste the relevant output? -- To view, visit https://review.coreboot.org/c/coreboot/+/82996?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc639b37e89ec251f55859331ab5c2f4b2b45a7d Gerrit-Change-Number: 82996 Gerrit-PatchSet: 2 Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 21:07:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/brya: Create a tereid variant
by Paul Menzel (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Nick Vaccaro, Subrata Banik, V Sowmya. Paul Menzel has posted comments on this change by V Sowmya. ( https://review.coreboot.org/c/coreboot/+/83145?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/brya: Create a tereid variant ...................................................................... Patch Set 1: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83145/comment/b7a87682_723187bb?us… : PS1, Line 7: a Remove. https://review.coreboot.org/c/coreboot/+/83145/comment/6f6a9843_e4259708?us… : PS1, Line 9: Twinlake Twin Lake https://review.coreboot.org/c/coreboot/+/83145/comment/9327d161_f593960b?us… : PS1, Line 11: Twinlake Twin Lake https://review.coreboot.org/c/coreboot/+/83145/comment/2b004cb1_28b3ce99?us… : PS1, Line 9: This patch creates a new tereid variant, which is a Twinlake : platform. This variant uses Nivviks board mounted with the : Twinlake SOC and hence the plan is to reuse the existing : nivviks variant code. Please use 72 characters per line. https://review.coreboot.org/c/coreboot/+/83145/comment/488a740b_9c1a8337?us… : PS1, Line 15: TEST= Genearte Please remove the space after =. https://review.coreboot.org/c/coreboot/+/83145/comment/55b9727e_1d6c667f?us… : PS1, Line 15: Genearte Generate -- To view, visit https://review.coreboot.org/c/coreboot/+/83145?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I052c3ba93d00e2df7e205c3127210bacaa956ca0 Gerrit-Change-Number: 83145 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 20 Jun 2024 21:05:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: include/device_tree.h: Fix function name fdt_node_name
by Felix Singer (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Maximilian Brune. Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83084?usp=email ) Change subject: include/device_tree.h: Fix function name fdt_node_name ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > It's concerning that this got merged, does Jenkins not test a configuration with this code enabled? […] Jenkins only does build tests. Two boards are build-tested with `PAYLOAD_FIT_SUPPORT` enabled, which pulls in this code. ``` configs/config.emulation_qemu_aarch64_fit_support_timestamps 8:CONFIG_PAYLOAD_FIT_SUPPORT=y configs/config.cavium_cn8100_sff_evb_bdk_verbose_fit_payload_support 10:CONFIG_PAYLOAD_FIT_SUPPORT=y ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/83084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I527146df26264a0c3af1ad01c21644d751b80236 Gerrit-Change-Number: 83084 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 20:53:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[XS] Change in coreboot[main]: acpigen_ps2_keybd: Support a Do Not Disturb key
by Paul Menzel (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Aseda Aboagye, Cliff Huang, Lance Zhao, Tim Wawrzynczak. Paul Menzel has posted comments on this change by Aseda Aboagye. ( https://review.coreboot.org/c/coreboot/+/82997?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: acpigen_ps2_keybd: Support a Do Not Disturb key ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82997/comment/62206179_fbd6700e?us… : PS2, Line 15: Linux : kernel with patches Please reference the patches. -- To view, visit https://review.coreboot.org/c/coreboot/+/82997?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I26e719bbde5106305282fe43dd15833a3e48e41e Gerrit-Change-Number: 82997 Gerrit-PatchSet: 2 Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 20:43:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: soc/intel: Enable crashlog IP for both 32-bit and 64-bit architectures
by Paul Menzel (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Angel Pons, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Pratikkumar V Prajapati, Sowmya Aralguppe, Tarun. Paul Menzel has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83106?usp=email ) Change subject: soc/intel: Enable crashlog IP for both 32-bit and 64-bit architectures ...................................................................... Patch Set 19: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83106/comment/f3714801_6d19068f?us… : PS19, Line 7: Enable crashlog IP for both 32-bit and 64-bit architectures Adapt crashlog IP to also support 64-bit https://review.coreboot.org/c/coreboot/+/83106/comment/318b45f9_aecb9aa2?us… : PS19, Line 10: future generation SoCs Aren’t current SoCs already 64-bit? https://review.coreboot.org/c/coreboot/+/83106/comment/a60e2c4b_e3333134?us… : PS19, Line 12: Please summarize the changes. Mainly casts? … -- To view, visit https://review.coreboot.org/c/coreboot/+/83106?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I552257d3770abb409e2dcd8a13392506b5e7feb7 Gerrit-Change-Number: 83106 Gerrit-PatchSet: 19 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 20:42:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: include/device_tree.h: Fix function name fdt_node_name
by Julius Werner (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Maximilian Brune. Julius Werner has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83084?usp=email ) Change subject: include/device_tree.h: Fix function name fdt_node_name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I527146df26264a0c3af1ad01c21644d751b80236 Gerrit-Change-Number: 83084 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 20:42:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: include/device_tree.h: Fix function name fdt_node_name
by Julius Werner (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Maximilian Brune. Julius Werner has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83084?usp=email ) Change subject: include/device_tree.h: Fix function name fdt_node_name ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: It's concerning that this got merged, does Jenkins not test a configuration with this code enabled? We should add something to `configs/` to make sure it does. -- To view, visit https://review.coreboot.org/c/coreboot/+/83084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I527146df26264a0c3af1ad01c21644d751b80236 Gerrit-Change-Number: 83084 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 20:42:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: lib/device_tree.c: Fix results length check
by Julius Werner (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Maximilian Brune. Julius Werner has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83085?usp=email ) Change subject: lib/device_tree.c: Fix results length check ...................................................................... Patch Set 1: (1 comment) File src/lib/device_tree.c: https://review.coreboot.org/c/coreboot/+/83085/comment/997a92f9_34423bc8?us… : PS1, Line 363: if (count_results > results_len) { I don't think this is correct? `results_len` X means that the `results` array has X entries, which means that `results[0]` to `results[X-1]` are valid entries. With this patch, we won't error out here if `count_results` is also X. That means below in line 372 we will access `results[X]`, which is invalid. -- To view, visit https://review.coreboot.org/c/coreboot/+/83085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic1111e8acb72ea1e9159da0d8386f40cbbdbc63f Gerrit-Change-Number: 83085 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 20:41:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: soc/intel: Enable crashlog IP for both 32-bit and 64-bit architectures
by Subrata Banik (Code Review) 20 Jun '24

20 Jun '24

Attention is currently required from: Angel Pons, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Pratikkumar V Prajapati, Sowmya Aralguppe, Tarun. Subrata Banik has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83106?usp=email ) Change subject: soc/intel: Enable crashlog IP for both 32-bit and 64-bit architectures ...................................................................... Patch Set 19: (6 comments) File src/soc/intel/common/block/crashlog/crashlog.c: https://review.coreboot.org/c/coreboot/+/83106/comment/c40bae6a_f71e82a9?us… : PS15, Line 321: sizeof(uintptr_t) > I have changed dest_addr to be u32 *,IMHO that is right solution isn't `u32 *dest_addr` also 8-byte in 64-bit arch? if we decide to do DW by DW copy then we need to ensure that both src and dest addr are getting incremented by 4-bytes post copy. Looking at `dest_addr` i felt this is okay as the declaration and increment both would be 4-bytes irrespective of 32-bit vs 64bit arch. but looks like `src_addr` is not using fixed data type. 32-bit systems: uintptr_t is 32 bits (4 bytes) 64-bit systems: uintptr_t is 64 bits (8 bytes) Let's say src_addr initially holds the value 0x1000. 32-bit: After src_addr += sizeof(uintptr_t);, it will hold the value 0x1004. 64-bit: After src_addr += sizeof(uintptr_t);, it will hold the value 0x1008. can you please fix this problem? File src/soc/intel/meteorlake/crashlog.c: https://review.coreboot.org/c/coreboot/+/83106/comment/919333fb_73b727fb?us… : PS19, Line 352: cl_buffer this is now combined dw0 and dw1, if so, then why are we calling it as `cl_buffer`. IMO, a buffer is either array or pointer type https://review.coreboot.org/c/coreboot/+/83106/comment/67839746_29932be0?us… : PS19, Line 353: */ space before ? https://review.coreboot.org/c/coreboot/+/83106/comment/262f39a8_ac483e59?us… : PS19, Line 354: if (!(cl_buffer >> 32)) this can check if MSB is zero or not. Not sure what is the purpose ? mostly to eliminate the zero based CL entries (which caused hang in MTL) https://review.coreboot.org/c/coreboot/+/83106/comment/61e33fdd_4021116f?us… : PS19, Line 357: u32 dw0 = read32p(disc_tab_addr + cur_offset); this is same as https://review.coreboot.org/c/coreboot/+/83106/19/src/soc/intel/meteorlake/…, if so, how this is different than what we have inside `cl_buffer` LSB already ? why no `if (!is_crashlog_data_valid(dw0))` checks? File src/soc/intel/tigerlake/crashlog_lib.c: https://review.coreboot.org/c/coreboot/+/83106/comment/e559107e_4f6c6048?us… : PS19, Line 165: bar_addr we should check if this value is non-zero ? -- To view, visit https://review.coreboot.org/c/coreboot/+/83106?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I552257d3770abb409e2dcd8a13392506b5e7feb7 Gerrit-Change-Number: 83106 Gerrit-PatchSet: 19 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Jun 2024 20:33:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024