Attention is currently required from: Jeremy Soller, Tim Crawford.
Felix Singer has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82596?usp=email )
Change subject: mb/system76/rpl: Add Oryx Pro 12 as a variant
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82596?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I11cf2dbd1512ebae44e0109bdb78e6eafa027444
Gerrit-Change-Number: 82596
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Wed, 29 May 2024 20:18:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Singer, Jeremy Soller.
Tim Crawford has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82595?usp=email )
Change subject: mb/system76/rpl: Add Adder WS 4 as a variant
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/system76/rpl/variants/addw4/overridetree.cb:
PS3:
> Add missing SPDX license identifier.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/82595?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a6819cbcf64f68237008adebdd7eb196336514c
Gerrit-Change-Number: 82595
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Wed, 29 May 2024 20:18:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Jeremy Soller, Tim Crawford.
Hello Jeremy Soller, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82595?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+2 by Jeremy Soller, Verified+1 by build bot (Jenkins)
Change subject: mb/system76/rpl: Add Adder WS 4 as a variant
......................................................................
mb/system76/rpl: Add Adder WS 4 as a variant
The Adder WS 4 (addw4) is a Raptor Lake-HX board.
Tested with a custom edk2 UefiPayloadPkg.
Working:
- PS/2 keyboard
- I2C HID touchpad
- Both DIMM slots (with Crucial CT8G48C40S5)
- M.2 NVMe SSDs
- All USB ports
- MicroSD card reader
- Webcam
- Ethernet
- WiFi/Bluetooth
- Integrated graphics using Intel GOP driver
- Backlight controls on Linux 6.8
- DisplayPort output over USB-C
- Internal microphone
- Internal speakers
- Combined headset + mic 3.5mm audio
- 3.5mm microphone input
- S3 suspend/resume
- Booting Pop!_OS Linux 22.04 with kernel 6.8.0
- TPM 2.0 device
Not working:
- Discrete/Hybrid graphics
- Detection of devices in TBT slot on boot
Change-Id: I4a6819cbcf64f68237008adebdd7eb196336514c
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M src/mainboard/system76/rpl/Kconfig
M src/mainboard/system76/rpl/Kconfig.name
M src/mainboard/system76/rpl/devicetree.cb
A src/mainboard/system76/rpl/variants/addw4/board.fmd
A src/mainboard/system76/rpl/variants/addw4/board_info.txt
A src/mainboard/system76/rpl/variants/addw4/data.vbt
A src/mainboard/system76/rpl/variants/addw4/gpio.c
A src/mainboard/system76/rpl/variants/addw4/gpio_early.c
A src/mainboard/system76/rpl/variants/addw4/hda_verb.c
A src/mainboard/system76/rpl/variants/addw4/overridetree.cb
A src/mainboard/system76/rpl/variants/addw4/romstage.c
11 files changed, 525 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/82595/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/82595?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a6819cbcf64f68237008adebdd7eb196336514c
Gerrit-Change-Number: 82595
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Attention is currently required from: Felix Singer, Jeremy Soller.
Tim Crawford has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82596?usp=email )
Change subject: mb/system76/rpl: Add Oryx Pro 12 as a variant
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/system76/rpl/variants/oryp12/overridetree.cb:
PS1:
> Add missing SPDX license identifier.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/82596?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I11cf2dbd1512ebae44e0109bdb78e6eafa027444
Gerrit-Change-Number: 82596
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Wed, 29 May 2024 20:17:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Jeremy Soller, Tim Crawford.
Hello Jeremy Soller, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82596?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by Jeremy Soller, Verified+1 by build bot (Jenkins)
Change subject: mb/system76/rpl: Add Oryx Pro 12 as a variant
......................................................................
mb/system76/rpl: Add Oryx Pro 12 as a variant
The Oryx Pro 12 (oryp12) is a Raptor Lake-HX board.
Tested with a custom edk2 UefiPayloadPkg.
Working:
- PS/2 keyboard
- I2C HID touchpad
- Both DIMM slots (with Crucial CT8G48C40S5)
- M.2 NVMe SSDs
- MicroSD card reader
- Webcam
- Ethernet
- WiFi/Bluetooth
- Integrated graphics using Intel GOP driver
- Backlight controls on Linux 6.8
- Internal microphone
- Internal speakers
- Combined headset + mic 3.5mm audio
- 3.5mm microphone input
- S3 suspend/resume
- Booting Pop!_OS Linux 22.04 with kernel 6.8.0
- TPM 2.0 device
Not working:
- Discrete/Hybrid graphics
- Thunderbolt
Change-Id: I11cf2dbd1512ebae44e0109bdb78e6eafa027444
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M src/mainboard/system76/rpl/Kconfig
M src/mainboard/system76/rpl/Kconfig.name
A src/mainboard/system76/rpl/variants/oryp12/board.fmd
A src/mainboard/system76/rpl/variants/oryp12/board_info.txt
A src/mainboard/system76/rpl/variants/oryp12/data.vbt
A src/mainboard/system76/rpl/variants/oryp12/gpio.c
A src/mainboard/system76/rpl/variants/oryp12/gpio_early.c
A src/mainboard/system76/rpl/variants/oryp12/hda_verb.c
A src/mainboard/system76/rpl/variants/oryp12/overridetree.cb
A src/mainboard/system76/rpl/variants/oryp12/romstage.c
A src/mainboard/system76/rpl/variants/oryp12/tas5825m.c
11 files changed, 1,587 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/82596/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82596?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I11cf2dbd1512ebae44e0109bdb78e6eafa027444
Gerrit-Change-Number: 82596
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Attention is currently required from: Tim Crawford.
Felix Singer has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82595?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/system76/rpl: Add Adder WS 4 as a variant
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/system76/rpl/variants/addw4/overridetree.cb:
PS3:
Add missing SPDX license identifier.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82595?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a6819cbcf64f68237008adebdd7eb196336514c
Gerrit-Change-Number: 82595
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Comment-Date: Wed, 29 May 2024 20:13:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Tim Crawford.
Felix Singer has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82596?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/system76/rpl: Add Oryx Pro 12 as a variant
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/system76/rpl/variants/oryp12/overridetree.cb:
PS1:
Add missing SPDX license identifier.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82596?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I11cf2dbd1512ebae44e0109bdb78e6eafa027444
Gerrit-Change-Number: 82596
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Comment-Date: Wed, 29 May 2024 20:12:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Subrata Banik.
Appukuttan V K has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82473?usp=email )
Change subject: vc/intel/fsp/mtl: Add x86_64 FSP V3471.91 headers
......................................................................
Patch Set 10:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82473/comment/453706d7_b66a373e?us… :
PS6, Line 9: header files
> what is the FSP version ?
Version number also added to commit message.
https://review.coreboot.org/c/coreboot/+/82473/comment/f71ed753_4e84ff04?us… :
PS6, Line 11: when FSP2.4 is in use.
> please write the motivation behind the fact that the 32-bit FSP will support FSP2. […]
Mentioned "FSP2.4 brings FSP 64-bits" the commit message.
Or should I remove the src/soc/intel/meteorlake/Kconfig change from this patch. Which is anyway handled in https://review.coreboot.org/c/coreboot/+/82624 ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/82473?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib41b57e794311db729ac65a968f562aa127e86c3
Gerrit-Change-Number: 82473
Gerrit-PatchSet: 10
Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Wed, 29 May 2024 19:51:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>