coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[S] Change in coreboot[main]: drivers/crb: Check for PTT before attempting to initialize CRB TPM
by Michał Kopeć (Code Review) 24 Apr '24

24 Apr '24

Attention is currently required from: Christian Walter, Michał Żygowski. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80453?usp=email ) Change subject: drivers/crb: Check for PTT before attempting to initialize CRB TPM ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80453?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0ec6217b0e321b7d7a9410b70defde3c3195fc3 Gerrit-Change-Number: 80453 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Wed, 24 Apr 2024 12:07:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/pc80/tpm: Disable device if TPM not present
by Michał Żygowski (Code Review) 24 Apr '24

24 Apr '24

Attention is currently required from: Christian Walter, Jérémy Compostella, Patrick Rudolph, Sergii Dmytruk. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80455?usp=email ) Change subject: drivers/pc80/tpm: Disable device if TPM not present ...................................................................... Patch Set 4: (1 comment) File src/drivers/pc80/tpm/tis.c: https://review.coreboot.org/c/coreboot/+/80455/comment/b6cdbe10_dd8a92a1 : PS3, Line 911: &family > `NULL` can be used instead. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I05972ad74a36abaafa2f17a16f09710550a3a3f3 Gerrit-Change-Number: 80455 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 24 Apr 2024 12:03:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/crb: Disable device if CRB TPM not present
by Michał Żygowski (Code Review) 24 Apr '24

24 Apr '24

Attention is currently required from: Christian Walter, Sergii Dmytruk. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80454?usp=email ) Change subject: drivers/crb: Disable device if CRB TPM not present ...................................................................... Patch Set 3: (1 comment) File src/drivers/crb/tis.c: https://review.coreboot.org/c/coreboot/+/80454/comment/39650653_893defe6 : PS2, Line 212: &family > You can use `NULL` now. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80454?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0928536d9042b1f680d585e1ca9ad2cadf0c8ef Gerrit-Change-Number: 80454 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 24 Apr 2024 12:03:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/crb,pc80/tpm: Add crb and pc80 prefixes to chip configs
by Michał Żygowski (Code Review) 24 Apr '24

24 Apr '24

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82057?usp=email ) Change subject: drivers/crb,pc80/tpm: Add crb and pc80 prefixes to chip configs ...................................................................... drivers/crb,pc80/tpm: Add crb and pc80 prefixes to chip configs Avoid tpm_config_t type redefinition by adding crb and pc80 prefixes. TEST=Compile MSI PRO Z690-A target with CRB and PC80 TPM chips enabled in devicetree. Change-Id: Id41717e265362303a17745303a907c9c8f4f4e12 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M src/drivers/crb/chip.h M src/drivers/pc80/tpm/chip.h M src/drivers/pc80/tpm/tis.c 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/82057/1 diff --git a/src/drivers/crb/chip.h b/src/drivers/crb/chip.h index f0e471f..8fd32d9 100644 --- a/src/drivers/crb/chip.h +++ b/src/drivers/crb/chip.h @@ -4,6 +4,6 @@ #define DRIVERS_CRB_CHIP_H typedef struct drivers_crb_config { -} tpm_config_t; +} crb_tpm_config_t; #endif /* DRIVERS_CRB_CHIP_H */ diff --git a/src/drivers/pc80/tpm/chip.h b/src/drivers/pc80/tpm/chip.h index af73153..cc842ff 100644 --- a/src/drivers/pc80/tpm/chip.h +++ b/src/drivers/pc80/tpm/chip.h @@ -13,6 +13,6 @@ * Falling Edge 3 */ u8 irq_polarity; -} tpm_config_t; +} pc80_tpm_config_t; #endif /* DRIVERS_PC80_TPM_CHIP_H */ diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c index d811c52..635dc7b 100644 --- a/src/drivers/pc80/tpm/tis.c +++ b/src/drivers/pc80/tpm/tis.c @@ -779,7 +779,7 @@ static void lpc_tpm_set_resources(struct device *dev) { - tpm_config_t *config = (tpm_config_t *)dev->chip_info; + pc80_tpm_config_t *config = (pc80_tpm_config_t *)dev->chip_info; DEVTREE_CONST struct resource *res; for (res = dev->resource_list; res; res = res->next) { -- To view, visit https://review.coreboot.org/c/coreboot/+/82057?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id41717e265362303a17745303a907c9c8f4f4e12 Gerrit-Change-Number: 82057 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: drivers/pc80/tpm: Disable device if TPM not present
by Michał Żygowski (Code Review) 24 Apr '24

24 Apr '24

Attention is currently required from: Christian Walter, Jérémy Compostella, Michał Żygowski, Patrick Rudolph. Hello Christian Walter, Jérémy Compostella, Patrick Rudolph, Sergii Dmytruk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80455?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: drivers/pc80/tpm: Disable device if TPM not present ...................................................................... drivers/pc80/tpm: Disable device if TPM not present If the TPM is not detected in the system it may mean it is inactive due to enabled ME with active PTT. In such case, the chipset will route the TPM traffic to PTT CRB TPM on Intel systems. If TPM is not probed, disable the PC80 TPM device driver, so that coreboot will not generate improper SSDT ACPI table. Change-Id: I05972ad74a36abaafa2f17a16f09710550a3a3f3 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M src/drivers/pc80/tpm/tis.c 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/80455/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/80455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I05972ad74a36abaafa2f17a16f09710550a3a3f3 Gerrit-Change-Number: 80455 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: drivers/crb: Disable device if CRB TPM not present
by Michał Żygowski (Code Review) 24 Apr '24

24 Apr '24

Attention is currently required from: Christian Walter, Michał Żygowski. Hello Christian Walter, Sergii Dmytruk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80454?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: drivers/crb: Disable device if CRB TPM not present ...................................................................... drivers/crb: Disable device if CRB TPM not present If CRB TPM is not detected in the system it may mean it is inactive due to disabled or neutered ME. In such case, the chipset will route the TPM traffic to LPC/SPI on Intel systems. If CRB TPM is not probed, disable the CRB TPM device driver, so that coreboot will not generate improper SMBIOS/SSDT ACPI tables. Change-Id: Ie0928536d9042b1f680d585e1ca9ad2cadf0c8ef Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M src/drivers/crb/tis.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/80454/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/80454?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0928536d9042b1f680d585e1ca9ad2cadf0c8ef Gerrit-Change-Number: 80454 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: block/fast_spi: Use read32p/write32p for spi rw
by Ashish Kumar Mishra (Code Review) 24 Apr '24

24 Apr '24

Attention is currently required from: Saurabh Mishra, Subrata Banik. Hello Saurabh Mishra, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82079?usp=email to look at the new patch set (#2). Change subject: block/fast_spi: Use read32p/write32p for spi rw ...................................................................... block/fast_spi: Use read32p/write32p for spi rw The current fast_spi impl. uses memcpy for rw. The memcpy impl. for x86_64 changed to 8 byte copy and due to 4 byte limit, spi rw fails. MRC cache rw regression observed in existing X86_64 platforms. Hence update rw ops to use read32p/write32p. BUG=b:242829490 TEST=Build and boot mtl 64-bit and verified MRC cache working. Change-Id: I317c7160bf192dd2aeacebf6029a809bc97f3420 Signed-off-by: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> --- M src/soc/intel/common/block/fast_spi/fast_spi_flash.c 1 file changed, 30 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/82079/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82079?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I317c7160bf192dd2aeacebf6029a809bc97f3420 Gerrit-Change-Number: 82079 Gerrit-PatchSet: 2 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: commonlib/bsd/cbfs_serialized: Remove condition on old gcc version
by Elyes Haouas (Code Review) 24 Apr '24

24 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/82008?usp=email ) Change subject: commonlib/bsd/cbfs_serialized: Remove condition on old gcc version ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/82008?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f98bf59f39b3966ecec558dc0f36110fb14279c Gerrit-Change-Number: 82008 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: bsd/cbfs_serialized: Check the cbfs_file size also when using clang
by Elyes Haouas (Code Review) 24 Apr '24

24 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/82009?usp=email ) Change subject: bsd/cbfs_serialized: Check the cbfs_file size also when using clang ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/82009?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I106d3bc85862546592ad5625592fe2c4733a8151 Gerrit-Change-Number: 82009 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: [MTL-x64]arch/x86: Update X86_64 memcpy for 4 byte copy
by Ashish Kumar Mishra (Code Review) 24 Apr '24

24 Apr '24

Ashish Kumar Mishra has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81959?usp=email ) Change subject: [MTL-x64]arch/x86: Update X86_64 memcpy for 4 byte copy ...................................................................... Abandoned New implementation here: https://review.coreboot.org/c/coreboot/+/82079 -- To view, visit https://review.coreboot.org/c/coreboot/+/81959?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1110cc18f5aa59c864e3cc04b9e6b3501ec4d54d Gerrit-Change-Number: 81959 Gerrit-PatchSet: 3 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024