coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[M] Change in coreboot[main]: drivers/intel/fsp2_0: Support FSP 2.4 64-bits
by Appukuttan V K (Code Review) 02 Apr '24

02 Apr '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Bora Guvendik, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Matt DeVillier, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Shuo Liu, Subrata Banik, Tim Chu, Wonkyu Kim. Appukuttan V K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80277?usp=email ) Change subject: drivers/intel/fsp2_0: Support FSP 2.4 64-bits ...................................................................... Patch Set 30: (1 comment) Patchset: PS30: > can you please try to split this changes to first accommodate […] Can you please check this for 1 above ? https://review.coreboot.org/c/coreboot/+/81630 -- To view, visit https://review.coreboot.org/c/coreboot/+/80277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec99 Gerrit-Change-Number: 80277 Gerrit-PatchSet: 30 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 02 Apr 2024 13:20:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: soc/intel/xeon_sp: Add Granite Rapids initial codes
by Shuo Liu (Code Review) 02 Apr '24

02 Apr '24

Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Felix Singer, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Paul Menzel, TangYiwei, Tim Chu. Hello Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, TangYiwei, Tim Chu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81316?usp=email to look at the new patch set (#35). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/xeon_sp: Add Granite Rapids initial codes ...................................................................... soc/intel/xeon_sp: Add Granite Rapids initial codes coreboot GNR (Granite Rapids) is a FSP 2.4 based, no-PCH, single IO-APIC Xeon-SP platform. The same set of codes is also used for SRF (Sierra Forest) SoC. This patch initially sets the code set up. 1. All register definitions are forked from SPR (Sapphire Rapids) and EBG (Emmisburg PCH)'s codes are reused. 2. src/soc/intel/xeon_sp/chip_gen6.c is newly added as chip common codes for 6th Gen Xeon-SP SoC (Granite Rapids) and later. TEST=intel/archercity CRB Change-Id: I3084e1b5abf25d8d9504bebeaed2a15b916ed56b Signed-off-by: Shuo Liu <shuo.liu(a)intel.com> Signed-off-by: Gang Chen <gang.c.chen(a)intel.com> Signed-off-by: Jincheng Li <jincheng.li(a)intel.com> --- M MAINTAINERS M src/soc/intel/xeon_sp/Makefile.mk M src/soc/intel/xeon_sp/chip_gen1.c A src/soc/intel/xeon_sp/chip_gen6.c A src/soc/intel/xeon_sp/gnr/Kconfig A src/soc/intel/xeon_sp/gnr/Makefile.inc A src/soc/intel/xeon_sp/gnr/acpi/gpe.asl A src/soc/intel/xeon_sp/gnr/chip.c A src/soc/intel/xeon_sp/gnr/chip.h A src/soc/intel/xeon_sp/gnr/cpu.c A src/soc/intel/xeon_sp/gnr/include/soc/cpu.h A src/soc/intel/xeon_sp/gnr/include/soc/pci_devs.h A src/soc/intel/xeon_sp/gnr/include/soc/soc_msr.h A src/soc/intel/xeon_sp/gnr/include/soc/soc_util.h A src/soc/intel/xeon_sp/gnr/include/soc/vpd.h A src/soc/intel/xeon_sp/gnr/ramstage.c A src/soc/intel/xeon_sp/gnr/romstage.c A src/soc/intel/xeon_sp/gnr/soc_acpi.c A src/soc/intel/xeon_sp/gnr/soc_util.c M src/soc/intel/xeon_sp/include/soc/chip_common.h M src/soc/intel/xeon_sp/include/soc/fsp_upd.h M src/soc/intel/xeon_sp/lockdown.c M src/soc/intel/xeon_sp/uncore.c 23 files changed, 1,311 insertions(+), 62 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/81316/35 -- To view, visit https://review.coreboot.org/c/coreboot/+/81316?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3084e1b5abf25d8d9504bebeaed2a15b916ed56b Gerrit-Change-Number: 81316 Gerrit-PatchSet: 35 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: TangYiwei Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in libgfxinit[main]: gma display_probing: Make new TGL ports available
by Elyes Haouas (Code Review) 02 Apr '24

02 Apr '24

Attention is currently required from: Dinesh Gehlot, Nico Huber. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/81522?usp=email ) Change subject: gma display_probing: Make new TGL ports available ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/81522?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I9d96673f931be0086536044694ecd127ba2a823d Gerrit-Change-Number: 81522 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Tue, 02 Apr 2024 13:16:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in libgfxinit[main]: gfxtest: Drop unnecessary with of ancestor
by Elyes Haouas (Code Review) 02 Apr '24

02 Apr '24

Attention is currently required from: Dinesh Gehlot, Nico Huber. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/81521?usp=email ) Change subject: gfxtest: Drop unnecessary with of ancestor ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/81521?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: Ibc1a6710a5cd12be9190860635e7b951d4fe4775 Gerrit-Change-Number: 81521 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Tue, 02 Apr 2024 13:15:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brya: Create trulo variant
by Dinesh Gehlot (Code Review) 02 Apr '24

02 Apr '24

1 0

[M] Change in coreboot[main]: mb/google/brya: Add new baseboard trulo
by Dinesh Gehlot (Code Review) 02 Apr '24

02 Apr '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Varshit Pandya. Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81626?usp=email ) Change subject: mb/google/brya: Add new baseboard trulo ...................................................................... Patch Set 3: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81626/comment/5550c7e0_d5e598ac : PS2, Line 11: > would be good if you could add the "TEST" info Acknowledged File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/81626/comment/416e9fd6_8cc746ed : PS2, Line 128: config BOARD_GOOGLE_BASEBOARD_TRULO : def_bool n : select BOARD_GOOGLE_BRYA_COMMON : select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if CHROMEOS : select SOC_INTEL_ALDERLAKE_PCH_N : select SYSTEM_TYPE_LAPTOP > all the baseboard related config are in alphabetical order, may be move this after the "BOARD_GOOGLE […] Acknowledged File src/mainboard/google/brya/variants/baseboard/trulo/gpio.c: https://review.coreboot.org/c/coreboot/+/81626/comment/3b4d76ee_e7b80d29 : PS2, Line 1: > empty line after the line containing license information, just like how you did for ec.h file. Acknowledged https://review.coreboot.org/c/coreboot/+/81626/comment/7e31b70a_c7cedbad : PS2, Line 5: #include <types.h> : #include <soc/gpio.h> > sort them in alphabetical order ? Acknowledged https://review.coreboot.org/c/coreboot/+/81626/comment/341b8712_1a5b3d46 : PS2, Line 8: /* Pad configuration in ramstage */ > I would put an empty line after include file list ending (line 8 should be an empty line) Acknowledged File src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/ec.h: https://review.coreboot.org/c/coreboot/+/81626/comment/29722cc0_d282133e : PS2, Line 6: #include <ec/ec.h> : #include <ec/google/chromeec/ec_commands.h> : #include <baseboard/gpio.h> > sort them alphabetically .. Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/81626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d Gerrit-Change-Number: 81626 Gerrit-PatchSet: 3 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 02 Apr 2024 13:09:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brya: Create trulo variant
by Dinesh Gehlot (Code Review) 02 Apr '24

02 Apr '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81627?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/google/brya: Create trulo variant ...................................................................... mb/google/brya: Create trulo variant This patch adds a new variant trulo for the baseboard trulo. TEST=abuild -a -x -p none -t google/brya Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/trulo/include/variant/ec.h A src/mainboard/google/brya/variants/trulo/include/variant/gpio.h A src/mainboard/google/brya/variants/trulo/overridetree.cb 5 files changed, 29 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/81627/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d Gerrit-Change-Number: 81627 Gerrit-PatchSet: 3 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: mb/google/brya: Add new baseboard trulo
by Dinesh Gehlot (Code Review) 02 Apr '24

02 Apr '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81626?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/google/brya: Add new baseboard trulo ...................................................................... mb/google/brya: Add new baseboard trulo This patch adds a new baseboard trulo. This commit is a stub which only adds the minimum code needed for a successful build. TEST=abuild -a -x -p none -t google/brya Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> --- M src/mainboard/google/brya/Kconfig A src/mainboard/google/brya/variants/baseboard/trulo/Makefile.mk A src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb A src/mainboard/google/brya/variants/baseboard/trulo/gpio.c A src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/ec.h A src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h A src/mainboard/google/brya/variants/baseboard/trulo/memory.c 7 files changed, 120 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/81626/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d Gerrit-Change-Number: 81626 Gerrit-PatchSet: 3 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Support FSP-T in long mode
by Elyes Haouas (Code Review) 02 Apr '24

02 Apr '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Patrick Rudolph, Ronak Kanabar. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81281?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: drivers/intel/fsp2_0: Support FSP-T in long mode ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/drivers/intel/fsp2_0/temp_ram_exit.c: https://review.coreboot.org/c/coreboot/+/81281/comment/66c3adab_97933e7f : PS5, Line 9: <stdint.h> <types.h> is supposed to provide it -- To view, visit https://review.coreboot.org/c/coreboot/+/81281?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id6b9780b06b4bfbb952e32091ffbf3d0014f2090 Gerrit-Change-Number: 81281 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Apr 2024 13:06:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/google/brya: Sort Kconfig option alphabetically
by Varshit Pandya (Code Review) 02 Apr '24

02 Apr '24

Varshit Pandya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81631?usp=email ) Change subject: mb/google/brya: Sort Kconfig option alphabetically ...................................................................... mb/google/brya: Sort Kconfig option alphabetically Change-Id: I878c14058e1edc0f64e37c2fc16b8dcf75b90192 Signed-off-by: Varshit Pandya <varshit.pandya(a)amd.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 154 insertions(+), 154 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/81631/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 160d12a..2466776 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -59,6 +59,7 @@ def_bool n select BOARD_GOOGLE_BRYA_COMMON select BOARD_ROMSIZE_KB_32768 + select CR50_RESET_CLEAR_EC_AP_IDLE_FLAG select ENABLE_TCSS_DISPLAY_DETECTION if RUN_FSP_GOP select HAVE_SLP_S0_GATE select MEMORY_SODIMM if !BOARD_GOOGLE_CONSTITUTION @@ -67,7 +68,6 @@ select RT8168_SET_LED_MODE select SOC_INTEL_ALDERLAKE_PCH_P select TPM_GOOGLE_CR50 - select CR50_RESET_CLEAR_EC_AP_IDLE_FLAG config BOARD_GOOGLE_BASEBOARD_HADES def_bool n @@ -130,10 +130,10 @@ select BOARD_ROMSIZE_KB_16384 select DRIVERS_GENERIC_BAYHUB_LV2 select DRIVERS_GENERIC_GPIO_KEYS - select INTEL_GMA_HAVE_VBT - select DRIVERS_INTEL_MIPI_CAMERA - select HAVE_WWAN_POWER_SEQUENCE select DRIVERS_GFX_GENERIC + select DRIVERS_INTEL_MIPI_CAMERA + select INTEL_GMA_HAVE_VBT + select HAVE_WWAN_POWER_SEQUENCE select CHROMEOS_WIFI_SAR if CHROMEOS config BOARD_GOOGLE_AURASH @@ -155,6 +155,7 @@ config BOARD_GOOGLE_BRYA0 select BOARD_GOOGLE_BASEBOARD_BRYA + select DRIVERS_GENERIC_NAU8315 select DRIVERS_GENESYSLOGIC_GL9755 select DRIVERS_I2C_SX9324 select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER @@ -162,7 +163,6 @@ select SOC_INTEL_COMMON_BLOCK_IPU select SOC_INTEL_CRASHLOG select SOC_INTEL_RAPTORLAKE - select DRIVERS_GENERIC_NAU8315 config BOARD_GOOGLE_BUJIA select BOARD_GOOGLE_BASEBOARD_BRASK @@ -396,11 +396,11 @@ config BOARD_GOOGLE_REDRIX select BOARD_GOOGLE_BASEBOARD_BRYA - select GOOGLE_DSM_CALIB if VPD select DRIVERS_GENESYSLOGIC_GL9755 select DRIVERS_I2C_MAX98390 select DRIVERS_INTEL_MIPI_CAMERA select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG + select GOOGLE_DSM_CALIB if VPD select GOOGLE_DSM_PARAM_FILE_NAME if VPD select INTEL_GMA_HAVE_VBT select SOC_INTEL_COMMON_BLOCK_IPU @@ -418,6 +418,7 @@ config BOARD_GOOGLE_SKOLAS select BOARD_GOOGLE_BASEBOARD_BRYA + select DRIVERS_GENERIC_NAU8315 select DRIVERS_GENESYSLOGIC_GL9755 select DRIVERS_INTEL_MIPI_CAMERA select DRIVERS_I2C_SX9324 @@ -425,7 +426,6 @@ select INTEL_GMA_HAVE_VBT select SOC_INTEL_COMMON_BLOCK_IPU select SOC_INTEL_RAPTORLAKE - select DRIVERS_GENERIC_NAU8315 config BOARD_GOOGLE_SKOLAS4ES select BOARD_GOOGLE_BASEBOARD_BRYA @@ -529,9 +529,9 @@ select CHROMEOS_WIFI_SAR if CHROMEOS select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_INTEL_MIPI_CAMERA + select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG select HAVE_WWAN_POWER_SEQUENCE select INTEL_GMA_HAVE_VBT - select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG config BOARD_GOOGLE_YAVISTA select BOARD_GOOGLE_BASEBOARD_NISSA @@ -573,61 +573,61 @@ config DRIVER_TPM_I2C_BUS hex - default 0x1 if BOARD_GOOGLE_BRYA0 - default 0x1 if BOARD_GOOGLE_BRASK - default 0x1 if BOARD_GOOGLE_PRIMUS - default 0x1 if BOARD_GOOGLE_GIMBLE - default 0x3 if BOARD_GOOGLE_GIMBLE4ES - default 0x1 if BOARD_GOOGLE_REDRIX - default 0x3 if BOARD_GOOGLE_REDRIX4ES - default 0x1 if BOARD_GOOGLE_KANO - default 0x1 if BOARD_GOOGLE_TAEKO - default 0x3 if BOARD_GOOGLE_TAEKO4ES - default 0x1 if BOARD_GOOGLE_FELWINTER + default 0x3 if BOARD_GOOGLE_AGAH default 0x1 if BOARD_GOOGLE_ANAHERA default 0x3 if BOARD_GOOGLE_ANAHERA4ES - default 0x1 if BOARD_GOOGLE_VELL - default 0x1 if BOARD_GOOGLE_TANIKS - default 0x0 if BOARD_GOOGLE_NIVVIKS - default 0x0 if BOARD_GOOGLE_NEREID - default 0x3 if BOARD_GOOGLE_AGAH - default 0x1 if BOARD_GOOGLE_VOLMAR + default 0x0 if BOARD_GOOGLE_ANRAGGAR + default 0x1 if BOARD_GOOGLE_AURASH default 0x1 if BOARD_GOOGLE_BANSHEE - default 0x1 if BOARD_GOOGLE_KINOX + default 0x1 if BOARD_GOOGLE_BRASK + default 0x1 if BOARD_GOOGLE_BRYA0 + default 0x1 if BOARD_GOOGLE_BUJIA + default 0x1 if BOARD_GOOGLE_CONSTITUTION default 0x0 if BOARD_GOOGLE_CRAASK + default 0x0 if BOARD_GOOGLE_CRAASKOV default 0x1 if BOARD_GOOGLE_CROTA - default 0x1 if BOARD_GOOGLE_MOLI - default 0x1 if BOARD_GOOGLE_OSIRIS - default 0x1 if BOARD_GOOGLE_MITHRAX + default 0x1 if BOARD_GOOGLE_DOCHI + default 0x1 if BOARD_GOOGLE_FELWINTER + default 0x1 if BOARD_GOOGLE_GAELIN + default 0x1 if BOARD_GOOGLE_GIMBLE + default 0x3 if BOARD_GOOGLE_GIMBLE4ES + default 0x1 if BOARD_GOOGLE_GLADIOS + default 0x0 if BOARD_GOOGLE_GLASSWAY + default 0x0 if BOARD_GOOGLE_GOTHRAX + default 0x3 if BOARD_GOOGLE_HADES + default 0x0 if BOARD_GOOGLE_JOXER + default 0x1 if BOARD_GOOGLE_KANO + default 0x1 if BOARD_GOOGLE_KINOX default 0x1 if BOARD_GOOGLE_KULDAX + default 0x1 if BOARD_GOOGLE_LISBON + default 0x1 if BOARD_GOOGLE_MARASOV + default 0x1 if BOARD_GOOGLE_MITHRAX + default 0x1 if BOARD_GOOGLE_MOLI + default 0x0 if BOARD_GOOGLE_NEREID + default 0x0 if BOARD_GOOGLE_NIVVIKS + default 0x1 if BOARD_GOOGLE_NOVA + default 0x1 if BOARD_GOOGLE_OMNIGUL + default 0x1 if BOARD_GOOGLE_OSIRIS + default 0x0 if BOARD_GOOGLE_PIRRHA + default 0x1 if BOARD_GOOGLE_PRIMUS + default 0x0 if BOARD_GOOGLE_PUJJO + default 0x0 if BOARD_GOOGLE_QUANDISO + default 0x1 if BOARD_GOOGLE_REDRIX + default 0x3 if BOARD_GOOGLE_REDRIX4ES default 0x1 if BOARD_GOOGLE_SKOLAS default 0x1 if BOARD_GOOGLE_SKOLAS4ES - default 0x0 if BOARD_GOOGLE_JOXER - default 0x0 if BOARD_GOOGLE_PUJJO - default 0x0 if BOARD_GOOGLE_XIVU - default 0x0 if BOARD_GOOGLE_YAVIKS - default 0x1 if BOARD_GOOGLE_ZYDRON - default 0x1 if BOARD_GOOGLE_LISBON - default 0x1 if BOARD_GOOGLE_GLADIOS - default 0x1 if BOARD_GOOGLE_MARASOV - default 0x1 if BOARD_GOOGLE_GAELIN - default 0x1 if BOARD_GOOGLE_OMNIGUL - default 0x1 if BOARD_GOOGLE_CONSTITUTION - default 0x1 if BOARD_GOOGLE_AURASH - default 0x3 if BOARD_GOOGLE_HADES - default 0x0 if BOARD_GOOGLE_YAVILLA - default 0x0 if BOARD_GOOGLE_ULDREN - default 0x0 if BOARD_GOOGLE_CRAASKOV - default 0x0 if BOARD_GOOGLE_GOTHRAX - default 0x0 if BOARD_GOOGLE_PIRRHA - default 0x1 if BOARD_GOOGLE_DOCHI - default 0x0 if BOARD_GOOGLE_QUANDISO - default 0x0 if BOARD_GOOGLE_ANRAGGAR - default 0x1 if BOARD_GOOGLE_XOL - default 0x0 if BOARD_GOOGLE_GLASSWAY - default 0x1 if BOARD_GOOGLE_NOVA - default 0x1 if BOARD_GOOGLE_BUJIA + default 0x1 if BOARD_GOOGLE_TAEKO + default 0x3 if BOARD_GOOGLE_TAEKO4ES + default 0x1 if BOARD_GOOGLE_TANIKS default 0x0 if BOARD_GOOGLE_TIVVIKS + default 0x0 if BOARD_GOOGLE_ULDREN + default 0x1 if BOARD_GOOGLE_VELL + default 0x1 if BOARD_GOOGLE_VOLMAR + default 0x0 if BOARD_GOOGLE_XIVU + default 0x1 if BOARD_GOOGLE_XOL + default 0x0 if BOARD_GOOGLE_YAVIKS + default 0x0 if BOARD_GOOGLE_YAVILLA + default 0x1 if BOARD_GOOGLE_ZYDRON config DRIVER_TPM_I2C_ADDR hex @@ -659,124 +659,124 @@ default "Google_Nissa" if BOARD_GOOGLE_BASEBOARD_NISSA config MAINBOARD_PART_NUMBER - default "Brya" if BOARD_GOOGLE_BRYA0 - default "Brask" if BOARD_GOOGLE_BRASK - default "Primus" if BOARD_GOOGLE_PRIMUS - default "Gimble" if BOARD_GOOGLE_GIMBLE - default "Gimble4ES" if BOARD_GOOGLE_GIMBLE4ES - default "Redrix" if BOARD_GOOGLE_REDRIX - default "Redrix4ES" if BOARD_GOOGLE_REDRIX4ES - default "Kano" if BOARD_GOOGLE_KANO - default "Taeko" if BOARD_GOOGLE_TAEKO - default "Taeko4ES" if BOARD_GOOGLE_TAEKO4ES - default "Felwinter" if BOARD_GOOGLE_FELWINTER + default "Agah" if BOARD_GOOGLE_AGAH default "Anahera" if BOARD_GOOGLE_ANAHERA default "Anahera4ES" if BOARD_GOOGLE_ANAHERA4ES - default "Vell" if BOARD_GOOGLE_VELL - default "Taniks" if BOARD_GOOGLE_TANIKS - default "Nivviks" if BOARD_GOOGLE_NIVVIKS - default "Nereid" if BOARD_GOOGLE_NEREID - default "Agah" if BOARD_GOOGLE_AGAH - default "Volmar" if BOARD_GOOGLE_VOLMAR + default "Anraggar" if BOARD_GOOGLE_ANRAGGAR + default "Aurash" if BOARD_GOOGLE_AURASH default "Banshee" if BOARD_GOOGLE_BANSHEE - default "Crota" if BOARD_GOOGLE_CROTA - default "Moli" if BOARD_GOOGLE_MOLI - default "Kinox" if BOARD_GOOGLE_KINOX + default "Brask" if BOARD_GOOGLE_BRASK + default "Brya" if BOARD_GOOGLE_BRYA0 + default "Bujia" if BOARD_GOOGLE_BUJIA + default "Constitution" if BOARD_GOOGLE_CONSTITUTION default "Craask" if BOARD_GOOGLE_CRAASK - default "Osiris" if BOARD_GOOGLE_OSIRIS - default "Mithrax" if BOARD_GOOGLE_MITHRAX + default "Craaskov" if BOARD_GOOGLE_CRAASKOV + default "Crota" if BOARD_GOOGLE_CROTA + default "Dochi" if BOARD_GOOGLE_DOCHI + default "Felwinter" if BOARD_GOOGLE_FELWINTER + default "Gaelin" if BOARD_GOOGLE_GAELIN + default "Gimble" if BOARD_GOOGLE_GIMBLE + default "Gimble4ES" if BOARD_GOOGLE_GIMBLE4ES + default "Gladios" if BOARD_GOOGLE_GLADIOS + default "Glassway" if BOARD_GOOGLE_GLASSWAY + default "Gothrax" if BOARD_GOOGLE_GOTHRAX + default "Hades" if BOARD_GOOGLE_HADES + default "Joxer" if BOARD_GOOGLE_JOXER + default "Kano" if BOARD_GOOGLE_KANO + default "Kinox" if BOARD_GOOGLE_KINOX default "Kuldax" if BOARD_GOOGLE_KULDAX + default "Lisbon" if BOARD_GOOGLE_LISBON + default "Marasov" if BOARD_GOOGLE_MARASOV + default "Mithrax" if BOARD_GOOGLE_MITHRAX + default "Moli" if BOARD_GOOGLE_MOLI + default "Nereid" if BOARD_GOOGLE_NEREID + default "Nivviks" if BOARD_GOOGLE_NIVVIKS + default "Nokris" if BOARD_GOOGLE_NOKRIS + default "Nova" if BOARD_GOOGLE_NOVA + default "Omnigul" if BOARD_GOOGLE_OMNIGUL + default "Osiris" if BOARD_GOOGLE_OSIRIS + default "Pirrha" if BOARD_GOOGLE_PIRRHA + default "Primus" if BOARD_GOOGLE_PRIMUS + default "Pujjo" if BOARD_GOOGLE_PUJJO + default "Quandiso" if BOARD_GOOGLE_QUANDISO + default "Redrix" if BOARD_GOOGLE_REDRIX + default "Redrix4ES" if BOARD_GOOGLE_REDRIX4ES default "Skolas" if BOARD_GOOGLE_SKOLAS default "Skolas4ES" if BOARD_GOOGLE_SKOLAS4ES - default "Joxer" if BOARD_GOOGLE_JOXER - default "Pujjo" if BOARD_GOOGLE_PUJJO - default "Xivu" if BOARD_GOOGLE_XIVU - default "Gaelin" if BOARD_GOOGLE_GAELIN - default "Yaviks" if BOARD_GOOGLE_YAVIKS - default "Lisbon" if BOARD_GOOGLE_LISBON - default "Zydron" if BOARD_GOOGLE_ZYDRON - default "Gladios" if BOARD_GOOGLE_GLADIOS - default "Marasov" if BOARD_GOOGLE_MARASOV - default "Omnigul" if BOARD_GOOGLE_OMNIGUL - default "Constitution" if BOARD_GOOGLE_CONSTITUTION - default "Aurash" if BOARD_GOOGLE_AURASH - default "Hades" if BOARD_GOOGLE_HADES - default "Uldren" if BOARD_GOOGLE_ULDREN - default "Yavilla" if BOARD_GOOGLE_YAVILLA - default "Gothrax" if BOARD_GOOGLE_GOTHRAX - default "Craaskov" if BOARD_GOOGLE_CRAASKOV - default "Pirrha" if BOARD_GOOGLE_PIRRHA - default "Quandiso" if BOARD_GOOGLE_QUANDISO - default "Nokris" if BOARD_GOOGLE_NOKRIS - default "Dochi" if BOARD_GOOGLE_DOCHI - default "Anraggar" if BOARD_GOOGLE_ANRAGGAR - default "Xol" if BOARD_GOOGLE_XOL - default "Glassway" if BOARD_GOOGLE_GLASSWAY - default "Nova" if BOARD_GOOGLE_NOVA - default "Bujia" if BOARD_GOOGLE_BUJIA - default "Tivviks" if BOARD_GOOGLE_TIVVIKS - default "Yavista" if BOARD_GOOGLE_YAVISTA default "Sundance" if BOARD_GOOGLE_SUNDANCE + default "Taeko" if BOARD_GOOGLE_TAEKO + default "Taeko4ES" if BOARD_GOOGLE_TAEKO4ES + default "Taniks" if BOARD_GOOGLE_TANIKS + default "Tivviks" if BOARD_GOOGLE_TIVVIKS + default "Uldren" if BOARD_GOOGLE_ULDREN + default "Vell" if BOARD_GOOGLE_VELL + default "Volmar" if BOARD_GOOGLE_VOLMAR + default "Xivu" if BOARD_GOOGLE_XIVU + default "Xol" if BOARD_GOOGLE_XOL + default "Yaviks" if BOARD_GOOGLE_YAVIKS + default "Yavilla" if BOARD_GOOGLE_YAVILLA + default "Yavista" if BOARD_GOOGLE_YAVISTA + default "Zydron" if BOARD_GOOGLE_ZYDRON config VARIANT_DIR - default "brya0" if BOARD_GOOGLE_BRYA0 - default "brask" if BOARD_GOOGLE_BRASK - default "primus" if BOARD_GOOGLE_PRIMUS - default "gimble" if BOARD_GOOGLE_GIMBLE - default "gimble4es" if BOARD_GOOGLE_GIMBLE4ES - default "redrix" if BOARD_GOOGLE_REDRIX - default "redrix4es" if BOARD_GOOGLE_REDRIX4ES - default "kano" if BOARD_GOOGLE_KANO - default "taeko" if BOARD_GOOGLE_TAEKO - default "taeko4es" if BOARD_GOOGLE_TAEKO4ES - default "felwinter" if BOARD_GOOGLE_FELWINTER + default "agah" if BOARD_GOOGLE_AGAH default "anahera" if BOARD_GOOGLE_ANAHERA default "anahera4es" if BOARD_GOOGLE_ANAHERA4ES - default "vell" if BOARD_GOOGLE_VELL - default "taniks" if BOARD_GOOGLE_TANIKS - default "nivviks" if BOARD_GOOGLE_NIVVIKS - default "nereid" if BOARD_GOOGLE_NEREID - default "agah" if BOARD_GOOGLE_AGAH - default "volmar" if BOARD_GOOGLE_VOLMAR + default "anraggar" if BOARD_GOOGLE_ANRAGGAR + default "aurash" if BOARD_GOOGLE_AURASH default "banshee" if BOARD_GOOGLE_BANSHEE - default "crota" if BOARD_GOOGLE_CROTA - default "moli" if BOARD_GOOGLE_MOLI - default "kinox" if BOARD_GOOGLE_KINOX + default "brask" if BOARD_GOOGLE_BRASK + default "brya0" if BOARD_GOOGLE_BRYA0 + default "bujia" if BOARD_GOOGLE_BUJIA + default "constitution" if BOARD_GOOGLE_CONSTITUTION default "craask" if BOARD_GOOGLE_CRAASK - default "osiris" if BOARD_GOOGLE_OSIRIS - default "mithrax" if BOARD_GOOGLE_MITHRAX + default "craaskov" if BOARD_GOOGLE_CRAASKOV + default "crota" if BOARD_GOOGLE_CROTA + default "dochi" if BOARD_GOOGLE_DOCHI + default "felwinter" if BOARD_GOOGLE_FELWINTER + default "gaelin" if BOARD_GOOGLE_GAELIN + default "gimble" if BOARD_GOOGLE_GIMBLE + default "gimble4es" if BOARD_GOOGLE_GIMBLE4ES + default "gladios" if BOARD_GOOGLE_GLADIOS + default "glassway" if BOARD_GOOGLE_GLASSWAY + default "gothrax" if BOARD_GOOGLE_GOTHRAX + default "hades" if BOARD_GOOGLE_HADES + default "joxer" if BOARD_GOOGLE_JOXER + default "kano" if BOARD_GOOGLE_KANO + default "kinox" if BOARD_GOOGLE_KINOX default "kuldax" if BOARD_GOOGLE_KULDAX + default "lisbon" if BOARD_GOOGLE_LISBON + default "marasov" if BOARD_GOOGLE_MARASOV + default "mithrax" if BOARD_GOOGLE_MITHRAX + default "moli" if BOARD_GOOGLE_MOLI + default "nereid" if BOARD_GOOGLE_NEREID + default "nivviks" if BOARD_GOOGLE_NIVVIKS + default "nivviks" if BOARD_GOOGLE_TIVVIKS + default "nokris" if BOARD_GOOGLE_NOKRIS + default "nova" if BOARD_GOOGLE_NOVA + default "omnigul" if BOARD_GOOGLE_OMNIGUL + default "osiris" if BOARD_GOOGLE_OSIRIS + default "pirrha" if BOARD_GOOGLE_PIRRHA + default "primus" if BOARD_GOOGLE_PRIMUS + default "pujjo" if BOARD_GOOGLE_PUJJO + default "quandiso" if BOARD_GOOGLE_QUANDISO + default "redrix" if BOARD_GOOGLE_REDRIX + default "redrix4es" if BOARD_GOOGLE_REDRIX4ES default "skolas" if BOARD_GOOGLE_SKOLAS default "skolas4es" if BOARD_GOOGLE_SKOLAS4ES - default "joxer" if BOARD_GOOGLE_JOXER - default "pujjo" if BOARD_GOOGLE_PUJJO - default "xivu" if BOARD_GOOGLE_XIVU - default "gaelin" if BOARD_GOOGLE_GAELIN - default "yaviks" if BOARD_GOOGLE_YAVIKS - default "lisbon" if BOARD_GOOGLE_LISBON - default "zydron" if BOARD_GOOGLE_ZYDRON - default "gladios" if BOARD_GOOGLE_GLADIOS - default "marasov" if BOARD_GOOGLE_MARASOV - default "omnigul" if BOARD_GOOGLE_OMNIGUL - default "constitution" if BOARD_GOOGLE_CONSTITUTION - default "aurash" if BOARD_GOOGLE_AURASH - default "hades" if BOARD_GOOGLE_HADES - default "uldren" if BOARD_GOOGLE_ULDREN - default "yavilla" if BOARD_GOOGLE_YAVILLA - default "gothrax" if BOARD_GOOGLE_GOTHRAX - default "craaskov" if BOARD_GOOGLE_CRAASKOV - default "pirrha" if BOARD_GOOGLE_PIRRHA - default "quandiso" if BOARD_GOOGLE_QUANDISO - default "nokris" if BOARD_GOOGLE_NOKRIS - default "dochi" if BOARD_GOOGLE_DOCHI - default "anraggar" if BOARD_GOOGLE_ANRAGGAR - default "xol" if BOARD_GOOGLE_XOL - default "glassway" if BOARD_GOOGLE_GLASSWAY - default "nova" if BOARD_GOOGLE_NOVA - default "bujia" if BOARD_GOOGLE_BUJIA - default "nivviks" if BOARD_GOOGLE_TIVVIKS - default "yavista" if BOARD_GOOGLE_YAVISTA default "sundance" if BOARD_GOOGLE_SUNDANCE + default "taeko" if BOARD_GOOGLE_TAEKO + default "taeko4es" if BOARD_GOOGLE_TAEKO4ES + default "taniks" if BOARD_GOOGLE_TANIKS + default "uldren" if BOARD_GOOGLE_ULDREN + default "vell" if BOARD_GOOGLE_VELL + default "volmar" if BOARD_GOOGLE_VOLMAR + default "xivu" if BOARD_GOOGLE_XIVU + default "xol" if BOARD_GOOGLE_XOL + default "yaviks" if BOARD_GOOGLE_YAVIKS + default "yavilla" if BOARD_GOOGLE_YAVILLA + default "zydron" if BOARD_GOOGLE_ZYDRON + default "yavista" if BOARD_GOOGLE_YAVISTA config VBOOT select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_BASEBOARD_NISSA -- To view, visit https://review.coreboot.org/c/coreboot/+/81631?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I878c14058e1edc0f64e37c2fc16b8dcf75b90192 Gerrit-Change-Number: 81631 Gerrit-PatchSet: 1 Gerrit-Owner: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024