coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[XS] Change in coreboot[main]: tree: Drop duplicated <stdarg.h> and <stdio.h>
by Elyes Haouas (Code Review) 11 Apr '24

11 Apr '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81853?usp=email ) Change subject: tree: Drop duplicated <stdarg.h> and <stdio.h> ...................................................................... tree: Drop duplicated <stdarg.h> and <stdio.h> <string.h> is supposed to provide <stdarg.h> and <stdio.h> Change-Id: I021ba535ba5ec683021c4dfc41ac18d9cebbcfd2 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/console/vsprintf.c M src/console/vtxprintf.c M src/cpu/x86/smm/smm_module_loader.c M src/device/pci_rom.c M src/drivers/ocp/dmi/smbios.c M src/mainboard/ocp/deltalake/ramstage.c M tests/lib/string-test.c 7 files changed, 0 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/81853/1 diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index 6892639..06b9e49 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/vtxprintf.h> -#include <stdarg.h> #include <string.h> struct vsnprintf_context { diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c index cfba6db..fba76bc 100644 --- a/src/console/vtxprintf.c +++ b/src/console/vtxprintf.c @@ -6,7 +6,6 @@ #include <console/vtxprintf.h> #include <ctype.h> -#include <stdarg.h> #include <string.h> #include <types.h> diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index 646f3bb..02debfc 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -11,7 +11,6 @@ #include <device/mmio.h> #include <rmodule.h> #include <smmstore.h> -#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index a29af6a..603597a 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <stdio.h> #include <string.h> #include <cbfs.h> #include <cbmem.h> diff --git a/src/drivers/ocp/dmi/smbios.c b/src/drivers/ocp/dmi/smbios.c index 0ac3334..ead9b4d 100644 --- a/src/drivers/ocp/dmi/smbios.c +++ b/src/drivers/ocp/dmi/smbios.c @@ -6,7 +6,6 @@ #include <delay.h> #include <cpu/x86/mp.h> #include <timer.h> -#include <stdio.h> #include <string.h> #include <soc/soc_util.h> #include <soc/util.h> diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index 55a10ad..6dd7c10 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -20,7 +20,6 @@ #include <soc/smmrelocate.h> #include <soc/soc_util.h> #include <soc/util.h> -#include <stdio.h> #include <string.h> #include <types.h> diff --git a/tests/lib/string-test.c b/tests/lib/string-test.c index 0f21747..621a74c 100644 --- a/tests/lib/string-test.c +++ b/tests/lib/string-test.c @@ -5,7 +5,6 @@ #include <stdint.h> #include <stddef.h> #include <tests/test.h> -#include <stdio.h> /* * Important note: In every particular test, don't use any string-related -- To view, visit https://review.coreboot.org/c/coreboot/+/81853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I021ba535ba5ec683021c4dfc41ac18d9cebbcfd2 Gerrit-Change-Number: 81853 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[L] Change in libgfxinit[main]: gma tgl: Add combo PHY programming sequence
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Attention is currently required from: Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Tarun Tuli, Tim Wawrzynczak. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67496?usp=email ) Change subject: gma tgl: Add combo PHY programming sequence ...................................................................... Patch Set 30: Code-Review+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67496?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: Id0c2495872250e84057c3130cab19dea05a00b75 Gerrit-Change-Number: 67496 Gerrit-PatchSet: 30 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 11 Apr 2024 12:28:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libgfxinit[main]: gma pipe_setup: Update for TGL
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Attention is currently required from: Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Tarun Tuli, Tim Wawrzynczak. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67494?usp=email ) Change subject: gma pipe_setup: Update for TGL ...................................................................... Patch Set 31: Code-Review+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67494?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I93329c0a012da83abc379d6782fabe257dc180f3 Gerrit-Change-Number: 67494 Gerrit-PatchSet: 31 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 11 Apr 2024 12:25:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[main]: gma display_probing: Make new TGL ports available
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Attention is currently required from: Dinesh Gehlot, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/81522?usp=email ) Change subject: gma display_probing: Make new TGL ports available ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/81522?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I9d96673f931be0086536044694ecd127ba2a823d Gerrit-Change-Number: 81522 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Thu, 11 Apr 2024 12:25:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in libgfxinit[main]: gfxtest: Drop unnecessary with of ancestor
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Attention is currently required from: Dinesh Gehlot, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/81521?usp=email ) Change subject: gfxtest: Drop unnecessary with of ancestor ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/81521?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: Ibc1a6710a5cd12be9190860635e7b951d4fe4775 Gerrit-Change-Number: 81521 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Thu, 11 Apr 2024 12:24:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in libgfxinit[main]: gfxtest: Drop unnecessary with of ancestor
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Attention is currently required from: Dinesh Gehlot, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/81521?usp=email ) Change subject: gfxtest: Drop unnecessary with of ancestor ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Can't fully test it because there's other warnings, but at least `unnecessary with of ancestor` is gone. Other warnings: ``` hw-gfx-gma-gfx_test.adb:54:07: warning: component clause out of order with respect to declaration [-gnatw_r] hw-gfx-gma-gfx_test.adb:61:13: warning: component clause out of order with respect to declaration [-gnatw_r] ``` -- To view, visit https://review.coreboot.org/c/libgfxinit/+/81521?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: Ibc1a6710a5cd12be9190860635e7b951d4fe4775 Gerrit-Change-Number: 81521 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Thu, 11 Apr 2024 12:24:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in libgfxinit[main]: gfxtest: Drop unnecessary with of ancestor
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Attention is currently required from: Dinesh Gehlot, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/81521?usp=email ) Change subject: gfxtest: Drop unnecessary with of ancestor ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/81521?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: Ibc1a6710a5cd12be9190860635e7b951d4fe4775 Gerrit-Change-Number: 81521 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Thu, 11 Apr 2024 12:23:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/craaskov: Disable external fivr
by Felix Held (Code Review) 11 Apr '24

11 Apr '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81607?usp=email ) Change subject: mb/google/nissa/var/craaskov: Disable external fivr ...................................................................... mb/google/nissa/var/craaskov: Disable external fivr In next phase, craaskov will remove external fivr. Use the board version to config external fivr for backward compatibility and show message. BUG=b:330253778 TEST=boot to ChromeOS, cold reboot/suspend/recovery mode/install OS work normally. Change-Id: I9280a86bf78caa10b527a6569ac580dfe1d66f60 Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81607 Reviewed-by: Eric Lai <ericllai(a)google.com> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/brya/variants/craaskov/overridetree.cb M src/mainboard/google/brya/variants/craaskov/variant.c 2 files changed, 26 insertions(+), 15 deletions(-) Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Sumeet R Pawnikar: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/craaskov/overridetree.cb b/src/mainboard/google/brya/variants/craaskov/overridetree.cb index 686c829..eee5402 100644 --- a/src/mainboard/google/brya/variants/craaskov/overridetree.cb +++ b/src/mainboard/google/brya/variants/craaskov/overridetree.cb @@ -60,21 +60,6 @@ register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_E22, .pad_auxn_dc = GPP_E23}" - # Configure external V1P05/Vnn/VnnSx Rails - register "ext_fivr_settings" = "{ - .configure_ext_fivr = 1, - .v1p05_enable_bitmap = FIVR_ENABLE_ALL_SX & ~FIVR_ENABLE_S0, - .vnn_enable_bitmap = FIVR_ENABLE_ALL_SX, - .vnn_sx_enable_bitmap = FIVR_ENABLE_ALL_SX, - .v1p05_supported_voltage_bitmap = FIVR_VOLTAGE_NORMAL, - .vnn_supported_voltage_bitmap = FIVR_VOLTAGE_MIN_ACTIVE, - .v1p05_voltage_mv = 1050, - .vnn_voltage_mv = 780, - .vnn_sx_voltage_mv = 1050, - .v1p05_icc_max_ma = 500, - .vnn_icc_max_ma = 500, - }" - register "serial_io_i2c_mode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, [PchSerialIoIndexI2C1] = PchSerialIoPci, diff --git a/src/mainboard/google/brya/variants/craaskov/variant.c b/src/mainboard/google/brya/variants/craaskov/variant.c index 68f128c..cee0308 100644 --- a/src/mainboard/google/brya/variants/craaskov/variant.c +++ b/src/mainboard/google/brya/variants/craaskov/variant.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <baseboard/variants.h> +#include <boardid.h> #include <device/device.h> #include <sar.h> @@ -31,3 +32,28 @@ ish->enabled = 0; } } + +void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config) +{ + const uint32_t id = board_id(); + if (id == BOARD_ID_UNKNOWN || id < 2) { // proto=0, EVT=1 + config->ext_fivr_settings.configure_ext_fivr = 1; + + config->ext_fivr_settings.v1p05_enable_bitmap = + FIVR_ENABLE_ALL_SX & ~FIVR_ENABLE_S0; + config->ext_fivr_settings.vnn_enable_bitmap = + FIVR_ENABLE_ALL_SX; + config->ext_fivr_settings.vnn_sx_enable_bitmap = + FIVR_ENABLE_ALL_SX; + config->ext_fivr_settings.v1p05_supported_voltage_bitmap = + FIVR_VOLTAGE_NORMAL; + config->ext_fivr_settings.vnn_supported_voltage_bitmap = + FIVR_VOLTAGE_MIN_ACTIVE; + config->ext_fivr_settings.v1p05_voltage_mv = 1050; + config->ext_fivr_settings.vnn_voltage_mv = 780; + config->ext_fivr_settings.vnn_sx_voltage_mv = 1050; + config->ext_fivr_settings.v1p05_icc_max_ma = 500; + config->ext_fivr_settings.vnn_icc_max_ma = 500; + printk(BIOS_INFO, "Configured external FIVR\n"); + } +} -- To view, visit https://review.coreboot.org/c/coreboot/+/81607?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9280a86bf78caa10b527a6569ac580dfe1d66f60 Gerrit-Change-Number: 81607 Gerrit-PatchSet: 8 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: tree: Drop duplicated <device/{path,resource}.h>
by Elyes Haouas (Code Review) 11 Apr '24

11 Apr '24

Attention is currently required from: Arthur Heymans, Caveh Jalali, Christian Walter, Cliff Huang, Elyes Haouas, Felix Held, Forest Mittelberg, Fred Reitberger, Hung-Te Lin, Jakub Czapiga, Jason Glenesk, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lance Zhao, Lean Sheng Tan, Matt DeVillier, Patrick Rudolph, Sean Rhodes, Shuo Liu, Tim Chu, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu. Hello Arthur Heymans, Caveh Jalali, Christian Walter, Cliff Huang, Felix Held, Forest Mittelberg, Fred Reitberger, Hung-Te Lin, Jakub Czapiga, Jason Glenesk, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lance Zhao, Lean Sheng Tan, Matt DeVillier, Patrick Rudolph, Sean Rhodes, Shuo Liu, Tim Chu, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81830?usp=email to look at the new patch set (#3). Change subject: tree: Drop duplicated <device/{path,resource}.h> ...................................................................... tree: Drop duplicated <device/{path,resource}.h> <device/device.h> is supposed to provide <device/{path,resource}.h> Change-Id: I2ef82c8fe30b1c1399a9f85c1734ce8ba16a1f88 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/acpi/device.c M src/arch/x86/cpu.c M src/arch/x86/mpspec.c M src/cpu/x86/mp_init.c M src/device/device_const.c M src/device/device_util.c M src/device/oprom/yabel/device.c M src/device/oprom/yabel/io.c M src/device/oprom/yabel/mem.c M src/drivers/generic/adau7002/adau7002.c M src/drivers/generic/alc1015/alc1015.c M src/drivers/generic/bayhub/bh720.c M src/drivers/generic/bayhub_lv2/lv2.c M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/generic/max98357a/max98357a.c M src/drivers/generic/nau8315/nau8315.c M src/drivers/genesyslogic/gl9755/gl9755.c M src/drivers/genesyslogic/gl9763e/gl9763e.c M src/drivers/i2c/cs35l53/cs35l53.c M src/drivers/i2c/cs42l42/cs42l42.c M src/drivers/i2c/da7219/da7219.c M src/drivers/i2c/generic/generic.c M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c M src/drivers/i2c/max98373/max98373.c M src/drivers/i2c/max98390/max98390.c M src/drivers/i2c/max98396/max98396.c M src/drivers/i2c/max98927/max98927.c M src/drivers/i2c/nau8825/nau8825.c M src/drivers/i2c/rt1011/rt1011.c M src/drivers/i2c/rt5663/rt5663.c M src/drivers/i2c/sx9310/sx9310.c M src/drivers/i2c/sx9324/sx9324.c M src/drivers/i2c/sx9360/sx9360.c M src/drivers/i2c/tpm/chip.c M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/soundwire/soundwire.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/nxp/uwb/uwb.c M src/drivers/sof/sof.c M src/drivers/soundwire/alc1308/alc1308.c M src/drivers/soundwire/alc5682/alc5682.c M src/drivers/soundwire/alc711/alc711.c M src/drivers/soundwire/cs42l42/cs42l42.c M src/drivers/soundwire/max98363/max98363.c M src/drivers/soundwire/max98373/max98373.c M src/drivers/spi/acpi/acpi.c M src/drivers/uart/acpi/acpi.c M src/drivers/usb/acpi/usb_acpi.c M src/ec/google/chromeec/audio_codec/audio_codec.c M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c M src/include/device/pci.h M src/include/reg_script.h M src/lib/reg_script.c M src/soc/amd/common/block/root_complex/ioapic.c M src/soc/amd/common/fsp/fsp_graphics.c M src/soc/intel/apollolake/romstage.c M src/soc/intel/cannonlake/graphics.c M src/soc/intel/common/block/smbus/smbus.c M src/soc/intel/common/block/usb4/pcie.c M src/soc/intel/xeon_sp/include/soc/chip_common.h M src/soc/intel/xeon_sp/spr/ioat.c M src/soc/mediatek/common/pcie.c M src/southbridge/intel/bd82x6x/smbus.c M src/southbridge/intel/common/smbus_ops.c M src/southbridge/intel/i82801gx/smbus.c M src/southbridge/intel/i82801ix/smbus.c M src/southbridge/intel/i82801jx/smbus.c M src/southbridge/intel/ibexpeak/smbus.c M src/southbridge/intel/lynxpoint/smbus.c M tests/lib/bootmem-test.c M tests/lib/memrange-test.c M util/vgabios/device.c 74 files changed, 0 insertions(+), 75 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/81830/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81830?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2ef82c8fe30b1c1399a9f85c1734ce8ba16a1f88 Gerrit-Change-Number: 81830 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/karis: Add FW_CONFIG and device for VPU
by Felix Held (Code Review) 11 Apr '24

11 Apr '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81655?usp=email ) Change subject: mb/google/karis: Add FW_CONFIG and device for VPU ...................................................................... mb/google/karis: Add FW_CONFIG and device for VPU BUG=b:333605309 TEST=set and unset bit20 in HW_CONFIG and check if VPU(0b.0) is enabled when bit20 is set, and disabled when cleared. Change-Id: I6e2230715d783ea7108d71699fd19684ce19e2ff Signed-off-by: Jamie Ryu <jamie.m.ryu(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81655 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/rex/variants/karis/overridetree.cb 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Sumeet R Pawnikar: Looks good to me, approved build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved diff --git a/src/mainboard/google/rex/variants/karis/overridetree.cb b/src/mainboard/google/rex/variants/karis/overridetree.cb index c74b51c..c654933 100644 --- a/src/mainboard/google/rex/variants/karis/overridetree.cb +++ b/src/mainboard/google/rex/variants/karis/overridetree.cb @@ -34,6 +34,10 @@ option DISABLE 0 option ENABLE 1 end + field VPU 22 + option VPU_DIS 0 + option VPU_EN 1 + end end chip soc/intel/meteorlake @@ -581,5 +585,8 @@ end end device ref hda on end + device ref vpu on + probe VPU VPU_EN + end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/81655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6e2230715d783ea7108d71699fd19684ce19e2ff Gerrit-Change-Number: 81655 Gerrit-PatchSet: 3 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Daniel Kang <daniel.h.kang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024