coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[M] Change in coreboot[main]: tree: Drop duplicated <device/{path,resource}.h>
by Elyes Haouas (Code Review) 11 Apr '24

11 Apr '24

Attention is currently required from: Arthur Heymans, Caveh Jalali, Christian Walter, Cliff Huang, Elyes Haouas, Felix Held, Forest Mittelberg, Fred Reitberger, Hung-Te Lin, Jakub Czapiga, Jason Glenesk, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lance Zhao, Lean Sheng Tan, Matt DeVillier, Patrick Rudolph, Sean Rhodes, Shuo Liu, Tim Chu, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu. Hello Arthur Heymans, Caveh Jalali, Christian Walter, Cliff Huang, Felix Held, Forest Mittelberg, Fred Reitberger, Hung-Te Lin, Jakub Czapiga, Jason Glenesk, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lance Zhao, Lean Sheng Tan, Matt DeVillier, Patrick Rudolph, Sean Rhodes, Shuo Liu, Tim Chu, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81830?usp=email to look at the new patch set (#2). Change subject: tree: Drop duplicated <device/{path,resource}.h> ...................................................................... tree: Drop duplicated <device/{path,resource}.h> <device/pci.h> is supposed to provide <device/{path,resource}.h> Change-Id: I2ef82c8fe30b1c1399a9f85c1734ce8ba16a1f88 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/acpi/device.c M src/arch/x86/cpu.c M src/arch/x86/mpspec.c M src/cpu/x86/mp_init.c M src/device/device_const.c M src/device/device_util.c M src/device/oprom/yabel/device.c M src/device/oprom/yabel/io.c M src/device/oprom/yabel/mem.c M src/drivers/generic/adau7002/adau7002.c M src/drivers/generic/alc1015/alc1015.c M src/drivers/generic/bayhub/bh720.c M src/drivers/generic/bayhub_lv2/lv2.c M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/generic/max98357a/max98357a.c M src/drivers/generic/nau8315/nau8315.c M src/drivers/genesyslogic/gl9755/gl9755.c M src/drivers/genesyslogic/gl9763e/gl9763e.c M src/drivers/i2c/cs35l53/cs35l53.c M src/drivers/i2c/cs42l42/cs42l42.c M src/drivers/i2c/da7219/da7219.c M src/drivers/i2c/generic/generic.c M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c M src/drivers/i2c/max98373/max98373.c M src/drivers/i2c/max98390/max98390.c M src/drivers/i2c/max98396/max98396.c M src/drivers/i2c/max98927/max98927.c M src/drivers/i2c/nau8825/nau8825.c M src/drivers/i2c/rt1011/rt1011.c M src/drivers/i2c/rt5663/rt5663.c M src/drivers/i2c/sx9310/sx9310.c M src/drivers/i2c/sx9324/sx9324.c M src/drivers/i2c/sx9360/sx9360.c M src/drivers/i2c/tpm/chip.c M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/soundwire/soundwire.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/nxp/uwb/uwb.c M src/drivers/sof/sof.c M src/drivers/soundwire/alc1308/alc1308.c M src/drivers/soundwire/alc5682/alc5682.c M src/drivers/soundwire/alc711/alc711.c M src/drivers/soundwire/cs42l42/cs42l42.c M src/drivers/soundwire/max98363/max98363.c M src/drivers/soundwire/max98373/max98373.c M src/drivers/spi/acpi/acpi.c M src/drivers/uart/acpi/acpi.c M src/drivers/usb/acpi/usb_acpi.c M src/ec/google/chromeec/audio_codec/audio_codec.c M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c M src/include/device/pci.h M src/include/reg_script.h M src/lib/reg_script.c M src/soc/amd/common/block/root_complex/ioapic.c M src/soc/amd/common/fsp/fsp_graphics.c M src/soc/intel/apollolake/romstage.c M src/soc/intel/cannonlake/graphics.c M src/soc/intel/common/block/smbus/smbus.c M src/soc/intel/common/block/usb4/pcie.c M src/soc/intel/xeon_sp/include/soc/chip_common.h M src/soc/intel/xeon_sp/spr/ioat.c M src/soc/mediatek/common/pcie.c M src/southbridge/intel/bd82x6x/smbus.c M src/southbridge/intel/common/smbus_ops.c M src/southbridge/intel/i82801gx/smbus.c M src/southbridge/intel/i82801ix/smbus.c M src/southbridge/intel/i82801jx/smbus.c M src/southbridge/intel/ibexpeak/smbus.c M src/southbridge/intel/lynxpoint/smbus.c M tests/lib/bootmem-test.c M tests/lib/memrange-test.c M util/vgabios/device.c 74 files changed, 0 insertions(+), 75 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/81830/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81830?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2ef82c8fe30b1c1399a9f85c1734ce8ba16a1f88 Gerrit-Change-Number: 81830 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[XS] Change in libgfxinit[main]: tgl plls: Disable warnings about unused variable
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/81852?usp=email ) Change subject: tgl plls: Disable warnings about unused variable ...................................................................... tgl plls: Disable warnings about unused variable Looks like this is yet-to-be-implemented code. To be able to build-test other changes, turn off some warnings about the `PLLs` variable. TEST=Run this and make sure all builds pass: for f in configs/* do make distclean make DEBUG=1 cnf=$f -j$(nproc) done Change-Id: I51a14f7a9d6d6d930b9239ed5d0f61c45f2f123b Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M common/tigerlake/hw-gfx-gma-plls.adb 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/52/81852/1 diff --git a/common/tigerlake/hw-gfx-gma-plls.adb b/common/tigerlake/hw-gfx-gma-plls.adb index bf58f57..2823870 100644 --- a/common/tigerlake/hw-gfx-gma-plls.adb +++ b/common/tigerlake/hw-gfx-gma-plls.adb @@ -27,7 +27,14 @@ end record; type PLL_State_Array is array (Configurable_DPLLs) of PLL_State; + + pragma Warnings (Off, "unused variable ""PLLs""", + Reason => "Not yet implemented."); + pragma Warnings (Off, "variable ""PLLs"" is assigned but never read", + Reason => "Not yet implemented."); PLLs : PLL_State_Array; + pragma Warnings (On, "variable ""PLLs"" is assigned but never read"); + pragma Warnings (On, "unused variable ""PLLs"""); procedure Initialize is begin -- To view, visit https://review.coreboot.org/c/libgfxinit/+/81852?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I51a14f7a9d6d6d930b9239ed5d0f61c45f2f123b Gerrit-Change-Number: 81852 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[main]: tree: Drop duplicated <device/pci_{def,ops,rom,type}.h>
by Elyes Haouas (Code Review) 11 Apr '24

11 Apr '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81831?usp=email ) Change subject: tree: Drop duplicated <device/pci_{def,ops,rom,type}.h> ...................................................................... tree: Drop duplicated <device/pci_{def,ops,rom,type}.h> <device/pci.h> is supposed to provide <device/pci_{def,ops,rom,type}.h> Change-Id: Ia645b8dba8c688187a25916f508593f333821f88 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/commonlib/storage/pci_sdhci.c M src/cpu/intel/haswell/smmrelocate.c M src/device/cardbus_device.c M src/device/oprom/realmode/x86_interrupts.c M src/device/oprom/yabel/device.c M src/device/oprom/yabel/interrupt.c M src/device/oprom/yabel/io.c M src/device/pci_class.c M src/device/pci_device.c M src/device/pci_early.c M src/device/pci_ops.c M src/device/pci_rom.c M src/device/pciexp_device.c M src/device/pcix_device.c M src/drivers/aspeed/common/aspeed_coreboot.h M src/drivers/emulation/qemu/bochs.c M src/drivers/emulation/qemu/cirrus.c M src/drivers/generic/bayhub/bh720.c M src/drivers/generic/bayhub_lv2/lv2.c M src/drivers/genesyslogic/gl9750/gl9750.c M src/drivers/genesyslogic/gl9755/gl9755.c M src/drivers/genesyslogic/gl9763e/gl9763e.c M src/drivers/intel/gma/opregion.c M src/drivers/intel/gma/vbt.c M src/drivers/intel/i210/i210.c M src/drivers/net/atl1e.c M src/drivers/net/ne2k.c M src/drivers/net/r8168.c M src/drivers/pcie/rtd3/device/chip.c M src/drivers/ricoh/rce822/rce822.c M src/drivers/siemens/nc_fpga/nc_fpga.c M src/drivers/siemens/nc_fpga/nc_fpga_early.c M src/drivers/sil/3114/sil_sata.c M src/drivers/uart/oxpcie.c M src/drivers/uart/oxpcie_early.c M src/drivers/usb/pci_ehci.c M src/lib/reg_script.c M src/lib/smbios.c M src/mainboard/emulation/qemu-i440fx/mainboard.c M src/mainboard/emulation/qemu-q35/mainboard.c M src/mainboard/google/brya/variants/aurash/ramstage.c M src/mainboard/google/brya/variants/moli/ramstage.c M src/mainboard/roda/rk9/ti_pci7xx1.c M src/northbridge/amd/pi/00730F01/northbridge.c M src/northbridge/intel/e7505/northbridge.c M src/northbridge/intel/gm45/gma.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/haswell/minihd.c M src/northbridge/intel/haswell/northbridge.c M src/northbridge/intel/haswell/pcie.c M src/northbridge/intel/i440bx/northbridge.c M src/northbridge/intel/i945/early_init.c M src/northbridge/intel/i945/gma.c M src/northbridge/intel/i945/northbridge.c M src/northbridge/intel/ironlake/gma.c M src/northbridge/intel/ironlake/northbridge.c M src/northbridge/intel/pineview/gma.c M src/northbridge/intel/sandybridge/gma.c M src/northbridge/intel/sandybridge/northbridge.c M src/northbridge/intel/x4x/gma.c M src/soc/amd/common/block/acp/acp.c M src/soc/amd/common/block/data_fabric/domain.c M src/soc/amd/common/block/hda/hda.c M src/soc/amd/common/block/lpc/lpc.c M src/soc/amd/common/block/pci/amd_pci_util.c M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/fch.c M src/soc/amd/picasso/sata.c M src/soc/amd/stoneyridge/acpi.c M src/soc/amd/stoneyridge/fch.c M src/soc/amd/stoneyridge/northbridge.c M src/soc/amd/stoneyridge/sata.c M src/soc/amd/stoneyridge/usb.c M src/soc/cavium/cn81xx/ecam0.c M src/soc/cavium/cn81xx/sdram.c M src/soc/cavium/common/ecam.c M src/soc/intel/alderlake/bootblock/report_platform.c M src/soc/intel/alderlake/fsp_params.c M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/report_platform.c M src/soc/intel/baytrail/gfx.c M src/soc/intel/baytrail/lpe.c M src/soc/intel/baytrail/pcie.c M src/soc/intel/baytrail/pmutil.c M src/soc/intel/baytrail/sata.c M src/soc/intel/baytrail/sd.c M src/soc/intel/baytrail/southcluster.c M src/soc/intel/baytrail/xhci.c M src/soc/intel/braswell/chip.c M src/soc/intel/braswell/lpe.c M src/soc/intel/braswell/pcie.c M src/soc/intel/braswell/pmutil.c M src/soc/intel/braswell/sd.c M src/soc/intel/braswell/southcluster.c M src/soc/intel/broadwell/gma.c M src/soc/intel/broadwell/memmap.c M src/soc/intel/broadwell/minihd.c M src/soc/intel/broadwell/northbridge.c M src/soc/intel/broadwell/pch/adsp.c M src/soc/intel/broadwell/pch/hda.c M src/soc/intel/broadwell/pch/lpc.c M src/soc/intel/broadwell/pch/me.c M src/soc/intel/broadwell/pch/me_status.c M src/soc/intel/broadwell/pch/pch.c M src/soc/intel/broadwell/pch/pcie.c M src/soc/intel/broadwell/pch/pmutil.c M src/soc/intel/broadwell/pch/power_state.c M src/soc/intel/broadwell/pch/sata.c M src/soc/intel/broadwell/pch/serialio.c M src/soc/intel/broadwell/pch/usb_ehci.c M src/soc/intel/broadwell/pch/usb_xhci.c M src/soc/intel/broadwell/report_platform.c M src/soc/intel/cannonlake/bootblock/report_platform.c M src/soc/intel/cannonlake/lpc.c M src/soc/intel/cannonlake/systemagent.c M src/soc/intel/common/block/cpu/smmrelocate.c M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/cse/disable_heci.c M src/soc/intel/common/block/fast_spi/fast_spi.c M src/soc/intel/common/block/i2c/i2c.c M src/soc/intel/common/block/irq/irq.c M src/soc/intel/common/block/lpc/lpc_lib.c M src/soc/intel/common/block/p2sb/p2sb.c M src/soc/intel/common/block/pcie/pcie.c M src/soc/intel/common/block/pcie/rtd3/rtd3.c M src/soc/intel/common/block/pmc/pmc.c M src/soc/intel/common/block/smbus/tco.c M src/soc/intel/common/block/spi/spi.c M src/soc/intel/common/block/systemagent/systemagent_early.c M src/soc/intel/common/block/uart/uart.c M src/soc/intel/denverton_ns/acpi.c M src/soc/intel/denverton_ns/bootblock/bootblock.c M src/soc/intel/denverton_ns/lpc.c M src/soc/intel/denverton_ns/pmc.c M src/soc/intel/denverton_ns/sata.c M src/soc/intel/denverton_ns/soc_util.c M src/soc/intel/denverton_ns/systemagent.c M src/soc/intel/denverton_ns/uart.c M src/soc/intel/denverton_ns/xhci.c M src/soc/intel/elkhartlake/bootblock/report_platform.c M src/soc/intel/elkhartlake/espi.c M src/soc/intel/elkhartlake/systemagent.c M src/soc/intel/elkhartlake/tsn_gbe.c M src/soc/intel/jasperlake/bootblock/report_platform.c M src/soc/intel/jasperlake/espi.c M src/soc/intel/jasperlake/systemagent.c M src/soc/intel/meteorlake/bootblock/report_platform.c M src/soc/intel/skylake/bootblock/report_platform.c M src/soc/intel/skylake/finalize.c M src/soc/intel/skylake/irq.c M src/soc/intel/skylake/me.c M src/soc/intel/skylake/pmutil.c M src/soc/intel/tigerlake/bootblock/report_platform.c M src/soc/intel/tigerlake/espi.c M src/soc/intel/tigerlake/fsp_params.c M src/soc/intel/tigerlake/systemagent.c M src/soc/intel/xeon_sp/chip_gen1.c M src/soc/intel/xeon_sp/cpx/chip.c M src/soc/intel/xeon_sp/numa.c M src/soc/intel/xeon_sp/skx/soc_util.c M src/soc/intel/xeon_sp/spr/chip.c M src/southbridge/amd/common/amd_pci_util.c M src/southbridge/amd/pi/hudson/hudson.c M src/southbridge/amd/pi/hudson/lpc.c M src/southbridge/amd/pi/hudson/sata.c M src/southbridge/amd/pi/hudson/sd.c M src/southbridge/intel/bd82x6x/azalia.c M src/southbridge/intel/bd82x6x/common.c M src/southbridge/intel/bd82x6x/elog.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/bd82x6x/me.c M src/southbridge/intel/bd82x6x/me_8.x.c M src/southbridge/intel/bd82x6x/me_common.c M src/southbridge/intel/bd82x6x/me_smm.c M src/southbridge/intel/bd82x6x/pch.c M src/southbridge/intel/bd82x6x/pci.c M src/southbridge/intel/bd82x6x/pcie.c M src/southbridge/intel/bd82x6x/sata.c M src/southbridge/intel/bd82x6x/smbus.c M src/southbridge/intel/bd82x6x/usb_ehci.c M src/southbridge/intel/bd82x6x/usb_xhci.c M src/southbridge/intel/common/spi.c M src/southbridge/intel/common/watchdog.c M src/southbridge/intel/i82371eb/early_pm.c M src/southbridge/intel/i82371eb/early_smbus.c M src/southbridge/intel/i82371eb/ide.c M src/southbridge/intel/i82371eb/isa.c M src/southbridge/intel/i82371eb/smbus.c M src/southbridge/intel/i82801dx/ac97.c M src/southbridge/intel/i82801dx/i82801dx.c M src/southbridge/intel/i82801dx/ide.c M src/southbridge/intel/i82801dx/lpc.c M src/southbridge/intel/i82801dx/usb.c M src/southbridge/intel/i82801dx/usb2.c M src/southbridge/intel/i82801gx/ac97.c M src/southbridge/intel/i82801gx/azalia.c M src/southbridge/intel/i82801gx/i82801gx.c M src/southbridge/intel/i82801gx/ide.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801gx/pci.c M src/southbridge/intel/i82801gx/pcie.c M src/southbridge/intel/i82801gx/sata.c M src/southbridge/intel/i82801gx/usb.c M src/southbridge/intel/i82801gx/usb_ehci.c M src/southbridge/intel/i82801ix/azalia.c M src/southbridge/intel/i82801ix/i82801ix.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801ix/pci.c M src/southbridge/intel/i82801ix/pcie.c M src/southbridge/intel/i82801ix/sata.c M src/southbridge/intel/i82801ix/smbus.c M src/southbridge/intel/i82801ix/thermal.c M src/southbridge/intel/i82801ix/usb_ehci.c M src/southbridge/intel/i82801jx/azalia.c M src/southbridge/intel/i82801jx/i82801jx.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/i82801jx/pci.c M src/southbridge/intel/i82801jx/pcie.c M src/southbridge/intel/i82801jx/sata.c M src/southbridge/intel/i82801jx/smbus.c M src/southbridge/intel/i82801jx/thermal.c M src/southbridge/intel/i82801jx/usb_ehci.c M src/southbridge/intel/i82870/ioapic.c M src/southbridge/intel/i82870/pcibridge.c M src/southbridge/intel/ibexpeak/azalia.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/ibexpeak/me.c M src/southbridge/intel/ibexpeak/pch.c M src/southbridge/intel/ibexpeak/sata.c M src/southbridge/intel/ibexpeak/smbus.c M src/southbridge/intel/ibexpeak/usb_ehci.c M src/southbridge/intel/lynxpoint/azalia.c M src/southbridge/intel/lynxpoint/elog.c M src/southbridge/intel/lynxpoint/lp_gpio.c M src/southbridge/intel/lynxpoint/lpc.c M src/southbridge/intel/lynxpoint/me.c M src/southbridge/intel/lynxpoint/pch.c M src/southbridge/intel/lynxpoint/pcie.c M src/southbridge/intel/lynxpoint/sata.c M src/southbridge/intel/lynxpoint/serialio.c M src/southbridge/intel/lynxpoint/smbus.c M src/southbridge/intel/lynxpoint/usb_ehci.c M src/southbridge/intel/lynxpoint/usb_xhci.c M src/southbridge/ricoh/rl5c476/rl5c476.c M src/southbridge/ti/pci1x2x/pci1x2x.c M src/southbridge/ti/pci7420/cardbus.c M src/southbridge/ti/pci7420/firewire.c M util/vgabios/device.c 249 files changed, 0 insertions(+), 250 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/81831/1 diff --git a/src/commonlib/storage/pci_sdhci.c b/src/commonlib/storage/pci_sdhci.c index f7922d4..8c4d4cf 100644 --- a/src/commonlib/storage/pci_sdhci.c +++ b/src/commonlib/storage/pci_sdhci.c @@ -2,7 +2,6 @@ #include <commonlib/sdhci.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <stdint.h> #include "sd_mmc.h" diff --git a/src/cpu/intel/haswell/smmrelocate.c b/src/cpu/intel/haswell/smmrelocate.c index 9e3554f..16e0577 100644 --- a/src/cpu/intel/haswell/smmrelocate.c +++ b/src/cpu/intel/haswell/smmrelocate.c @@ -4,7 +4,6 @@ #include <string.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/device/cardbus_device.c b/src/device/cardbus_device.c index 2eb070e..32cdcb2 100644 --- a/src/device/cardbus_device.c +++ b/src/device/cardbus_device.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/cardbus.h> #include <types.h> diff --git a/src/device/oprom/realmode/x86_interrupts.c b/src/device/oprom/realmode/x86_interrupts.c index 71fc1d5..8ef44cb 100644 --- a/src/device/oprom/realmode/x86_interrupts.c +++ b/src/device/oprom/realmode/x86_interrupts.c @@ -3,7 +3,6 @@ #include <arch/registers.h> #include <console/console.h> #include <device/pci.h> -#include <device/pci_ops.h> /* we use x86emu's register file representation */ #include <x86emu/regs.h> diff --git a/src/device/oprom/yabel/device.c b/src/device/oprom/yabel/device.c index 13723fe..2badebe 100644 --- a/src/device/oprom/yabel/device.c +++ b/src/device/oprom/yabel/device.c @@ -39,7 +39,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> /* the device we are working with... */ biosemu_device_t bios_device; diff --git a/src/device/oprom/yabel/interrupt.c b/src/device/oprom/yabel/interrupt.c index e78a3cb..69c43cb 100644 --- a/src/device/oprom/yabel/interrupt.c +++ b/src/device/oprom/yabel/interrupt.c @@ -46,7 +46,6 @@ #include "../x86emu/prim_ops.h" #include <device/pci.h> -#include <device/pci_ops.h> //setup to run the code at the address, that the Interrupt Vector points to... static void diff --git a/src/device/oprom/yabel/io.c b/src/device/oprom/yabel/io.c index 8005bab..f4ab6ae 100644 --- a/src/device/oprom/yabel/io.c +++ b/src/device/oprom/yabel/io.c @@ -42,7 +42,6 @@ #include "io.h" #include <device/pci.h> -#include <device/pci_ops.h> #include <arch/io.h> diff --git a/src/device/pci_class.c b/src/device/pci_class.c index 9f2e7d6..e04e7b3 100644 --- a/src/device/pci_class.c +++ b/src/device/pci_class.c @@ -3,7 +3,6 @@ #include <commonlib/bsd/helpers.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <stddef.h> typedef struct { diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 8ead8a5..7be4288 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -8,7 +8,6 @@ #include <acpi/acpi.h> #include <assert.h> #include <cbmem.h> -#include <device/pci_ops.h> #include <bootmode.h> #include <console/console.h> #include <cpu/cpu.h> diff --git a/src/device/pci_early.c b/src/device/pci_early.c index 86278f9..245d3c0 100644 --- a/src/device/pci_early.c +++ b/src/device/pci_early.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/pci.h> -#include <device/pci_ops.h> #include <delay.h> void pci_s_assert_secondary_reset(pci_devfn_t p2p_bridge) diff --git a/src/device/pci_ops.c b/src/device/pci_ops.c index 31b7345..19bca7b 100644 --- a/src/device/pci_ops.c +++ b/src/device/pci_ops.c @@ -3,7 +3,6 @@ #include <stdint.h> #include <console/console.h> #include <device/pci.h> -#include <device/pci_ops.h> u8 *const pci_mmconf = (void *)(uintptr_t)CONFIG_ECAM_MMCONF_BASE_ADDRESS; diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index 1e212ab..a29af6a 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <stdio.h> #include <string.h> #include <cbfs.h> diff --git a/src/device/pciexp_device.c b/src/device/pciexp_device.c index db351ef..e036dfe 100644 --- a/src/device/pciexp_device.c +++ b/src/device/pciexp_device.c @@ -6,7 +6,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/pciexp.h> static unsigned int ext_cap_id(unsigned int cap) diff --git a/src/device/pcix_device.c b/src/device/pcix_device.c index 7ddc15d..c919b6c 100644 --- a/src/device/pcix_device.c +++ b/src/device/pcix_device.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pcix.h> #include <stdint.h> diff --git a/src/drivers/aspeed/common/aspeed_coreboot.h b/src/drivers/aspeed/common/aspeed_coreboot.h index 3f740b2..125adc0 100644 --- a/src/drivers/aspeed/common/aspeed_coreboot.h +++ b/src/drivers/aspeed/common/aspeed_coreboot.h @@ -13,7 +13,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> /* coreboot <--> kernel code interface */ #define __iomem diff --git a/src/drivers/emulation/qemu/bochs.c b/src/drivers/emulation/qemu/bochs.c index 0650430..426569f 100644 --- a/src/drivers/emulation/qemu/bochs.c +++ b/src/drivers/emulation/qemu/bochs.c @@ -6,7 +6,6 @@ #include <device/mmio.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <framebuffer_info.h> #include <pc80/vga.h> #include <pc80/vga_io.h> diff --git a/src/drivers/emulation/qemu/cirrus.c b/src/drivers/emulation/qemu/cirrus.c index 1dc8ac9..42b33fd 100644 --- a/src/drivers/emulation/qemu/cirrus.c +++ b/src/drivers/emulation/qemu/cirrus.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <pc80/vga.h> #include <pc80/vga_io.h> #include <framebuffer_info.h> diff --git a/src/drivers/generic/bayhub/bh720.c b/src/drivers/generic/bayhub/bh720.c index fb782ca..13ceee8 100644 --- a/src/drivers/generic/bayhub/bh720.c +++ b/src/drivers/generic/bayhub/bh720.c @@ -6,7 +6,6 @@ #include <device/device.h> #include <device/mmio.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include <acpi/acpigen.h> #include <acpi/acpigen_pci.h> diff --git a/src/drivers/generic/bayhub_lv2/lv2.c b/src/drivers/generic/bayhub_lv2/lv2.c index 3d94ac3..b9da77d 100644 --- a/src/drivers/generic/bayhub_lv2/lv2.c +++ b/src/drivers/generic/bayhub_lv2/lv2.c @@ -6,7 +6,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pciexp.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "chip.h" #include "lv2.h" diff --git a/src/drivers/genesyslogic/gl9750/gl9750.c b/src/drivers/genesyslogic/gl9750/gl9750.c index 92d96be..8dc1964 100644 --- a/src/drivers/genesyslogic/gl9750/gl9750.c +++ b/src/drivers/genesyslogic/gl9750/gl9750.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "gl9750.h" diff --git a/src/drivers/genesyslogic/gl9755/gl9755.c b/src/drivers/genesyslogic/gl9755/gl9755.c index a160c0b..09eacc0 100644 --- a/src/drivers/genesyslogic/gl9755/gl9755.c +++ b/src/drivers/genesyslogic/gl9755/gl9755.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "gl9755.h" diff --git a/src/drivers/genesyslogic/gl9763e/gl9763e.c b/src/drivers/genesyslogic/gl9763e/gl9763e.c index 136c585..2ea0c8f 100644 --- a/src/drivers/genesyslogic/gl9763e/gl9763e.c +++ b/src/drivers/genesyslogic/gl9763e/gl9763e.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "gl9763e.h" diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c index d551638..cad80d8 100644 --- a/src/drivers/intel/gma/opregion.c +++ b/src/drivers/intel/gma/opregion.c @@ -7,7 +7,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <console/console.h> #include <cbmem.h> #include "intel_bios.h" diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c index b42c52d..d8db450 100644 --- a/src/drivers/intel/gma/vbt.c +++ b/src/drivers/intel/gma/vbt.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <device/pci_ops.h> #include <device/device.h> #include <string.h> #include <device/pci.h> diff --git a/src/drivers/intel/i210/i210.c b/src/drivers/intel/i210/i210.c index 45219c6..24983d9 100644 --- a/src/drivers/intel/i210/i210.c +++ b/src/drivers/intel/i210/i210.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <string.h> #include <types.h> #include <delay.h> diff --git a/src/drivers/net/atl1e.c b/src/drivers/net/atl1e.c index fe85b83..ff1ef11 100644 --- a/src/drivers/net/atl1e.c +++ b/src/drivers/net/atl1e.c @@ -9,7 +9,6 @@ #include <cbfs.h> #include <console/console.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <types.h> #define REG_SPI_FLASH_CTRL 0x200 diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c index 70ef0ef..b79b449 100644 --- a/src/drivers/net/ne2k.c +++ b/src/drivers/net/ne2k.c @@ -32,7 +32,6 @@ #include <console/ne2k.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include "ns8390.h" diff --git a/src/drivers/net/r8168.c b/src/drivers/net/r8168.c index 6d93ed2..2ac28ce 100644 --- a/src/drivers/net/r8168.c +++ b/src/drivers/net/r8168.c @@ -15,7 +15,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include <delay.h> #include <fmap.h> diff --git a/src/drivers/pcie/rtd3/device/chip.c b/src/drivers/pcie/rtd3/device/chip.c index 314aff8..e642767 100644 --- a/src/drivers/pcie/rtd3/device/chip.c +++ b/src/drivers/pcie/rtd3/device/chip.c @@ -8,7 +8,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include "chip.h" /* diff --git a/src/drivers/ricoh/rce822/rce822.c b/src/drivers/ricoh/rce822/rce822.c index f1cba75..0c7b6bd 100644 --- a/src/drivers/ricoh/rce822/rce822.c +++ b/src/drivers/ricoh/rce822/rce822.c @@ -3,7 +3,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include "chip.h" static void rce822_enable(struct device *dev) diff --git a/src/drivers/siemens/nc_fpga/nc_fpga.c b/src/drivers/siemens/nc_fpga/nc_fpga.c index e9b39bc..c5f68c4 100644 --- a/src/drivers/siemens/nc_fpga/nc_fpga.c +++ b/src/drivers/siemens/nc_fpga/nc_fpga.c @@ -3,7 +3,6 @@ #include <types.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/mmio.h> #include <hwilib.h> #include <bootstate.h> diff --git a/src/drivers/siemens/nc_fpga/nc_fpga_early.c b/src/drivers/siemens/nc_fpga/nc_fpga_early.c index 830291c..9408c75 100644 --- a/src/drivers/siemens/nc_fpga/nc_fpga_early.c +++ b/src/drivers/siemens/nc_fpga/nc_fpga_early.c @@ -3,7 +3,6 @@ #include <device/mmio.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <types.h> #include "nc_fpga.h" diff --git a/src/drivers/sil/3114/sil_sata.c b/src/drivers/sil/3114/sil_sata.c index 3b895e6..678b358c9 100644 --- a/src/drivers/sil/3114/sil_sata.c +++ b/src/drivers/sil/3114/sil_sata.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> static void si_sata_init(struct device *dev) { diff --git a/src/drivers/uart/oxpcie.c b/src/drivers/uart/oxpcie.c index ae2a3a6..8c8fadd 100644 --- a/src/drivers/uart/oxpcie.c +++ b/src/drivers/uart/oxpcie.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <console/uart.h> #include <device/mmio.h> -#include <device/pci_ops.h> static void oxford_oxpcie_enable(struct device *dev) { diff --git a/src/drivers/uart/oxpcie_early.c b/src/drivers/uart/oxpcie_early.c index 206f54d..0f275c8 100644 --- a/src/drivers/uart/oxpcie_early.c +++ b/src/drivers/uart/oxpcie_early.c @@ -2,7 +2,6 @@ #include <stdint.h> #include <stddef.h> -#include <device/pci_ops.h> #include <console/uart.h> #include <device/pci.h> #include "uart8250reg.h" diff --git a/src/drivers/usb/pci_ehci.c b/src/drivers/usb/pci_ehci.c index 8b68bc2..50ef22b 100644 --- a/src/drivers/usb/pci_ehci.c +++ b/src/drivers/usb/pci_ehci.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/pci_ehci.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <device/pci.h> #include <string.h> diff --git a/src/lib/reg_script.c b/src/lib/reg_script.c index c14f927..2a1e048 100644 --- a/src/lib/reg_script.c +++ b/src/lib/reg_script.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <delay.h> #include <device/device.h> diff --git a/src/lib/smbios.c b/src/lib/smbios.c index 449e4fd..dcf12bf 100644 --- a/src/lib/smbios.c +++ b/src/lib/smbios.c @@ -15,7 +15,6 @@ #include <commonlib/helpers.h> #include <device/pci_ids.h> #include <device/pci.h> -#include <device/pci_def.h> #include <drivers/vpd/vpd.h> #include <stdlib.h> diff --git a/src/mainboard/emulation/qemu-i440fx/mainboard.c b/src/mainboard/emulation/qemu-i440fx/mainboard.c index 7debf8c..550eb79 100644 --- a/src/mainboard/emulation/qemu-i440fx/mainboard.c +++ b/src/mainboard/emulation/qemu-i440fx/mainboard.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <pc80/keyboard.h> static const unsigned char qemu_i440fx_irqs[] = { diff --git a/src/mainboard/emulation/qemu-q35/mainboard.c b/src/mainboard/emulation/qemu-q35/mainboard.c index 1ff4c04..9478c06 100644 --- a/src/mainboard/emulation/qemu-q35/mainboard.c +++ b/src/mainboard/emulation/qemu-q35/mainboard.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <pc80/keyboard.h> #include <cpu/x86/smm.h> diff --git a/src/mainboard/google/brya/variants/aurash/ramstage.c b/src/mainboard/google/brya/variants/aurash/ramstage.c index 700d173..25f3d4d 100644 --- a/src/mainboard/google/brya/variants/aurash/ramstage.c +++ b/src/mainboard/google/brya/variants/aurash/ramstage.c @@ -4,7 +4,6 @@ #include <chip.h> #include <device/device.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/pci.h> #include <drivers/intel/gma/opregion.h> #include <ec/google/chromeec/ec.h> diff --git a/src/mainboard/google/brya/variants/moli/ramstage.c b/src/mainboard/google/brya/variants/moli/ramstage.c index 2be75e4..9257598 100644 --- a/src/mainboard/google/brya/variants/moli/ramstage.c +++ b/src/mainboard/google/brya/variants/moli/ramstage.c @@ -4,7 +4,6 @@ #include <chip.h> #include <device/device.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/pci.h> #include <drivers/intel/gma/opregion.h> #include <ec/google/chromeec/ec.h> diff --git a/src/mainboard/roda/rk9/ti_pci7xx1.c b/src/mainboard/roda/rk9/ti_pci7xx1.c index 970e83d..40105ee 100644 --- a/src/mainboard/roda/rk9/ti_pci7xx1.c +++ b/src/mainboard/roda/rk9/ti_pci7xx1.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/cardbus.h> static void pci7xx1_enable(struct device *const dev) diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c index 430eeef..64b9fd8 100644 --- a/src/northbridge/amd/pi/00730F01/northbridge.c +++ b/src/northbridge/amd/pi/00730F01/northbridge.c @@ -2,7 +2,6 @@ #include <commonlib/helpers.h> #include <console/console.h> -#include <device/pci_ops.h> #include <acpi/acpi.h> #include <acpi/acpi_ivrs.h> #include <arch/ioapic.h> diff --git a/src/northbridge/intel/e7505/northbridge.c b/src/northbridge/intel/e7505/northbridge.c index 23d60dc..729775c 100644 --- a/src/northbridge/intel/e7505/northbridge.c +++ b/src/northbridge/intel/e7505/northbridge.c @@ -2,7 +2,6 @@ #include <assert.h> #include <console/console.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include <cpu/cpu.h> diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c index c53e93c..c38cc50 100644 --- a/src/northbridge/intel/gm45/gma.c +++ b/src/northbridge/intel/gm45/gma.c @@ -9,7 +9,6 @@ #include <drivers/intel/gma/opregion.h> #include <drivers/intel/gma/libgfxinit.h> #include <string.h> -#include <device/pci_ops.h> #include <commonlib/helpers.h> #include <types.h> diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index 48a0ba5..c02485c 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -3,7 +3,6 @@ #include <commonlib/helpers.h> #include <arch/io.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <bootmode.h> #include <delay.h> diff --git a/src/northbridge/intel/haswell/minihd.c b/src/northbridge/intel/haswell/minihd.c index 6abc6c1..780e65c 100644 --- a/src/northbridge/intel/haswell/minihd.c +++ b/src/northbridge/intel/haswell/minihd.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/mmio.h> #include <southbridge/intel/lynxpoint/hda_verb.h> diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c index c544ad3..b9fd22a 100644 --- a/src/northbridge/intel/haswell/northbridge.c +++ b/src/northbridge/intel/haswell/northbridge.c @@ -8,7 +8,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <boot/tables.h> #include <security/intel/txt/txt_register.h> #include <southbridge/intel/lynxpoint/pch.h> diff --git a/src/northbridge/intel/haswell/pcie.c b/src/northbridge/intel/haswell/pcie.c index 4eeaa3f..d5e1754 100644 --- a/src/northbridge/intel/haswell/pcie.c +++ b/src/northbridge/intel/haswell/pcie.c @@ -5,7 +5,6 @@ #include <device/pci.h> #include <device/pciexp.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <assert.h> #include <types.h> diff --git a/src/northbridge/intel/i440bx/northbridge.c b/src/northbridge/intel/i440bx/northbridge.c index 0a72cb7..c07632c 100644 --- a/src/northbridge/intel/i440bx/northbridge.c +++ b/src/northbridge/intel/i440bx/northbridge.c @@ -2,7 +2,6 @@ #include <console/console.h> #include <cpu/x86/mp.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/northbridge/intel/i945/early_init.c b/src/northbridge/intel/i945/early_init.c index d61949f..d773783 100644 --- a/src/northbridge/intel/i945/early_init.c +++ b/src/northbridge/intel/i945/early_init.c @@ -3,7 +3,6 @@ #include <cbmem.h> #include <cf9_reset.h> #include <console/console.h> -#include <device/pci_ops.h> #include <device/pci.h> #include <option.h> #include <romstage_handoff.h> diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index d99a733..724f8a7 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -7,7 +7,6 @@ #include <arch/io.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include <option.h> #include <edid.h> diff --git a/src/northbridge/intel/i945/northbridge.c b/src/northbridge/intel/i945/northbridge.c index 79e9ee5..3bb08a3 100644 --- a/src/northbridge/intel/i945/northbridge.c +++ b/src/northbridge/intel/i945/northbridge.c @@ -3,7 +3,6 @@ #include <cbmem.h> #include <commonlib/helpers.h> #include <console/console.h> -#include <device/pci_ops.h> #include <stdint.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/northbridge/intel/ironlake/gma.c b/src/northbridge/intel/ironlake/gma.c index 515dc2f..749a2e37 100644 --- a/src/northbridge/intel/ironlake/gma.c +++ b/src/northbridge/intel/ironlake/gma.c @@ -7,7 +7,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <drivers/intel/gma/edid.h> #include <drivers/intel/gma/i915.h> #include <drivers/intel/gma/intel_bios.h> diff --git a/src/northbridge/intel/ironlake/northbridge.c b/src/northbridge/intel/ironlake/northbridge.c index e6bc375..4084909 100644 --- a/src/northbridge/intel/ironlake/northbridge.c +++ b/src/northbridge/intel/ironlake/northbridge.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <acpi/acpi.h> #include <arch/hpet.h> -#include <device/pci_ops.h> #include <stdint.h> #include <cpu/intel/model_2065x/model_2065x.h> #include <device/device.h> diff --git a/src/northbridge/intel/pineview/gma.c b/src/northbridge/intel/pineview/gma.c index a7ff32f..04d1752 100644 --- a/src/northbridge/intel/pineview/gma.c +++ b/src/northbridge/intel/pineview/gma.c @@ -7,7 +7,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <drivers/intel/gma/i915_reg.h> #include <drivers/intel/gma/intel_bios.h> #include <drivers/intel/gma/i915.h> diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c index 2304a04..2ace285 100644 --- a/src/northbridge/intel/sandybridge/gma.c +++ b/src/northbridge/intel/sandybridge/gma.c @@ -9,7 +9,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <drivers/intel/gma/libgfxinit.h> #include <drivers/intel/gma/opregion.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/northbridge/intel/sandybridge/northbridge.c b/src/northbridge/intel/sandybridge/northbridge.c index 3db9086..d2c6b0d 100644 --- a/src/northbridge/intel/sandybridge/northbridge.c +++ b/src/northbridge/intel/sandybridge/northbridge.c @@ -5,7 +5,6 @@ #include <acpi/acpi.h> #include <acpi/acpigen.h> #include <commonlib/helpers.h> -#include <device/pci_ops.h> #include <delay.h> #include <cpu/intel/model_206ax/model_206ax.h> #include <cpu/x86/msr.h> diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c index fe0893b..c4ab05c 100644 --- a/src/northbridge/intel/x4x/gma.c +++ b/src/northbridge/intel/x4x/gma.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <commonlib/helpers.h> #include <drivers/intel/gma/intel_bios.h> #include <drivers/intel/gma/edid.h> diff --git a/src/soc/amd/common/block/acp/acp.c b/src/soc/amd/common/block/acp/acp.c index a43792e..dd14035 100644 --- a/src/soc/amd/common/block/acp/acp.c +++ b/src/soc/amd/common/block/acp/acp.c @@ -7,7 +7,6 @@ #include <amdblocks/chip.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <commonlib/helpers.h> #include "acp_def.h" diff --git a/src/soc/amd/common/block/data_fabric/domain.c b/src/soc/amd/common/block/data_fabric/domain.c index b056d60..596d64c 100644 --- a/src/soc/amd/common/block/data_fabric/domain.c +++ b/src/soc/amd/common/block/data_fabric/domain.c @@ -8,7 +8,6 @@ #include <cpu/cpu.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <types.h> void amd_pci_domain_scan_bus(struct device *domain) diff --git a/src/soc/amd/common/block/hda/hda.c b/src/soc/amd/common/block/hda/hda.c index 8bc0abd..437b56d7 100644 --- a/src/soc/amd/common/block/hda/hda.c +++ b/src/soc/amd/common/block/hda/hda.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/azalia_device.h> static const unsigned short pci_device_ids[] = { diff --git a/src/soc/amd/common/block/lpc/lpc.c b/src/soc/amd/common/block/lpc/lpc.c index 2392d5f..539bea3 100644 --- a/src/soc/amd/common/block/lpc/lpc.c +++ b/src/soc/amd/common/block/lpc/lpc.c @@ -6,7 +6,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pnp.h> -#include <device/pci_ops.h> #include <pc80/mc146818rtc.h> #include <pc80/isa-dma.h> #include <pc80/i8254.h> diff --git a/src/soc/amd/common/block/pci/amd_pci_util.c b/src/soc/amd/common/block/pci/amd_pci_util.c index ecc0498..7b38970 100644 --- a/src/soc/amd/common/block/pci/amd_pci_util.c +++ b/src/soc/amd/common/block/pci/amd_pci_util.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/pci.h> #include <arch/io.h> -#include <device/pci_ops.h> #include <amdblocks/amd_pci_util.h> #include <pc80/i8259.h> #include <soc/amd_pci_int_defs.h> diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index b95db5d..86ab393 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -7,7 +7,6 @@ #include <console/console.h> #include <acpi/acpi.h> #include <acpi/acpigen.h> -#include <device/pci_ops.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> #include <cpu/amd/cpuid.h> diff --git a/src/soc/amd/picasso/fch.c b/src/soc/amd/picasso/fch.c index 8952c16..629afe6 100644 --- a/src/soc/amd/picasso/fch.c +++ b/src/soc/amd/picasso/fch.c @@ -5,7 +5,6 @@ #include <cpu/x86/smm.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <amdblocks/amd_pci_util.h> #include <amdblocks/pci_clk_req.h> #include <amdblocks/reset.h> diff --git a/src/soc/amd/picasso/sata.c b/src/soc/amd/picasso/sata.c index fb2f7ac..a6d1957 100644 --- a/src/soc/amd/picasso/sata.c +++ b/src/soc/amd/picasso/sata.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <amdblocks/sata.h> #include <soc/southbridge.h> diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index 9dd8d72..036ca77 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -7,7 +7,6 @@ #include <console/console.h> #include <acpi/acpi.h> #include <acpi/acpigen.h> -#include <device/pci_ops.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> #include <device/device.h> diff --git a/src/soc/amd/stoneyridge/fch.c b/src/soc/amd/stoneyridge/fch.c index 3013500..93534ad 100644 --- a/src/soc/amd/stoneyridge/fch.c +++ b/src/soc/amd/stoneyridge/fch.c @@ -5,7 +5,6 @@ #include <cpu/x86/smm.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <acpi/acpi_gnvs.h> #include <amdblocks/amd_pci_util.h> #include <amdblocks/aoac.h> diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c index b51601b..14a2800 100644 --- a/src/soc/amd/stoneyridge/northbridge.c +++ b/src/soc/amd/stoneyridge/northbridge.c @@ -3,7 +3,6 @@ #include <assert.h> #include <amdblocks/acpi.h> #include <amdblocks/biosram.h> -#include <device/pci_ops.h> #include <arch/hpet.h> #include <arch/ioapic.h> #include <arch/vga.h> diff --git a/src/soc/amd/stoneyridge/sata.c b/src/soc/amd/stoneyridge/sata.c index fb2f7ac..a6d1957 100644 --- a/src/soc/amd/stoneyridge/sata.c +++ b/src/soc/amd/stoneyridge/sata.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <amdblocks/sata.h> #include <soc/southbridge.h> diff --git a/src/soc/amd/stoneyridge/usb.c b/src/soc/amd/stoneyridge/usb.c index 977144f..6968c58 100644 --- a/src/soc/amd/stoneyridge/usb.c +++ b/src/soc/amd/stoneyridge/usb.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/pci_ehci.h> #include <soc/acpi.h> #include <soc/pci_devs.h> diff --git a/src/soc/cavium/cn81xx/ecam0.c b/src/soc/cavium/cn81xx/ecam0.c index ff3e709..b7ce848 100644 --- a/src/soc/cavium/cn81xx/ecam0.c +++ b/src/soc/cavium/cn81xx/ecam0.c @@ -7,7 +7,6 @@ #include <console/console.h> #include <device/mmio.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <soc/addressmap.h> #include <soc/cavium/common/pci/chip.h> #include <soc/ecam.h> diff --git a/src/soc/cavium/cn81xx/sdram.c b/src/soc/cavium/cn81xx/sdram.c index cdfa0f7..54b1271 100644 --- a/src/soc/cavium/cn81xx/sdram.c +++ b/src/soc/cavium/cn81xx/sdram.c @@ -17,7 +17,6 @@ #include <libbdk-hal/bdk-l2c.h> #include <libdram/libdram-config.h> #include <soc/ecam.h> -#include <device/pci_ops.h> #include <device/mmio.h> #include <device/pci.h> diff --git a/src/soc/cavium/common/ecam.c b/src/soc/cavium/common/ecam.c index 1781820..91bc1bb 100644 --- a/src/soc/cavium/common/ecam.c +++ b/src/soc/cavium/common/ecam.c @@ -6,7 +6,6 @@ #define __SIMPLE_DEVICE__ -#include <device/pci_ops.h> #include <device/pci.h> #include <soc/addressmap.h> #include <soc/ecam.h> diff --git a/src/soc/intel/alderlake/bootblock/report_platform.c b/src/soc/intel/alderlake/bootblock/report_platform.c index bd4960d..321dfaa 100644 --- a/src/soc/intel/alderlake/bootblock/report_platform.c +++ b/src/soc/intel/alderlake/bootblock/report_platform.c @@ -15,7 +15,6 @@ #include <cpu/x86/name.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/bootblock.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index 33ebee3..6cb59e7 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -9,7 +9,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <drivers/intel/gma/i915_reg.h> #include <fsp/api.h> #include <fsp/fsp_debug_event.h> diff --git a/src/soc/intel/apollolake/bootblock/bootblock.c b/src/soc/intel/apollolake/bootblock/bootblock.c index cd938c5..bf9dfde 100644 --- a/src/soc/intel/apollolake/bootblock/bootblock.c +++ b/src/soc/intel/apollolake/bootblock/bootblock.c @@ -3,7 +3,6 @@ #include <bootblock_common.h> #include <cpu/x86/pae.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <gpio.h> #include <intelblocks/cpulib.h> #include <intelblocks/fast_spi.h> diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index 1d15eec..d185c71 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -8,7 +8,6 @@ #include <device/mmio.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <intelblocks/acpi.h> #include <intelblocks/cfg.h> #include <intelblocks/fast_spi.h> diff --git a/src/soc/intel/apollolake/report_platform.c b/src/soc/intel/apollolake/report_platform.c index 2e73f4a..af4060d 100644 --- a/src/soc/intel/apollolake/report_platform.c +++ b/src/soc/intel/apollolake/report_platform.c @@ -8,7 +8,6 @@ #include <cpu/x86/name.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/pci_devs.h> #include <soc/romstage.h> diff --git a/src/soc/intel/baytrail/gfx.c b/src/soc/intel/baytrail/gfx.c index 1027168..19e23d9 100644 --- a/src/soc/intel/baytrail/gfx.c +++ b/src/soc/intel/baytrail/gfx.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/soc/intel/baytrail/lpe.c b/src/soc/intel/baytrail/lpe.c index 71a1e1f..fc1f2b4 100644 --- a/src/soc/intel/baytrail/lpe.c +++ b/src/soc/intel/baytrail/lpe.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <acpi/acpi_gnvs.h> #include <console/console.h> #include <device/device.h> diff --git a/src/soc/intel/baytrail/pcie.c b/src/soc/intel/baytrail/pcie.c index de3f0c5..3806848 100644 --- a/src/soc/intel/baytrail/pcie.c +++ b/src/soc/intel/baytrail/pcie.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pciexp.h> #include <device/pci_ids.h> #include <reg_script.h> diff --git a/src/soc/intel/baytrail/pmutil.c b/src/soc/intel/baytrail/pmutil.c index 6308227..63b3d46 100644 --- a/src/soc/intel/baytrail/pmutil.c +++ b/src/soc/intel/baytrail/pmutil.c @@ -11,7 +11,6 @@ #include <device/device.h> #include <device/mmio.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <halt.h> #include <security/vboot/vbnv.h> diff --git a/src/soc/intel/baytrail/sata.c b/src/soc/intel/baytrail/sata.c index 5c81544..386a98e 100644 --- a/src/soc/intel/baytrail/sata.c +++ b/src/soc/intel/baytrail/sata.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include <soc/sata.h> diff --git a/src/soc/intel/baytrail/sd.c b/src/soc/intel/baytrail/sd.c index 920a960..00eefeb 100644 --- a/src/soc/intel/baytrail/sd.c +++ b/src/soc/intel/baytrail/sd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/soc/intel/baytrail/southcluster.c b/src/soc/intel/baytrail/southcluster.c index 1afea59..182f103 100644 --- a/src/soc/intel/baytrail/southcluster.c +++ b/src/soc/intel/baytrail/southcluster.c @@ -3,7 +3,6 @@ #include <stdint.h> #include <arch/io.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <acpi/acpi.h> #include <bootstate.h> #include <console/console.h> diff --git a/src/soc/intel/baytrail/xhci.c b/src/soc/intel/baytrail/xhci.c index 99b091c..77c8ca5 100644 --- a/src/soc/intel/baytrail/xhci.c +++ b/src/soc/intel/baytrail/xhci.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include <stdint.h> #include <reg_script.h> diff --git a/src/soc/intel/braswell/chip.c b/src/soc/intel/braswell/chip.c index 407b6ea..a7c35ac 100644 --- a/src/soc/intel/braswell/chip.c +++ b/src/soc/intel/braswell/chip.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <fsp/util.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> diff --git a/src/soc/intel/braswell/lpe.c b/src/soc/intel/braswell/lpe.c index 92632d8..62ea636 100644 --- a/src/soc/intel/braswell/lpe.c +++ b/src/soc/intel/braswell/lpe.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <acpi/acpi_gnvs.h> #include <console/console.h> #include <device/device.h> diff --git a/src/soc/intel/braswell/pcie.c b/src/soc/intel/braswell/pcie.c index 762dfd4..2d36890 100644 --- a/src/soc/intel/braswell/pcie.c +++ b/src/soc/intel/braswell/pcie.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pciexp.h> #include <device/pci_ids.h> #include <reg_script.h> diff --git a/src/soc/intel/braswell/pmutil.c b/src/soc/intel/braswell/pmutil.c index f00eb4b..479c9ad 100644 --- a/src/soc/intel/braswell/pmutil.c +++ b/src/soc/intel/braswell/pmutil.c @@ -10,7 +10,6 @@ #include <device/device.h> #include <device/mmio.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <halt.h> #include <soc/iomap.h> #include <soc/lpc.h> diff --git a/src/soc/intel/braswell/sd.c b/src/soc/intel/braswell/sd.c index 12e77c9..0150234 100644 --- a/src/soc/intel/braswell/sd.c +++ b/src/soc/intel/braswell/sd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/soc/intel/braswell/southcluster.c b/src/soc/intel/braswell/southcluster.c index 06a47bc..5d20d34 100644 --- a/src/soc/intel/braswell/southcluster.c +++ b/src/soc/intel/braswell/southcluster.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <acpi/acpi.h> #include <arch/ioapic.h> #include <bootstate.h> diff --git a/src/soc/intel/broadwell/gma.c b/src/soc/intel/broadwell/gma.c index 639a945..55ed791 100644 --- a/src/soc/intel/broadwell/gma.c +++ b/src/soc/intel/broadwell/gma.c @@ -2,7 +2,6 @@ #include <acpi/acpi.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <bootmode.h> #include <commonlib/helpers.h> #include <console/console.h> diff --git a/src/soc/intel/broadwell/memmap.c b/src/soc/intel/broadwell/memmap.c index 98c8016..061d2f5 100644 --- a/src/soc/intel/broadwell/memmap.c +++ b/src/soc/intel/broadwell/memmap.c @@ -7,7 +7,6 @@ #include <cbmem.h> #include <cpu/x86/smm.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <soc/pci_devs.h> #include <soc/systemagent.h> #include <stdint.h> diff --git a/src/soc/intel/broadwell/minihd.c b/src/soc/intel/broadwell/minihd.c index ee63501..a527849 100644 --- a/src/soc/intel/broadwell/minihd.c +++ b/src/soc/intel/broadwell/minihd.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/mmio.h> #include <soc/igd.h> #include <southbridge/intel/lynxpoint/hda_verb.h> diff --git a/src/soc/intel/broadwell/northbridge.c b/src/soc/intel/broadwell/northbridge.c index 3d2574b..50a7e2f 100644 --- a/src/soc/intel/broadwell/northbridge.c +++ b/src/soc/intel/broadwell/northbridge.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <cpu/intel/haswell/haswell.h> #include <acpi/acpi.h> -#include <device/pci_ops.h> #include <stdint.h> #include <delay.h> #include <device/device.h> diff --git a/src/soc/intel/broadwell/pch/adsp.c b/src/soc/intel/broadwell/pch/adsp.c index 7da807a..42a2d89 100644 --- a/src/soc/intel/broadwell/pch/adsp.c +++ b/src/soc/intel/broadwell/pch/adsp.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/mmio.h> #include <soc/adsp.h> #include <soc/device_nvs.h> diff --git a/src/soc/intel/broadwell/pch/hda.c b/src/soc/intel/broadwell/pch/hda.c index ad3d8e9..da5c5fd 100644 --- a/src/soc/intel/broadwell/pch/hda.c +++ b/src/soc/intel/broadwell/pch/hda.c @@ -5,7 +5,6 @@ #include <device/azalia_device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/mmio.h> #include <soc/pch.h> #include <soc/rcba.h> diff --git a/src/soc/intel/broadwell/pch/lpc.c b/src/soc/intel/broadwell/pch/lpc.c index 8a703df..d2c4919 100644 --- a/src/soc/intel/broadwell/pch/lpc.c +++ b/src/soc/intel/broadwell/pch/lpc.c @@ -7,7 +7,6 @@ #include <option.h> #include <pc80/isa-dma.h> #include <pc80/i8259.h> -#include <device/pci_ops.h> #include <arch/ioapic.h> #include <acpi/acpi.h> #include <cpu/x86/smm.h> diff --git a/src/soc/intel/broadwell/pch/me.c b/src/soc/intel/broadwell/pch/me.c index 147eb29..af70b90 100644 --- a/src/soc/intel/broadwell/pch/me.c +++ b/src/soc/intel/broadwell/pch/me.c @@ -10,7 +10,6 @@ #include <acpi/acpi.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/soc/intel/broadwell/pch/me_status.c b/src/soc/intel/broadwell/pch/me_status.c index ef6a0f3..ba865bf 100644 --- a/src/soc/intel/broadwell/pch/me_status.c +++ b/src/soc/intel/broadwell/pch/me_status.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <device/pci_ops.h> #include <console/console.h> #include <device/pci.h> #include <string.h> diff --git a/src/soc/intel/broadwell/pch/pch.c b/src/soc/intel/broadwell/pch/pch.c index ddb51cc..5abc0aa 100644 --- a/src/soc/intel/broadwell/pch/pch.c +++ b/src/soc/intel/broadwell/pch/pch.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/console.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include <soc/pch.h> diff --git a/src/soc/intel/broadwell/pch/pcie.c b/src/soc/intel/broadwell/pch/pcie.c index ef03eee..9a9fa64 100644 --- a/src/soc/intel/broadwell/pch/pcie.c +++ b/src/soc/intel/broadwell/pch/pcie.c @@ -7,7 +7,6 @@ #include <device/pci.h> #include <device/pciexp.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/lpc.h> #include <soc/pch.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/broadwell/pch/pmutil.c b/src/soc/intel/broadwell/pch/pmutil.c index 8fc1670..52ddd8b 100644 --- a/src/soc/intel/broadwell/pch/pmutil.c +++ b/src/soc/intel/broadwell/pch/pmutil.c @@ -10,7 +10,6 @@ #include <bootmode.h> #include <console/console.h> #include <device/device.h> -#include <device/pci_ops.h> #include <device/pci.h> #include <halt.h> #include <security/vboot/vbnv.h> diff --git a/src/soc/intel/broadwell/pch/power_state.c b/src/soc/intel/broadwell/pch/power_state.c index 842878b..5504259 100644 --- a/src/soc/intel/broadwell/pch/power_state.c +++ b/src/soc/intel/broadwell/pch/power_state.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <arch/io.h> -#include <device/pci_ops.h> #include <cbmem.h> #include <console/console.h> #include <device/device.h> diff --git a/src/soc/intel/broadwell/pch/sata.c b/src/soc/intel/broadwell/pch/sata.c index edb9830..23f9cab 100644 --- a/src/soc/intel/broadwell/pch/sata.c +++ b/src/soc/intel/broadwell/pch/sata.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/soc/intel/broadwell/pch/serialio.c b/src/soc/intel/broadwell/pch/serialio.c index 336b501..cccfcef 100644 --- a/src/soc/intel/broadwell/pch/serialio.c +++ b/src/soc/intel/broadwell/pch/serialio.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <acpi/acpi_gnvs.h> #include <console/console.h> #include <device/device.h> diff --git a/src/soc/intel/broadwell/pch/usb_ehci.c b/src/soc/intel/broadwell/pch/usb_ehci.c index 3ada5b2..1aeae62 100644 --- a/src/soc/intel/broadwell/pch/usb_ehci.c +++ b/src/soc/intel/broadwell/pch/usb_ehci.c @@ -4,7 +4,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ehci.h> -#include <device/pci_ops.h> #include <soc/ehci.h> #include <soc/pch.h> diff --git a/src/soc/intel/broadwell/pch/usb_xhci.c b/src/soc/intel/broadwell/pch/usb_xhci.c index e3bb40f..f4967c5 100644 --- a/src/soc/intel/broadwell/pch/usb_xhci.c +++ b/src/soc/intel/broadwell/pch/usb_xhci.c @@ -7,7 +7,6 @@ #include <device/pci_ids.h> #include <acpi/acpi.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <soc/xhci.h> #ifdef __SIMPLE_DEVICE__ diff --git a/src/soc/intel/broadwell/report_platform.c b/src/soc/intel/broadwell/report_platform.c index 5dbe196..a4ce6bf 100644 --- a/src/soc/intel/broadwell/report_platform.c +++ b/src/soc/intel/broadwell/report_platform.c @@ -6,7 +6,6 @@ #include <cpu/intel/microcode.h> #include <cpu/x86/msr.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <soc/pch.h> #include <soc/pci_devs.h> #include <soc/romstage.h> diff --git a/src/soc/intel/cannonlake/bootblock/report_platform.c b/src/soc/intel/cannonlake/bootblock/report_platform.c index c062746..f671636 100644 --- a/src/soc/intel/cannonlake/bootblock/report_platform.c +++ b/src/soc/intel/cannonlake/bootblock/report_platform.c @@ -8,7 +8,6 @@ #include <cpu/x86/name.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/bootblock.h> #include <soc/pch.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/cannonlake/lpc.c b/src/soc/intel/cannonlake/lpc.c index 8bc30da..76731ae 100644 --- a/src/soc/intel/cannonlake/lpc.c +++ b/src/soc/intel/cannonlake/lpc.c @@ -4,7 +4,6 @@ #include <device/pci.h> #include <pc80/isa-dma.h> #include <pc80/i8259.h> -#include <device/pci_ops.h> #include <arch/ioapic.h> #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> diff --git a/src/soc/intel/cannonlake/systemagent.c b/src/soc/intel/cannonlake/systemagent.c index a2bea45..2063c24 100644 --- a/src/soc/intel/cannonlake/systemagent.c +++ b/src/soc/intel/cannonlake/systemagent.c @@ -3,7 +3,6 @@ #include <device/device.h> #include <delay.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <intelblocks/power_limit.h> #include <intelblocks/systemagent.h> #include <soc/cpu.h> diff --git a/src/soc/intel/common/block/cpu/smmrelocate.c b/src/soc/intel/common/block/cpu/smmrelocate.c index 4df90fd..82474b3 100644 --- a/src/soc/intel/common/block/cpu/smmrelocate.c +++ b/src/soc/intel/common/block/cpu/smmrelocate.c @@ -10,7 +10,6 @@ #include <cpu/x86/smm.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <smp/node.h> #include <soc/cpu.h> #include <soc/msr.h> diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index d0ca57b..3940f6c 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -9,7 +9,6 @@ #include <delay.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <intelblocks/cse.h> #include <intelblocks/me.h> #include <intelblocks/pmclib.h> diff --git a/src/soc/intel/common/block/cse/disable_heci.c b/src/soc/intel/common/block/cse/disable_heci.c index 625de75..e943a395 100644 --- a/src/soc/intel/common/block/cse/disable_heci.c +++ b/src/soc/intel/common/block/cse/disable_heci.c @@ -6,7 +6,6 @@ #include <console/console.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <intelblocks/cse.h> #include <intelblocks/p2sb.h> #include <intelblocks/pcr.h> diff --git a/src/soc/intel/common/block/fast_spi/fast_spi.c b/src/soc/intel/common/block/fast_spi/fast_spi.c index 74449df..2ec055f 100644 --- a/src/soc/intel/common/block/fast_spi/fast_spi.c +++ b/src/soc/intel/common/block/fast_spi/fast_spi.c @@ -9,7 +9,6 @@ #include <assert.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <console/console.h> #include <commonlib/helpers.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/common/block/i2c/i2c.c b/src/soc/intel/common/block/i2c/i2c.c index c0f0b6e0..61bef57 100644 --- a/src/soc/intel/common/block/i2c/i2c.c +++ b/src/soc/intel/common/block/i2c/i2c.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/i2c_simple.h> diff --git a/src/soc/intel/common/block/irq/irq.c b/src/soc/intel/common/block/irq/irq.c index 4ffe138..1380a66 100644 --- a/src/soc/intel/common/block/irq/irq.c +++ b/src/soc/intel/common/block/irq/irq.c @@ -3,7 +3,6 @@ #include <assert.h> #include <console/console.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <intelblocks/gpio.h> #include <intelblocks/irq.h> #include <intelblocks/lpc_lib.h> diff --git a/src/soc/intel/common/block/lpc/lpc_lib.c b/src/soc/intel/common/block/lpc/lpc_lib.c index 9a7165b..f0d7aa8 100644 --- a/src/soc/intel/common/block/lpc/lpc_lib.c +++ b/src/soc/intel/common/block/lpc/lpc_lib.c @@ -6,7 +6,6 @@ #include <assert.h> #include <console/console.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <intelblocks/gpmr.h> #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> diff --git a/src/soc/intel/common/block/p2sb/p2sb.c b/src/soc/intel/common/block/p2sb/p2sb.c index e348501..58fd64b 100644 --- a/src/soc/intel/common/block/p2sb/p2sb.c +++ b/src/soc/intel/common/block/p2sb/p2sb.c @@ -2,7 +2,6 @@ #define __SIMPLE_DEVICE__ -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/soc/intel/common/block/pcie/pcie.c b/src/soc/intel/common/block/pcie/pcie.c index 5c6681d..81b4a1e 100644 --- a/src/soc/intel/common/block/pcie/pcie.c +++ b/src/soc/intel/common/block/pcie/pcie.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/pciexp.h> #include <stdint.h> diff --git a/src/soc/intel/common/block/pcie/rtd3/rtd3.c b/src/soc/intel/common/block/pcie/rtd3/rtd3.c index 3a7c8b4..727599c 100644 --- a/src/soc/intel/common/block/pcie/rtd3/rtd3.c +++ b/src/soc/intel/common/block/pcie/rtd3/rtd3.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/pci.h> #include <intelblocks/pmc.h> #include <intelblocks/pmc_ipc.h> diff --git a/src/soc/intel/common/block/pmc/pmc.c b/src/soc/intel/common/block/pmc/pmc.c index ca575ff..d7faf02 100644 --- a/src/soc/intel/common/block/pmc/pmc.c +++ b/src/soc/intel/common/block/pmc/pmc.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <device/pci_ops.h> #include <console/console.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/soc/intel/common/block/smbus/tco.c b/src/soc/intel/common/block/smbus/tco.c index ef7ef07..54a5310 100644 --- a/src/soc/intel/common/block/smbus/tco.c +++ b/src/soc/intel/common/block/smbus/tco.c @@ -3,7 +3,6 @@ #define __SIMPLE_DEVICE__ #include <arch/io.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include <intelblocks/gpmr.h> diff --git a/src/soc/intel/common/block/spi/spi.c b/src/soc/intel/common/block/spi/spi.c index d1063f1..7d46ae8 100644 --- a/src/soc/intel/common/block/spi/spi.c +++ b/src/soc/intel/common/block/spi/spi.c @@ -8,7 +8,6 @@ #include <device/mmio.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/spi.h> #include <intelblocks/fast_spi.h> #include <intelblocks/gspi.h> diff --git a/src/soc/intel/common/block/systemagent/systemagent_early.c b/src/soc/intel/common/block/systemagent/systemagent_early.c index aecdfbb..cd5d7c1 100644 --- a/src/soc/intel/common/block/systemagent/systemagent_early.c +++ b/src/soc/intel/common/block/systemagent/systemagent_early.c @@ -4,7 +4,6 @@ #include <assert.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include <intelblocks/systemagent.h> diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c index c03f5a9..fdff7c4 100644 --- a/src/soc/intel/common/block/uart/uart.c +++ b/src/soc/intel/common/block/uart/uart.c @@ -7,7 +7,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <intelblocks/irq.h> #include <intelblocks/lpss.h> #include <intelblocks/uart.h> diff --git a/src/soc/intel/denverton_ns/acpi.c b/src/soc/intel/denverton_ns/acpi.c index d0fde3e..82d5467 100644 --- a/src/soc/intel/denverton_ns/acpi.c +++ b/src/soc/intel/denverton_ns/acpi.c @@ -9,7 +9,6 @@ #include <cpu/x86/smm.h> #include <string.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <cbmem.h> #include <console/console.h> #include <intelblocks/acpi.h> diff --git a/src/soc/intel/denverton_ns/bootblock/bootblock.c b/src/soc/intel/denverton_ns/bootblock/bootblock.c index 6601714..002d421 100644 --- a/src/soc/intel/denverton_ns/bootblock/bootblock.c +++ b/src/soc/intel/denverton_ns/bootblock/bootblock.c @@ -3,7 +3,6 @@ #include <assert.h> #include <bootblock_common.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <FsptUpd.h> #include <intelblocks/fast_spi.h> #include <soc/bootblock.h> diff --git a/src/soc/intel/denverton_ns/lpc.c b/src/soc/intel/denverton_ns/lpc.c index 7dc971e..695c1c0 100644 --- a/src/soc/intel/denverton_ns/lpc.c +++ b/src/soc/intel/denverton_ns/lpc.c @@ -5,7 +5,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <arch/ioapic.h> #include <acpi/acpi.h> #include <cpu/x86/smm.h> diff --git a/src/soc/intel/denverton_ns/pmc.c b/src/soc/intel/denverton_ns/pmc.c index b1a37a9..d28ecc2 100644 --- a/src/soc/intel/denverton_ns/pmc.c +++ b/src/soc/intel/denverton_ns/pmc.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <acpi/acpi.h> -#include <device/pci_ops.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <device/device.h> diff --git a/src/soc/intel/denverton_ns/sata.c b/src/soc/intel/denverton_ns/sata.c index 3fb5d75..6c29139 100644 --- a/src/soc/intel/denverton_ns/sata.c +++ b/src/soc/intel/denverton_ns/sata.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/soc/intel/denverton_ns/soc_util.c b/src/soc/intel/denverton_ns/soc_util.c index dbe924b..2ca731e 100644 --- a/src/soc/intel/denverton_ns/soc_util.c +++ b/src/soc/intel/denverton_ns/soc_util.c @@ -2,7 +2,6 @@ #include <stdint.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <device/pci.h> #include <device/device.h> #include <string.h> diff --git a/src/soc/intel/denverton_ns/systemagent.c b/src/soc/intel/denverton_ns/systemagent.c index 6c5149b..93b776f 100644 --- a/src/soc/intel/denverton_ns/systemagent.c +++ b/src/soc/intel/denverton_ns/systemagent.c @@ -3,7 +3,6 @@ #include <cbmem.h> #include <console/console.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <stdint.h> #include <delay.h> #include <device/device.h> diff --git a/src/soc/intel/denverton_ns/uart.c b/src/soc/intel/denverton_ns/uart.c index ca2e67f..7f8f3fe 100644 --- a/src/soc/intel/denverton_ns/uart.c +++ b/src/soc/intel/denverton_ns/uart.c @@ -9,7 +9,6 @@ #include <console/uart.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include <soc/pci_devs.h> #include <console/console.h> diff --git a/src/soc/intel/denverton_ns/xhci.c b/src/soc/intel/denverton_ns/xhci.c index 2760120..2dd82f9 100644 --- a/src/soc/intel/denverton_ns/xhci.c +++ b/src/soc/intel/denverton_ns/xhci.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> diff --git a/src/soc/intel/elkhartlake/bootblock/report_platform.c b/src/soc/intel/elkhartlake/bootblock/report_platform.c index 40816bb..4eccc7a 100644 --- a/src/soc/intel/elkhartlake/bootblock/report_platform.c +++ b/src/soc/intel/elkhartlake/bootblock/report_platform.c @@ -8,7 +8,6 @@ #include <cpu/x86/name.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/bootblock.h> #include <soc/pch.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/elkhartlake/espi.c b/src/soc/intel/elkhartlake/espi.c index 3c9e81b..f9d624f 100644 --- a/src/soc/intel/elkhartlake/espi.c +++ b/src/soc/intel/elkhartlake/espi.c @@ -3,7 +3,6 @@ #include <arch/ioapic.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> #include <pc80/isa-dma.h> diff --git a/src/soc/intel/elkhartlake/systemagent.c b/src/soc/intel/elkhartlake/systemagent.c index 9eadf89..10f8226 100644 --- a/src/soc/intel/elkhartlake/systemagent.c +++ b/src/soc/intel/elkhartlake/systemagent.c @@ -3,7 +3,6 @@ #include <delay.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <intelblocks/power_limit.h> #include <intelblocks/systemagent.h> #include <soc/iomap.h> diff --git a/src/soc/intel/elkhartlake/tsn_gbe.c b/src/soc/intel/elkhartlake/tsn_gbe.c index 6092824..5d38ad4 100644 --- a/src/soc/intel/elkhartlake/tsn_gbe.c +++ b/src/soc/intel/elkhartlake/tsn_gbe.c @@ -5,7 +5,6 @@ #include <device/mdio.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <intelblocks/lpss.h> #include <soc/soc_chip.h> #include <soc/tsn_gbe.h> diff --git a/src/soc/intel/jasperlake/bootblock/report_platform.c b/src/soc/intel/jasperlake/bootblock/report_platform.c index e3214c9..0dafeda 100644 --- a/src/soc/intel/jasperlake/bootblock/report_platform.c +++ b/src/soc/intel/jasperlake/bootblock/report_platform.c @@ -8,7 +8,6 @@ #include <cpu/x86/name.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/bootblock.h> #include <soc/pch.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/jasperlake/espi.c b/src/soc/intel/jasperlake/espi.c index 139fc8b..37d3927 100644 --- a/src/soc/intel/jasperlake/espi.c +++ b/src/soc/intel/jasperlake/espi.c @@ -4,7 +4,6 @@ #include <device/pci.h> #include <pc80/isa-dma.h> #include <pc80/i8259.h> -#include <device/pci_ops.h> #include <arch/ioapic.h> #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> diff --git a/src/soc/intel/jasperlake/systemagent.c b/src/soc/intel/jasperlake/systemagent.c index f0e9d44..0a04034 100644 --- a/src/soc/intel/jasperlake/systemagent.c +++ b/src/soc/intel/jasperlake/systemagent.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <delay.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <intelblocks/systemagent.h> #include <intelblocks/power_limit.h> #include <soc/iomap.h> diff --git a/src/soc/intel/meteorlake/bootblock/report_platform.c b/src/soc/intel/meteorlake/bootblock/report_platform.c index 49d0661..66426d7 100644 --- a/src/soc/intel/meteorlake/bootblock/report_platform.c +++ b/src/soc/intel/meteorlake/bootblock/report_platform.c @@ -9,7 +9,6 @@ #include <cpu/x86/name.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/bootblock.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/skylake/bootblock/report_platform.c b/src/soc/intel/skylake/bootblock/report_platform.c index ce250ad..faad9cf 100644 --- a/src/soc/intel/skylake/bootblock/report_platform.c +++ b/src/soc/intel/skylake/bootblock/report_platform.c @@ -8,7 +8,6 @@ #include <cpu/x86/name.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/bootblock.h> #include <soc/cpu.h> #include <soc/pch.h> diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c index fd80aea..c68730f 100644 --- a/src/soc/intel/skylake/finalize.c +++ b/src/soc/intel/skylake/finalize.c @@ -7,7 +7,6 @@ #include <cpu/x86/smm.h> #include <device/mmio.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <intelblocks/cpulib.h> #include <intelblocks/cse.h> #include <intelblocks/lpc_lib.h> diff --git a/src/soc/intel/skylake/irq.c b/src/soc/intel/skylake/irq.c index 8a9ec81..4d8997b 100644 --- a/src/soc/intel/skylake/irq.c +++ b/src/soc/intel/skylake/irq.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <intelblocks/lpc_lib.h> #include <intelblocks/itss.h> #include <soc/ramstage.h> diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c index 89491f8..9e905e6 100644 --- a/src/soc/intel/skylake/me.c +++ b/src/soc/intel/skylake/me.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <device/pci_ops.h> #include <bootstate.h> #include <commonlib/helpers.h> #include <console/console.h> diff --git a/src/soc/intel/skylake/pmutil.c b/src/soc/intel/skylake/pmutil.c index 5152237..442cdcb 100644 --- a/src/soc/intel/skylake/pmutil.c +++ b/src/soc/intel/skylake/pmutil.c @@ -10,7 +10,6 @@ #include <acpi/acpi.h> #include <console/console.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include <gpio.h> diff --git a/src/soc/intel/tigerlake/bootblock/report_platform.c b/src/soc/intel/tigerlake/bootblock/report_platform.c index 8f90b3c..0a5b453 100644 --- a/src/soc/intel/tigerlake/bootblock/report_platform.c +++ b/src/soc/intel/tigerlake/bootblock/report_platform.c @@ -13,7 +13,6 @@ #include <cpu/x86/msr.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/bootblock.h> #include <soc/pch.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/tigerlake/espi.c b/src/soc/intel/tigerlake/espi.c index 99bc620..3ecda12 100644 --- a/src/soc/intel/tigerlake/espi.c +++ b/src/soc/intel/tigerlake/espi.c @@ -10,7 +10,6 @@ #include <device/pci.h> #include <pc80/isa-dma.h> #include <pc80/i8259.h> -#include <device/pci_ops.h> #include <arch/ioapic.h> #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> diff --git a/src/soc/intel/tigerlake/fsp_params.c b/src/soc/intel/tigerlake/fsp_params.c index d5472dd..6492c80 100644 --- a/src/soc/intel/tigerlake/fsp_params.c +++ b/src/soc/intel/tigerlake/fsp_params.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <cpu/intel/cpu_ids.h> #include <device/device.h> -#include <device/pci_ops.h> #include <device/pci.h> #include <device/pci_ids.h> #include <fsp/api.h> diff --git a/src/soc/intel/tigerlake/systemagent.c b/src/soc/intel/tigerlake/systemagent.c index 06282ea..5f78cca 100644 --- a/src/soc/intel/tigerlake/systemagent.c +++ b/src/soc/intel/tigerlake/systemagent.c @@ -11,7 +11,6 @@ #include <delay.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <intelblocks/power_limit.h> #include <intelblocks/systemagent.h> #include <soc/iomap.h> diff --git a/src/soc/intel/xeon_sp/chip_gen1.c b/src/soc/intel/xeon_sp/chip_gen1.c index 7e831ab..ac8a31d 100644 --- a/src/soc/intel/xeon_sp/chip_gen1.c +++ b/src/soc/intel/xeon_sp/chip_gen1.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_def.h> #include <soc/pci_devs.h> #include <intelblocks/acpi.h> #include <soc/acpi.h> diff --git a/src/soc/intel/xeon_sp/cpx/chip.c b/src/soc/intel/xeon_sp/cpx/chip.c index 9c86aee..8b9a673 100644 --- a/src/soc/intel/xeon_sp/cpx/chip.c +++ b/src/soc/intel/xeon_sp/cpx/chip.c @@ -6,7 +6,6 @@ #include <cpu/x86/mp.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_def.h> #include <gpio.h> #include <intelblocks/acpi.h> #include <intelblocks/lpc_lib.h> diff --git a/src/soc/intel/xeon_sp/numa.c b/src/soc/intel/xeon_sp/numa.c index 62657dc..73e162a 100644 --- a/src/soc/intel/xeon_sp/numa.c +++ b/src/soc/intel/xeon_sp/numa.c @@ -2,7 +2,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci_ops.h> #include <device/pci.h> #include <device/pciexp.h> #include <soc/numa.h> diff --git a/src/soc/intel/xeon_sp/skx/soc_util.c b/src/soc/intel/xeon_sp/skx/soc_util.c index 38d834f..6f48246 100644 --- a/src/soc/intel/xeon_sp/skx/soc_util.c +++ b/src/soc/intel/xeon_sp/skx/soc_util.c @@ -3,7 +3,6 @@ #include <assert.h> #include <console/console.h> #include <device/pci.h> -#include <device/pci_def.h> #include <device/pci_ids.h> #include <hob_iiouds.h> #include <intelblocks/cpulib.h> diff --git a/src/soc/intel/xeon_sp/spr/chip.c b/src/soc/intel/xeon_sp/spr/chip.c index 9b3b46f..ec23940 100644 --- a/src/soc/intel/xeon_sp/spr/chip.c +++ b/src/soc/intel/xeon_sp/spr/chip.c @@ -6,7 +6,6 @@ #include <cpu/x86/lapic.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_def.h> #include <device/pciexp.h> #include <intelblocks/acpi.h> #include <intelblocks/gpio.h> diff --git a/src/southbridge/amd/common/amd_pci_util.c b/src/southbridge/amd/common/amd_pci_util.c index b9e8a5f..68b4b1e 100644 --- a/src/southbridge/amd/common/amd_pci_util.c +++ b/src/southbridge/amd/common/amd_pci_util.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/pci.h> #include <arch/io.h> -#include <device/pci_ops.h> #include "amd_pci_util.h" #include <pc80/i8259.h> #include "amd_pci_int_defs.h" diff --git a/src/southbridge/amd/pi/hudson/hudson.c b/src/southbridge/amd/pi/hudson/hudson.c index 26fb258..340167a 100644 --- a/src/southbridge/amd/pi/hudson/hudson.c +++ b/src/southbridge/amd/pi/hudson/hudson.c @@ -8,7 +8,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <types.h> #include "hudson.h" diff --git a/src/southbridge/amd/pi/hudson/lpc.c b/src/southbridge/amd/pi/hudson/lpc.c index 66ec824..0803a07 100644 --- a/src/southbridge/amd/pi/hudson/lpc.c +++ b/src/southbridge/amd/pi/hudson/lpc.c @@ -6,7 +6,6 @@ #include <device/pci.h> #include <device/pnp.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <pc80/mc146818rtc.h> #include <pc80/isa-dma.h> #include <arch/io.h> diff --git a/src/southbridge/amd/pi/hudson/sata.c b/src/southbridge/amd/pi/hudson/sata.c index 381f7d3..8c83ded 100644 --- a/src/southbridge/amd/pi/hudson/sata.c +++ b/src/southbridge/amd/pi/hudson/sata.c @@ -3,7 +3,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include "hudson.h" diff --git a/src/southbridge/amd/pi/hudson/sd.c b/src/southbridge/amd/pi/hudson/sd.c index 6dad334..7494a5d 100644 --- a/src/southbridge/amd/pi/hudson/sd.c +++ b/src/southbridge/amd/pi/hudson/sd.c @@ -3,7 +3,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include "chip.h" #include "hudson.h" diff --git a/src/southbridge/intel/bd82x6x/azalia.c b/src/southbridge/intel/bd82x6x/azalia.c index ddaa8a1..fd9dfe7 100644 --- a/src/southbridge/intel/bd82x6x/azalia.c +++ b/src/southbridge/intel/bd82x6x/azalia.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/mmio.h> #include <delay.h> #include <device/azalia_device.h> diff --git a/src/southbridge/intel/bd82x6x/common.c b/src/southbridge/intel/bd82x6x/common.c index 63d2fb2..8dca36f 100644 --- a/src/southbridge/intel/bd82x6x/common.c +++ b/src/southbridge/intel/bd82x6x/common.c @@ -5,9 +5,7 @@ #include <console/console.h> #include <delay.h> #include <device/pci.h> -#include <device/pci_def.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <stdint.h> #include "pch.h" diff --git a/src/southbridge/intel/bd82x6x/elog.c b/src/southbridge/intel/bd82x6x/elog.c index 684f830..66cb171 100644 --- a/src/southbridge/intel/bd82x6x/elog.c +++ b/src/southbridge/intel/bd82x6x/elog.c @@ -4,7 +4,6 @@ #include <acpi/acpi.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <stdint.h> #include <elog.h> #include <southbridge/intel/common/pmutil.h> diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c index 67d883a..825f670 100644 --- a/src/southbridge/intel/bd82x6x/lpc.c +++ b/src/southbridge/intel/bd82x6x/lpc.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <option.h> #include <pc80/isa-dma.h> #include <pc80/i8259.h> diff --git a/src/southbridge/intel/bd82x6x/me.c b/src/southbridge/intel/bd82x6x/me.c index 7394882..0f8f152 100644 --- a/src/southbridge/intel/bd82x6x/me.c +++ b/src/southbridge/intel/bd82x6x/me.c @@ -13,7 +13,6 @@ #include <device/mmio.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/pci_ids.h> #include <elog.h> diff --git a/src/southbridge/intel/bd82x6x/me_8.x.c b/src/southbridge/intel/bd82x6x/me_8.x.c index 8702c4d..1d3cdbc 100644 --- a/src/southbridge/intel/bd82x6x/me_8.x.c +++ b/src/southbridge/intel/bd82x6x/me_8.x.c @@ -13,7 +13,6 @@ #include <device/mmio.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/pci_ids.h> #include <string.h> diff --git a/src/southbridge/intel/bd82x6x/me_common.c b/src/southbridge/intel/bd82x6x/me_common.c index 2db3c2d..7637c72 100644 --- a/src/southbridge/intel/bd82x6x/me_common.c +++ b/src/southbridge/intel/bd82x6x/me_common.c @@ -3,7 +3,6 @@ #include <device/mmio.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/pci_ids.h> #include <string.h> diff --git a/src/southbridge/intel/bd82x6x/me_smm.c b/src/southbridge/intel/bd82x6x/me_smm.c index ea39559..b88d83d 100644 --- a/src/southbridge/intel/bd82x6x/me_smm.c +++ b/src/southbridge/intel/bd82x6x/me_smm.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <stdint.h> #include "me.h" diff --git a/src/southbridge/intel/bd82x6x/pch.c b/src/southbridge/intel/bd82x6x/pch.c index 1a9c2ae..5d930d7 100644 --- a/src/southbridge/intel/bd82x6x/pch.c +++ b/src/southbridge/intel/bd82x6x/pch.c @@ -4,7 +4,6 @@ #include <delay.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <string.h> #include <timer.h> diff --git a/src/southbridge/intel/bd82x6x/pci.c b/src/southbridge/intel/bd82x6x/pci.c index 2294421..166d55a 100644 --- a/src/southbridge/intel/bd82x6x/pci.c +++ b/src/southbridge/intel/bd82x6x/pci.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "pch.h" diff --git a/src/southbridge/intel/bd82x6x/pcie.c b/src/southbridge/intel/bd82x6x/pcie.c index a1dd16e..70d914c 100644 --- a/src/southbridge/intel/bd82x6x/pcie.c +++ b/src/southbridge/intel/bd82x6x/pcie.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pciexp.h> #include <device/pci_ids.h> #include <southbridge/intel/common/pciehp.h> diff --git a/src/southbridge/intel/bd82x6x/sata.c b/src/southbridge/intel/bd82x6x/sata.c index a30c01a..1e2527d 100644 --- a/src/southbridge/intel/bd82x6x/sata.c +++ b/src/southbridge/intel/bd82x6x/sata.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/southbridge/intel/bd82x6x/smbus.c b/src/southbridge/intel/bd82x6x/smbus.c index 9db8d7a..0c4745c 100644 --- a/src/southbridge/intel/bd82x6x/smbus.c +++ b/src/southbridge/intel/bd82x6x/smbus.c @@ -4,7 +4,6 @@ #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/smbus_host.h> #include <southbridge/intel/common/smbus_ops.h> #include "pch.h" diff --git a/src/southbridge/intel/bd82x6x/usb_ehci.c b/src/southbridge/intel/bd82x6x/usb_ehci.c index f05d932..4faa0ef 100644 --- a/src/southbridge/intel/bd82x6x/usb_ehci.c +++ b/src/southbridge/intel/bd82x6x/usb_ehci.c @@ -5,7 +5,6 @@ #include <device/mmio.h> #include <device/pci_ehci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/pci.h> #include "pch.h" diff --git a/src/southbridge/intel/bd82x6x/usb_xhci.c b/src/southbridge/intel/bd82x6x/usb_xhci.c index f71a505..d2f07a1 100644 --- a/src/southbridge/intel/bd82x6x/usb_xhci.c +++ b/src/southbridge/intel/bd82x6x/usb_xhci.c @@ -6,7 +6,6 @@ #include <device/pci_ids.h> #include "pch.h" #include <device/pci_ehci.h> -#include <device/pci_ops.h> #include "chip.h" static void usb_xhci_init(struct device *dev) diff --git a/src/southbridge/intel/common/spi.c b/src/southbridge/intel/common/spi.c index 93185d4..2cc8026 100644 --- a/src/southbridge/intel/common/spi.c +++ b/src/southbridge/intel/common/spi.c @@ -9,7 +9,6 @@ #include <commonlib/helpers.h> #include <delay.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/southbridge/intel/common/watchdog.c b/src/southbridge/intel/common/watchdog.c index 36b9525..5f76ff8 100644 --- a/src/southbridge/intel/common/watchdog.c +++ b/src/southbridge/intel/common/watchdog.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <southbridge/intel/common/pmbase.h> #include <southbridge/intel/common/tco.h> #include <watchdog.h> diff --git a/src/southbridge/intel/i82371eb/early_pm.c b/src/southbridge/intel/i82371eb/early_pm.c index 3cf56f2..52a7967 100644 --- a/src/southbridge/intel/i82371eb/early_pm.c +++ b/src/southbridge/intel/i82371eb/early_pm.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <stdint.h> -#include <device/pci_ops.h> #include <device/pci.h> #include <device/pci_ids.h> #include "i82371eb.h" diff --git a/src/southbridge/intel/i82371eb/early_smbus.c b/src/southbridge/intel/i82371eb/early_smbus.c index 0e0fd5b..1217d53 100644 --- a/src/southbridge/intel/i82371eb/early_smbus.c +++ b/src/southbridge/intel/i82371eb/early_smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <stdint.h> -#include <device/pci_ops.h> #include <device/pci.h> #include <device/pci_ids.h> #include <device/smbus_host.h> diff --git a/src/southbridge/intel/i82371eb/ide.c b/src/southbridge/intel/i82371eb/ide.c index 5a2f190..c0a6d81 100644 --- a/src/southbridge/intel/i82371eb/ide.c +++ b/src/southbridge/intel/i82371eb/ide.c @@ -6,7 +6,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "chip.h" #include "i82371eb.h" diff --git a/src/southbridge/intel/i82371eb/isa.c b/src/southbridge/intel/i82371eb/isa.c index 692fd8b..c0c37a5 100644 --- a/src/southbridge/intel/i82371eb/isa.c +++ b/src/southbridge/intel/i82371eb/isa.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include <pc80/isa-dma.h> #include <pc80/mc146818rtc.h> diff --git a/src/southbridge/intel/i82371eb/smbus.c b/src/southbridge/intel/i82371eb/smbus.c index 7c1ce1b..fb192d2 100644 --- a/src/southbridge/intel/i82371eb/smbus.c +++ b/src/southbridge/intel/i82371eb/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <arch/io.h> -#include <device/pci_ops.h> #include <console/console.h> #include <stdint.h> #include <device/device.h> diff --git a/src/southbridge/intel/i82801dx/ac97.c b/src/southbridge/intel/i82801dx/ac97.c index c30c5ef..e7e1882 100644 --- a/src/southbridge/intel/i82801dx/ac97.c +++ b/src/southbridge/intel/i82801dx/ac97.c @@ -6,7 +6,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <stdint.h> #include "i82801dx.h" diff --git a/src/southbridge/intel/i82801dx/i82801dx.c b/src/southbridge/intel/i82801dx/i82801dx.c index 7a70902..a6f3b31 100644 --- a/src/southbridge/intel/i82801dx/i82801dx.c +++ b/src/southbridge/intel/i82801dx/i82801dx.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <stdint.h> #include "i82801dx.h" diff --git a/src/southbridge/intel/i82801dx/ide.c b/src/southbridge/intel/i82801dx/ide.c index c439ffe..bc37dee 100644 --- a/src/southbridge/intel/i82801dx/ide.c +++ b/src/southbridge/intel/i82801dx/ide.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <stdint.h> #include "chip.h" diff --git a/src/southbridge/intel/i82801dx/lpc.c b/src/southbridge/intel/i82801dx/lpc.c index c8b0760..7bf0c53 100644 --- a/src/southbridge/intel/i82801dx/lpc.c +++ b/src/southbridge/intel/i82801dx/lpc.c @@ -8,7 +8,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <option.h> #include <pc80/i8259.h> #include <pc80/isa-dma.h> diff --git a/src/southbridge/intel/i82801dx/usb.c b/src/southbridge/intel/i82801dx/usb.c index 16ec307..4e136a6 100644 --- a/src/southbridge/intel/i82801dx/usb.c +++ b/src/southbridge/intel/i82801dx/usb.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include "i82801dx.h" static void usb_init(struct device *dev) diff --git a/src/southbridge/intel/i82801dx/usb2.c b/src/southbridge/intel/i82801dx/usb2.c index 0fe7c93..474e5ff 100644 --- a/src/southbridge/intel/i82801dx/usb2.c +++ b/src/southbridge/intel/i82801dx/usb2.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/pci_ehci.h> #include "i82801dx.h" diff --git a/src/southbridge/intel/i82801gx/ac97.c b/src/southbridge/intel/i82801gx/ac97.c index aa73ae2..29145d8 100644 --- a/src/southbridge/intel/i82801gx/ac97.c +++ b/src/southbridge/intel/i82801gx/ac97.c @@ -5,7 +5,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <arch/io.h> -#include <device/pci_ops.h> #include <delay.h> #include "i82801gx.h" diff --git a/src/southbridge/intel/i82801gx/azalia.c b/src/southbridge/intel/i82801gx/azalia.c index 31827e6..28560f4 100644 --- a/src/southbridge/intel/i82801gx/azalia.c +++ b/src/southbridge/intel/i82801gx/azalia.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/mmio.h> #include <delay.h> #include <device/azalia_device.h> diff --git a/src/southbridge/intel/i82801gx/i82801gx.c b/src/southbridge/intel/i82801gx/i82801gx.c index 86db048..a02aa42 100644 --- a/src/southbridge/intel/i82801gx/i82801gx.c +++ b/src/southbridge/intel/i82801gx/i82801gx.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include "i82801gx.h" #include "sata.h" diff --git a/src/southbridge/intel/i82801gx/ide.c b/src/southbridge/intel/i82801gx/ide.c index 71fc738..22c8895 100644 --- a/src/southbridge/intel/i82801gx/ide.c +++ b/src/southbridge/intel/i82801gx/ide.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "chip.h" #include "i82801gx.h" diff --git a/src/southbridge/intel/i82801gx/lpc.c b/src/southbridge/intel/i82801gx/lpc.c index a04b4b9..599657e 100644 --- a/src/southbridge/intel/i82801gx/lpc.c +++ b/src/southbridge/intel/i82801gx/lpc.c @@ -10,7 +10,6 @@ #include <pc80/isa-dma.h> #include <pc80/i8259.h> #include <arch/io.h> -#include <device/pci_ops.h> #include <arch/ioapic.h> #include <acpi/acpi.h> #include <cpu/x86/smm.h> diff --git a/src/southbridge/intel/i82801gx/pci.c b/src/southbridge/intel/i82801gx/pci.c index a9e86a0..0515031 100644 --- a/src/southbridge/intel/i82801gx/pci.c +++ b/src/southbridge/intel/i82801gx/pci.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "i82801gx.h" diff --git a/src/southbridge/intel/i82801gx/pcie.c b/src/southbridge/intel/i82801gx/pcie.c index befbf3b..2f6a5c8 100644 --- a/src/southbridge/intel/i82801gx/pcie.c +++ b/src/southbridge/intel/i82801gx/pcie.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "chip.h" #include "i82801gx.h" diff --git a/src/southbridge/intel/i82801gx/sata.c b/src/southbridge/intel/i82801gx/sata.c index 2333c76..329ae4b 100644 --- a/src/southbridge/intel/i82801gx/sata.c +++ b/src/southbridge/intel/i82801gx/sata.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "chip.h" #include "i82801gx.h" diff --git a/src/southbridge/intel/i82801gx/usb.c b/src/southbridge/intel/i82801gx/usb.c index 4f3261f..7c5c901 100644 --- a/src/southbridge/intel/i82801gx/usb.c +++ b/src/southbridge/intel/i82801gx/usb.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "i82801gx.h" diff --git a/src/southbridge/intel/i82801gx/usb_ehci.c b/src/southbridge/intel/i82801gx/usb_ehci.c index bfaceea..d4e52e6 100644 --- a/src/southbridge/intel/i82801gx/usb_ehci.c +++ b/src/southbridge/intel/i82801gx/usb_ehci.c @@ -7,7 +7,6 @@ #include "i82801gx.h" #include <device/pci_ehci.h> #include <device/mmio.h> -#include <device/pci_ops.h> static void usb_ehci_init(struct device *dev) { diff --git a/src/southbridge/intel/i82801ix/azalia.c b/src/southbridge/intel/i82801ix/azalia.c index fdc9514..b044e6d 100644 --- a/src/southbridge/intel/i82801ix/azalia.c +++ b/src/southbridge/intel/i82801ix/azalia.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/mmio.h> #include <device/azalia_device.h> #include "chip.h" diff --git a/src/southbridge/intel/i82801ix/i82801ix.c b/src/southbridge/intel/i82801ix/i82801ix.c index 3d56594..9d68262b 100644 --- a/src/southbridge/intel/i82801ix/i82801ix.c +++ b/src/southbridge/intel/i82801ix/i82801ix.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <arch/io.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include <console/console.h> diff --git a/src/southbridge/intel/i82801ix/lpc.c b/src/southbridge/intel/i82801ix/lpc.c index 0adc1b9..40c0209 100644 --- a/src/southbridge/intel/i82801ix/lpc.c +++ b/src/southbridge/intel/i82801ix/lpc.c @@ -10,7 +10,6 @@ #include <pc80/isa-dma.h> #include <pc80/i8259.h> #include <arch/io.h> -#include <device/pci_ops.h> #include <arch/ioapic.h> #include <acpi/acpi.h> #include <cpu/x86/smm.h> diff --git a/src/southbridge/intel/i82801ix/pci.c b/src/southbridge/intel/i82801ix/pci.c index 5a13503..8ce3464 100644 --- a/src/southbridge/intel/i82801ix/pci.c +++ b/src/southbridge/intel/i82801ix/pci.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "i82801ix.h" diff --git a/src/southbridge/intel/i82801ix/pcie.c b/src/southbridge/intel/i82801ix/pcie.c index a374068..f34206c 100644 --- a/src/southbridge/intel/i82801ix/pcie.c +++ b/src/southbridge/intel/i82801ix/pcie.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pciexp.h> #include <device/pci_ids.h> #include <southbridge/intel/common/pciehp.h> diff --git a/src/southbridge/intel/i82801ix/sata.c b/src/southbridge/intel/i82801ix/sata.c index 7621a4d..4e40acc 100644 --- a/src/southbridge/intel/i82801ix/sata.c +++ b/src/southbridge/intel/i82801ix/sata.c @@ -2,7 +2,6 @@ #include <arch/io.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/southbridge/intel/i82801ix/smbus.c b/src/southbridge/intel/i82801ix/smbus.c index 8f60408..df8786f 100644 --- a/src/southbridge/intel/i82801ix/smbus.c +++ b/src/southbridge/intel/i82801ix/smbus.c @@ -4,7 +4,6 @@ #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/smbus_host.h> #include <southbridge/intel/common/smbus_ops.h> #include "i82801ix.h" diff --git a/src/southbridge/intel/i82801ix/thermal.c b/src/southbridge/intel/i82801ix/thermal.c index 543b2ff..590299a 100644 --- a/src/southbridge/intel/i82801ix/thermal.c +++ b/src/southbridge/intel/i82801ix/thermal.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/i82801ix/usb_ehci.c b/src/southbridge/intel/i82801ix/usb_ehci.c index 4e6327a..fc0625e 100644 --- a/src/southbridge/intel/i82801ix/usb_ehci.c +++ b/src/southbridge/intel/i82801ix/usb_ehci.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "i82801ix.h" #include <device/pci_ehci.h> diff --git a/src/southbridge/intel/i82801jx/azalia.c b/src/southbridge/intel/i82801jx/azalia.c index fa0209a..eebf4bf 100644 --- a/src/southbridge/intel/i82801jx/azalia.c +++ b/src/southbridge/intel/i82801jx/azalia.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/mmio.h> #include <device/azalia_device.h> #include "chip.h" diff --git a/src/southbridge/intel/i82801jx/i82801jx.c b/src/southbridge/intel/i82801jx/i82801jx.c index 6f10be0..fdf76fa 100644 --- a/src/southbridge/intel/i82801jx/i82801jx.c +++ b/src/southbridge/intel/i82801jx/i82801jx.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <arch/io.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include <console/console.h> diff --git a/src/southbridge/intel/i82801jx/lpc.c b/src/southbridge/intel/i82801jx/lpc.c index 0a3e26f..4dce75d 100644 --- a/src/southbridge/intel/i82801jx/lpc.c +++ b/src/southbridge/intel/i82801jx/lpc.c @@ -9,7 +9,6 @@ #include <pc80/isa-dma.h> #include <pc80/i8259.h> #include <arch/io.h> -#include <device/pci_ops.h> #include <arch/ioapic.h> #include <acpi/acpi.h> #include <cpu/x86/smm.h> diff --git a/src/southbridge/intel/i82801jx/pci.c b/src/southbridge/intel/i82801jx/pci.c index 37b759c..6c101b3 100644 --- a/src/southbridge/intel/i82801jx/pci.c +++ b/src/southbridge/intel/i82801jx/pci.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "i82801jx.h" diff --git a/src/southbridge/intel/i82801jx/pcie.c b/src/southbridge/intel/i82801jx/pcie.c index 3ed9d60..28302a3 100644 --- a/src/southbridge/intel/i82801jx/pcie.c +++ b/src/southbridge/intel/i82801jx/pcie.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pciexp.h> #include <device/pci_ids.h> #include <southbridge/intel/common/pciehp.h> diff --git a/src/southbridge/intel/i82801jx/sata.c b/src/southbridge/intel/i82801jx/sata.c index 1694d3c..ff9aea9 100644 --- a/src/southbridge/intel/i82801jx/sata.c +++ b/src/southbridge/intel/i82801jx/sata.c @@ -2,7 +2,6 @@ #include <arch/io.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/southbridge/intel/i82801jx/smbus.c b/src/southbridge/intel/i82801jx/smbus.c index 15643bd..0481a991 100644 --- a/src/southbridge/intel/i82801jx/smbus.c +++ b/src/southbridge/intel/i82801jx/smbus.c @@ -4,7 +4,6 @@ #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/smbus_host.h> #include <southbridge/intel/common/smbus_ops.h> #include "i82801jx.h" diff --git a/src/southbridge/intel/i82801jx/thermal.c b/src/southbridge/intel/i82801jx/thermal.c index b8a7e84..e0cdcee 100644 --- a/src/southbridge/intel/i82801jx/thermal.c +++ b/src/southbridge/intel/i82801jx/thermal.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/i82801jx/usb_ehci.c b/src/southbridge/intel/i82801jx/usb_ehci.c index 1a59d37..7f09c7e 100644 --- a/src/southbridge/intel/i82801jx/usb_ehci.c +++ b/src/southbridge/intel/i82801jx/usb_ehci.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include "i82801jx.h" #include <device/pci_ehci.h> diff --git a/src/southbridge/intel/i82870/ioapic.c b/src/southbridge/intel/i82870/ioapic.c index 4a25f6b..1b03bc2 100644 --- a/src/southbridge/intel/i82870/ioapic.c +++ b/src/southbridge/intel/i82870/ioapic.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <assert.h> #include <types.h> #include "82870.h" diff --git a/src/southbridge/intel/i82870/pcibridge.c b/src/southbridge/intel/i82870/pcibridge.c index 4ca8010..5d5a467 100644 --- a/src/southbridge/intel/i82870/pcibridge.c +++ b/src/southbridge/intel/i82870/pcibridge.c @@ -3,7 +3,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include "82870.h" static void p64h2_pcix_init(struct device *dev) diff --git a/src/southbridge/intel/ibexpeak/azalia.c b/src/southbridge/intel/ibexpeak/azalia.c index ac950c4..110f98f 100644 --- a/src/southbridge/intel/ibexpeak/azalia.c +++ b/src/southbridge/intel/ibexpeak/azalia.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/mmio.h> #include <delay.h> #include <device/azalia_device.h> diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c index 93dc387..d0062fdb 100644 --- a/src/southbridge/intel/ibexpeak/lpc.c +++ b/src/southbridge/intel/ibexpeak/lpc.c @@ -10,7 +10,6 @@ #include <pc80/i8259.h> #include <arch/io.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <arch/ioapic.h> #include <acpi/acpi.h> #include <elog.h> diff --git a/src/southbridge/intel/ibexpeak/me.c b/src/southbridge/intel/ibexpeak/me.c index fbcb01d..e3e3fa2 100644 --- a/src/southbridge/intel/ibexpeak/me.c +++ b/src/southbridge/intel/ibexpeak/me.c @@ -14,7 +14,6 @@ #include <device/mmio.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <string.h> #include <delay.h> #include <elog.h> diff --git a/src/southbridge/intel/ibexpeak/pch.c b/src/southbridge/intel/ibexpeak/pch.c index f77dc62..4cd17b0 100644 --- a/src/southbridge/intel/ibexpeak/pch.c +++ b/src/southbridge/intel/ibexpeak/pch.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/console.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include "pch.h" diff --git a/src/southbridge/intel/ibexpeak/sata.c b/src/southbridge/intel/ibexpeak/sata.c index 45520cd..64e02c9 100644 --- a/src/southbridge/intel/ibexpeak/sata.c +++ b/src/southbridge/intel/ibexpeak/sata.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/southbridge/intel/ibexpeak/smbus.c b/src/southbridge/intel/ibexpeak/smbus.c index 6bbd1e4..3ce0e86 100644 --- a/src/southbridge/intel/ibexpeak/smbus.c +++ b/src/southbridge/intel/ibexpeak/smbus.c @@ -4,7 +4,6 @@ #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/smbus_host.h> #include <southbridge/intel/common/smbus_ops.h> #include "pch.h" diff --git a/src/southbridge/intel/ibexpeak/usb_ehci.c b/src/southbridge/intel/ibexpeak/usb_ehci.c index 45c5cec..d4a8ad0 100644 --- a/src/southbridge/intel/ibexpeak/usb_ehci.c +++ b/src/southbridge/intel/ibexpeak/usb_ehci.c @@ -7,7 +7,6 @@ #include "pch.h" #include <device/pci_ehci.h> #include <device/mmio.h> -#include <device/pci_ops.h> static void usb_ehci_init(struct device *dev) { diff --git a/src/southbridge/intel/lynxpoint/azalia.c b/src/southbridge/intel/lynxpoint/azalia.c index 34f0753..0422dd6 100644 --- a/src/southbridge/intel/lynxpoint/azalia.c +++ b/src/southbridge/intel/lynxpoint/azalia.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/mmio.h> #include <device/azalia_device.h> diff --git a/src/southbridge/intel/lynxpoint/elog.c b/src/southbridge/intel/lynxpoint/elog.c index ce19091..fc1f75d 100644 --- a/src/southbridge/intel/lynxpoint/elog.c +++ b/src/southbridge/intel/lynxpoint/elog.c @@ -4,7 +4,6 @@ #include <acpi/acpi.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <stdint.h> #include <elog.h> #include "pch.h" diff --git a/src/southbridge/intel/lynxpoint/lp_gpio.c b/src/southbridge/intel/lynxpoint/lp_gpio.c index 448ee8b..8a697fe 100644 --- a/src/southbridge/intel/lynxpoint/lp_gpio.c +++ b/src/southbridge/intel/lynxpoint/lp_gpio.c @@ -2,7 +2,6 @@ #include <stdint.h> #include <arch/io.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c index 93b7423..fca96b4 100644 --- a/src/southbridge/intel/lynxpoint/lpc.c +++ b/src/southbridge/intel/lynxpoint/lpc.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <option.h> #include <pc80/isa-dma.h> #include <pc80/i8259.h> diff --git a/src/southbridge/intel/lynxpoint/me.c b/src/southbridge/intel/lynxpoint/me.c index b0d98d4..70702d5 100644 --- a/src/southbridge/intel/lynxpoint/me.c +++ b/src/southbridge/intel/lynxpoint/me.c @@ -10,7 +10,6 @@ #include <acpi/acpi.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/southbridge/intel/lynxpoint/pch.c b/src/southbridge/intel/lynxpoint/pch.c index ae4e714..cb9deba 100644 --- a/src/southbridge/intel/lynxpoint/pch.c +++ b/src/southbridge/intel/lynxpoint/pch.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/console.h> -#include <device/pci_ops.h> #include <device/device.h> #include <device/pci.h> #include "iobp.h" diff --git a/src/southbridge/intel/lynxpoint/pcie.c b/src/southbridge/intel/lynxpoint/pcie.c index 7d31b3e..4f28bbb 100644 --- a/src/southbridge/intel/lynxpoint/pcie.c +++ b/src/southbridge/intel/lynxpoint/pcie.c @@ -7,7 +7,6 @@ #include <device/pci.h> #include <device/pciexp.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include "iobp.h" #include "pch.h" #include <southbridge/intel/common/gpio.h> diff --git a/src/southbridge/intel/lynxpoint/sata.c b/src/southbridge/intel/lynxpoint/sata.c index b6cbb13..bae21d0 100644 --- a/src/southbridge/intel/lynxpoint/sata.c +++ b/src/southbridge/intel/lynxpoint/sata.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/southbridge/intel/lynxpoint/serialio.c b/src/southbridge/intel/lynxpoint/serialio.c index 208c52a..ddf1743 100644 --- a/src/southbridge/intel/lynxpoint/serialio.c +++ b/src/southbridge/intel/lynxpoint/serialio.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <device/pci_ops.h> #include <acpi/acpi_gnvs.h> #include <console/console.h> #include <device/device.h> diff --git a/src/southbridge/intel/lynxpoint/smbus.c b/src/southbridge/intel/lynxpoint/smbus.c index 0363802..dd3e87d 100644 --- a/src/southbridge/intel/lynxpoint/smbus.c +++ b/src/southbridge/intel/lynxpoint/smbus.c @@ -4,7 +4,6 @@ #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/smbus_host.h> #include <southbridge/intel/common/smbus_ops.h> #include "pch.h" diff --git a/src/southbridge/intel/lynxpoint/usb_ehci.c b/src/southbridge/intel/lynxpoint/usb_ehci.c index 662a421..bb0757c 100644 --- a/src/southbridge/intel/lynxpoint/usb_ehci.c +++ b/src/southbridge/intel/lynxpoint/usb_ehci.c @@ -7,7 +7,6 @@ #include <device/pci_ids.h> #include <device/pci_ehci.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include "iobp.h" #include "pch.h" diff --git a/src/southbridge/intel/lynxpoint/usb_xhci.c b/src/southbridge/intel/lynxpoint/usb_xhci.c index 2660be1..886844a5 100644 --- a/src/southbridge/intel/lynxpoint/usb_xhci.c +++ b/src/southbridge/intel/lynxpoint/usb_xhci.c @@ -6,7 +6,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/mmio.h> -#include <device/pci_ops.h> #include "chip.h" #include "iobp.h" #include "pch.h" diff --git a/src/southbridge/ricoh/rl5c476/rl5c476.c b/src/southbridge/ricoh/rl5c476/rl5c476.c index f78f816..da812e1 100644 --- a/src/southbridge/ricoh/rl5c476/rl5c476.c +++ b/src/southbridge/ricoh/rl5c476/rl5c476.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include <console/console.h> #include <device/cardbus.h> diff --git a/src/southbridge/ti/pci1x2x/pci1x2x.c b/src/southbridge/ti/pci1x2x/pci1x2x.c index 55d37af..2145f2f 100644 --- a/src/southbridge/ti/pci1x2x/pci1x2x.c +++ b/src/southbridge/ti/pci1x2x/pci1x2x.c @@ -3,7 +3,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/cardbus.h> #include <console/console.h> #include "chip.h" diff --git a/src/southbridge/ti/pci7420/cardbus.c b/src/southbridge/ti/pci7420/cardbus.c index 16fdf44..6a2b5fb 100644 --- a/src/southbridge/ti/pci7420/cardbus.c +++ b/src/southbridge/ti/pci7420/cardbus.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/cardbus.h> #include "pci7420.h" diff --git a/src/southbridge/ti/pci7420/firewire.c b/src/southbridge/ti/pci7420/firewire.c index a327745..53a9bd6 100644 --- a/src/southbridge/ti/pci7420/firewire.c +++ b/src/southbridge/ti/pci7420/firewire.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <console/console.h> #include <device/cardbus.h> #include "pci7420.h" diff --git a/util/vgabios/device.c b/util/vgabios/device.c index a129cbf..03920e9 100644 --- a/util/vgabios/device.c +++ b/util/vgabios/device.c @@ -10,7 +10,6 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> /* the device we are working with... */ biosemu_device_t bios_device; -- To view, visit https://review.coreboot.org/c/coreboot/+/81831?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia645b8dba8c688187a25916f508593f333821f88 Gerrit-Change-Number: 81831 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: tree: Drop duplicated <device/{path.h,resource.h}>
by Elyes Haouas (Code Review) 11 Apr '24

11 Apr '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81830?usp=email ) Change subject: tree: Drop duplicated <device/{path.h,resource.h}> ...................................................................... tree: Drop duplicated <device/{path.h,resource.h}> Change-Id: I2ef82c8fe30b1c1399a9f85c1734ce8ba16a1f88 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/acpi/device.c M src/arch/x86/cpu.c M src/arch/x86/mpspec.c M src/cpu/x86/mp_init.c M src/device/device_const.c M src/device/device_util.c M src/device/oprom/yabel/device.c M src/device/oprom/yabel/io.c M src/device/oprom/yabel/mem.c M src/drivers/generic/adau7002/adau7002.c M src/drivers/generic/alc1015/alc1015.c M src/drivers/generic/bayhub/bh720.c M src/drivers/generic/bayhub_lv2/lv2.c M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/generic/max98357a/max98357a.c M src/drivers/generic/nau8315/nau8315.c M src/drivers/genesyslogic/gl9755/gl9755.c M src/drivers/genesyslogic/gl9763e/gl9763e.c M src/drivers/i2c/cs35l53/cs35l53.c M src/drivers/i2c/cs42l42/cs42l42.c M src/drivers/i2c/da7219/da7219.c M src/drivers/i2c/generic/generic.c M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c M src/drivers/i2c/max98373/max98373.c M src/drivers/i2c/max98390/max98390.c M src/drivers/i2c/max98396/max98396.c M src/drivers/i2c/max98927/max98927.c M src/drivers/i2c/nau8825/nau8825.c M src/drivers/i2c/rt1011/rt1011.c M src/drivers/i2c/rt5663/rt5663.c M src/drivers/i2c/sx9310/sx9310.c M src/drivers/i2c/sx9324/sx9324.c M src/drivers/i2c/sx9360/sx9360.c M src/drivers/i2c/tpm/chip.c M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/soundwire/soundwire.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/nxp/uwb/uwb.c M src/drivers/sof/sof.c M src/drivers/soundwire/alc1308/alc1308.c M src/drivers/soundwire/alc5682/alc5682.c M src/drivers/soundwire/alc711/alc711.c M src/drivers/soundwire/cs42l42/cs42l42.c M src/drivers/soundwire/max98363/max98363.c M src/drivers/soundwire/max98373/max98373.c M src/drivers/spi/acpi/acpi.c M src/drivers/uart/acpi/acpi.c M src/drivers/usb/acpi/usb_acpi.c M src/ec/google/chromeec/audio_codec/audio_codec.c M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c M src/include/device/pci.h M src/include/reg_script.h M src/lib/reg_script.c M src/soc/amd/common/block/root_complex/ioapic.c M src/soc/amd/common/fsp/fsp_graphics.c M src/soc/intel/apollolake/romstage.c M src/soc/intel/cannonlake/graphics.c M src/soc/intel/common/block/smbus/smbus.c M src/soc/intel/common/block/usb4/pcie.c M src/soc/intel/xeon_sp/include/soc/chip_common.h M src/soc/intel/xeon_sp/spr/ioat.c M src/soc/mediatek/common/pcie.c M src/southbridge/intel/bd82x6x/smbus.c M src/southbridge/intel/common/smbus_ops.c M src/southbridge/intel/i82801gx/smbus.c M src/southbridge/intel/i82801ix/smbus.c M src/southbridge/intel/i82801jx/smbus.c M src/southbridge/intel/ibexpeak/smbus.c M src/southbridge/intel/lynxpoint/smbus.c M tests/lib/bootmem-test.c M tests/lib/memrange-test.c M util/vgabios/device.c 74 files changed, 0 insertions(+), 75 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/81830/1 diff --git a/src/acpi/device.c b/src/acpi/device.c index 7fe5a37..95316b0 100644 --- a/src/acpi/device.c +++ b/src/acpi/device.c @@ -7,7 +7,6 @@ #include <acpi/acpigen.h> #include <acpi/acpigen_pci.h> #include <device/device.h> -#include <device/path.h> #include <stdlib.h> #include <types.h> #include <crc_byte.h> diff --git a/src/arch/x86/cpu.c b/src/arch/x86/cpu.c index f4c18c2..91cbcb0 100644 --- a/src/arch/x86/cpu.c +++ b/src/arch/x86/cpu.c @@ -10,7 +10,6 @@ #include <cpu/x86/mp.h> #include <cpu/x86/lapic.h> #include <cpu/x86/tsc.h> -#include <device/path.h> #include <device/device.h> #include <smp/spinlock.h> diff --git a/src/arch/x86/mpspec.c b/src/arch/x86/mpspec.c index f5242d3..d6f0cd5b 100644 --- a/src/arch/x86/mpspec.c +++ b/src/arch/x86/mpspec.c @@ -7,7 +7,6 @@ #include <cpu/cpu.h> #include <cpu/x86/lapic.h> #include <device/device.h> -#include <device/path.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <identity.h> diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index dd5e94d..bb51697 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -17,7 +17,6 @@ #include <cpu/x86/mp.h> #include <delay.h> #include <device/device.h> -#include <device/path.h> #include <smp/atomic.h> #include <smp/spinlock.h> #include <symbols.h> diff --git a/src/device/device_const.c b/src/device/device_const.c index 0521c7e..fc76304 100644 --- a/src/device/device_const.c +++ b/src/device/device_const.c @@ -3,7 +3,6 @@ #include <assert.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/pci_def.h> #include <device/pci_type.h> #include <fw_config.h> diff --git a/src/device/device_util.c b/src/device/device_util.c index b5d0d98..02641c1 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -3,9 +3,7 @@ #include <commonlib/bsd/helpers.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/pci_def.h> -#include <device/resource.h> #include <stdlib.h> #include <string.h> #include <types.h> diff --git a/src/device/oprom/yabel/device.c b/src/device/oprom/yabel/device.c index d1dc801..13723fe 100644 --- a/src/device/oprom/yabel/device.c +++ b/src/device/oprom/yabel/device.c @@ -40,7 +40,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <device/resource.h> /* the device we are working with... */ biosemu_device_t bios_device; diff --git a/src/device/oprom/yabel/io.c b/src/device/oprom/yabel/io.c index ed8db1a..8005bab 100644 --- a/src/device/oprom/yabel/io.c +++ b/src/device/oprom/yabel/io.c @@ -43,7 +43,6 @@ #include <device/pci.h> #include <device/pci_ops.h> -#include <device/resource.h> #include <arch/io.h> diff --git a/src/device/oprom/yabel/mem.c b/src/device/oprom/yabel/mem.c index fa6959e..0ec1c20 100644 --- a/src/device/oprom/yabel/mem.c +++ b/src/device/oprom/yabel/mem.c @@ -39,7 +39,6 @@ #include "biosemu.h" #include "mem.h" #include "compat/time.h" -#include <device/resource.h> #if !CONFIG(YABEL_DIRECTHW) || !CONFIG(YABEL_DIRECTHW) diff --git a/src/drivers/generic/adau7002/adau7002.c b/src/drivers/generic/adau7002/adau7002.c index 5917f69..db48bfe 100644 --- a/src/drivers/generic/adau7002/adau7002.c +++ b/src/drivers/generic/adau7002/adau7002.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" #if CONFIG(HAVE_ACPI_TABLES) diff --git a/src/drivers/generic/alc1015/alc1015.c b/src/drivers/generic/alc1015/alc1015.c index 7245f0c..257775e 100644 --- a/src/drivers/generic/alc1015/alc1015.c +++ b/src/drivers/generic/alc1015/alc1015.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" static void alc1015_fill_ssdt(const struct device *dev) diff --git a/src/drivers/generic/bayhub/bh720.c b/src/drivers/generic/bayhub/bh720.c index 5104c35..fb782ca 100644 --- a/src/drivers/generic/bayhub/bh720.c +++ b/src/drivers/generic/bayhub/bh720.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <device/mmio.h> -#include <device/path.h> #include <device/pci.h> #include <device/pci_ops.h> #include <device/pci_ids.h> diff --git a/src/drivers/generic/bayhub_lv2/lv2.c b/src/drivers/generic/bayhub_lv2/lv2.c index b2b85e1..3d94ac3 100644 --- a/src/drivers/generic/bayhub_lv2/lv2.c +++ b/src/drivers/generic/bayhub_lv2/lv2.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/pci.h> #include <device/pciexp.h> #include <device/pci_ops.h> diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c index 28e5be5..37b90ca 100644 --- a/src/drivers/generic/gpio_keys/gpio_keys.c +++ b/src/drivers/generic/gpio_keys/gpio_keys.c @@ -3,7 +3,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/generic/max98357a/max98357a.c b/src/drivers/generic/max98357a/max98357a.c index 8ce80f1..9b190ce 100644 --- a/src/drivers/generic/max98357a/max98357a.c +++ b/src/drivers/generic/max98357a/max98357a.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <gpio.h> #include "chip.h" diff --git a/src/drivers/generic/nau8315/nau8315.c b/src/drivers/generic/nau8315/nau8315.c index 8fe4e1f..294d519 100644 --- a/src/drivers/generic/nau8315/nau8315.c +++ b/src/drivers/generic/nau8315/nau8315.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <gpio.h> #include "chip.h" diff --git a/src/drivers/genesyslogic/gl9755/gl9755.c b/src/drivers/genesyslogic/gl9755/gl9755.c index 6b8dd7d..a160c0b 100644 --- a/src/drivers/genesyslogic/gl9755/gl9755.c +++ b/src/drivers/genesyslogic/gl9755/gl9755.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/pci.h> #include <device/pci_ops.h> #include <device/pci_ids.h> diff --git a/src/drivers/genesyslogic/gl9763e/gl9763e.c b/src/drivers/genesyslogic/gl9763e/gl9763e.c index 140535d..136c585 100644 --- a/src/drivers/genesyslogic/gl9763e/gl9763e.c +++ b/src/drivers/genesyslogic/gl9763e/gl9763e.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/pci.h> #include <device/pci_ops.h> #include <device/pci_ids.h> diff --git a/src/drivers/i2c/cs35l53/cs35l53.c b/src/drivers/i2c/cs35l53/cs35l53.c index 578e272..479ef7f 100644 --- a/src/drivers/i2c/cs35l53/cs35l53.c +++ b/src/drivers/i2c/cs35l53/cs35l53.c @@ -6,7 +6,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" diff --git a/src/drivers/i2c/cs42l42/cs42l42.c b/src/drivers/i2c/cs42l42/cs42l42.c index 8ccfd77..6d29dfe 100644 --- a/src/drivers/i2c/cs42l42/cs42l42.c +++ b/src/drivers/i2c/cs42l42/cs42l42.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" diff --git a/src/drivers/i2c/da7219/da7219.c b/src/drivers/i2c/da7219/da7219.c index 1a149ca..e6a5283 100644 --- a/src/drivers/i2c/da7219/da7219.c +++ b/src/drivers/i2c/da7219/da7219.c @@ -6,7 +6,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 03018ee..afff978 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -6,7 +6,6 @@ #include <device/i2c_bus.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include <gpio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/gpiomux/bus/bus.c b/src/drivers/i2c/gpiomux/bus/bus.c index a6c603a..5487f6d 100644 --- a/src/drivers/i2c/gpiomux/bus/bus.c +++ b/src/drivers/i2c/gpiomux/bus/bus.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/gpiomux/mux/mux.c b/src/drivers/i2c/gpiomux/mux/mux.c index 5f79fe5..91d4ebf 100644 --- a/src/drivers/i2c/gpiomux/mux/mux.c +++ b/src/drivers/i2c/gpiomux/mux/mux.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/max98373/max98373.c b/src/drivers/i2c/max98373/max98373.c index 37a8864..1035a7c 100644 --- a/src/drivers/i2c/max98373/max98373.c +++ b/src/drivers/i2c/max98373/max98373.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" #define MAX98373_ACPI_NAME "MAXI" diff --git a/src/drivers/i2c/max98390/max98390.c b/src/drivers/i2c/max98390/max98390.c index f4c4a70..f4912c1 100644 --- a/src/drivers/i2c/max98390/max98390.c +++ b/src/drivers/i2c/max98390/max98390.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c.h> #include <device/device.h> -#include <device/path.h> #include <identity.h> #include <stdint.h> #include <vendorcode/google/dsm_calib.h> diff --git a/src/drivers/i2c/max98396/max98396.c b/src/drivers/i2c/max98396/max98396.c index 6ad3931..ca07dbd 100644 --- a/src/drivers/i2c/max98396/max98396.c +++ b/src/drivers/i2c/max98396/max98396.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" diff --git a/src/drivers/i2c/max98927/max98927.c b/src/drivers/i2c/max98927/max98927.c index 9935d10..a5775db 100644 --- a/src/drivers/i2c/max98927/max98927.c +++ b/src/drivers/i2c/max98927/max98927.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" #define MAX98927_ACPI_NAME "MAXI" diff --git a/src/drivers/i2c/nau8825/nau8825.c b/src/drivers/i2c/nau8825/nau8825.c index 9e82538..8bf9e43 100644 --- a/src/drivers/i2c/nau8825/nau8825.c +++ b/src/drivers/i2c/nau8825/nau8825.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include <stdint.h> #include "chip.h" diff --git a/src/drivers/i2c/rt1011/rt1011.c b/src/drivers/i2c/rt1011/rt1011.c index bf62a6f..e8ee8df 100644 --- a/src/drivers/i2c/rt1011/rt1011.c +++ b/src/drivers/i2c/rt1011/rt1011.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c.h> #include <device/device.h> -#include <device/path.h> #include <stdint.h> #include <vendorcode/google/dsm_calib.h> #include "chip.h" diff --git a/src/drivers/i2c/rt5663/rt5663.c b/src/drivers/i2c/rt5663/rt5663.c index e2341dd..bcbe0ff 100644 --- a/src/drivers/i2c/rt5663/rt5663.c +++ b/src/drivers/i2c/rt5663/rt5663.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" #define RT5663_ACPI_NAME "RT53" diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index 5094608..e5142bc 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/sx9324/sx9324.c b/src/drivers/i2c/sx9324/sx9324.c index 05aca00..966726f 100644 --- a/src/drivers/i2c/sx9324/sx9324.c +++ b/src/drivers/i2c/sx9324/sx9324.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/sx9360/sx9360.c b/src/drivers/i2c/sx9360/sx9360.c index c9de0de..df154f4 100644 --- a/src/drivers/i2c/sx9360/sx9360.c +++ b/src/drivers/i2c/sx9360/sx9360.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/tpm/chip.c b/src/drivers/i2c/tpm/chip.c index a1d7389..cb99144 100644 --- a/src/drivers/i2c/tpm/chip.c +++ b/src/drivers/i2c/tpm/chip.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "tpm.h" #include "chip.h" diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c index 4044a26..92c45a8 100644 --- a/src/drivers/intel/mipi_camera/camera.c +++ b/src/drivers/intel/mipi_camera/camera.c @@ -8,7 +8,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include <device/pci_def.h> #include "chip.h" diff --git a/src/drivers/intel/soundwire/soundwire.c b/src/drivers/intel/soundwire/soundwire.c index 0137dad..2afb156 100644 --- a/src/drivers/intel/soundwire/soundwire.c +++ b/src/drivers/intel/soundwire/soundwire.c @@ -5,7 +5,6 @@ #include <acpi/acpi_soundwire.h> #include <commonlib/helpers.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <stdbool.h> diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 9704139..9e627de 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -5,7 +5,6 @@ #include <acpi/acpi_pld.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <drivers/usb/acpi/chip.h> #include <gpio.h> #include <string.h> diff --git a/src/drivers/nxp/uwb/uwb.c b/src/drivers/nxp/uwb/uwb.c index b828657..590b3f5 100644 --- a/src/drivers/nxp/uwb/uwb.c +++ b/src/drivers/nxp/uwb/uwb.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/spi.h> #include <spi-generic.h> #include <string.h> diff --git a/src/drivers/sof/sof.c b/src/drivers/sof/sof.c index 8cd577e..9f6391b 100644 --- a/src/drivers/sof/sof.c +++ b/src/drivers/sof/sof.c @@ -3,7 +3,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" diff --git a/src/drivers/soundwire/alc1308/alc1308.c b/src/drivers/soundwire/alc1308/alc1308.c index 5449fe8..fc7b2af 100644 --- a/src/drivers/soundwire/alc1308/alc1308.c +++ b/src/drivers/soundwire/alc1308/alc1308.c @@ -4,7 +4,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpi_soundwire.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <mipi/ids.h> #include <stdio.h> diff --git a/src/drivers/soundwire/alc5682/alc5682.c b/src/drivers/soundwire/alc5682/alc5682.c index 0d8a3ab..67ce61c 100644 --- a/src/drivers/soundwire/alc5682/alc5682.c +++ b/src/drivers/soundwire/alc5682/alc5682.c @@ -4,7 +4,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpi_soundwire.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <mipi/ids.h> #include <stdio.h> diff --git a/src/drivers/soundwire/alc711/alc711.c b/src/drivers/soundwire/alc711/alc711.c index cfe28ad..7d1ac42 100644 --- a/src/drivers/soundwire/alc711/alc711.c +++ b/src/drivers/soundwire/alc711/alc711.c @@ -4,7 +4,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpi_soundwire.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <mipi/ids.h> #include <stdio.h> diff --git a/src/drivers/soundwire/cs42l42/cs42l42.c b/src/drivers/soundwire/cs42l42/cs42l42.c index e7c14cc..c0e1d90 100644 --- a/src/drivers/soundwire/cs42l42/cs42l42.c +++ b/src/drivers/soundwire/cs42l42/cs42l42.c @@ -4,7 +4,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpi_soundwire.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <mipi/ids.h> #include <stdio.h> diff --git a/src/drivers/soundwire/max98363/max98363.c b/src/drivers/soundwire/max98363/max98363.c index 7b90d78..6eec97b 100644 --- a/src/drivers/soundwire/max98363/max98363.c +++ b/src/drivers/soundwire/max98363/max98363.c @@ -4,7 +4,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpi_soundwire.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <mipi/ids.h> #include <stdio.h> diff --git a/src/drivers/soundwire/max98373/max98373.c b/src/drivers/soundwire/max98373/max98373.c index e3107c4..a394154 100644 --- a/src/drivers/soundwire/max98373/max98373.c +++ b/src/drivers/soundwire/max98373/max98373.c @@ -4,7 +4,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpi_soundwire.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <mipi/ids.h> #include <stdio.h> diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c index 537c377..e87946f 100644 --- a/src/drivers/spi/acpi/acpi.c +++ b/src/drivers/spi/acpi/acpi.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/spi.h> #include <spi-generic.h> #include <string.h> diff --git a/src/drivers/uart/acpi/acpi.c b/src/drivers/uart/acpi/acpi.c index bcf896d..a245f2c 100644 --- a/src/drivers/uart/acpi/acpi.c +++ b/src/drivers/uart/acpi/acpi.c @@ -3,7 +3,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <console/console.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/usb/acpi/usb_acpi.c b/src/drivers/usb/acpi/usb_acpi.c index b463b3b..569147a 100644 --- a/src/drivers/usb/acpi/usb_acpi.c +++ b/src/drivers/usb/acpi/usb_acpi.c @@ -6,7 +6,6 @@ #include <acpi/acpigen_dsm.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" static bool usb_acpi_add_gpios_to_crs(struct drivers_usb_acpi_config *cfg) diff --git a/src/ec/google/chromeec/audio_codec/audio_codec.c b/src/ec/google/chromeec/audio_codec/audio_codec.c index a8def98..46c46f1 100644 --- a/src/ec/google/chromeec/audio_codec/audio_codec.c +++ b/src/ec/google/chromeec/audio_codec/audio_codec.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" #define CROS_EC_AUDIO_CODEC_HID "GOOG0013" diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 8fdfbfb..1ff2395 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -6,7 +6,6 @@ #include <console/console.h> #include <delay.h> #include <device/device.h> -#include <device/path.h> #include <elog.h> #include <rtc.h> #include <security/vboot/vboot_common.h> diff --git a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c index 64812d4..355ef71 100644 --- a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c +++ b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/include/device/pci.h b/src/include/device/pci.h index 88b9555..2e75195 100644 --- a/src/include/device/pci.h +++ b/src/include/device/pci.h @@ -25,7 +25,6 @@ #include <device/pci_ops.h> #include <device/pci_rom.h> #include <device/pci_type.h> /* IWYU pragma: export */ -#include <device/resource.h> #include <stddef.h> #include <stdint.h> diff --git a/src/include/reg_script.h b/src/include/reg_script.h index 38a80aa..56db353 100644 --- a/src/include/reg_script.h +++ b/src/include/reg_script.h @@ -6,7 +6,6 @@ #include <stdint.h> #include <device/device.h> #include <device/pci_type.h> -#include <device/resource.h> /* * The reg script library is a way to provide data-driven I/O accesses for diff --git a/src/lib/reg_script.c b/src/lib/reg_script.c index bad9d9c..c14f927 100644 --- a/src/lib/reg_script.c +++ b/src/lib/reg_script.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <delay.h> #include <device/device.h> -#include <device/resource.h> #include <device/pci.h> #include <stdint.h> #include <reg_script.h> diff --git a/src/soc/amd/common/block/root_complex/ioapic.c b/src/soc/amd/common/block/root_complex/ioapic.c index e183428..17e283f 100644 --- a/src/soc/amd/common/block/root_complex/ioapic.c +++ b/src/soc/amd/common/block/root_complex/ioapic.c @@ -4,7 +4,6 @@ #include <amdblocks/root_complex.h> #include <arch/ioapic.h> #include <device/device.h> -#include <device/resource.h> #include <types.h> void amd_pci_domain_init(struct device *domain) diff --git a/src/soc/amd/common/fsp/fsp_graphics.c b/src/soc/amd/common/fsp/fsp_graphics.c index 4847e3c..3e082e6 100644 --- a/src/soc/amd/common/fsp/fsp_graphics.c +++ b/src/soc/amd/common/fsp/fsp_graphics.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/resource.h> #include <fsp/graphics.h> void fsp_graphics_init(struct device *const dev) diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c index ba865e3..f710883 100644 --- a/src/soc/intel/apollolake/romstage.c +++ b/src/soc/intel/apollolake/romstage.c @@ -9,7 +9,6 @@ #include <device/device.h> #include <delay.h> #include <device/pci_def.h> -#include <device/resource.h> #include <fsp/api.h> #include <fsp/util.h> #include <intelblocks/cpulib.h> diff --git a/src/soc/intel/cannonlake/graphics.c b/src/soc/intel/cannonlake/graphics.c index 93a84c2..abbe079 100644 --- a/src/soc/intel/cannonlake/graphics.c +++ b/src/soc/intel/cannonlake/graphics.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/mmio.h> #include <device/pci_def.h> -#include <device/resource.h> #include <drivers/intel/gma/i915_reg.h> #include <intelblocks/graphics.h> #include <soc/ramstage.h> diff --git a/src/soc/intel/common/block/smbus/smbus.c b/src/soc/intel/common/block/smbus/smbus.c index 4f2ed36..97651c0 100644 --- a/src/soc/intel/common/block/smbus/smbus.c +++ b/src/soc/intel/common/block/smbus/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/soc/intel/common/block/usb4/pcie.c b/src/soc/intel/common/block/usb4/pcie.c index c066647..24b6f46 100644 --- a/src/soc/intel/common/block/usb4/pcie.c +++ b/src/soc/intel/common/block/usb4/pcie.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/soc/intel/xeon_sp/include/soc/chip_common.h b/src/soc/intel/xeon_sp/include/soc/chip_common.h index c499f62..0c0258a 100644 --- a/src/soc/intel/xeon_sp/include/soc/chip_common.h +++ b/src/soc/intel/xeon_sp/include/soc/chip_common.h @@ -4,7 +4,6 @@ #define _CHIP_COMMON_H_ #include <device/device.h> -#include <device/path.h> #include <soc/soc_util.h> union xeon_domain_path { diff --git a/src/soc/intel/xeon_sp/spr/ioat.c b/src/soc/intel/xeon_sp/spr/ioat.c index ecfc1f7..9ed9576 100644 --- a/src/soc/intel/xeon_sp/spr/ioat.c +++ b/src/soc/intel/xeon_sp/spr/ioat.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/resource.h> #include <defs_iio.h> #include <hob_iiouds.h> diff --git a/src/soc/mediatek/common/pcie.c b/src/soc/mediatek/common/pcie.c index 10bece9..ce9055a 100644 --- a/src/soc/mediatek/common/pcie.c +++ b/src/soc/mediatek/common/pcie.c @@ -6,7 +6,6 @@ #include <device/mmio.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/resource.h> #include <delay.h> #include <lib.h> #include <soc/addressmap.h> diff --git a/src/southbridge/intel/bd82x6x/smbus.c b/src/southbridge/intel/bd82x6x/smbus.c index d2ca247..9db8d7a 100644 --- a/src/southbridge/intel/bd82x6x/smbus.c +++ b/src/southbridge/intel/bd82x6x/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/common/smbus_ops.c b/src/southbridge/intel/common/smbus_ops.c index 347de73..8542ba3 100644 --- a/src/southbridge/intel/common/smbus_ops.c +++ b/src/southbridge/intel/common/smbus_ops.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/i82801gx/smbus.c b/src/southbridge/intel/i82801gx/smbus.c index d498037..f26ddd4 100644 --- a/src/southbridge/intel/i82801gx/smbus.c +++ b/src/southbridge/intel/i82801gx/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/i82801ix/smbus.c b/src/southbridge/intel/i82801ix/smbus.c index 1ddfb7f..8f60408 100644 --- a/src/southbridge/intel/i82801ix/smbus.c +++ b/src/southbridge/intel/i82801ix/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/i82801jx/smbus.c b/src/southbridge/intel/i82801jx/smbus.c index 8fa1914..15643bd 100644 --- a/src/southbridge/intel/i82801jx/smbus.c +++ b/src/southbridge/intel/i82801jx/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/ibexpeak/smbus.c b/src/southbridge/intel/ibexpeak/smbus.c index 3318458..6bbd1e4 100644 --- a/src/southbridge/intel/ibexpeak/smbus.c +++ b/src/southbridge/intel/ibexpeak/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/lynxpoint/smbus.c b/src/southbridge/intel/lynxpoint/smbus.c index 757254e..0363802 100644 --- a/src/southbridge/intel/lynxpoint/smbus.c +++ b/src/southbridge/intel/lynxpoint/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/tests/lib/bootmem-test.c b/tests/lib/bootmem-test.c index 4cf9a2d..5137533 100644 --- a/tests/lib/bootmem-test.c +++ b/tests/lib/bootmem-test.c @@ -3,7 +3,6 @@ #include <bootmem.h> #include <commonlib/coreboot_tables.h> #include <device/device.h> -#include <device/resource.h> #include <memrange.h> #include <stdlib.h> #include <string.h> diff --git a/tests/lib/memrange-test.c b/tests/lib/memrange-test.c index 9871484..eac4769 100644 --- a/tests/lib/memrange-test.c +++ b/tests/lib/memrange-test.c @@ -3,7 +3,6 @@ #include <tests/test.h> #include <device/device.h> -#include <device/resource.h> #include <commonlib/helpers.h> #include <memrange.h> diff --git a/util/vgabios/device.c b/util/vgabios/device.c index d130314..a129cbf 100644 --- a/util/vgabios/device.c +++ b/util/vgabios/device.c @@ -11,7 +11,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <device/resource.h> /* the device we are working with... */ biosemu_device_t bios_device; -- To view, visit https://review.coreboot.org/c/coreboot/+/81830?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2ef82c8fe30b1c1399a9f85c1734ce8ba16a1f88 Gerrit-Change-Number: 81830 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: mb/google/brya: Create trulo variant
by Subrata Banik (Code Review) 11 Apr '24

11 Apr '24

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81627?usp=email ) Change subject: mb/google/brya: Create trulo variant ...................................................................... mb/google/brya: Create trulo variant This patch adds a new variant trulo for the baseboard trulo. BUG=b:333314089 TEST=abuild -a -x -p none -t google/brya Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81627 Reviewed-by: Subrata Banik <subratabanik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <ericllai(a)google.com> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/trulo/include/variant/ec.h A src/mainboard/google/brya/variants/trulo/include/variant/gpio.h A src/mainboard/google/brya/variants/trulo/memory/Makefile.mk A src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/trulo/overridetree.cb 8 files changed, 52 insertions(+), 0 deletions(-) Approvals: Eric Lai: Looks good to me, approved Kapil Porwal: Looks good to me, approved build bot (Jenkins): Verified Sumeet R Pawnikar: Looks good to me, approved Subrata Banik: Looks good to me, approved diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 0df0ec1..7f6f7c7 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -494,6 +494,9 @@ select INTEL_GMA_HAVE_VBT select SOC_INTEL_TWINLAKE +config BOARD_GOOGLE_TRULO + select BOARD_GOOGLE_BASEBOARD_TRULO + config BOARD_GOOGLE_ULDREN select BOARD_GOOGLE_BASEBOARD_NISSA select CHROMEOS_WIFI_SAR if CHROMEOS @@ -638,6 +641,7 @@ default 0x3 if BOARD_GOOGLE_TAEKO4ES default 0x1 if BOARD_GOOGLE_TANIKS default 0x0 if BOARD_GOOGLE_TIVVIKS + default 0x0 if BOARD_GOOGLE_TRULO default 0x0 if BOARD_GOOGLE_ULDREN default 0x1 if BOARD_GOOGLE_VELL default 0x1 if BOARD_GOOGLE_VOLMAR @@ -726,6 +730,7 @@ default "Taeko4ES" if BOARD_GOOGLE_TAEKO4ES default "Taniks" if BOARD_GOOGLE_TANIKS default "Tivviks" if BOARD_GOOGLE_TIVVIKS + default "Trulo" if BOARD_GOOGLE_TRULO default "Uldren" if BOARD_GOOGLE_ULDREN default "Vell" if BOARD_GOOGLE_VELL default "Volmar" if BOARD_GOOGLE_VOLMAR @@ -786,6 +791,7 @@ default "taeko" if BOARD_GOOGLE_TAEKO default "taeko4es" if BOARD_GOOGLE_TAEKO4ES default "taniks" if BOARD_GOOGLE_TANIKS + default "trulo" if BOARD_GOOGLE_TRULO default "uldren" if BOARD_GOOGLE_ULDREN default "vell" if BOARD_GOOGLE_VELL default "volmar" if BOARD_GOOGLE_VOLMAR diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index a8d111a..0a22cad 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -140,6 +140,9 @@ config BOARD_GOOGLE_TIVVIKS bool "-> Tivviks" +config BOARD_GOOGLE_TRULO + bool "-> Trulo" + config BOARD_GOOGLE_ULDREN bool "-> Uldren" diff --git a/src/mainboard/google/brya/variants/trulo/include/variant/ec.h b/src/mainboard/google/brya/variants/trulo/include/variant/ec.h new file mode 100644 index 0000000..7a2a6ff --- /dev/null +++ b/src/mainboard/google/brya/variants/trulo/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __VARIANT_EC_H__ +#define __VARIANT_EC_H__ + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/brya/variants/trulo/include/variant/gpio.h b/src/mainboard/google/brya/variants/trulo/include/variant/gpio.h new file mode 100644 index 0000000..c4fe342 --- /dev/null +++ b/src/mainboard/google/brya/variants/trulo/include/variant/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +#endif diff --git a/src/mainboard/google/brya/variants/trulo/memory/Makefile.mk b/src/mainboard/google/brya/variants/trulo/memory/Makefile.mk new file mode 100644 index 0000000..850a62c --- /dev/null +++ b/src/mainboard/google/brya/variants/trulo/memory/Makefile.mk @@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Generated by: +# /tmp/go-build204585115/b001/exe/part_id_gen ADL lp5 src/mainboard/google/brya/variants/trulo/memory src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt + +SPD_SOURCES = placeholder diff --git a/src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt new file mode 100644 index 0000000..8ce2480 --- /dev/null +++ b/src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt @@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Generated by: +# /tmp/go-build204585115/b001/exe/part_id_gen ADL lp5 src/mainboard/google/brya/variants/trulo/memory src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt + +DRAM Part Name ID to assign diff --git a/src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt new file mode 100644 index 0000000..2499005 --- /dev/null +++ b/src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt @@ -0,0 +1,11 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Generated IDs are dependent on the order of parts in this file, +# so new parts must always be added at the end of the file! +# +# Generate an updated Makefile.mk and dram_id.generated.txt by running the +# part_id_gen tool from util/spd_tools. +# See util/spd_tools/README.md for more details and instructions. + +# Part Name diff --git a/src/mainboard/google/brya/variants/trulo/overridetree.cb b/src/mainboard/google/brya/variants/trulo/overridetree.cb new file mode 100644 index 0000000..ee86142 --- /dev/null +++ b/src/mainboard/google/brya/variants/trulo/overridetree.cb @@ -0,0 +1,4 @@ +chip soc/intel/alderlake + device domain 0 on + end +end -- To view, visit https://review.coreboot.org/c/coreboot/+/81627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d Gerrit-Change-Number: 81627 Gerrit-PatchSet: 20 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: mb/google/brya: Add new baseboard trulo
by Subrata Banik (Code Review) 11 Apr '24

11 Apr '24

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81626?usp=email ) Change subject: mb/google/brya: Add new baseboard trulo ...................................................................... mb/google/brya: Add new baseboard trulo This patch adds a new baseboard trulo. This commit is a stub which only adds the minimum code needed for a successful build. BUG=b:333314089 TEST=abuild -a -x -p none -t google/brya Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81626 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> --- M src/mainboard/google/brya/Kconfig A src/mainboard/google/brya/variants/baseboard/trulo/Makefile.mk A src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb A src/mainboard/google/brya/variants/baseboard/trulo/gpio.c A src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/ec.h A src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h A src/mainboard/google/brya/variants/baseboard/trulo/memory.c 7 files changed, 133 insertions(+), 2 deletions(-) Approvals: Subrata Banik: Looks good to me, approved Kapil Porwal: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index acafcda..0df0ec1 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -99,6 +99,22 @@ select TPM_GOOGLE_TI50 select SOC_INTEL_COMMON_MMC_OVERRIDE +config BOARD_GOOGLE_BASEBOARD_TRULO + def_bool n + select BOARD_GOOGLE_BRYA_COMMON + select BOARD_ROMSIZE_KB_16384 if !BOARD_ROMSIZE_KB_32768 + select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if CHROMEOS + select DRIVERS_AUDIO_SOF + select DRIVERS_INTEL_ISH + select MAINBOARD_DISABLE_STAGE_CACHE + select MEMORY_SOLDERDOWN + select SOC_INTEL_COMMON_MMC_OVERRIDE + select SOC_INTEL_CSE_LITE_COMPRESS_ME_RW + select SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE + select SOC_INTEL_TWINLAKE + select SYSTEM_TYPE_LAPTOP + select TPM_GOOGLE_TI50 + config BOARD_GOOGLE_AGAH select BOARD_GOOGLE_BASEBOARD_BRYA select DRIVERS_GENESYSLOGIC_GL9750 @@ -556,6 +572,7 @@ default "brask" if BOARD_GOOGLE_BASEBOARD_BRASK default "hades" if BOARD_GOOGLE_BASEBOARD_HADES default "nissa" if BOARD_GOOGLE_BASEBOARD_NISSA + default "trulo" if BOARD_GOOGLE_BASEBOARD_TRULO config CHROMEOS select EC_GOOGLE_CHROMEEC_SWITCHES @@ -636,8 +653,8 @@ config FMDFILE default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-serger.fmd" if CHROMEOS && BOARD_GOOGLE_BRASK - default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-16MiB-debugfsp.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_NISSA && BOARD_ROMSIZE_KB_16384 && BUILDING_WITH_DEBUG_FSP - default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-16MiB.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_NISSA && BOARD_ROMSIZE_KB_16384 + default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-16MiB-debugfsp.fmd" if CHROMEOS && (BOARD_GOOGLE_BASEBOARD_NISSA || BOARD_GOOGLE_BASEBOARD_TRULO) && BOARD_ROMSIZE_KB_16384 && BUILDING_WITH_DEBUG_FSP + default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-16MiB.fmd" if CHROMEOS && (BOARD_GOOGLE_BASEBOARD_NISSA || BOARD_GOOGLE_BASEBOARD_TRULO) && BOARD_ROMSIZE_KB_16384 default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if CHROMEOS config TPM_TIS_ACPI_INTERRUPT @@ -657,6 +674,7 @@ default "Google_Brask" if BOARD_GOOGLE_BASEBOARD_BRASK default "Google_Hades" if BOARD_GOOGLE_BASEBOARD_HADES default "Google_Nissa" if BOARD_GOOGLE_BASEBOARD_NISSA + default "Google_Trulo" if BOARD_GOOGLE_BASEBOARD_TRULO config MAINBOARD_PART_NUMBER default "Agah" if BOARD_GOOGLE_AGAH diff --git a/src/mainboard/google/brya/variants/baseboard/trulo/Makefile.mk b/src/mainboard/google/brya/variants/baseboard/trulo/Makefile.mk new file mode 100644 index 0000000..54a5c5b --- /dev/null +++ b/src/mainboard/google/brya/variants/baseboard/trulo/Makefile.mk @@ -0,0 +1,8 @@ +## SPDX-License-Identifier: GPL-2.0-only + +bootblock-y += gpio.c + +romstage-y += memory.c +romstage-y += gpio.c + +ramstage-y += gpio.c diff --git a/src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb new file mode 100644 index 0000000..a5e2217 --- /dev/null +++ b/src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb @@ -0,0 +1,4 @@ +chip soc/intel/alderlake + device domain 0 on + end +end diff --git a/src/mainboard/google/brya/variants/baseboard/trulo/gpio.c b/src/mainboard/google/brya/variants/baseboard/trulo/gpio.c new file mode 100644 index 0000000..410f194 --- /dev/null +++ b/src/mainboard/google/brya/variants/baseboard/trulo/gpio.c @@ -0,0 +1,46 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <soc/gpio.h> +#include <types.h> +#include <vendorcode/google/chromeos/chromeos.h> + +/* Pad configuration in ramstage */ +static const struct pad_config gpio_table[] = { + /* TODO */ +}; + +/* Early pad configuration in bootblock */ +static const struct pad_config early_gpio_table[] = { + /* TODO */ +}; + +const struct pad_config *__weak variant_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(gpio_table); + return gpio_table; +} + +const struct pad_config *__weak variant_gpio_override_table(size_t *num) +{ + *num = 0; + return NULL; +} + +const struct pad_config *__weak variant_early_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(early_gpio_table); + return early_gpio_table; +} + +static const struct cros_gpio cros_gpios[] = { + /* TODO */ +}; +DECLARE_CROS_GPIOS(cros_gpios); + +const struct pad_config *__weak variant_romstage_gpio_table(size_t *num) +{ + *num = 0; + return NULL; +} diff --git a/src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/ec.h b/src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/ec.h new file mode 100644 index 0000000..5ae5064 --- /dev/null +++ b/src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/ec.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __BASEBOARD_EC_H__ +#define __BASEBOARD_EC_H__ + +#include <baseboard/gpio.h> +#include <ec/ec.h> +#include <ec/google/chromeec/ec_commands.h> + +/* TODO: Set the correct values */ +#define MAINBOARD_EC_SCI_EVENTS 0 +#define MAINBOARD_EC_SMI_EVENTS 0 +#define MAINBOARD_EC_S5_WAKE_EVENTS 0 +#define MAINBOARD_EC_S3_WAKE_EVENTS 0 +#define MAINBOARD_EC_S0IX_WAKE_EVENTS 0 +#define MAINBOARD_EC_LOG_EVENTS 0 + +#endif /* __BASEBOARD_EC_H__ */ diff --git a/src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h b/src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h new file mode 100644 index 0000000..9ca9ee7 --- /dev/null +++ b/src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __BASEBOARD_GPIO_H__ +#define __BASEBOARD_GPIO_H__ + +#include <soc/gpe.h> +#include <soc/gpio.h> + +/* TODO: Set the correct values */ +#define EC_SCI_GPI 0 +#define GPIO_PCH_WP 0 +#define GPIO_EC_IN_RW 0 +#define GPIO_SLP_S0_GATE 0 + +#endif /* __BASEBOARD_GPIO_H__ */ diff --git a/src/mainboard/google/brya/variants/baseboard/trulo/memory.c b/src/mainboard/google/brya/variants/baseboard/trulo/memory.c new file mode 100644 index 0000000..420b366 --- /dev/null +++ b/src/mainboard/google/brya/variants/baseboard/trulo/memory.c @@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <gpio.h> + +const struct mb_cfg *__weak variant_memory_params(void) +{ + /* TODO */ + return NULL; +} + +bool __weak variant_is_half_populated(void) +{ + /* TODO */ + return false; +} + +void __weak variant_get_spd_info(struct mem_spd *spd_info) +{ + /* TODO */ +} -- To view, visit https://review.coreboot.org/c/coreboot/+/81626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d Gerrit-Change-Number: 81626 Gerrit-PatchSet: 18 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: mb/google/brya: Add new baseboard trulo
by Subrata Banik (Code Review) 11 Apr '24

11 Apr '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Nick Vaccaro, Sumeet R Pawnikar, Varshit Pandya. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81626?usp=email ) Change subject: mb/google/brya: Add new baseboard trulo ...................................................................... Patch Set 17: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/81626/comment/88c59460_77393b72 : PS16, Line 111: SOC_INTEL_ALDERLAKE_PCH_N > Any specific reason for this removal? We have this for Nissa which is the similar design like Trulo. Nissa is with ADL-N and Trulo is with TWL btw, we haven't removed the ADL-N config it just avoided the redundant selection as SOC_INTEL_TWINLAKE inherits SOC_INTEL_ALDERLAKE_PCH_N anyway, ``` config SOC_INTEL_TWINLAKE bool select SOC_INTEL_ALDERLAKE_PCH_N help Intel Twinlake support. Mainboards using TWL should select SOC_INTEL_TWINLAKE. ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/81626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d Gerrit-Change-Number: 81626 Gerrit-PatchSet: 17 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 11 Apr 2024 11:55:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/dell/optiplex_9020: Implement late HWM initialization
by Máté Kukri (Code Review) 11 Apr '24

11 Apr '24

Attention is currently required from: Angel Pons, Varshit Pandya. Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email ) Change subject: mb/dell/optiplex_9020: Implement late HWM initialization ...................................................................... Patch Set 5: (7 comments) Patchset: PS5: Left some quick comments, I'll fix the issues late tonight, or tomorrow. File src/mainboard/dell/optiplex_9020/mainboard.c: https://review.coreboot.org/c/coreboot/+/81529/comment/144a5c80_8907d081 : PS5, Line 290: die("Unknown GPIO chassis type\n"); > Why not return some fallback default value instead? There's nothing stopping coreboot from continuin […] I am fine with turning these into warning. https://review.coreboot.org/c/coreboot/+/81529/comment/8e6f8503_b594f8fd : PS5, Line 355: case 3: > Would it make sense to use an enum? Or are these "type" numbers magic? These are the same chassis type values the vendor firmware uses. I kept them to make it easier to cross reference in case any bugs pop up on the chassis types i dont have. https://review.coreboot.org/c/coreboot/+/81529/comment/666812be_a92c9be7 : PS5, Line 368: die("Unknown chassis type\n"); > Same here, is there any harm in not programming any table? No table results in the fan running at a low constant speed. https://review.coreboot.org/c/coreboot/+/81529/comment/0630ca2b_a6ba66bf : PS5, Line 371: if (CONFIG_MAX_CPUS > 2) { > This is a compile-time check. […] The vendor firmware bases this check on "max core address MSR" > 2 (i dont remember the id off the top of my head). on my system that returns 7, despite having a quad core cpu. I didn't check with a dual core, but it might be fine to remove this check as I don't think any supported cpu would return < 2 File src/mainboard/dell/optiplex_9020/sch5555_ec.h: https://review.coreboot.org/c/coreboot/+/81529/comment/9cdfb485_13d732a4 : PS5, Line 3: #pragma once > Hmmm, I thought we were supposed to use traditional include guards. […] Indeed, I missed that as this file copy pasted from my user-space utility. File src/mainboard/dell/optiplex_9020/sch5555_ec.c: https://review.coreboot.org/c/coreboot/+/81529/comment/df098fcb_8088718b : PS5, Line 51: for (size_t timeout = 0; timeout < 0xfff; ++timeout) : if (inb(SCH555x_EMI_IOBASE + 1) & 1) : break; > No delay in the polling loop? Vendor firmware doesn't use any delay either. LPC traffic shows a couple dozen iterations always being enough, so i think this is fine here. -- To view, visit https://review.coreboot.org/c/coreboot/+/81529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43 Gerrit-Change-Number: 81529 Gerrit-PatchSet: 5 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 11 Apr 2024 11:50:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: tree: Drop unused <cbmem.h>
by Elyes Haouas (Code Review) 11 Apr '24

11 Apr '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81829?usp=email ) Change subject: tree: Drop unused <cbmem.h> ...................................................................... tree: Drop unused <cbmem.h> Change-Id: If8be8dc26f2729f55dc6716e6d01e2b801d79e44 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/arch/riscv/payload.c M src/include/cbfs.h M src/soc/intel/common/block/crashlog/crashlog.c M src/soc/intel/common/block/vtd/vtd.c M src/soc/intel/xeon_sp/spr/soc_acpi.c M src/soc/intel/xeon_sp/uncore_acpi.c 6 files changed, 0 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/81829/1 diff --git a/src/arch/riscv/payload.c b/src/arch/riscv/payload.c index 7c6e0f4..2e35e60 100644 --- a/src/arch/riscv/payload.c +++ b/src/arch/riscv/payload.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <cbmem.h> #include <program_loading.h> #include <stdint.h> #include <arch/boot.h> diff --git a/src/include/cbfs.h b/src/include/cbfs.h index f0ae7a8..fc268f2 100644 --- a/src/include/cbfs.h +++ b/src/include/cbfs.h @@ -3,7 +3,6 @@ #ifndef _CBFS_H_ #define _CBFS_H_ -#include <cbmem.h> #include <commonlib/bsd/cbfs_mdata.h> #include <commonlib/mem_pool.h> #include <commonlib/region.h> diff --git a/src/soc/intel/common/block/crashlog/crashlog.c b/src/soc/intel/common/block/crashlog/crashlog.c index 541dea4..a9ac8a53 100644 --- a/src/soc/intel/common/block/crashlog/crashlog.c +++ b/src/soc/intel/common/block/crashlog/crashlog.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <cbmem.h> #include <console/console.h> #include <delay.h> #include <device/mmio.h> diff --git a/src/soc/intel/common/block/vtd/vtd.c b/src/soc/intel/common/block/vtd/vtd.c index f7da277..f67d8db 100644 --- a/src/soc/intel/common/block/vtd/vtd.c +++ b/src/soc/intel/common/block/vtd/vtd.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <bootstate.h> -#include <cbmem.h> #include <console/console.h> #include <cpu/cpu.h> #include <device/mmio.h> diff --git a/src/soc/intel/xeon_sp/spr/soc_acpi.c b/src/soc/intel/xeon_sp/spr/soc_acpi.c index 2d1f375..1249b8f 100644 --- a/src/soc/intel/xeon_sp/spr/soc_acpi.c +++ b/src/soc/intel/xeon_sp/spr/soc_acpi.c @@ -4,7 +4,6 @@ #include <arch/smp/mpspec.h> #include <arch/vga.h> #include <assert.h> -#include <cbmem.h> #include <cpu/intel/turbo.h> #include <device/mmio.h> #include <device/pci.h> diff --git a/src/soc/intel/xeon_sp/uncore_acpi.c b/src/soc/intel/xeon_sp/uncore_acpi.c index 86c3a66..29dc3ec 100644 --- a/src/soc/intel/xeon_sp/uncore_acpi.c +++ b/src/soc/intel/xeon_sp/uncore_acpi.c @@ -4,7 +4,6 @@ #include <arch/hpet.h> #include <arch/ioapic.h> #include <assert.h> -#include <cbmem.h> #include <cpu/x86/lapic.h> #include <commonlib/sort.h> #include <device/mmio.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/81829?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If8be8dc26f2729f55dc6716e6d01e2b801d79e44 Gerrit-Change-Number: 81829 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[main]: mb/dell/optiplex_9020: Implement late HWM initialization
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Attention is currently required from: Máté Kukri, Varshit Pandya. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email ) Change subject: mb/dell/optiplex_9020: Implement late HWM initialization ...................................................................... Patch Set 5: (6 comments) File src/mainboard/dell/optiplex_9020/mainboard.c: https://review.coreboot.org/c/coreboot/+/81529/comment/93c6a2d1_db420594 : PS5, Line 290: die("Unknown GPIO chassis type\n"); Why not return some fallback default value instead? There's nothing stopping coreboot from continuing to boot, even if the fans don't cooperate. https://review.coreboot.org/c/coreboot/+/81529/comment/152a91f0_b3ace8b6 : PS5, Line 355: case 3: Would it make sense to use an enum? Or are these "type" numbers magic? https://review.coreboot.org/c/coreboot/+/81529/comment/2aefdcb5_bead46be : PS5, Line 368: die("Unknown chassis type\n"); Same here, is there any harm in not programming any table? https://review.coreboot.org/c/coreboot/+/81529/comment/92684024_dba255a2 : PS5, Line 371: if (CONFIG_MAX_CPUS > 2) { This is a compile-time check. If this is about applying different values depending on the number of cores (or threads?) of the CPU, it would make more sense to query the information at runtime. File src/mainboard/dell/optiplex_9020/sch5555_ec.h: https://review.coreboot.org/c/coreboot/+/81529/comment/ccb820eb_39b954c1 : PS5, Line 3: #pragma once Hmmm, I thought we were supposed to use traditional include guards. Did the coding style change? File src/mainboard/dell/optiplex_9020/sch5555_ec.c: https://review.coreboot.org/c/coreboot/+/81529/comment/5add389b_b100fd0a : PS5, Line 51: for (size_t timeout = 0; timeout < 0xfff; ++timeout) : if (inb(SCH555x_EMI_IOBASE + 1) & 1) : break; No delay in the polling loop? -- To view, visit https://review.coreboot.org/c/coreboot/+/81529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43 Gerrit-Change-Number: 81529 Gerrit-PatchSet: 5 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Comment-Date: Thu, 11 Apr 2024 11:38:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024