Attention is currently required from: Frank Wu, Hung-Te Lin, Ian Feng, John Su, Paul Menzel, Shawn Ku, Shawn Ku, Yidi Lin, Yu-Ping Wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81791?usp=email )
Change subject: mb/google/corsola: Add new board variant Veluza
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81791?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c
Gerrit-Change-Number: 81791
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jasper Lee <jasper_lee(a)compal.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shawn Ku <shawnku(a)google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shawn Ku <shawnku(a)google.com>
Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 05:24:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Jon Murphy, Jérémy Compostella, Nico Huber, Werner Zeh.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81886?usp=email )
Change subject: arch/x86: Prevent .text/.init overlap with older linkers
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81886/comment/42262f7a_70c3684f :
PS2, Line 11: Default is 1024 bytes (1 KiB)
> > Sure, if you see it just as an intermediate workaround for ChromeOS build, it makes sense. I have switched to the newer binutils as of today 😊
>
> Yes, i'm seeing this as intermediate W/A for the next few months ( < 2month) where I wish Intel team will be able to support the EDK2 build with a new linker.
>
> Can I get a vote to land this CL as we are unable to pick remaining 64-bit PT related changes w/o this W/A.
marking as resolved now based on current discussion
--
To view, visit https://review.coreboot.org/c/coreboot/+/81886?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I019bf6896d84b2a84dff6f22323f0f446c0740b5
Gerrit-Change-Number: 81886
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 05:16:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Benjamin Doron, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81938?usp=email )
Change subject: soc/intel/alderlake: Enable Early CrashLog support
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/alderlake/crashlog.c:
https://review.coreboot.org/c/coreboot/+/81938/comment/6b620bcb_bf27450a :
PS1, Line 28: /* Set CrashLog BARs (FIXME: Is there a second BAR here? Documentation doesn't say so) */
don't u need to disable the MMIO and temp BAR before assigning the new one?
https://review.coreboot.org/c/coreboot/+/81938/comment/95e2eb91_e3fb0639 :
PS1, Line 38: /* Clear CrashLog BARs */
disable the memory before clearing the BAT other wise some transaction might fail in between
--
To view, visit https://review.coreboot.org/c/coreboot/+/81938?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1ce47531a74486bc5c996f7793af7087bc30d1f7
Gerrit-Change-Number: 81938
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 16 Apr 2024 05:16:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Hung-Te Lin, Ian Feng, John Su, Paul Menzel, Shawn Ku, Shawn Ku, Yidi Lin, Yu-Ping Wu.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81791?usp=email )
Change subject: mb/google/corsola: Add new board variant Veluza
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Hi Google,
Could you review the CL since it is rebased and the conflict is solved?
Thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81791?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c
Gerrit-Change-Number: 81791
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jasper Lee <jasper_lee(a)compal.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shawn Ku <shawnku(a)google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shawn Ku <shawnku(a)google.com>
Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 03:59:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Frank Wu, Hung-Te Lin, Ian Feng, John Su, Paul Menzel, Shawn Ku, Shawn Ku, Yidi Lin, Yu-Ping Wu.
Hello Eric Lai, Hung-Te Lin, Ian Feng, John Su, Shawn Ku, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81791?usp=email
to look at the new patch set (#6).
Change subject: mb/google/corsola: Add new board variant Veluza
......................................................................
mb/google/corsola: Add new board variant Veluza
Add a new Krabby follower device 'Veluza'.
BUG=b:333630131
BRANCH=corsola
TEST=none
Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c
Signed-off-by: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
---
M src/mainboard/google/corsola/Kconfig
M src/mainboard/google/corsola/Kconfig.name
2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/81791/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/81791?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c
Gerrit-Change-Number: 81791
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jasper Lee <jasper_lee(a)compal.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shawn Ku <shawnku(a)google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shawn Ku <shawnku(a)google.com>
Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai, Frank Wu, Hung-Te Lin, Ian Feng, John Su, Paul Menzel, Shawn Ku, Shawn Ku, Yidi Lin, Yu-Ping Wu.
Hello Eric Lai, Hung-Te Lin, Ian Feng, John Su, Shawn Ku, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81791?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+2 by Eric Lai, Code-Review+2 by Yu-Ping Wu, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: mb/google/corsola: Add new board variant Veluza
......................................................................
mb/google/corsola: Add new board variant Veluza
Add a new Krabby follower device 'Veluza'.
BUG=b:333630131
BRANCH=corsola
TEST=none
Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c
Signed-off-by: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
---
M src/mainboard/google/corsola/Kconfig
M src/mainboard/google/corsola/Kconfig.name
2 files changed, 9 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/81791/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/81791?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c
Gerrit-Change-Number: 81791
Gerrit-PatchSet: 5
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jasper Lee <jasper_lee(a)compal.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shawn Ku <shawnku(a)google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shawn Ku <shawnku(a)google.com>
Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Frank Wu, Hung-Te Lin, Ian Feng, John Su, Paul Menzel, Shawn Ku, Shawn Ku, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81791?usp=email )
Change subject: mb/google/corsola: Add new board variant Veluza
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Patchset:
PS4:
Please rebase.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81791?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c
Gerrit-Change-Number: 81791
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jasper Lee <jasper_lee(a)compal.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shawn Ku <shawnku(a)google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shawn Ku <shawnku(a)google.com>
Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 03:44:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Ian Feng, John Su, Paul Menzel, Shawn Ku, Shawn Ku, Yidi Lin.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81791?usp=email )
Change subject: mb/google/corsola: Add new board variant Veluza
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81791/comment/0f45a685_c28e0e47 :
PS3, Line 7: mb/google/corsola: Add new board Veluza
> Since this is only a minor comment about the commit subject, please just add `variant` to the title. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81791?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c
Gerrit-Change-Number: 81791
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jasper Lee <jasper_lee(a)compal.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shawn Ku <shawnku(a)google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shawn Ku <shawnku(a)google.com>
Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 03:29:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Frank Wu, Hung-Te Lin, Ian Feng, John Su, Paul Menzel, Shawn Ku, Shawn Ku, Yidi Lin.
Hello Eric Lai, Hung-Te Lin, Ian Feng, John Su, Shawn Ku, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81791?usp=email
to look at the new patch set (#4).
Change subject: mb/google/corsola: Add new board variant Veluza
......................................................................
mb/google/corsola: Add new board variant Veluza
Add a new Krabby follower device 'Veluza'.
BUG=b:333630131
BRANCH=corsola
TEST=none
Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c
Signed-off-by: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
---
M src/mainboard/google/corsola/Kconfig
M src/mainboard/google/corsola/Kconfig.name
2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/81791/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/81791?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c
Gerrit-Change-Number: 81791
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jasper Lee <jasper_lee(a)compal.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shawn Ku <shawnku(a)google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shawn Ku <shawnku(a)google.com>
Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: newpatchset