Attention is currently required from: Arthur Heymans, Jon Murphy, Jérémy Compostella, Subrata Banik, Werner Zeh.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81886?usp=email )
Change subject: arch/x86: Prevent .text/.init overlap with older linkers
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81886/comment/557a3bdc_5ded9abf :
PS2, Line 11: Default is 1024 bytes (1 KiB)
> > > Sure, if you see it just as an intermediate workaround for ChromeOS build, it makes sense. […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/81886?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I019bf6896d84b2a84dff6f22323f0f446c0740b5
Gerrit-Change-Number: 81886
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 08:47:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter, Jérémy Compostella, Michał Kopeć, Michał Żygowski, Patrick Rudolph, Shuo Liu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81276?usp=email )
Change subject: drivers/pc80/tpm: Support Xeon-SP
......................................................................
Patch Set 7:
(3 comments)
File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/81276/comment/28611b1d_2b75e6c9 :
PS7, Line 808: /* Windows 11 requires the following path for TPM to be detected */
Do we know that for sure? i.e. do we know that Windows 11 would accept a TPM
below a segment group that isn't called `PCI0'? Otherwise we should probably
change the comment to reflect what Arthur said.
https://review.coreboot.org/c/coreboot/+/81276/comment/deb81fd3_46e5882f :
PS7, Line 812: path = "\\_SB_.PCI0";
While I could imagine a devicetree where the TPM device isn't below a domain
device, this path would certainly not work in that case.
I guess we should try the original code that was used before the Windows 11
quirk was added.
https://review.coreboot.org/c/coreboot/+/81276/comment/f8754c10_fd10500d :
PS7, Line 813:
`path` could be `NULL` here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81276?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6130b937ec81bbde78d2619eb859ecf354fc3854
Gerrit-Change-Number: 81276
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 16 Apr 2024 08:42:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Martin L Roth, Patrick Rudolph, Shuo Liu, Tim Chu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81275?usp=email )
Change subject: device/device_util: Use const qualifier
......................................................................
Patch Set 20: Code-Review+1
(2 comments)
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/81275/comment/fe474551_a03a28a6 :
PS20, Line 3: #include <assert.h>
Not needed anymore, I guess.
File src/soc/intel/xeon_sp/chip_common.c:
https://review.coreboot.org/c/coreboot/+/81275/comment/ee2369a8_f895836f :
PS20, Line 139: if (dev->path.type == DEVICE_PATH_DOMAIN)
: domain = dev;
: else
: domain = dev_get_pci_domain(dev);
Just for the future: this pattern wouldn't be necessary if dev_get_domain()
would allow to be called with the domain.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81275?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac04fe6931a43070f6638b399adbff2ce64829c9
Gerrit-Change-Number: 81275
Gerrit-PatchSet: 20
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 08:27:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Benjamin Doron, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81936?usp=email )
Change subject: soc/intel/alderlake: Refactor CrashLog BAR helpers
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/crashlog.c:
https://review.coreboot.org/c/coreboot/+/81936/comment/34ace578_c5591ff6 :
PS1, Line 43: pci_read_config32(SA_DEV_TMT, PCI_BASE_ADDRESS_0) &
: ~PCI_BASE_ADDRESS_MEM_ATTR_MASK;
is the bar MEM32 ? Otherwise you need the upper 32bit too.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81936?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4d1d9d19b4b81e5e90f18ae0c03d1c34d3724eb
Gerrit-Change-Number: 81936
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 16 Apr 2024 08:16:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Benjamin Doron.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81937?usp=email )
Change subject: soc/intel/common/block/crashlog: Add Early CrashLog feature
......................................................................
Patch Set 1:
(5 comments)
File src/soc/intel/common/block/crashlog/early_crashlog.c:
https://review.coreboot.org/c/coreboot/+/81937/comment/b1b58618_e4775a21 :
PS1, Line 7: void __weak early_cl_enable_bars(void)
: {
: printk(BIOS_WARNING, "%s: Operation unsupported!\n", __func__);
: }
:
: void __weak early_cl_disable_bars(void)
: {
: printk(BIOS_WARNING, "%s: Operation unsupported!\n", __func__);
: }
why weak functions? Linker errors when the functions are lacking at buildtime would be better than runtime warnings.
https://review.coreboot.org/c/coreboot/+/81937/comment/873e751d_0eb87fd5 :
PS1, Line 56: while (copied < size) {
I don't understand the naming of the variables. It looks like stuff only gets printed and not copied?
https://review.coreboot.org/c/coreboot/+/81937/comment/2419e673_2643cdcd :
PS1, Line 58: u32
void *, or maybe use read32p?
https://review.coreboot.org/c/coreboot/+/81937/comment/6b72ce69_91de8ceb :
PS1, Line 59: BIOS_DEBUG
BIOS_SPEW?
https://review.coreboot.org/c/coreboot/+/81937/comment/93f1adbc_c56f01c1 :
PS1, Line 59: printk(BIOS_DEBUG, "0x%x 0x%x 0x%x 0x%x ",
: (data & 0xff000000) >> 24,
: (data & 0x00ff0000) >> 16,
: (data & 0x0000ff00) >> 8,
: (data & 0x000000ff));
Any reason for big endian representation?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81937?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a02f29a3bb63ed210ab3a6812c8575569e43c07
Gerrit-Change-Number: 81937
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 08:15:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Zheng Bao.
Hello Zheng Bao,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81929?usp=email
to look at the new patch set (#2).
Change subject: amdfwtool: function getopt prints usage only once and returns
......................................................................
amdfwtool: function getopt prints usage only once and returns
Change-Id: Ie377c65147f6a72955e840fcf60001224e9e6f84
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/amdfwtool/opts.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/81929/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81929?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie377c65147f6a72955e840fcf60001224e9e6f84
Gerrit-Change-Number: 81929
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Attention: Zheng Bao
Gerrit-MessageType: newpatchset
Attention is currently required from: David Wu, Krishna P Bhat D, Reka Norman, Stefan Reinauer, Subrata Banik.
Hello David Wu, Krishna P Bhat D, Reka Norman, Stefan Reinauer, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81928?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/ifdtool: Add support for checking GPR0 status
......................................................................
util/ifdtool: Add support for checking GPR0 status
This patch adds support for the new command-line option `-c` to
the ifdtool, which is able to check GPR0 status.
User can use ifdtool with '-c' option to check whether GPR0 is set to
enabled or disabled in the binary file.
BUG=none
TEST=(1) Run `ifdtool -p mtl -c image.bin` on a locked karis image,
show "GPRO status: Enabled".
(2) Run `ifdtool -p mtl -c unlock_image.bin` on a unlocked karis
image, show "GPRO status: Disabled".
Change-Id: I6b3af973be784200b965a68e5f6b7737cba03ed7
Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
---
M util/ifdtool/ifdtool.c
1 file changed, 33 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/81928/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/81928?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b3af973be784200b965a68e5f6b7737cba03ed7
Gerrit-Change-Number: 81928
Gerrit-PatchSet: 4
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: David Wu.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81928?usp=email )
Change subject: util/ifdtool: Add support for checking GPR0 status
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81928?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b3af973be784200b965a68e5f6b7737cba03ed7
Gerrit-Change-Number: 81928
Gerrit-PatchSet: 3
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 07:46:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment