Attention is currently required from: Arthur Heymans, Jon Murphy, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Subrata Banik, Werner Zeh.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81886?usp=email )
Change subject: arch/x86: Prevent .text/.init overlap with older linkers
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81886?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I019bf6896d84b2a84dff6f22323f0f446c0740b5
Gerrit-Change-Number: 81886
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 02:29:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Felix Held, Kapil Porwal, Matt DeVillier, Nick Vaccaro, Subrata Banik.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81871?usp=email )
Change subject: mb/google/brya: Enable UFS driver for edk2 payload
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81871?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3dc018582e974bf73c7668f78da9b81eeb038c01
Gerrit-Change-Number: 81871
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 17 Apr 2024 02:28:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Martin L Roth, Maximilian Brune.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81081?usp=email )
Change subject: lib/device_tree: Add some FDT helper functions
......................................................................
Patch Set 18:
(1 comment)
File src/lib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/81081/comment/314ecaa8_bf4bbf8a :
PS18, Line 175: ""
> You always want the addr/size cells from the parent node, since these are the ones that influence th […]
Yeah, you're right, sorry. `dt_find_node()` is doing something different, that's what threw me for a loop there. I'm not sure if that's a bug or just intentional lazyness (because in practice nodes that have reg props don't also tend to have addr/size cell props for their children that are different than their own), but it wouldn't be hard to fix (just move the `dt_read_cell_props()` below the abort condition check), so we probably should.
For your case... hmm... actually, upon reading it closely again I think you're currently making a subtle mistake with what you pass through the offset parameter, and if you fix that, this should become easier:
Right now I believe(?) you want `node_offset` in `fdt_find_node()` to be pointing the the start of an array of child nodes, right? But that's not how you're calling it from `fdt_find_node_by_path()`. You're calling it with `fdt_hdr->struct_offset`, which points to the very start of the root node, not to an array of its children. The root node is a full node that begins with a FDT_BEGIN_NODE token, then a name (which is normally just four '\0' bytes), then potentially a bunch of FDT_PROP tokens, then the whole subtree of child nodes, and finally an FDT_END_NODE. So that means that when you first enter `fdt_find_node()` and immediately jump into that do-while loop, you're trying to iterate over an array of nodes but you actually only have a single root node. I guess it doesn't matter as long as the path you're searching can always be found under that root node, but theoretically, if the path check wasn't stopping it, your code would continue running over the end of the root node (and thereby the whole struct block) in search for more nodes.
I think it would make more sense to pass the offset of the start of the properties (i.e. what you get after you call `fdt_next_node_name()`). Then it can either return that immediately if we've reached the `NULL` in the path array, or it can parse addr/size cell props and then go iterate through the children if it hasn't. So basically in `fdt_find_node_by_path()` you'd start by calling
```
u32 struct_offset = be32toh(fdt_hdr->structure_offset);
size_t name_size = fdt_next_node_name(blob, struct_offset, NULL);
fdt_find_node(blob, struct_offset + name_size, path_array /* of the form { "cpus", "cpu@1", NULL } */, addrcp, sizecp);
```
and then `fdt_find_node()` would look roughly like this:
```
u32 fdt_find_node(const void *blob, u32 prop_start_offset, const char** path, u32 *addrcp, u32 *sizecp)
{
size_t size;
const char *node_name;
if (!*path)
return prop_start_offset;
u32 offset = fdt_read_cell_props(blob, prop_start_offset, addrcp, sizecp);
while ((size = fdt_next_node_name(blob, offset, &node_name))) {
if (!strcmp(*path, node_name))
return fdt_find_node(blob, offset + size, path + 1, addrcp, sizecp);
offset += fdt_skip_node(blob, offset);
}
return 0;
}
```
Would that make sense?
(BTW, have you noticed that you're basically parsing each node name twice, because you need to first call `fdt_next_node_name()` manually to have the name to `strcmp()`, but then `fdt_skip_node()` wants to call `fdt_next_node_name()` again? It would probably be good to optimize that, maybe by adding a `skip_name` parameter to `fdt_skip_node()`.)
--
To view, visit https://review.coreboot.org/c/coreboot/+/81081?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2fb1d93c5b3e1cb2f7d9584db52bbce3767b63d8
Gerrit-Change-Number: 81081
Gerrit-PatchSet: 18
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 02:12:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Paul Menzel.
Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81553?usp=email )
Change subject: mb/google/brya/var/bujia: Add VBT data files
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81553/comment/91e13ec6_77fb5532 :
PS5, Line 7: for bujia
> Redundant as it’s in the prefix.
Done
https://review.coreboot.org/c/coreboot/+/81553/comment/ff823e68_78ad34f6 :
PS5, Line 11:
> How did you create the VBT? What does it contain?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81553?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id56461708250eaedd288ddbf788d686153df0b96
Gerrit-Change-Number: 81553
Gerrit-PatchSet: 6
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 17 Apr 2024 01:32:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Ivan Chen, Nick Vaccaro, Paul Menzel, Shelley Chen, Sumeet R Pawnikar.
Eren Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81833?usp=email )
Change subject: mb/google/brox/var/greenbayupoc: Add fw_config field for storage
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> IMHO, move to baseboard also can benefit the depthcharge like nissa did.
Hi all,
May I ask that is there a final conclusion?
Should we change the fw_config definition to baseboard or should we keep it here?
Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/81833?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e220787d6ac73ec8fa2469ed958981d0801920e
Gerrit-Change-Number: 81833
Gerrit-PatchSet: 3
Gerrit-Owner: Eren Peng <peng.eren(a)inventec.corp-partner.google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <ericllai(a)google.com>
Gerrit-CC: Garen Wu <wu.garen(a)inventec.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rasheed Hsueh <hsueh.rasheed(a)inventec.corp-partner.google.com>
Gerrit-CC: Steven Yeh <yeh.stevenct(a)inventec.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 01:05:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen <shchen(a)google.com>
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Comment-In-Reply-To: Ivan Chen <yulunchen(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Ivan Chen, Nick Vaccaro, Paul Menzel, Shelley Chen, Sumeet R Pawnikar.
Eren Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81833?usp=email )
Change subject: mb/google/brox/var/greenbayupoc: Add fw_config field for storage
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81833/comment/ce6d8f70_32327b13 :
PS2, Line 9: Add fw_config field for storage to prevent depthcharge build break
> Please mention the options, and add a dot/period at the end of sentences.
Done
File src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/81833/comment/89c5e786_5672ec07 :
PS2, Line 3:
> Remove extra tab. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81833?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e220787d6ac73ec8fa2469ed958981d0801920e
Gerrit-Change-Number: 81833
Gerrit-PatchSet: 3
Gerrit-Owner: Eren Peng <peng.eren(a)inventec.corp-partner.google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <ericllai(a)google.com>
Gerrit-CC: Garen Wu <wu.garen(a)inventec.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rasheed Hsueh <hsueh.rasheed(a)inventec.corp-partner.google.com>
Gerrit-CC: Steven Yeh <yeh.stevenct(a)inventec.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 01:03:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Eren Peng, Ivan Chen, Nick Vaccaro, Shelley Chen, Sumeet R Pawnikar.
Hello Ivan Chen, Nick Vaccaro, Shelley Chen, Sumeet R Pawnikar, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81833?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Sumeet R Pawnikar, Verified+1 by build bot (Jenkins)
Change subject: mb/google/brox/var/greenbayupoc: Add fw_config field for storage
......................................................................
mb/google/brox/var/greenbayupoc: Add fw_config field for storage
Add STORAGE_UNKNOWN, STORAGE_UFS, STORAGE_NVME for storage fw_config
field to prevent depthcharge build break.
BUG=b:333325006
TEST=emerge-brox coreboot depthcharge with no errors
Change-Id: I0e220787d6ac73ec8fa2469ed958981d0801920e
Signed-off-by: Eren Peng <peng.eren(a)inventec.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/81833/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/81833?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e220787d6ac73ec8fa2469ed958981d0801920e
Gerrit-Change-Number: 81833
Gerrit-PatchSet: 3
Gerrit-Owner: Eren Peng <peng.eren(a)inventec.corp-partner.google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <ericllai(a)google.com>
Gerrit-CC: Garen Wu <wu.garen(a)inventec.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rasheed Hsueh <hsueh.rasheed(a)inventec.corp-partner.google.com>
Gerrit-CC: Steven Yeh <yeh.stevenct(a)inventec.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Eren Peng <peng.eren(a)inventec.corp-partner.google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Elyes Haouas, Eric Lai, Felix Held, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81857?usp=email )
Change subject: util/lint: Add lint rule to watch for Makefile.inc
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File util/lint/lint-stable-030-makefile-inc:
https://review.coreboot.org/c/coreboot/+/81857/comment/95eed081_7966d3e9 :
PS2, Line 22:
Use spaces instead of tabs for consistency
--
To view, visit https://review.coreboot.org/c/coreboot/+/81857?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a47998e1c997b82b8a15319eae96cdc0de64e77
Gerrit-Change-Number: 81857
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 16 Apr 2024 23:00:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Nico Huber.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81947?usp=email )
Change subject: payloads/external: Call $(strip_quotes ) on prebuilt iPXE path
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81947?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibcaa59be0fdd84d1fb9e061394fd9b0f7aa1830b
Gerrit-Change-Number: 81947
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 22:44:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81947?usp=email )
Change subject: payloads/external: Call $(strip_quotes ) on prebuilt iPXE path
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81947?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibcaa59be0fdd84d1fb9e061394fd9b0f7aa1830b
Gerrit-Change-Number: 81947
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 21:43:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment