Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81947?usp=email )
Change subject: payloads/external: Call $(strip_quotes ) on prebuilt iPXE path
......................................................................
payloads/external: Call $(strip_quotes ) on prebuilt iPXE path
Currently, we keep the double-quotes from Kconfig, resulting in an
invalid path. So just call `strip_quotes` like we do with all other
paths from Kconfig.
Change-Id: Ibcaa59be0fdd84d1fb9e061394fd9b0f7aa1830b
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M payloads/external/Makefile.mk
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/81947/1
diff --git a/payloads/external/Makefile.mk b/payloads/external/Makefile.mk
index 9b79f1a..5d385a4 100644
--- a/payloads/external/Makefile.mk
+++ b/payloads/external/Makefile.mk
@@ -344,7 +344,7 @@
PXE_ROM_PCI_ID:=$(subst $(comma),,$(CONFIG_PXE_ROM_ID))
ifeq ($(CONFIG_PXE_ROM),y)
-PXE_ROM_FILE:=$(CONFIG_PXE_ROM_FILE)
+PXE_ROM_FILE:=$(call strip_quotes,$(CONFIG_PXE_ROM_FILE))
endif
ifeq ($(CONFIG_BUILD_IPXE),y)
PXE_ROM_FILE:=payloads/external/iPXE/ipxe/ipxe.rom
--
To view, visit https://review.coreboot.org/c/coreboot/+/81947?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibcaa59be0fdd84d1fb9e061394fd9b0f7aa1830b
Gerrit-Change-Number: 81947
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: newchange
Attention is currently required from: Alicja Michalska, Felix Singer, Michał Żygowski, Nicholas Chin, Paul Menzel.
Maxim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80853?usp=email )
Change subject: mb/erying: Add Erying Polestar G613 Pro (TGL-H)
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/mainboard/erying/tgl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80853/comment/c96d5f17_031c2271 :
PS7, Line 144: register "TMPIN1.mode" = "THERMAL_DIODE"
> Hello! Yes, it usually should be the case, but that's not how vendor firmware had it configured. […]
Interesting. Thanks for the details.
Unfortunately, it's very difficult to resolve your problem without documentation, but here's another thought:
I have no experience with ITE, but usually need to set a target sensor for the fan and I don't see this in the settings. I mean, how is FAN2 related to TMPIN1?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80853?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iffb9e357da2eb686bdcd9a9837df8a60fa94011e
Gerrit-Change-Number: 80853
Gerrit-PatchSet: 7
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 20:51:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Alicja Michalska <ahplka19(a)gmail.com>
Comment-In-Reply-To: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Jean Lucas.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81946?usp=email )
Change subject: nb/intel/gm45: Call `mb_post_raminit_setup()` later
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81946?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46abffa48e7e0848f9346ce9c6498860e4ece2da
Gerrit-Change-Number: 81946
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jean Lucas
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Jean Lucas
Gerrit-Comment-Date: Tue, 16 Apr 2024 20:51:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Nicholas Chin.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81861?usp=email )
Change subject: nb/intel/gm45: Fill in memory info
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81861?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I92060ce05bdf0ca617a3383a2db1fdbd43df6fe4
Gerrit-Change-Number: 81861
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jean Lucas
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 20:49:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Vladimir Serbinenko.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81899?usp=email )
Change subject: libpayload: Support choosing fmap partitions
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I assume this is part of your boot path picker payload effort... can you explain why you need this? I thought your goal was just to either load depthcharge from the RW slot or a different payload from the RO slot, so aren't `cbfs_load()` and `cbfs_ro_load()` good enough for that?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81899?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie191b7003a2d9a2220bc27712ea9cb9434cf8d28
Gerrit-Change-Number: 81899
Gerrit-PatchSet: 1
Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Comment-Date: Tue, 16 Apr 2024 20:26:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment