coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: cbfstool: Add printing of legacy stage type
by Martin L Roth (Code Review) 27 Mar '24

27 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81504?usp=email ) Change subject: cbfstool: Add printing of legacy stage type ...................................................................... cbfstool: Add printing of legacy stage type This is useful for listing older images. Change-Id: I588028d4327f59538f7c9920b671458fc631cb4c Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81504 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- M util/cbfstool/cbfs.h 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved diff --git a/util/cbfstool/cbfs.h b/util/cbfstool/cbfs.h index eca7168..3336e08 100644 --- a/util/cbfstool/cbfs.h +++ b/util/cbfstool/cbfs.h @@ -31,6 +31,7 @@ static struct typedesc_t filetypes[] unused = { {CBFS_TYPE_BOOTBLOCK, "bootblock"}, {CBFS_TYPE_CBFSHEADER, "cbfs header"}, + {CBFS_TYPE_LEGACY_STAGE, "legacy stage"}, {CBFS_TYPE_STAGE, "stage"}, {CBFS_TYPE_SELF, "simple elf"}, {CBFS_TYPE_FIT_PAYLOAD, "fit_payload"}, -- To view, visit https://review.coreboot.org/c/coreboot/+/81504?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I588028d4327f59538f7c9920b671458fc631cb4c Gerrit-Change-Number: 81504 Gerrit-PatchSet: 2 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: cpu/x86/Kconfig: Mark 64bit support as stable
by Arthur Heymans (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Jérémy Compostella, Martin L Roth, Matt DeVillier, Patrick Rudolph. Hello Angel Pons, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Martin L Roth, Matt DeVillier, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80338?usp=email to look at the new patch set (#18). The following approvals got outdated and were removed: Code-Review+1 by Jérémy Compostella, Code-Review+2 by Martin L Roth, Code-Review+2 by Patrick Rudolph, Verified-1 by build bot (Jenkins) Change subject: cpu/x86/Kconfig: Mark 64bit support as stable ...................................................................... cpu/x86/Kconfig: Mark 64bit support as stable With SMM holding page tables itself, we can consider SMM support stable and safe enough for general use. Also update the respective documentation. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Ifcf0a1a5097a2d7c064bb709ec0b09ebee13a47d --- M Documentation/arch/x86/index.md M configs/config.emulation_qemu_x86_i440fx_x86_64 M configs/config.foxconn_g41m M configs/config.google_vilboz.x86_64 M configs/config.hp_compaq_8200_elite_sff_pc.x86_64 M configs/config.lenovo_t400_vboot_and_debug M configs/config.lenovo_x201_all_debug_option_table_bt_on_wifi M configs/config.prodrive_hermes.x86_64 M src/arch/x86/Kconfig M src/cpu/intel/model_2065x/Kconfig M src/cpu/intel/model_206ax/Kconfig M src/cpu/qemu-x86/Kconfig M src/northbridge/intel/gm45/Kconfig M src/northbridge/intel/x4x/Kconfig M src/soc/amd/genoa_poc/Kconfig M src/soc/amd/picasso/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/xeon_sp/spr/Kconfig 18 files changed, 25 insertions(+), 34 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/80338/18 -- To view, visit https://review.coreboot.org/c/coreboot/+/80338?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifcf0a1a5097a2d7c064bb709ec0b09ebee13a47d Gerrit-Change-Number: 80338 Gerrit-PatchSet: 18 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/beltino: Set initial fan PWM to 30%
by Matt DeVillier (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Varshit Pandya. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81513?usp=email ) Change subject: mb/google/beltino: Set initial fan PWM to 30% ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Also it would be good to mention the patch which changes the ITE 8772F SIO code. I did, in the first line of the commit msg body. Using CB:XXX references is generally frowned upon, and there's no commit hash yet since it's not merged so I can't use the standard format. I can amend the commit msg after the 8772F common code patch is merged if you'd like -- To view, visit https://review.coreboot.org/c/coreboot/+/81513?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0177235d73e051f02b5333cf1d735556382b919f Gerrit-Change-Number: 81513 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 13:38:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/non_car/memlayout_x86.ld: Top align the code
by Arthur Heymans (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier. Hello Felix Held, Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81433?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/amd/non_car/memlayout_x86.ld: Top align the code ...................................................................... soc/amd/non_car/memlayout_x86.ld: Top align the code This does the following: - Top align the bootblock so that the only the memory needed gets used. This might slightly reduce the time the PSP needs to decompress the bootblock in memory - Use a memory directive to assert that the 16bit code is inside the top 64K segment - Use the program counter less. While the BDF linker is happy about running the program counter backwards, LLD is not. There is no downside to this. - Use a symbol rather that the program counter for sections. LLD gets confused when (.) is used along with '<': it places the section at the start of the memory region, rather than at the program counter. Using a variable name works around this. - Use a 'last_byte' section to make sure the first instruction is at 0xfff0. Both the BDF and the LLD linkers seems to work well with this code TEST: Both BFD and LLD are able to link the bootblock Change-Id: I18bdf262f9c358aa01795b11efcb863686edc79c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld 1 file changed, 22 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/81433/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81433?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I18bdf262f9c358aa01795b11efcb863686edc79c Gerrit-Change-Number: 81433 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: soc/amd/non_car/memlayout_x86.ld: Top align the code
by Arthur Heymans (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81433?usp=email ) Change subject: soc/amd/non_car/memlayout_x86.ld: Top align the code ...................................................................... Patch Set 1: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81433/comment/7bf0ae67_32c03e22 : PS1, Line 26: bootlbock > bootblock Done File src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld: https://review.coreboot.org/c/coreboot/+/81433/comment/72399355_ea2680be : PS1, Line 128: 64K > I thought the whole point of this was that we didn't know the length, and it could be up to 128K with the next patch. I'm probably overlooking something, but this confuses me. So this section is about the code that is run in 16bit mode. It all needs to reside in that 64K segment in which the reset vector at IP 0xfff0 is. All the other 32/64bit code does not have this restriction. I'll add a comment to clarify. https://review.coreboot.org/c/coreboot/+/81433/comment/8c854f57_f8b748e5 : PS1, Line 132: /* Trigger an error if I have an unusable start address */ > We got rid of the assert, so remove this comment? Done https://review.coreboot.org/c/coreboot/+/81433/comment/44ea3daa_85176715 : PS1, Line 135: . = ALIGN(4096); > do we want a `. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81433?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I18bdf262f9c358aa01795b11efcb863686edc79c Gerrit-Change-Number: 81433 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 13:28:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: lib/spd_bin: Add LPDDR5X dram_type in use_ddr4_params
by Subrata Banik (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Ashish Kumar Mishra, Paul Menzel, Varshit Pandya. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81437?usp=email ) Change subject: lib/spd_bin: Add LPDDR5X dram_type in use_ddr4_params ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81437/comment/04f9f912_6a83be06 : PS4, Line 16: Bug > "BUG" instead of "bug" see, i said the same but it got overlooked. https://review.coreboot.org/c/coreboot/+/81437/comment/8a1c2857_494d33be/ thanks Varshit for raising again. Please avoid marking the comments unless it has been done. -- To view, visit https://review.coreboot.org/c/coreboot/+/81437?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id78ef90c0dc2e869c1f0424674b982ba64ba3939 Gerrit-Change-Number: 81437 Gerrit-PatchSet: 4 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 27 Mar 2024 12:55:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/samsung/stumpy: Set initial fan PWM to 30%
by Varshit Pandya (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Matt DeVillier. Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81514?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: mb/samsung/stumpy: Set initial fan PWM to 30% ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: just noticed some of the patches related to ITE 8772F are still open, I guess we should wait to merge these patches till then ? Also it would be good to mention the patch which changes the ITE 8772F SIO code. -- To view, visit https://review.coreboot.org/c/coreboot/+/81514?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I287e46202ee1c112d1da63c0d8b7889958e3807e Gerrit-Change-Number: 81514 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 12:54:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/beltino: Set initial fan PWM to 30%
by Varshit Pandya (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Matt DeVillier. Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81513?usp=email ) Change subject: mb/google/beltino: Set initial fan PWM to 30% ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: just noticed some of the patches related to ITE 8772F are still open, I guess we should wait to merge these patches till then ? Also it would be good to mention the patch which changes the ITE 8772F SIO code. -- To view, visit https://review.coreboot.org/c/coreboot/+/81513?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0177235d73e051f02b5333cf1d735556382b919f Gerrit-Change-Number: 81513 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 12:54:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/beltino: Set initial fan PWM to 30%
by Varshit Pandya (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Matt DeVillier. Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81513?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: mb/google/beltino: Set initial fan PWM to 30% ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81513?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0177235d73e051f02b5333cf1d735556382b919f Gerrit-Change-Number: 81513 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 12:53:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/beltino: Set initial fan PWM to 30%
by Varshit Pandya (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Matt DeVillier. Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81513?usp=email ) Change subject: mb/google/beltino: Set initial fan PWM to 30% ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81513?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0177235d73e051f02b5333cf1d735556382b919f Gerrit-Change-Number: 81513 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 12:52:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024