coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: soc/intel/cmn/cse: Deprecate CONFIG_SOC_INTEL_CSE_RW_VERSION
by Subrata Banik (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Werner Zeh. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80924?usp=email ) Change subject: soc/intel/cmn/cse: Deprecate CONFIG_SOC_INTEL_CSE_RW_VERSION ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/common/block/cse/Kconfig: https://review.coreboot.org/c/coreboot/+/80924/comment/1acb1c25_36d9fac4 : PS1, Line 236: enabling automatic detection > OK, then it is more about not specifying the CSE version at all in which case the automatic version discovery will take place, right? Maybe you can rephrase then a bit, e.g.: > > "This config may be deprecated in the future. Consider not providing a version here and let the CSE version be automatically queried from the CSE binary at build time (available with Meteor Lake and following platforms)." > > But it is up to you to decide, hence I will mark this as resolved. thanks for the suggestion, i have updated the help text now. -- To view, visit https://review.coreboot.org/c/coreboot/+/80924?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c3e5c759e4d9a43c3bce3a0c032086f17592a67 Gerrit-Change-Number: 80924 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 04 Mar 2024 18:18:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/cmn/cse: Deprecate CONFIG_SOC_INTEL_CSE_RW_VERSION
by Werner Zeh (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Subrata Banik. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80924?usp=email ) Change subject: soc/intel/cmn/cse: Deprecate CONFIG_SOC_INTEL_CSE_RW_VERSION ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/common/block/cse/Kconfig: https://review.coreboot.org/c/coreboot/+/80924/comment/ab0ac574_359d5548 : PS1, Line 236: enabling automatic detection > > > Is there an option which lets the user to enable it explicitly or is it available implicit with […] OK, then it is more about not specifying the CSE version at all in which case the automatic version discovery will take place, right? Maybe you can rephrase then a bit, e.g.: "This config may be deprecated in the future. Consider not providing a version here and let the CSE version be automatically queried from the CSE binary at build time (available with Meteor Lake and following platforms)." But it is up to you to decide, hence I will mark this as resolved. -- To view, visit https://review.coreboot.org/c/coreboot/+/80924?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c3e5c759e4d9a43c3bce3a0c032086f17592a67 Gerrit-Change-Number: 80924 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 04 Mar 2024 18:13:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Enable Wake on WLAN for SKU1
by Ashish Kumar Mishra (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Ashish Kumar Mishra, Shelley Chen, Subrata Banik. Ashish Kumar Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80780?usp=email ) Change subject: mb/google/brox: Enable Wake on WLAN for SKU1 ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brox/variants/brox/overridetree.cb: https://review.coreboot.org/c/coreboot/+/80780/comment/2907987b_beed8dae : PS1, Line 273: chip drivers/wifi/generic : register "wake" = "GPE0_DW0_03" : register "add_acpi_dma_property" = "true" : device pci 00.0 on : probe WIFI_BT WIFI_BT_PCIE : end : end > Out of curiosity, are these wake knobs not available for the rtd3 wifi driver? I would think that y […] There's no wake knob in rtd3. Hence added this. -- To view, visit https://review.coreboot.org/c/coreboot/+/80780?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I04c35da2c9ac57cafdf7f7a35d83ab2e7a05fe4a Gerrit-Change-Number: 80780 Gerrit-PatchSet: 1 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Mon, 04 Mar 2024 18:11:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: foo
by Felix Singer (Code Review) 04 Mar '24

04 Mar '24

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81073?usp=email ) Change subject: foo ...................................................................... foo Change-Id: I945b380934e5a9f993cc9adbd7e1764fc12d5212 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M README.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/81073/1 diff --git a/README.md b/README.md index 677d62d..be53ea0 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -coreboot README +ffcoreboot README =============== coreboot is a Free Software project aimed at replacing the proprietary -- To view, visit https://review.coreboot.org/c/coreboot/+/81073?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I945b380934e5a9f993cc9adbd7e1764fc12d5212 Gerrit-Change-Number: 81073 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: mb/emulation/qemu-riscv: Change to -bios option
by ron minnich (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Arthur Heymans, Maximilian Brune, Patrick Rudolph, Philipp Hug. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80746?usp=email ) Change subject: mb/emulation/qemu-riscv: Change to -bios option ...................................................................... Patch Set 8: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80746/comment/a98eeaf1_a9385353 : PS6, Line 9: bios > -bios is quite old as far as I know. pflash is I think more recent (not sure since when). […] -bios has been supported for at least 10 years, or more. -- To view, visit https://review.coreboot.org/c/coreboot/+/80746?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I009d97fa3e13068b91c604e987e50a65e525407d Gerrit-Change-Number: 80746 Gerrit-PatchSet: 8 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 04 Mar 2024 18:09:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/genoa_poc: Fix DEBUG_SMI compilation error
by Marvin Drees (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Arthur Heymans, Benjamin Doron, Lean Sheng Tan. Marvin Drees has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81072?usp=email ) Change subject: soc/amd/genoa_poc: Fix DEBUG_SMI compilation error ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If7c6f2346d5f9ffb371d51d1de6f0b695acedf10 Gerrit-Change-Number: 81072 Gerrit-PatchSet: 1 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Mon, 04 Mar 2024 18:05:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Enable Wake on WLAN for SKU1
by Shelley Chen (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Ashish Kumar Mishra, Subrata Banik. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80780?usp=email ) Change subject: mb/google/brox: Enable Wake on WLAN for SKU1 ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brox/variants/brox/overridetree.cb: https://review.coreboot.org/c/coreboot/+/80780/comment/af1730e6_c0a37f5d : PS1, Line 273: chip drivers/wifi/generic : register "wake" = "GPE0_DW0_03" : register "add_acpi_dma_property" = "true" : device pci 00.0 on : probe WIFI_BT WIFI_BT_PCIE : end : end Out of curiosity, are these wake knobs not available for the rtd3 wifi driver? I would think that you would just add the wake gpio into there instead of using this second generic wifi driver. -- To view, visit https://review.coreboot.org/c/coreboot/+/80780?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I04c35da2c9ac57cafdf7f7a35d83ab2e7a05fe4a Gerrit-Change-Number: 80780 Gerrit-PatchSet: 1 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Mon, 04 Mar 2024 17:23:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/emulation/qemu-riscv: Change to -bios option
by Maximilian Brune (Code Review) 04 Mar '24

04 Mar '24

1 0

[M] Change in coreboot[main]: mb/emulation/qemu-riscv: Change to -bios option
by Maximilian Brune (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Philipp Hug, ron minnich. Hello Arthur Heymans, Philipp Hug, build bot (Jenkins), ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80746?usp=email to look at the new patch set (#8). Change subject: mb/emulation/qemu-riscv: Change to -bios option ...................................................................... mb/emulation/qemu-riscv: Change to -bios option This changes the virt target so that it can be run with the -bios option and a pflash backend for the flash. QEMU can now be run as follows: qemu -M virt -m 1G -nographic -bios build/coreboot.rom \ -drive if=pflash,file=./build/coreboot.rom,format=raw coreboot will start in DRAM, but still have a flash to put CBFS onto and to load subsequent stages and payload from. Tested bootflow: coreboot -> OpenSBI -> Linux -> u-root Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I009d97fa3e13068b91c604e987e50a65e525407d --- M Documentation/mainboard/emulation/qemu-riscv.md M src/mainboard/emulation/Kconfig M src/mainboard/emulation/qemu-riscv/Kconfig M src/mainboard/emulation/qemu-riscv/Makefile.mk A src/mainboard/emulation/qemu-riscv/cbmem.c A src/mainboard/emulation/qemu-riscv/chip.c M src/mainboard/emulation/qemu-riscv/devicetree.cb M src/mainboard/emulation/qemu-riscv/include/mainboard/addressmap.h M src/mainboard/emulation/qemu-riscv/mainboard.c M src/mainboard/emulation/qemu-riscv/memlayout.ld M src/mainboard/emulation/qemu-riscv/rom_media.c M src/mainboard/emulation/qemu-riscv/romstage.c M util/qemu/Makefile.mk 13 files changed, 98 insertions(+), 55 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/80746/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/80746?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I009d97fa3e13068b91c604e987e50a65e525407d Gerrit-Change-Number: 80746 Gerrit-PatchSet: 8 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: mb/emulation/qemu-riscv: Change to -bios option
by Maximilian Brune (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Philipp Hug, ron minnich. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80746?usp=email ) Change subject: mb/emulation/qemu-riscv: Change to -bios option ...................................................................... Patch Set 7: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/80746/comment/8d9c24fc_7e0ff9e5 : PS6, Line 9: bios > Since which version is -bios supported in qemu? […] -bios is quite old as far as I know. pflash is I think more recent (not sure since when). QEMU virt target on RISC-V has changed to much in order to be much backwards compatible. I tested this with QEMU version 8.2.1 (2023). I don't have access to old QEMU versions, but I also tested with a QEMU commit from 2021 (3cbc17ee92479ff5) and compiling QEMU myself. The bootflow works there also. File src/mainboard/emulation/qemu-riscv/Makefile.mk: https://review.coreboot.org/c/coreboot/+/80746/comment/8e203be2_642e6c3f : PS6, Line 7: bootblock-y += cbmem.c > no need to move them to bootblock-y, those can stay romstage-y, to allow both with and without separ […] I personally don't care much if we want to support both, but I guess for an emulation target we want to cover all bootflows. I will make the changes to support both. File src/mainboard/emulation/qemu-riscv/memlayout.ld: https://review.coreboot.org/c/coreboot/+/80746/comment/74cc96be_e69a5cec : PS6, Line 20: #if ENV_SEPARATE_ROMSTAGE > romstage can be placed at same place as opensbi to keep separate romstage support I will put it below and leave out the if conditions entirely. RISC-V and ARM memlayout.ld files are also meant as documentation and putting unnecessary ifdef everywhere ist just confusing. See also: https://review.coreboot.org/c/coreboot/+/77974 File src/mainboard/emulation/qemu-riscv/romstage.c: https://review.coreboot.org/c/coreboot/+/80746/comment/b443e92d_a5f9ebc8 : PS6, Line 9: console_init(); > add main to allow both with and without separate romstage: […] Done File util/qemu/Makefile.mk: https://review.coreboot.org/c/coreboot/+/80746/comment/234e6777_bd1a9893 : PS6, Line 32: QEMU-$(CONFIG_BOARD_EMULATION_QEMU_RISCV_RV64) ?= qemu-system-riscv64 -M virt -drive \ > maybe add -m 1G as well here, as the default memory size is really low on riscv Done Although maybe something smaller. 512M? It still boots with 128M to Linux and u-root. -- To view, visit https://review.coreboot.org/c/coreboot/+/80746?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I009d97fa3e13068b91c604e987e50a65e525407d Gerrit-Change-Number: 80746 Gerrit-PatchSet: 7 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 04 Mar 2024 17:18:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Philipp Hug <philipp(a)hug.cx> Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024