Attention is currently required from: Felix Held, Felix Singer, Jason Nien, Martin Roth, Matt DeVillier.
Jason Nein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80237?usp=email )
Change subject: mb/google/guybrush: turn off SD ASPM L1.1/L1.2
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80237/comment/36a9e584_2016204d :
PS1, Line 9: turn off SD ASPM L1.1/L1.2 as w/a for wlan DMA resume failure
> Are there any guesses as to why the SD PCIe bus is able to affect the WLAN DMA? How are the two buss […]
We checked the schematics and we don't see why it affects. We are still digging it further and will update the bug once we have further update.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80237?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4d903f0f6333ffa18069e42be3c932aeae8013d9
Gerrit-Change-Number: 80237
Gerrit-PatchSet: 7
Gerrit-Owner: Jason Nein <finaljason(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 22:44:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com>
Gerrit-MessageType: comment
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78644?usp=email )
Change subject: payloads/LinuxBoot: Build the linux kernel with -j $(CPUS)
......................................................................
payloads/LinuxBoot: Build the linux kernel with -j $(CPUS)
Build the Linux kernel with the same amount of jobs as coreboot.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: Ie7af5aef4560b8d4dd840d9c578f8a2a4c387400
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78644
Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Reviewed-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
---
M payloads/external/LinuxBoot/targets/linux.mk
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Felix Singer: Looks good to me, approved
Maximilian Brune: Looks good to me, approved
Patrick Rudolph: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/payloads/external/LinuxBoot/targets/linux.mk b/payloads/external/LinuxBoot/targets/linux.mk
index 01da40c..1a882f1 100644
--- a/payloads/external/LinuxBoot/targets/linux.mk
+++ b/payloads/external/LinuxBoot/targets/linux.mk
@@ -45,8 +45,8 @@
$(kernel_dir)/vmlinux : $(kernel_dir)/.config | $(kernel_dir)
@echo " MAKE Linux $(kernel_version)"
- echo "$(MAKE) -j 4 -C $(kernel_dir) $(KERNEL_MAKE_FLAGS) vmlinux"
- $(MAKE) -j 4 -C $(kernel_dir) $(KERNEL_MAKE_FLAGS) vmlinux
+ echo "$(MAKE) -j $(CPUS) -C $(kernel_dir) $(KERNEL_MAKE_FLAGS) vmlinux"
+ $(MAKE) -j $(CPUS) -C $(kernel_dir) $(KERNEL_MAKE_FLAGS) vmlinux
build/vmlinux.bin: $(kernel_dir)/vmlinux | build
$(OBJCOPY) -O binary $< $@
--
To view, visit https://review.coreboot.org/c/coreboot/+/78644?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7af5aef4560b8d4dd840d9c578f8a2a4c387400
Gerrit-Change-Number: 78644
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Arthur Heymans, Christian Walter, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78644?usp=email )
Change subject: payloads/LinuxBoot: Build the linux kernel with -j $(CPUS)
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78644?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7af5aef4560b8d4dd840d9c578f8a2a4c387400
Gerrit-Change-Number: 78644
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Mon, 04 Mar 2024 22:36:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Alper Nebi Yasak, Arthur Heymans, Christian Walter, Maximilian Brune, Nico Huber, Philipp Hug.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68843?usp=email )
Change subject: mb/emulation/riscv: Limit DRAM size
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68843?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib8555de361d1129d3d1995f056518c576f055515
Gerrit-Change-Number: 68843
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-CC: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Mon, 04 Mar 2024 22:16:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
ron minnich has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68842?usp=email )
Change subject: lib/ramdetect: Limit probe size to function argument
......................................................................
lib/ramdetect: Limit probe size to function argument
This avoids probing above the function argument where other things than
DRAM could be mapped.
Change-Id: Ie7f915c6e150629eff235ee94719172467a54db2
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68842
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: ron minnich <rminnich(a)gmail.com>
Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M src/lib/ramdetect.c
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Maximilian Brune: Looks good to me, approved
build bot (Jenkins): Verified
ron minnich: Looks good to me, approved
diff --git a/src/lib/ramdetect.c b/src/lib/ramdetect.c
index cfec029..9a29d0f 100644
--- a/src/lib/ramdetect.c
+++ b/src/lib/ramdetect.c
@@ -57,9 +57,12 @@
msb = MIN(msb, MAX_ADDRESSABLE_SPACE);
/* Compact binary search. */
- for (i = msb; i >= 0; i--)
+ for (i = msb; i >= 0; i--) {
+ if ((discovered | (1ULL << i)) > probe_size)
+ continue;
if (probe_mb(dram_start, (discovered | (1ULL << i))))
discovered |= (1ULL << i);
+ }
saved_result = discovered;
printk(BIOS_DEBUG, "RAMDETECT: Found %zu MiB RAM\n", discovered);
--
To view, visit https://review.coreboot.org/c/coreboot/+/68842?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7f915c6e150629eff235ee94719172467a54db2
Gerrit-Change-Number: 68842
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: merged
Attention is currently required from: Cliff Huang, Hannah Williams, Martin L Roth, Subrata Banik.
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80726?usp=email )
Change subject: payloads/depthcharge: Add DEPTHCHARGE_REPO and DEPTHCHARGE_BRANCH
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80726?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icca10aa770b7b7a6e010f58bcf1e4f0a3401681a
Gerrit-Change-Number: 80726
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Mon, 04 Mar 2024 21:56:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Michał Żygowski, Subrata Banik.
Marek Maślanka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79909?usp=email )
Change subject: soc/intel/common/block: Add support for watchdog
......................................................................
Patch Set 15:
(5 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/79909/comment/a8c4c59c_803389e1 :
PS13, Line 396: rightmost_bit_offset
> > The only thing that comes to mind to make the name more descriptive is to change it to `find_right […]
thanks, the `__builtin_ctzll` is doing what I needed.
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/79909/comment/a6e5abe4_4be5071f :
PS14, Line 408: tcobase
> are we okay to go forward if tcobase is not even programmed ? like zero ?
`tcobase != 0` is already checked earlier in the caller function
https://review.coreboot.org/c/coreboot/+/79909/comment/585cda93_c59fbecb :
PS14, Line 430: 0x01
> can we have a macro ?
Done
https://review.coreboot.org/c/coreboot/+/79909/comment/241866f3_4713bafc :
PS14, Line 469: acpi_soc_fill_wdat
> do u have a caller of this function implemented already ?
yes, it's called from acpi_create_wdat (src/acpi/acpi.c) if CONFIG_ACPI_WDAT_WDT is enabled
https://review.coreboot.org/c/coreboot/+/79909/comment/fbb6ddf8_61d0fc8a :
PS14, Line 487: if (tcobase == 0) {
: wdat->flags = ACPI_WDAT_FLAG_DISABLED;
: return current;
: }
> shouldn't we return this at line 474?
right, just filling the flags to ACPI_WDAT_FLAG_DISABLED is enough
--
To view, visit https://review.coreboot.org/c/coreboot/+/79909?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf7971f8407920a553fd91d2ed04193c882e08f1
Gerrit-Change-Number: 79909
Gerrit-PatchSet: 15
Gerrit-Owner: Marek Maślanka <mmaslanka(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Comment-Date: Mon, 04 Mar 2024 19:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marek Maślanka <mmaslanka(a)google.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Marek Maślanka, Michał Żygowski.
Hello Jakub Czapiga, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79909?usp=email
to look at the new patch set (#15).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel/common/block: Add support for watchdog
......................................................................
soc/intel/common/block: Add support for watchdog
Implement watchdog for intel based platform by filling ACPI Watchdog
Action Table (WDAT) table.
The WDAT ACPI table encompasses essential watchdog functions, including:
- Setting and retrieving countdown/timeout values
- Starting and stopping the watchdog
- Pinging the watchdog
- Retrieving the cause of the last reboot, whether it was triggered by
the watchdog or another reason
The general purpose register TCO_MESSAGE1 stores the reason for the most
recent reboot rather than the original register TCO2_STS. This is
because the firmware must clear TCO2_STS, and it can't be reused for
storing this information for the operating system.
The watchdog is designed for use by the OS through certain defined
actions in the WDAT table. It relies on the ACPI Power Management Timer,
which may result in an increase in power consumption.
BUG=b:314260167
TEST=Enable CONFIG_ACPI_WDAT_WDT and CONFIG_USE_PM_ACPI_TIMER in the
config. Enable CONFIG_WDAT_WDT in the kernel config. Build and deploy
both firmware and kernel to the device. Trigger the watchdog by
performing the command: “cat > /dev/watchdog”. Wait approximately 30
seconds for the watchdog to reset the device.
Change-Id: Iaf7971f8407920a553fd91d2ed04193c882e08f1
Signed-off-by: Marek Maslanka <mmaslanka(a)google.com>
---
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/common/block/include/intelblocks/tco.h
M src/soc/intel/common/block/smbus/tco.c
3 files changed, 161 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/79909/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/79909?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf7971f8407920a553fd91d2ed04193c882e08f1
Gerrit-Change-Number: 79909
Gerrit-PatchSet: 15
Gerrit-Owner: Marek Maślanka <mmaslanka(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Marek Maślanka <mmaslanka(a)google.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Maximilian Brune, ron minnich.
Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81031?usp=email )
Change subject: SiFive Unmatched: add support for spi1 x4 mode
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81031/comment/aec80d60_5899445f :
PS2, Line 7: SiFive Unmatched: add support for spi1 x4 mode
use mb/sifive/sifive-unmatched: prefix?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81031?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ida7f195eb6e4fc85018ceb83cf317595127c4af5
Gerrit-Change-Number: 81031
Gerrit-PatchSet: 2
Gerrit-Owner: ron minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Mon, 04 Mar 2024 18:54:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment