coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Initialize CPUs only when FSP-S has completed
by Subrata Banik (Code Review) 05 Mar '24

05 Mar '24

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Initialize CPUs only when FSP-S has completed
by Jérémy Compostella (Code Review) 05 Mar '24

05 Mar '24

Attention is currently required from: Andrey Petrov, Ronak Kanabar, Shuo Liu, Subrata Banik. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80691?usp=email ) Change subject: drivers/intel/fsp2_0: Initialize CPUs only when FSP-S has completed ...................................................................... Patch Set 3: (1 comment) File src/drivers/intel/fsp2_0/silicon_init.c: https://review.coreboot.org/c/coreboot/+/80691/comment/6ab48492_88b33ebd : PS3, Line 204: USE_INTEL_FSP_MP_INIT > side question: what is the motivation of not using coreboot using MP init and using `USE_INTEL_FSP_M […] Since this option exist, the idea of this patch is to keep working for new platforms. I indeed noticed that no configuration are using it. if we think this options does not make sense, shouldn't we just remove it altogether ? -- To view, visit https://review.coreboot.org/c/coreboot/+/80691?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec92 Gerrit-Change-Number: 80691 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Tue, 05 Mar 2024 04:19:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: src/acpi: Increase ACPI revision from 6.0 to 6.4
by minyu li (Code Review) 05 Mar '24

05 Mar '24

Attention is currently required from: Cliff Huang, Felix Singer, Lance Zhao, Tim Wawrzynczak, minyu li. Hello Cliff Huang, Lance Zhao, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80781?usp=email to look at the new patch set (#2). Change subject: src/acpi: Increase ACPI revision from 6.0 to 6.4 ...................................................................... src/acpi: Increase ACPI revision from 6.0 to 6.4 Increase ACPI revision from 6.0 to 6.4 Change-Id: I77b978f07b296e55e67d4de5e981bd48fd28eb03 Signed-off-by: minyu li <li.minyu(a)h3c.com> --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/80781/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80781?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77b978f07b296e55e67d4de5e981bd48fd28eb03 Gerrit-Change-Number: 80781 Gerrit-PatchSet: 2 Gerrit-Owner: minyu li <li.minyu(a)h3c.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: minyu li <li.minyu(a)h3c.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/glassway: Tune eMMC DLL values
by Daniel Peng (Code Review) 05 Mar '24

05 Mar '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Shawn Ku, Simon Yang, Subrata Banik. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80779?usp=email ) Change subject: mb/google/nissa/var/glassway: Tune eMMC DLL values ...................................................................... Patch Set 3: (1 comment) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/80779/comment/b2667505_a6a36dd5 : PS2, Line 9: Update eMMC DLL values to improve initialization reliability. > How was the tuning done? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80779?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ice9ee217acf7dc6e3e704bc82529e0b9a8faf184 Gerrit-Change-Number: 80779 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Comment-Date: Tue, 05 Mar 2024 03:42:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/vpd: Add vpd_get_feature_level() API
by Subrata Banik (Code Review) 05 Mar '24

05 Mar '24

Attention is currently required from: Eric Lai, Gwendal Grignou, Nick Vaccaro, Shelley Chen. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80805?usp=email ) Change subject: drivers/vpd: Add vpd_get_feature_level() API ...................................................................... Patch Set 2: (1 comment) File src/drivers/vpd/vpd_device_feature.c: https://review.coreboot.org/c/coreboot/+/80805/comment/fa7a2240_103665f6 : PS2, Line 21: VPD_RW > > interesting, shouldn't this be in the RO? > > we have kept CBX feature as part of the RW VPD so, it can be field updatable (if required) marked closed based on offline discussion -- To view, visit https://review.coreboot.org/c/coreboot/+/80805?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I76fc220ed792abdfefb0b1a37873b5b828bfdda8 Gerrit-Change-Number: 80805 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Comment-Date: Tue, 05 Mar 2024 03:35:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/vpd: Add vpd_get_feature_level() API
by Subrata Banik (Code Review) 05 Mar '24

05 Mar '24

Attention is currently required from: Eric Lai, Gwendal Grignou, Nick Vaccaro, Shelley Chen. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80805?usp=email ) Change subject: drivers/vpd: Add vpd_get_feature_level() API ...................................................................... Patch Set 2: (1 comment) File src/drivers/vpd/vpd_device_feature.c: https://review.coreboot.org/c/coreboot/+/80805/comment/f15e5024_9bac19c6 : PS2, Line 21: VPD_RW > interesting, shouldn't this be in the RO? we have kept CBX feature as part of the RW VPD so, it can be field updatable (if required) -- To view, visit https://review.coreboot.org/c/coreboot/+/80805?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I76fc220ed792abdfefb0b1a37873b5b828bfdda8 Gerrit-Change-Number: 80805 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Comment-Date: Tue, 05 Mar 2024 03:26:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Initialize CPUs only when FSP-S has completed
by Subrata Banik (Code Review) 05 Mar '24

05 Mar '24

Attention is currently required from: Andrey Petrov, Jérémy Compostella, Ronak Kanabar, Shuo Liu. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80691?usp=email ) Change subject: drivers/intel/fsp2_0: Initialize CPUs only when FSP-S has completed ...................................................................... Patch Set 3: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/80691/comment/7611271c_30f1cfaa : PS3, Line 7: FSP-S i guess you mean to say `Add hooks to perform MP init post FSP-MultiPhase SI Init (if supported)` File src/drivers/intel/fsp2_0/silicon_init.c: https://review.coreboot.org/c/coreboot/+/80691/comment/8281680c_ad80102e : PS3, Line 158: /* Reinitialize CPUs if FSP-S has done MP Init */ : if (CONFIG(USE_INTEL_FSP_MP_INIT)) : do_mpinit_after_fsp(); if the goal is to skip do_mpinit_after_fsp() immediately after FSP-S API and wait till MultiPhaseSiInit then I will say follow the below snippet. ``` /* Reinitialize CPUs if FSP-S has done MP Init and MultiPhaseSiInit is not prsent */ if (CONFIG(USE_INTEL_FSP_MP_INIT) && !fsp_is_multi_phase_init_enabled()) do_mpinit_after_fsp(); ``` Platform which has MultiPhaseSiInit enabled will skip the do_mpinit_after_fsp() here and anyway till come to [line](https://review.coreboot.org/c/coreboot/+/80691/3/src/drivers/intel/fs… post MultiPhaseSiInit has executed https://review.coreboot.org/c/coreboot/+/80691/comment/18dbd9bc_1aa79d26 : PS3, Line 159: goto fsp_init_done; what is the point of calling `do_mpinit_after_fsp` when FSP itself is not compliant with FSP2.2 spec aka technically FSP-MultiPhase SI Init is not even there prior to FSP2.2 spec. Hence, why would we like to do MP Init again ? https://review.coreboot.org/c/coreboot/+/80691/comment/5fdfdcaf_fc13a685 : PS3, Line 163: goto fsp_init_done; same as before, assume FSP Multiphase Si Init itself is not enabled hence, why would we like to do do_mpinit_after_fsp() ? ideally a return is what we need here https://review.coreboot.org/c/coreboot/+/80691/comment/30d97220_a4d61aa3 : PS3, Line 171: oto fsp_init_done; again the same, if multi_phase_si_init itself is not implemented then what is the point of calling do_mpinit_after_fsp() from here. https://review.coreboot.org/c/coreboot/+/80691/comment/c0ea41b6_2e81122d : PS3, Line 204: USE_INTEL_FSP_MP_INIT side question: what is the motivation of not using coreboot using MP init and using `USE_INTEL_FSP_MP_INIT`. This is ideally a wrong direction for every new SOC power-on which i have seen previously during MTL as well. the entire X2APIC issue was a mess back then. I would never test this path as this is not a POR configuration for coreboot users (atleast i don't see any platform even bother to select this kconfig) -- To view, visit https://review.coreboot.org/c/coreboot/+/80691?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec92 Gerrit-Change-Number: 80691 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Tue, 05 Mar 2024 03:24:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Enable Wake on WLAN for SKU1
by Ashish Kumar Mishra (Code Review) 05 Mar '24

05 Mar '24

Attention is currently required from: Ashish Kumar Mishra, Shelley Chen, Subrata Banik. Ashish Kumar Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80780?usp=email ) Change subject: mb/google/brox: Enable Wake on WLAN for SKU1 ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brox/variants/brox/overridetree.cb: https://review.coreboot.org/c/coreboot/+/80780/comment/acd022c0_e432262d : PS1, Line 273: chip drivers/wifi/generic : register "wake" = "GPE0_DW0_03" : register "add_acpi_dma_property" = "true" : device pci 00.0 on : probe WIFI_BT WIFI_BT_PCIE : end : end > Just to clarify, this means that we need to load two drivers in the kernel for the wifi chip? The g […] yes -- To view, visit https://review.coreboot.org/c/coreboot/+/80780?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I04c35da2c9ac57cafdf7f7a35d83ab2e7a05fe4a Gerrit-Change-Number: 80780 Gerrit-PatchSet: 1 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 05 Mar 2024 03:24:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Comment-In-Reply-To: Ashish Kumar Mishra <ashish.k.mishra(a)intel.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/vpd: Add vpd_get_feature_level() API
by Eric Lai (Code Review) 05 Mar '24

05 Mar '24

Attention is currently required from: Gwendal Grignou, Nick Vaccaro, Shelley Chen, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80805?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: drivers/vpd: Add vpd_get_feature_level() API ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/drivers/vpd/vpd_device_feature.c: https://review.coreboot.org/c/coreboot/+/80805/comment/b1235f13_bfd139ba : PS2, Line 21: VPD_RW interesting, shouldn't this be in the RO? -- To view, visit https://review.coreboot.org/c/coreboot/+/80805?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I76fc220ed792abdfefb0b1a37873b5b828bfdda8 Gerrit-Change-Number: 80805 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Comment-Date: Tue, 05 Mar 2024 03:12:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection
by Eric Lai (Code Review) 05 Mar '24

05 Mar '24

Attention is currently required from: Gwendal Grignou, Kapil Porwal, Paul Menzel, Paz Zcharya, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80738?usp=email ) Change subject: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Gerrit-Change-Number: 80738 Gerrit-PatchSet: 12 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Comment-Date: Tue, 05 Mar 2024 03:10:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024