coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[S] Change in coreboot[main]: device/device_util: Use const qualifier
by Shuo Liu (Code Review) 14 Mar '24

14 Mar '24

Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Tim Chu. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81275?usp=email ) Change subject: device/device_util: Use const qualifier ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iac04fe6931a43070f6638b399adbff2ce64829c9 Gerrit-Change-Number: 81275 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 15 Mar 2024 01:21:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: symbols: Add __maybe_unused flag to region variable symbols
by Shuo Liu (Code Review) 14 Mar '24

14 Mar '24

Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81209?usp=email ) Change subject: symbols: Add __maybe_unused flag to region variable symbols ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > Sure, done to add __maybe_unused in all symbols. For the usage of DECLARE_REGION, we prefer to still keep it inside if (CONFIG(FSP_SPEC_VIOLATION_XEON_SP_HEAP_WORKAROUND)) otherwise we need to write another #if (CONFIG(FSP_SPEC_VIOLATION_XEON_SP_HEAP_WORKAROUND)) block to include the definition. Your opinion? -- To view, visit https://review.coreboot.org/c/coreboot/+/81209?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5ed183b2dd7a474ce51de47dbc1f9e3f61e5a41 Gerrit-Change-Number: 81209 Gerrit-PatchSet: 4 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Fri, 15 Mar 2024 01:16:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: symbols: Add __maybe_unused flag to region variable symbols
by Shuo Liu (Code Review) 14 Mar '24

14 Mar '24

Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81209?usp=email ) Change subject: symbols: Add __maybe_unused flag to region variable symbols ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > I mean, I still don't see why you can't just declare it at global scope in the `memory_init.c` file. […] Sure, done to add __maybe_unused in all symbols. -- To view, visit https://review.coreboot.org/c/coreboot/+/81209?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5ed183b2dd7a474ce51de47dbc1f9e3f61e5a41 Gerrit-Change-Number: 81209 Gerrit-PatchSet: 4 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Fri, 15 Mar 2024 01:11:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: symbols: Add __maybe_unused flag to region variable symbols
by Shuo Liu (Code Review) 14 Mar '24

14 Mar '24

Attention is currently required from: Arthur Heymans, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, Shuo Liu. Hello Arthur Heymans, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81209?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Jérémy Compostella, Verified+1 by build bot (Jenkins) Change subject: symbols: Add __maybe_unused flag to region variable symbols ...................................................................... symbols: Add __maybe_unused flag to region variable symbols In DECLARE_REGION and DECLARE_OPTIONAL_REGION, a set of 3 variables will be defined, that is the region 'base', 'end' and 'size'. However, in many codes, the users will only selectively use 'end' or 'size' instead of both of them, which will trigger comipler errors for unused variables. This patch sets __maybe_unused attributes on 'end' and 'size' so that users do not need to use all of them. TEST=intel/archercity CRB Change-Id: Ia5ed183b2dd7a474ce51de47dbc1f9e3f61e5a41 Signed-off-by: Shuo Liu <shuo.liu(a)intel.com> --- M src/include/symbols.h 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/81209/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81209?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5ed183b2dd7a474ce51de47dbc1f9e3f61e5a41 Gerrit-Change-Number: 81209 Gerrit-PatchSet: 3 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: ec/hp/kbc1126/acpi: Drop unnecessary method arguments
by Nicholas Sudsgaard (Code Review) 14 Mar '24

14 Mar '24

Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81205?usp=email ) Change subject: ec/hp/kbc1126/acpi: Drop unnecessary method arguments ...................................................................... Patch Set 6: (1 comment) Patchset: PS3: > I just don't know if everyone is aware of the defaults (e.g. […] I think it would be fair to assume anyone writing ASL would know about the defaults up to `NotSerialized`. The problem would be not a lot of people write ASL. 😄 -- To view, visit https://review.coreboot.org/c/coreboot/+/81205?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic24e004500a7fa2a5a5b38a3f6f0e13e4ce7dfac Gerrit-Change-Number: 81205 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 15 Mar 2024 00:10:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com> Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: payload/external/edk2: Explicitly define the build arch as X64
by Nicholas Sudsgaard (Code Review) 14 Mar '24

14 Mar '24

Attention is currently required from: Arthur Heymans, Arthur Heymans, Benjamin Doron, Martin L Roth, Matt DeVillier, Sean Rhodes. Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80883?usp=email ) Change subject: payload/external/edk2: Explicitly define the build arch as X64 ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/80883?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icd942d0c15a99231d09f9cbdc5eb48333b6aa6e5 Gerrit-Change-Number: 80883 Gerrit-PatchSet: 7 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 14 Mar 2024 23:28:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: lib/device_tree: Add some FDT helper functions
by Maximilian Brune (Code Review) 14 Mar '24

14 Mar '24

Attention is currently required from: Jakub Czapiga, Julius Werner, Martin L Roth. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81081?usp=email ) Change subject: lib/device_tree: Add some FDT helper functions ...................................................................... Patch Set 13: (17 comments) File src/include/device_tree.h: https://review.coreboot.org/c/coreboot/+/81081/comment/347b1794_1463f985 : PS12, Line 206: uintptr_t > Sorry, I just realized that you're using uintptr_t for node offsets everywhere, while all the existi […] Done https://review.coreboot.org/c/coreboot/+/81081/comment/48a5d568_e99923f8 : PS12, Line 207: uint8_t addr_cells, uint8_t size_cells, > Why u8? If anything, these should be u32. Done https://review.coreboot.org/c/coreboot/+/81081/comment/54402f67_b307a3b3 : PS12, Line 208: int n) > Not a big difference but the array size should probably be size_t. Done File src/lib/device_tree.c: https://review.coreboot.org/c/coreboot/+/81081/comment/d26e414c_d30f01b9 : PS6, Line 118: //TODO replace with something more computational > Hmm... okay. You should take out the TODO then. Done File src/lib/device_tree.c: https://review.coreboot.org/c/coreboot/+/81081/comment/d2597837_0dd76965 : PS12, Line 174: fdt_find_node_by_path_rel > I would suggest to just call this `fdt_find_node()`, because it's basically the FDT equivalent of `d […] Done https://review.coreboot.org/c/coreboot/+/81081/comment/370004a8_1ee598ba : PS12, Line 200: if (!strncmp(*path, node_name, path_sub_len)) { > I think you're forgetting to check that node_name isn't longer than the path segment here, you would […] I fixed the `strncmp` to also check the character after the 'subpath'. A slash '/' is not a valid node name character so it shouldn't cause any problems. I could also write it like this: ``` if (!strncmp(*path, node_name, path_sub_len) && strlen(node_name) == path_sub_len) ``` I can't use strdup, because I can't use malloc/heap. Putting it in an array would make complicated use of the stack if we can't use the heap. https://review.coreboot.org/c/coreboot/+/81081/comment/6a1c997a_ece9919f : PS12, Line 214: ince address-cells and size-cells are not inherited > That's not my understanding and not how the unflattened DT functions are implemented. […] I think I will investigate a bit on how other projects handle that. I didn't get the impression though, that it is known good to treat these properties as inheritable. https://review.coreboot.org/c/coreboot/+/81081/comment/73374e5f_276af485 : PS12, Line 234: (offset - size) > I think it would be cleaner to do the temporary offset adjustment in a different variable, rather th […] How would you call the variable? `node_offset` is already taken (but I guess we could just use that one) and I feel like it could look more complicated if I add another variable. https://review.coreboot.org/c/coreboot/+/81081/comment/652ce047_d9c58d9b : PS12, Line 235: } while (be32dec(blob + offset) != FDT_TOKEN_END_NODE); > Can't the whole thing just be a […] Using your approach you cannot distinguish between a faulty FDT and just running to the end of your loop/search. To be fair I currently also not have an error message in place for that. I am not sure if that is important for us though. Maybe useful to know if the FDT is broken somewhere after the header. https://review.coreboot.org/c/coreboot/+/81081/comment/40581a76_7bdc9552 : PS12, Line 280: * > Not all parameters documented. Done https://review.coreboot.org/c/coreboot/+/81081/comment/ca1606bc_190fa703 : PS12, Line 285: uint16_t > Why is this uint16_t? Should probably be size_t. Done https://review.coreboot.org/c/coreboot/+/81081/comment/078bdada_f19faafb : PS12, Line 293: printk(BIOS_ERR, "%s: prefix must not start with a /\n", __func__); > I'm not sure there's a point in checking this, I mean if people are going to call this with garbage […] Done https://review.coreboot.org/c/coreboot/+/81081/comment/3dd85b5e_04be0f5d : PS12, Line 297: printk(BIOS_ERR, "%s: prefix must not be empty/\n", __func__); > Why not? That would be a convenient way to get all subnodes. Sure but I am not sure how obvious it is. I will just add it to the description of the function. https://review.coreboot.org/c/coreboot/+/81081/comment/c9d01454_b3c0919e : PS12, Line 305: if(!size) { > This shouldn't be possible (right?), so it should be an assert or at least print an error. I think an assert is a bit radical in this context. Could be a faulty FDT or whatever. But you can potentially still ignore it for a successful boot up. But the error message is important. https://review.coreboot.org/c/coreboot/+/81081/comment/d38cf98e_d10b1e55 : PS12, Line 323: offset += size; > Since you need this twice it would probably be good to factor it out into a separate function (maybe […] Done https://review.coreboot.org/c/coreboot/+/81081/comment/78146373_a2b3f370 : PS12, Line 337: results[(*count_results)++] = offset; > Don't you need some part that tells you how big the original results array that got passed in was, s […] Done I now check for it and print a warning. Not sure if we want to treat that as error? Maybe someone wants to just get the first 3 (or something) nodes with a given prefix? https://review.coreboot.org/c/coreboot/+/81081/comment/7f98ed5a_9770669c : PS12, Line 348: return results[*count_results - 1]; > This is odd, why return exactly that one? Maybe we should just return the count instead? At some point I thought it was useful, but I think that was a few patchsets ago. Replaced it by returning the count now. -- To view, visit https://review.coreboot.org/c/coreboot/+/81081?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2fb1d93c5b3e1cb2f7d9584db52bbce3767b63d8 Gerrit-Change-Number: 81081 Gerrit-PatchSet: 13 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 14 Mar 2024 22:37:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: lib/device_tree: Add some FDT helper functions
by Maximilian Brune (Code Review) 14 Mar '24

14 Mar '24

Attention is currently required from: Jakub Czapiga, Martin L Roth, Maximilian Brune. Hello Jakub Czapiga, Julius Werner, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81081?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: lib/device_tree: Add some FDT helper functions ...................................................................... lib/device_tree: Add some FDT helper functions This adds some helper functions for FDT, since more and more mainboards seem to need FDT nowadays. For example our QEMU boards need it in order to know how much RAM is available. Also all RISC-V boards in our tree need FDT. This also adds some tests in order to test said functions. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I2fb1d93c5b3e1cb2f7d9584db52bbce3767b63d8 --- M src/include/device_tree.h M src/lib/device_tree.c M tests/lib/Makefile.mk A tests/lib/device_tree-test.c A tests/lib/tegra30-ouya.dtb.xxd A tests/lib/virt.dtb.xxd 6 files changed, 14,247 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/81081/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/81081?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2fb1d93c5b3e1cb2f7d9584db52bbce3767b63d8 Gerrit-Change-Number: 81081 Gerrit-PatchSet: 13 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: device/device_util: Use const qualifier
by Jérémy Compostella (Code Review) 14 Mar '24

14 Mar '24

Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81275?usp=email ) Change subject: device/device_util: Use const qualifier ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iac04fe6931a43070f6638b399adbff2ce64829c9 Gerrit-Change-Number: 81275 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 14 Mar 2024 20:44:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/pc80/tpm: Support Xeon-SP
by Jérémy Compostella (Code Review) 14 Mar '24

14 Mar '24

Attention is currently required from: Christian Walter, Patrick Rudolph, Shuo Liu. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81276?usp=email ) Change subject: drivers/pc80/tpm: Support Xeon-SP ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81276?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6130b937ec81bbde78d2619eb859ecf354fc3854 Gerrit-Change-Number: 81276 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Comment-Date: Thu, 14 Mar 2024 20:42:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024