coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: libpayload: Make GPL commonlib includes available to payloads and tests
by Julius Werner (Code Review) 15 Mar '24

15 Mar '24

Attention is currently required from: Jakub Czapiga, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81287?usp=email ) Change subject: libpayload: Make GPL commonlib includes available to payloads and tests ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81287/comment/8851aeea_ee28d8bf : PS2, Line 11: so that payloads can also call : the functions in them directly. > I know it is unrelated, but it still confuses me why we have `libpayload. […] I think it's just convenience. It's easier than always having to include the same headers for basic functionality everywhere. -- To view, visit https://review.coreboot.org/c/coreboot/+/81287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc3e52ee5c3e51520f7b7d44b483bfcb0e8380f8 Gerrit-Change-Number: 81287 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 15 Mar 2024 23:15:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: libpayload: Make GPL commonlib includes available to payloads and tests
by Maximilian Brune (Code Review) 15 Mar '24

15 Mar '24

Attention is currently required from: Jakub Czapiga, Julius Werner, Yu-Ping Wu. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81287?usp=email ) Change subject: libpayload: Make GPL commonlib includes available to payloads and tests ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81287/comment/f13595c4_ef9425be : PS2, Line 11: so that payloads can also call : the functions in them directly. > I'm not sure I understand the question? This doesn't really have anything to do with `libpayload.h`. […] I know it is unrelated, but it still confuses me why we have `libpayload.h` and thought maybe you could shine some light on it for me. -- To view, visit https://review.coreboot.org/c/coreboot/+/81287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc3e52ee5c3e51520f7b7d44b483bfcb0e8380f8 Gerrit-Change-Number: 81287 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 15 Mar 2024 23:02:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: commonlib: list: Include <stdint.h>
by Maximilian Brune (Code Review) 15 Mar '24

15 Mar '24

Attention is currently required from: Julius Werner, Yu-Ping Wu. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81288?usp=email ) Change subject: commonlib: list: Include <stdint.h> ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56b2a988bb11d40c8761717bcd02a8199c077046 Gerrit-Change-Number: 81288 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 15 Mar 2024 23:00:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: libpayload: Make GPL commonlib includes available to payloads and tests
by Julius Werner (Code Review) 15 Mar '24

15 Mar '24

Attention is currently required from: Jakub Czapiga, Maximilian Brune, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81287?usp=email ) Change subject: libpayload: Make GPL commonlib includes available to payloads and tests ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81287/comment/08c424f6_63913bc2 : PS2, Line 11: so that payloads can also call : the functions in them directly. > I am confused. Under which circumstances are payloads supposed to include `libpayload. […] I'm not sure I understand the question? This doesn't really have anything to do with `libpayload.h`. This just makes it so that payloads can find non-BSD commonlib headers (like `commonlib/list.h`). `libpayload.h` is a catch-all header that auto-includes a lot of things from libpayload, but not everything (e.g. not `commonlib/list.h`). -- To view, visit https://review.coreboot.org/c/coreboot/+/81287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc3e52ee5c3e51520f7b7d44b483bfcb0e8380f8 Gerrit-Change-Number: 81287 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 15 Mar 2024 22:58:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: libpayload: Include commonlib/helpers.h in libpayload.h for GPL builds
by Julius Werner (Code Review) 15 Mar '24

15 Mar '24

Julius Werner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81289?usp=email ) Change subject: libpayload: Include commonlib/helpers.h in libpayload.h for GPL builds ...................................................................... libpayload: Include commonlib/helpers.h in libpayload.h for GPL builds This patch makes the GPL-restricted commonlib helpers available in libpayload when CONFIG_LP_GPL is selected, as a convenience to GPL payloads that use them a lot. Change-Id: I844c6e700c4c0d557f97da94fa3aa2e868edd756 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M payloads/libpayload/include/libpayload.h 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/81289/1 diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index 05164e5..4f25ed5 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -45,9 +45,13 @@ #include <stdbool.h> #include <libpayload-config.h> #include <cbgfx.h> +#if CONFIG(LP_GPL) +#include <commonlib/helpers.h> +#else +#include <commonlib/bsd/helpers.h> +#endif #include <commonlib/bsd/elog.h> #include <commonlib/bsd/fmap_serialized.h> -#include <commonlib/bsd/helpers.h> #include <commonlib/bsd/ipchksum.h> #include <commonlib/bsd/mem_chip_info.h> #include <ctype.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/81289?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I844c6e700c4c0d557f97da94fa3aa2e868edd756 Gerrit-Change-Number: 81289 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: commonlib: list: Include <stdint.h>
by Julius Werner (Code Review) 15 Mar '24

15 Mar '24

Attention is currently required from: Julius Werner, Maximilian Brune, Yu-Ping Wu. Hello Maximilian Brune, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81288?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Maximilian Brune, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: commonlib: list: Include <stdint.h> ...................................................................... commonlib: list: Include <stdint.h> The list macros use uintptr_t, so they need to include the header that declares it. Change-Id: I56b2a988bb11d40c8761717bcd02a8199c077046 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/commonlib/include/commonlib/list.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/81288/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56b2a988bb11d40c8761717bcd02a8199c077046 Gerrit-Change-Number: 81288 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: libpayload: Make GPL commonlib includes available to payloads and tests
by Maximilian Brune (Code Review) 15 Mar '24

15 Mar '24

Attention is currently required from: Jakub Czapiga, Julius Werner, Yu-Ping Wu. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81287?usp=email ) Change subject: libpayload: Make GPL commonlib includes available to payloads and tests ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81287/comment/97893252_295527b2 : PS2, Line 11: so that payloads can also call : the functions in them directly. I am confused. Under which circumstances are payloads supposed to include `libpayload.h` and under which circumstances should they include the specific include files? -- To view, visit https://review.coreboot.org/c/coreboot/+/81287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc3e52ee5c3e51520f7b7d44b483bfcb0e8380f8 Gerrit-Change-Number: 81287 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 15 Mar 2024 22:54:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/lint/lint: Fix shellcheck errors in getopt support for darwin
by Felix Singer (Code Review) 15 Mar '24

15 Mar '24

Attention is currently required from: Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81285?usp=email ) Change subject: util/lint/lint: Fix shellcheck errors in getopt support for darwin ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81285?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icbdc4204f4c07d806e721fa39f96694c4df00e8d Gerrit-Change-Number: 81285 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 15 Mar 2024 22:43:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: commonlib: list: Include <stdint.h>
by Maximilian Brune (Code Review) 15 Mar '24

15 Mar '24

Attention is currently required from: Julius Werner, Yu-Ping Wu. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81288?usp=email ) Change subject: commonlib: list: Include <stdint.h> ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/commonlib/include/commonlib/list.h: https://review.coreboot.org/c/coreboot/+/81288/comment/a7c9c3d3_22ed78e2 : PS1, Line 7: #include <stdint.h> nit: could you keep the ordering by swapping the include statements? -- To view, visit https://review.coreboot.org/c/coreboot/+/81288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56b2a988bb11d40c8761717bcd02a8199c077046 Gerrit-Change-Number: 81288 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 15 Mar 2024 22:42:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: commonlib: list: Include <stdint.h>
by Julius Werner (Code Review) 15 Mar '24

15 Mar '24

Julius Werner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81288?usp=email ) Change subject: commonlib: list: Include <stdint.h> ...................................................................... commonlib: list: Include <stdint.h> The list macros use uintptr_t, so they need to include the header that declares it. Change-Id: I56b2a988bb11d40c8761717bcd02a8199c077046 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/commonlib/include/commonlib/list.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/81288/1 diff --git a/src/commonlib/include/commonlib/list.h b/src/commonlib/include/commonlib/list.h index 6c8a5d2..a9745d9 100644 --- a/src/commonlib/include/commonlib/list.h +++ b/src/commonlib/include/commonlib/list.h @@ -4,6 +4,7 @@ #ifndef __COMMONLIB_LIST_H__ #define __COMMONLIB_LIST_H__ +#include <stdint.h> #include <commonlib/helpers.h> struct list_node { -- To view, visit https://review.coreboot.org/c/coreboot/+/81288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56b2a988bb11d40c8761717bcd02a8199c077046 Gerrit-Change-Number: 81288 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024