Attention is currently required from: Arthur Heymans, Philipp Hug, ron minnich.
Hello Arthur Heymans, Maximilian Brune, Philipp Hug, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81286?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: arch/riscv: add constants for Base Extension
......................................................................
arch/riscv: add constants for Base Extension
Get used to this rate of change, SBI adds one new function a month,
on average, for the last 7 years.
Signed-off-by: Ronald G Minnich <rminnich(a)gmail.com>
Change-Id: Iaad763464678d1921dfefdbee1e39fba2fe5585a
---
M src/arch/riscv/include/sbi.h
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/81286/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaad763464678d1921dfefdbee1e39fba2fe5585a
Gerrit-Change-Number: 81286
Gerrit-PatchSet: 2
Gerrit-Owner: ron minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81263?usp=email )
Change subject: 3rdparty/amd_blobs: update submodule pointer
......................................................................
3rdparty/amd_blobs: update submodule pointer
Update the amd_blobs submodule pointer to now include the following
commit:
picasso: Update PSP fw to version 00.08.14.7B
TEST=Mandolin boots to the Windows 10 desktop and the GPU driver works
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: If1bd0b37bebcdd600465dbd48162792e2c32bfb7
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81263
Reviewed-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Reviewed-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Varshit Pandya <pandyavarshit(a)gmail.com>
---
M 3rdparty/amd_blobs
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Roth: Looks good to me, approved
Matt DeVillier: Looks good to me, approved
Varshit Pandya: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs
index 64cdd7c..ae5fc7d 160000
--- a/3rdparty/amd_blobs
+++ b/3rdparty/amd_blobs
@@ -1 +1 @@
-Subproject commit 64cdd7c8ef199f5d79be14e7972fb7316f41beed
+Subproject commit ae5fc7d27720267ceb2ccf2fbef0ab76b023ea26
--
To view, visit https://review.coreboot.org/c/coreboot/+/81263?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1bd0b37bebcdd600465dbd48162792e2c32bfb7
Gerrit-Change-Number: 81263
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81137?usp=email )
Change subject: amdfwtool: Remove the dissociated combo BIOS table for recovery A/B
......................................................................
amdfwtool: Remove the dissociated combo BIOS table for recovery A/B
For recovery A/B mode, the BIOS tables level 2 are traced by PSP table
instead of ROMSIG. There should not be a dedicated BIOS table, nor a
combo BIOS table.
Change-Id: I8735bd91b32bc9a0e4fc70d293e8d836d5e9c36b
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81137
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M util/amdfwtool/amdfwtool.c
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Felix Held: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index 3e71832..35d6cdf 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -1600,7 +1600,8 @@
adjust_current_pointer(&ctx, 0, 0x1000U);
- bhd_combo_dir = new_combo_dir(&ctx);
+ if (!cb_config.recovery_ab)
+ bhd_combo_dir = new_combo_dir(&ctx);
}
combo_index = 0;
@@ -1723,7 +1724,10 @@
if (!cb_config.use_combo) {
fill_bios_directory_to_efs(amd_romsig, biosdir,
&ctx, &cb_config);
- } else {
+ } else if (bhd_combo_dir != NULL) {
+ /* In recovery A/B mode, there isn't a BHD combo directory.
+ * Instead, the BIOS tables level 2 are linked by PSP tables.
+ */
fill_bios_directory_to_efs(amd_romsig, bhd_combo_dir,
&ctx, &cb_config);
assert_fw_entry(combo_index, MAX_COMBO_ENTRIES, &ctx);
--
To view, visit https://review.coreboot.org/c/coreboot/+/81137?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8735bd91b32bc9a0e4fc70d293e8d836d5e9c36b
Gerrit-Change-Number: 81137
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Bao Zheng, Fred Reitberger, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81137?usp=email )
Change subject: amdfwtool: Remove the dissociated combo BIOS table for recovery A/B
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81137?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8735bd91b32bc9a0e4fc70d293e8d836d5e9c36b
Gerrit-Change-Number: 81137
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Mon, 18 Mar 2024 14:49:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81273?usp=email )
Change subject: soc/intel/xeon_sp: Drop uncore_fill_ssdt
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81273?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib9051d608147f2de228509ff6b13871ca3183979
Gerrit-Change-Number: 81273
Gerrit-PatchSet: 9
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Mon, 18 Mar 2024 14:43:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Paul Menzel, Shuo Liu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81337?usp=email )
Change subject: MAINTAINERS: Update email address of Jonathan for Xeon SP
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81337?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icbf04f347a02670d0bf38e0328fa6b523d6851b5
Gerrit-Change-Number: 81337
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Mon, 18 Mar 2024 14:38:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Shuo Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81337?usp=email )
Change subject: MAINTAINERS: Update email address of Jonathan for Xeon SP
......................................................................
MAINTAINERS: Update email address of Jonathan for Xeon SP
Change-Id: Icbf04f347a02670d0bf38e0328fa6b523d6851b5
Signed-off-by: Shuo Liu <shuo.liu(a)intel.com>
---
M MAINTAINERS
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/81337/1
diff --git a/MAINTAINERS b/MAINTAINERS
index e7375da..49160c1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -938,7 +938,7 @@
F: src/soc/intel/tigerlake/
INTEL Xeon Sacalable Processor Family
-M: Jonathan Zhang <jonzhang(a)fb.com>
+M: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
M: Johnny Lin <Johnny_Lin(a)wiwynn.com>
M: Tim Chu <Tim.Chu(a)quantatw.com>
M: Arthur Heymans <arthur(a)aheymans.xyz>
--
To view, visit https://review.coreboot.org/c/coreboot/+/81337?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icbf04f347a02670d0bf38e0328fa6b523d6851b5
Gerrit-Change-Number: 81337
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-MessageType: newchange
Attention is currently required from: Marshall Dawson, Martin L Roth, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81190?usp=email )
Change subject: vc/amd/opensil: add site-local path for phoenix source
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Since this depends on site-local being present, and no default is set unless we're using genoa, it m […]
i agree with Martin that it would be better to set this in site-local
--
To view, visit https://review.coreboot.org/c/coreboot/+/81190?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibe2dbc2f1ff88d893ecdf32f21f4644d5184b143
Gerrit-Change-Number: 81190
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Comment-Date: Mon, 18 Mar 2024 13:59:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81275?usp=email )
Change subject: device/device_util: Use const qualifier
......................................................................
Patch Set 2:
(2 comments)
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/81275/comment/c3af6be2_dc021069 :
PS2, Line 252: given PCI device
struct device could be anything. Maybe assert that it's a PCI device?
https://review.coreboot.org/c/coreboot/+/81275/comment/912a959b_99326671 :
PS2, Line 253: const
> That because 'dev' is used as iterator, thus the return value also must be const.
> I don't see a problem with this code as all existing callers do not modify the domain device.
> I don't see a use-case why you need to modify the domain device after creation.
Using and returning a local mutable variable could make it such.
I don't know about use-cases where you'd want to modify the domain after creation from a pci device. I suppose someone can modify the function signature in the future if it's necessary?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81275?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac04fe6931a43070f6638b399adbff2ce64829c9
Gerrit-Change-Number: 81275
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Mon, 18 Mar 2024 13:58:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment