coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: vc/amd/vendorcode/stub/mpio: change mpio_engine_type prefix to IFTYPE
by Felix Held (Code Review) 19 Mar '24

19 Mar '24

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81346?usp=email ) Change subject: vc/amd/vendorcode/stub/mpio: change mpio_engine_type prefix to IFTYPE ...................................................................... vc/amd/vendorcode/stub/mpio: change mpio_engine_type prefix to IFTYPE Change the prefix of the elements of the mpio_engine_type enum from ENGINE_ to IFTYPE_. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Suggested-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: If81c5ea01ba147b71b423004a2199b348ffac99a --- M src/vendorcode/amd/opensil/stub/mpio/chip.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/81346/1 diff --git a/src/vendorcode/amd/opensil/stub/mpio/chip.h b/src/vendorcode/amd/opensil/stub/mpio/chip.h index 53d22a0..f2fb5da 100644 --- a/src/vendorcode/amd/opensil/stub/mpio/chip.h +++ b/src/vendorcode/amd/opensil/stub/mpio/chip.h @@ -3,8 +3,8 @@ #include <types.h> enum mpio_engine_type { - ENGINE_PCIE, - ENGINE_SATA, + IFTYPE_PCIE, + IFTYPE_SATA, }; /* Sync with PCIE_HOTPLUG_TYPE */ -- To view, visit https://review.coreboot.org/c/coreboot/+/81346?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If81c5ea01ba147b71b423004a2199b348ffac99a Gerrit-Change-Number: 81346 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: vc/amd/opensil/*/mpio: add IFTYPE_UNUSED mpio_type enum element
by Felix Held (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Arthur Heymans. Hello Arthur Heymans, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81339?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: vc/amd/opensil/*/mpio: add IFTYPE_UNUSED mpio_type enum element ...................................................................... vc/amd/opensil/*/mpio: add IFTYPE_UNUSED mpio_type enum element Add IFTYPE_UNUSED as first element to the mpio_type enum. This allows checking if the type was set in the devicetree, since the default will now be IFTYPE_UNUSED. If the type is set to IFTYPE_UNUSED although the corresponding PCI device function, a warning is printed and the PCI device function is disabled. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I85e2589c021b4f05662369fd551146b6f2fa0ad4 --- M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.h M src/vendorcode/amd/opensil/stub/mpio/chip.h 3 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/81339/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81339?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I85e2589c021b4f05662369fd551146b6f2fa0ad4 Gerrit-Change-Number: 81339 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: vc/amd/opensil/genoa_poc/mpio: add IFTYPE_ prefix to mpio_type values
by Felix Held (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Arthur Heymans, Martin L Roth. Hello Arthur Heymans, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81338?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by Arthur Heymans, Verified+1 by build bot (Jenkins) Change subject: vc/amd/opensil/genoa_poc/mpio: add IFTYPE_ prefix to mpio_type values ...................................................................... vc/amd/opensil/genoa_poc/mpio: add IFTYPE_ prefix to mpio_type values Add an IFTYPE_ prefix to all elements of the mpio_type enum to have more specific names. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I229a3402c36941ee5347e3704fcf8d8a1bbc78a6 --- M src/mainboard/amd/onyx_poc/devicetree.cb M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.h 3 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/81338/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81338?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I229a3402c36941ee5347e3704fcf8d8a1bbc78a6 Gerrit-Change-Number: 81338 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: Makefile: Drop unused variable originalobjs
by Martin L Roth (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Nicholas Chin. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80399?usp=email ) Change subject: Makefile: Drop unused variable originalobjs ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80399?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I011ff2070bc31ab9ddf2536873555d0157f91fce Gerrit-Change-Number: 80399 Gerrit-PatchSet: 5 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 19 Mar 2024 16:47:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Makefile.mk: Include build/dsdt.d at the same time as DEPENDENCIES
by Martin L Roth (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Maximilian Brune, Nicholas Chin. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80383?usp=email ) Change subject: Makefile.mk: Include build/dsdt.d at the same time as DEPENDENCIES ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80383?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8271d1e172395917f2859c8bbfd2041ddc572ca Gerrit-Change-Number: 80383 Gerrit-PatchSet: 8 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 19 Mar 2024 16:46:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: vc/amd/opensil/genoa_poc/mpio: add ENGINE_ prefix to mpio_type values
by Felix Held (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Martin L Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81338?usp=email ) Change subject: vc/amd/opensil/genoa_poc/mpio: add ENGINE_ prefix to mpio_type values ...................................................................... Patch Set 2: (1 comment) File src/vendorcode/amd/opensil/genoa_poc/mpio/chip.h: https://review.coreboot.org/c/coreboot/+/81338/comment/c2e4f686_f4e87ba1 : PS2, Line 20: ENGINE_PCIE > These are getting renamed away from "engine" internally. […] MUX_TYPE doesn't make much sense to me in this context; Matt suggested using IFTYPE_PCIE as prefix which sounds good to me -- To view, visit https://review.coreboot.org/c/coreboot/+/81338?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I229a3402c36941ee5347e3704fcf8d8a1bbc78a6 Gerrit-Change-Number: 81338 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Tue, 19 Mar 2024 16:24:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brox: support ISH
by Yuval Peress (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Ashish Kumar Mishra, Ashish Kumar Mishra, Bernardo Perez Priego, Karthik Ramasubramanian, Li1 Feng, Shelley Chen, Tanu Malhotra. Yuval Peress has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80773?usp=email ) Change subject: mb/google/brox: support ISH ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/80773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iadc5108c62737d27642a6948c00b5c122541aaba Gerrit-Change-Number: 80773 Gerrit-PatchSet: 7 Gerrit-Owner: Li1 Feng <li1.feng(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.corp-partner.google.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Reviewer: Yuval Peress <peress(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Attention: Li1 Feng <li1.feng(a)intel.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.corp-partner.google.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 19 Mar 2024 16:23:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: superio/ite: Add special fan vectors, unify it8722f with common
by Matt DeVillier (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Joel Linn, Michał Żygowski, MrChromebox, Piotr Król. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81310?usp=email ) Change subject: superio/ite: Add special fan vectors, unify it8722f with common ...................................................................... Patch Set 1: (3 comments) File src/mainboard/google/jecht/devicetree.cb: https://review.coreboot.org/c/coreboot/+/81310/comment/6358c58b_382e4ff3 : PS1, Line 84: FAN2.pwm_start needs to be `FAN2.smart.pwm_start` File src/superio/ite/common/early_serial.c: https://review.coreboot.org/c/coreboot/+/81310/comment/9fc1c83a_04014e59 : PS1, Line 90: void ite_set_3vsbsw(pnp_devfn_t dev, bool enable) not sure I see the point in changing this, given the disable option isn't used anywhere. At the very least, I'd keep the enable function as a call to `ite_set_3vsbsw()` so that none of the callers have to actually change File src/superio/ite/common/env_ctrl.c: https://review.coreboot.org/c/coreboot/+/81310/comment/732a32bf_f7463685 : PS1, Line 364: if (CONFIG(SUPERIO_ITE_ENV_CTRL_FAN_VECTOR)) { needs to be #ifdef'd since the `fan_vector` field doesn't exist if the config isn't set -- To view, visit https://review.coreboot.org/c/coreboot/+/81310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6 Gerrit-Change-Number: 81310 Gerrit-PatchSet: 1 Gerrit-Owner: Joel Linn Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Joel Linn Gerrit-Attention: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Tue, 19 Mar 2024 16:13:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp: Redefine data types for FSP2.4 adoption
by Nico Huber (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, TangYiwei, Tim Chu. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81040?usp=email ) Change subject: soc/intel/xeon_sp: Redefine data types for FSP2.4 adoption ...................................................................... Patch Set 9: (2 comments) Patchset: PS9: If possible, please contain the changes within `soc_util.h`. Also, is this really FSP 2.4 specific? Or is it just the next soc-specific header revision and the current architecture happens to be FSP 2.4 atm? I would not expect any of this in the FSP 2.4 spec. File src/soc/intel/xeon_sp/include/soc/fsp_adoption.h: https://review.coreboot.org/c/coreboot/+/81040/comment/4b14d18e_73fefa8f : PS9, Line 21: #define xSTACK_RES UDS_STACK_RES If the types are compatible, wouldn't it be enough to ``` #define STACK_RES UDS_STACK_RES ``` for the new headers? Then we wouldn't have to change all occurrences in the C code. -- To view, visit https://review.coreboot.org/c/coreboot/+/81040?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I28c948525cd6d7ac4b9c3fa67e3c99ec637ed38f Gerrit-Change-Number: 81040 Gerrit-PatchSet: 9 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: TangYiwei Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 19 Mar 2024 16:08:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: Docs: Replace Recommonmark with MyST Parser
by Matt DeVillier (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth, Nicholas Chin. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73158?usp=email ) Change subject: Docs: Replace Recommonmark with MyST Parser ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73158?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0837c1722fa56d25c9441ea218e943d8f3d9b804 Gerrit-Change-Number: 73158 Gerrit-PatchSet: 11 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 19 Mar 2024 16:00:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024