Attention is currently required from: Lean Sheng Tan, Mario Scheithauer, Paul Menzel, Werner Zeh.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81344?usp=email )
Change subject: soc/intel/elkhartlake/Kconfig: Rename FSPRel.bin to FSP.fd
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81344?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibc87ea2744e971d58e9a402f7cf04ef3f316f3b8
Gerrit-Change-Number: 81344
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 19:25:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Maciej Pijanowski, Nico Huber, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80608?usp=email )
Change subject: soc/intel/common/block/fast_spi: probe for 2nd flash component
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80608/comment/a49874d0_313921df :
PS2, Line 10: used
> Clarified on the old driver.
Done
https://review.coreboot.org/c/coreboot/+/80608/comment/fcd0e995_54565e27 :
PS2, Line 12: Some boards
> Example given
Done
File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:
https://review.coreboot.org/c/coreboot/+/80608/comment/38d44463_49731823 :
PS2, Line 58: hord
> Changed to HORD and added some more information
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80608?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8d7449f9e1470dc234fe5ba5217d3ce4c142b49c
Gerrit-Change-Number: 80608
Gerrit-PatchSet: 4
Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 19 Mar 2024 19:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Lean Sheng Tan, Mario Scheithauer, Paul Menzel, Werner Zeh.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81344?usp=email )
Change subject: soc/intel/elkhartlake/Kconfig: Rename FSPRel.bin to FSP.fd
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81344?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibc87ea2744e971d58e9a402f7cf04ef3f316f3b8
Gerrit-Change-Number: 81344
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 19:19:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Michał Żygowski, MrChromebox, Piotr Król.
Hello Michał Żygowski, MrChromebox, Piotr Król,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81310?usp=email
to look at the new patch set (#3).
Change subject: superio/ite: Add special fan vectors, unify it8722f with common
......................................................................
superio/ite: Add special fan vectors, unify it8722f with common
A number of ITE SIOs support "special fan control vectors", which
effectively allow non-linear fan speed control.
This is for example used by the vendor firmware of "HP Pro 3500 Series".
Because that board uses the it8779e (identifying itself as it8772f) and
porting it also required functionality that is only found in the common
code, the it8772f code was unified with the common code except for GPIO
handling which currently lacks a sane abstraction in any codebase.
The 3VSBSW# signal can now also be disabled again which is necessary to
power components down properly in SMM when entering S5.
The datasheets of the it8772e(f) and it8728f (for reference) were studied
and verified against the common code, adding exceptions where needed.
Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6
Signed-off-by: Joel Linn <jl(a)conductive.de>
---
M src/mainboard/foxconn/g41s-k/early_init.c
M src/mainboard/google/beltino/bootblock.c
M src/mainboard/google/beltino/devicetree.cb
M src/mainboard/google/beltino/onboard.h
M src/mainboard/google/jecht/bootblock.c
M src/mainboard/google/jecht/devicetree.cb
M src/mainboard/google/jecht/onboard.h
M src/mainboard/protectli/vault_kbl/devicetree.cb
M src/mainboard/samsung/stumpy/devicetree.cb
M src/mainboard/samsung/stumpy/early_init.c
M src/mainboard/samsung/stumpy/smihandler.c
M src/superio/ite/Makefile.mk
M src/superio/ite/common/Kconfig
M src/superio/ite/common/early_serial.c
M src/superio/ite/common/env_ctrl.c
M src/superio/ite/common/env_ctrl.h
M src/superio/ite/common/env_ctrl_chip.h
M src/superio/ite/common/ite.h
A src/superio/ite/common/mainboard_impl.h
M src/superio/ite/it8728f/Kconfig
M src/superio/ite/it8772f/Kconfig
M src/superio/ite/it8772f/chip.h
M src/superio/ite/it8772f/early_init.c
M src/superio/ite/it8772f/it8772f.h
M src/superio/ite/it8772f/superio.c
25 files changed, 236 insertions(+), 337 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/81310/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/81310?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6
Gerrit-Change-Number: 81310
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Linn
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: MrChromebox <mrchromebox(a)gmail.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ashish Kumar Mishra, Ashish Kumar Mishra, Bernardo Perez Priego, Li1 Feng, Tanu Malhotra.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80773?usp=email )
Change subject: mb/google/brox: support ISH
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80773/comment/9a32bdc0_2faf839a :
PS5, Line 297: chip drivers/intel/ish
: register "firmware_name" = ""brox_ish.bin""
: device generic 0 on
: probe ISH ISH_ENABLE
: end
: end
: chip drivers/intel/ish
: register "add_acpi_dma_property" = "true"
: device generic 0 on
: probe STORAGE STORAGE_UFS
: end
: end
> @Karthik done.
@tanu, Sure I understand. We will go with this change to unblock the ISH validation efforts. I will upload a follow-up CL to update the device tree such that ISH full sensing capability is enabled only when required. For that some additional changes are required.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80773?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iadc5108c62737d27642a6948c00b5c122541aaba
Gerrit-Change-Number: 80773
Gerrit-PatchSet: 7
Gerrit-Owner: Li1 Feng <li1.feng(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Tanu Malhotra <tanu.malhotra(a)intel.com>
Gerrit-Reviewer: Yuval Peress <peress(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Tanu Malhotra <tanu.malhotra(a)intel.com>
Gerrit-Attention: Li1 Feng <li1.feng(a)intel.com>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.corp-partner.google.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 18:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tanu Malhotra <tanu.malhotra(a)intel.com>
Comment-In-Reply-To: Li1 Feng <li1.feng(a)intel.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81334?usp=email )
Change subject: amdfwtool: Move linking BHD2 to PSP2 from main to link funcion
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81334?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia549a0d08c2a60b8858440543ac8d8b5259017dd
Gerrit-Change-Number: 81334
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 19 Mar 2024 18:25:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Michał Żygowski, MrChromebox, Piotr Król.
Joel Linn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81310?usp=email )
Change subject: superio/ite: Add special fan vectors, unify it8722f with common
......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/jecht/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81310/comment/54446bb3_7e171b85 :
PS1, Line 84: FAN2.pwm_start
> needs to be `FAN2.smart. […]
Done
File src/superio/ite/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/81310/comment/829315a4_473eb62a :
PS1, Line 90: void ite_set_3vsbsw(pnp_devfn_t dev, bool enable)
> not sure I see the point in changing this, given the disable option isn't used anywhere. […]
I am working on a new port that needs this otherwise it will not fully power down when entering S5. The port is very functional but it still needs documentation and some (m)pcie tests, therefore no changeset yet.
I added back the enable function as suggested.
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/81310/comment/6107839c_e2ba1929 :
PS1, Line 364: if (CONFIG(SUPERIO_ITE_ENV_CTRL_FAN_VECTOR)) {
> needs to be #ifdef'd since the `fan_vector` field doesn't exist if the config isn't set
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81310?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6
Gerrit-Change-Number: 81310
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Linn
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: MrChromebox <mrchromebox(a)gmail.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 18:13:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment