coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[S] Change in coreboot[main]: mb/google/brya: Create a tivviks variant
by Subrata Banik (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, V Sowmya. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81262?usp=email ) Change subject: mb/google/brya: Create a tivviks variant ...................................................................... Patch Set 1: -Code-Review (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/81262/comment/d176e7e3_80a964d3 : PS1, Line 464: select BOARD_ROMSIZE_KB_32768 : select DRIVERS_GENERIC_GPIO_KEYS : select DRIVERS_GENESYSLOGIC_GL9750 : select DRIVERS_I2C_SX9324 : select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER : select DRIVERS_INTEL_MIPI_CAMERA : select HAVE_WWAN_POWER_SEQUENCE : select INTEL_GMA_HAVE_VBT why not something like this ``` config BOARD_GOOGLE_TIVVIKS select BOARD_GOOGLE_NIVVIKS select SOC_INTEL_TWINLAKE ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/81262?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia833a1dad45e13cd271506ade364b116c5880982 Gerrit-Change-Number: 81262 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 19 Mar 2024 17:57:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brya: Create a tivviks variant
by Subrata Banik (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, V Sowmya. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81262?usp=email ) Change subject: mb/google/brya: Create a tivviks variant ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81262?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia833a1dad45e13cd271506ade364b116c5880982 Gerrit-Change-Number: 81262 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 19 Mar 2024 17:55:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brya: Create a tivviks variant
by Subrata Banik (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, V Sowmya. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81262?usp=email ) Change subject: mb/google/brya: Create a tivviks variant ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yes, Tivviks is a SKU reference/refresh of Nivviks with TWL silicon. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/81262?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia833a1dad45e13cd271506ade364b116c5880982 Gerrit-Change-Number: 81262 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 19 Mar 2024 17:53:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: V Sowmya <v.sowmya(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brya: Create a tivviks variant
by V Sowmya (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81262?usp=email ) Change subject: mb/google/brya: Create a tivviks variant ...................................................................... Patch Set 1: (4 comments) Patchset: PS1: > I am slightly perplexed. […] Yes, Tivviks is a SKU reference/refresh of Nivviks with TWL silicon. I initially thought about the approach of using the Nivviks by switching to TWL SOC/IFWI but due to the following reasons we decided to create a new variant Tivviks which will leverage the Nivviks code with TWL SOC/IFWI, 1. Until all the IFWI components are completely converged for ADL-N/TWL with required quality checks, there is need to maintain Nivviks (ADL-N SOC/IFWI) and add the support for Tivviks (TWL SOC/IFWI). 2. There is need to manage both the ADL-N (IPU) platform and Twinlake (execution) platform, so its recommended to maintain the builds/variants separately for both ADL-N and converged IFWI until these two are merged. Yes, we can stop support for Tivviks by updating Nivviks to use the converged firmware for both ADL-N/TWL SOC, post complete validation of the firmware and availability of the external releases. File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/81262/comment/cda681a9_6c743376 : PS1, Line 463: select SOC_INTEL_TWINLAKE > please follow the alphabetic order Acknowledged https://review.coreboot.org/c/coreboot/+/81262/comment/88f35ebd_35118b72 : PS1, Line 581: BOARD_GOOGLE_TIVVIKS > please make a separate entry Acknowledged https://review.coreboot.org/c/coreboot/+/81262/comment/b4a3609c_ea9a9a7d : PS1, Line 665: BOARD_GOOGLE_TIVVIKS > why not use `Tivviks` as MAINBOARD_PART_NUMBER ? Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/81262?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia833a1dad45e13cd271506ade364b116c5880982 Gerrit-Change-Number: 81262 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 19 Mar 2024 17:47:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: vc/amd/opensil/*/mpio: add IFTYPE_UNUSED mpio_type enum element
by Arthur Heymans (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81339?usp=email ) Change subject: vc/amd/opensil/*/mpio: add IFTYPE_UNUSED mpio_type enum element ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81339?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I85e2589c021b4f05662369fd551146b6f2fa0ad4 Gerrit-Change-Number: 81339 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 19 Mar 2024 17:41:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Correctly set CNVi Reset and Clkreq pins
by Nico Huber (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Martin L Roth, Nick Vaccaro, Sean Rhodes, Subrata Banik, srinivas.kulkarni(a)intel.com. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81080?usp=email ) Change subject: soc/intel/alderlake: Correctly set CNVi Reset and Clkreq pins ...................................................................... Patch Set 4: (3 comments) File src/soc/intel/alderlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/81080/comment/4183b5db_11324f84 : PS4, Line 837: * which are used for eSPI. `... hence we need to switch to GPP_F4 and GPP_F5`. Please add that info :) https://review.coreboot.org/c/coreboot/+/81080/comment/7ffeaa3a_40c31893 : PS4, Line 838: : s_cfg->CnviRfResetPinMux = 0x194ce404; : s_cfg->CnviClkreqPinMux = 0x294ce605; Comments in `Fsps_Upd.h` suggest that both should be 0 for ADL-S which can be checked with `CONFIG(SOC_INTEL_ALDERLAKE_PCH_S)`. Maybe just do nothing if it's set. https://review.coreboot.org/c/coreboot/+/81080/comment/8af45171_8f5440cd : PS4, Line 840: 2 The comment in `Fsps_Upd.h` says `0x394ce605`, is this a typo? -- To view, visit https://review.coreboot.org/c/coreboot/+/81080?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib534d3cfe888c1c538267caaf324c8ae743da496 Gerrit-Change-Number: 81080 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: srinivas.kulkarni(a)intel.com Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: srinivas.kulkarni(a)intel.com Gerrit-Comment-Date: Tue, 19 Mar 2024 17:37:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: vc/amd/opensil/stub/mpio: change mpio_engine_type prefix to IFTYPE
by Felix Held (Code Review) 19 Mar '24

19 Mar '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81346?usp=email to look at the new patch set (#2). Change subject: vc/amd/opensil/stub/mpio: change mpio_engine_type prefix to IFTYPE ...................................................................... vc/amd/opensil/stub/mpio: change mpio_engine_type prefix to IFTYPE Change the prefix of the elements of the mpio_engine_type enum from ENGINE_ to IFTYPE_. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Suggested-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: If81c5ea01ba147b71b423004a2199b348ffac99a --- M src/vendorcode/amd/opensil/stub/mpio/chip.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/81346/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81346?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If81c5ea01ba147b71b423004a2199b348ffac99a Gerrit-Change-Number: 81346 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: superio/ite: Add special fan vectors, unify it8722f with common
by Joel Linn (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Joel Linn, Michał Żygowski, MrChromebox, Piotr Król. Hello Michał Żygowski, MrChromebox, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81310?usp=email to look at the new patch set (#2). Change subject: superio/ite: Add special fan vectors, unify it8722f with common ...................................................................... superio/ite: Add special fan vectors, unify it8722f with common A number of ITE SIOs support "special fan control vectors", which effectively allow non-linear fan speed control. This is for example used by the vendor firmware of "HP Pro 3500 Series". Because that board uses the it8779e (identifying itself as it8772f) and porting it also required functionality that is only found in the common code, the it8772f code was unified with the common code except for GPIO handling which currently lacks a sane abstraction in any codebase. The 3VSBSW# signal can now also be disabled again which is necessary to power components down properly in SMM when entering S5. The datasheets of the it8772e(f) and it8728f (for reference) were studied and verified against the common code, adding exceptions where needed. Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6 Signed-off-by: Joel Linn <jl(a)conductive.de> --- M src/mainboard/foxconn/g41s-k/early_init.c M src/mainboard/google/beltino/bootblock.c M src/mainboard/google/beltino/devicetree.cb M src/mainboard/google/beltino/onboard.h M src/mainboard/google/jecht/bootblock.c M src/mainboard/google/jecht/devicetree.cb M src/mainboard/google/jecht/onboard.h M src/mainboard/protectli/vault_kbl/devicetree.cb M src/mainboard/samsung/stumpy/devicetree.cb M src/mainboard/samsung/stumpy/early_init.c M src/mainboard/samsung/stumpy/smihandler.c M src/superio/ite/Makefile.mk M src/superio/ite/common/Kconfig M src/superio/ite/common/early_serial.c M src/superio/ite/common/env_ctrl.c M src/superio/ite/common/env_ctrl.h M src/superio/ite/common/env_ctrl_chip.h M src/superio/ite/common/ite.h A src/superio/ite/common/mainboard_impl.h M src/superio/ite/it8728f/Kconfig M src/superio/ite/it8772f/Kconfig M src/superio/ite/it8772f/chip.h M src/superio/ite/it8772f/early_init.c M src/superio/ite/it8772f/it8772f.h M src/superio/ite/it8772f/superio.c 25 files changed, 233 insertions(+), 337 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/81310/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6 Gerrit-Change-Number: 81310 Gerrit-PatchSet: 2 Gerrit-Owner: Joel Linn Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Joel Linn Gerrit-Attention: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: arch/x86: Directly return result of `IS_POWER_OF_2()`
by Felix Held (Code Review) 19 Mar '24

19 Mar '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81299?usp=email ) Change subject: arch/x86: Directly return result of `IS_POWER_OF_2()` ...................................................................... arch/x86: Directly return result of `IS_POWER_OF_2()` Change-Id: I314d726deaed30e69121126ba6834e4c7cafd090 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81299 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jérémy Compostella <jeremy.compostella(a)intel.com> --- M src/arch/x86/cpu_common.c 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Jérémy Compostella: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/arch/x86/cpu_common.c b/src/arch/x86/cpu_common.c index ee07214..5f7cd5d 100644 --- a/src/arch/x86/cpu_common.c +++ b/src/arch/x86/cpu_common.c @@ -245,8 +245,5 @@ size_t cache_sets = cpu_get_cache_sets(&info); - if (IS_POWER_OF_2(cache_sets)) - return true; - - return false; + return IS_POWER_OF_2(cache_sets); } -- To view, visit https://review.coreboot.org/c/coreboot/+/81299?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I314d726deaed30e69121126ba6834e4c7cafd090 Gerrit-Change-Number: 81299 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: vc/amd/opensil/genoa_poc/mpio: add IFTYPE_ prefix to mpio_type values
by Felix Held (Code Review) 19 Mar '24

19 Mar '24

Attention is currently required from: Arthur Heymans, Martin L Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81338?usp=email ) Change subject: vc/amd/opensil/genoa_poc/mpio: add IFTYPE_ prefix to mpio_type values ...................................................................... Patch Set 3: (1 comment) File src/vendorcode/amd/opensil/genoa_poc/mpio/chip.h: https://review.coreboot.org/c/coreboot/+/81338/comment/fcb0560b_9de19ed1 : PS2, Line 20: ENGINE_PCIE > MUX_TYPE doesn't make much sense to me in this context; Matt suggested using IFTYPE_PCIE as prefix w […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81338?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I229a3402c36941ee5347e3704fcf8d8a1bbc78a6 Gerrit-Change-Number: 81338 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 19 Mar 2024 17:02:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024