coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: mb/google/veyron_{mickey;rialto}: Remove return statment in void func...
by Felix Singer (Code Review) 23 Mar '24

23 Mar '24

Attention is currently required from: Elyes Haouas. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81430?usp=email ) Change subject: mb/google/veyron_{mickey;rialto}: Remove return statment in void function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81430?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8cf020de335e4da933b7bbdc27b7ac6f31afe885 Gerrit-Change-Number: 81430 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 23 Mar 2024 13:22:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/common/block/cse: Remove return statment in void function
by Felix Singer (Code Review) 23 Mar '24

23 Mar '24

Attention is currently required from: Elyes Haouas. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81429?usp=email ) Change subject: soc/intel/common/block/cse: Remove return statment in void function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81429?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb8e07f48043452b329d255fe457f00317c017ae Gerrit-Change-Number: 81429 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 23 Mar 2024 13:22:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Makefile.inc: Also add -libs to bootblock when !SEPARATE_ROMSTAGE
by Felix Singer (Code Review) 23 Mar '24

23 Mar '24

Attention is currently required from: Arthur Heymans, Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79575?usp=email ) Change subject: Makefile.inc: Also add -libs to bootblock when !SEPARATE_ROMSTAGE ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79575/comment/349db8cd_da02ebf0 : PS4, Line 7: Makefile.inc Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/79575?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I18bf67cae7af90a92a030e552af6dc6b134a8357 Gerrit-Change-Number: 79575 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 23 Mar 2024 13:21:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Don't build a separate romstage by default in some cases
by Nico Huber (Code Review) 23 Mar '24

23 Mar '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Frans Hendriks, Julius Werner, Paul Menzel, Yu-Ping Wu. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63419?usp=email ) Change subject: Don't build a separate romstage by default in some cases ...................................................................... Patch Set 56: (1 comment) File src/Kconfig: https://review.coreboot.org/c/coreboot/+/63419/comment/335bcfb7_6b915074 : PS42, Line 1471: default y if VBOOT_STARTS_IN_BOOTBLOCK || BOOTBLOCK_NORMAL || ASAN_IN_ROMSTAGE > Done I guess? Partially. BOOTBLOCK_NORMAL has a `select SEPARATE_ROMSTAGE` now, so listing it here is redundant. -- To view, visit https://review.coreboot.org/c/coreboot/+/63419?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c53b6fa7a3e66415c5b1c539918a6c1cd8defa1 Gerrit-Change-Number: 63419 Gerrit-PatchSet: 56 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sat, 23 Mar 2024 13:19:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: superio/ite: Add special fan vectors and further options
by Nico Huber (Code Review) 23 Mar '24

23 Mar '24

1 0

[M] Change in coreboot[main]: superio/ite: Add special fan vectors and further options
by Nico Huber (Code Review) 23 Mar '24

23 Mar '24

Attention is currently required from: Joel Linn, Matt DeVillier. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email ) Change subject: superio/ite: Add special fan vectors and further options ...................................................................... Patch Set 1: (7 comments) File src/superio/ite/common/env_ctrl.h: https://review.coreboot.org/c/coreboot/+/81426/comment/da992687_84b281ea : PS1, Line 211: #define ITE_EC_FAN_VEC_CTL_SLOPESIGN(x) (((x) & 0x1) << 7) As many of the bits are in unexpected registers, it might be worth to put the full register name into the bit definitions, e.g. ``` ITE_EC_FAN_VEC_CTL_SLOPE_TMPIN0(x) ITE_EC_FAN_VEC_CTL_DELTA_TMPIN1(x) ITE_EC_FAN_VEC_CTL_DELTA_FANOUT(x) ITE_EC_FAN_VEC_CTL_RANGE_SLOPE_SIGN(x) ``` File src/superio/ite/common/env_ctrl.c: https://review.coreboot.org/c/coreboot/+/81426/comment/0cdfc806_d1fbff97 : PS1, Line 128: } I guess the whole thing should be handled in mainboard code. Then we wouldn't need the callback nor special values. You can actually change devicetree settings in ramstage C code, for instance your mainboard_enable(). e.g. ``` #include <static_devices.h> ... static void mainboard_enable(struct device *dev) { ... __pnp_002e_04->chip->config.ec.tmpin[2].offset = cpu_get_temp_offset(); } ``` https://review.coreboot.org/c/coreboot/+/81426/comment/394057a2_deb728f2 : PS1, Line 274: s8 slope = conf->slope; : bool slope_neg = slope < 0; Both should be `const` to show the intention. https://review.coreboot.org/c/coreboot/+/81426/comment/968104e5_3517200d : PS1, Line 369: #endif If trying the 0 array length (see comment in `env_ctrl_chip.h`), this should become a C `if (CONFIG(SUPERIO_ITE_ENV_CTRL_FAN_VECTOR)) { ... }` so garbage collection would know that we don't need enable_fan_vector() in the binary. File src/superio/ite/common/env_ctrl_chip.h: https://review.coreboot.org/c/coreboot/+/81426/comment/6f6dcb02_665e3a1b : PS1, Line 106: #endif As odd as it may seem, GCC accepts a `[0]` here (hopefully clang too). This would save us from all of the `#if` in C code. e.g. if we did ``` #if CONFIG(SUPERIO_ITE_ENV_CTRL_FAN_VECTOR) #define ITE_EC_FAN_VECTOR_CNT 2 #else #define ITE_EC_FAN_VECTOR_CNT 0 #endif ``` File src/superio/ite/common/ite.h: https://review.coreboot.org/c/coreboot/+/81426/comment/557575bd_2e7afead : PS1, Line 21: void ite_pme_out_disable(pnp_devfn_t dev); The other APIs above have the verb first. So how about `ite_diable_pme_out()`? https://review.coreboot.org/c/coreboot/+/81426/comment/a613e6b3_62001f62 : PS1, Line 26: #define ite_disable_3vsbsw(dev) ite_set_3vsbsw((dev), false) Inline functions are preferred. e.g. ``` static inline void ite_disable_3vsbsw(pnp_devfn_t dev) { ite_set_3vsbsw(dev, false); } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/81426?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93df2b5652fc3fde775b6161fa5bebc4a34d5e94 Gerrit-Change-Number: 81426 Gerrit-PatchSet: 1 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Comment-Date: Sat, 23 Mar 2024 12:59:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Don't build a separate romstage by default in some cases
by Arthur Heymans (Code Review) 23 Mar '24

23 Mar '24

Attention is currently required from: Andrey Petrov, Frans Hendriks, Julius Werner, Nico Huber, Paul Menzel, Yu-Ping Wu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63419?usp=email ) Change subject: Don't build a separate romstage by default in some cases ...................................................................... Patch Set 56: (1 comment) File src/Kconfig: https://review.coreboot.org/c/coreboot/+/63419/comment/04ee9d40_72b81eeb : PS42, Line 1471: default y if VBOOT_STARTS_IN_BOOTBLOCK || BOOTBLOCK_NORMAL || ASAN_IN_ROMSTAGE > VBOOT alread has a select on this and maybe the others should have one too? […] Done I guess? -- To view, visit https://review.coreboot.org/c/coreboot/+/63419?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c53b6fa7a3e66415c5b1c539918a6c1cd8defa1 Gerrit-Change-Number: 63419 Gerrit-PatchSet: 56 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sat, 23 Mar 2024 12:42:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Don't build a separate romstage by default in some cases
by Arthur Heymans (Code Review) 23 Mar '24

23 Mar '24

Attention is currently required from: Andrey Petrov, Frans Hendriks, Julius Werner, Paul Menzel, Yu-Ping Wu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63419?usp=email ) Change subject: Don't build a separate romstage by default in some cases ...................................................................... Patch Set 56: (1 comment) File src/Kconfig: https://review.coreboot.org/c/coreboot/+/63419/comment/9583ec30_c48cd54a : PS11, Line 1389: default n if ARCH_X86 > (Sorry for the delay, this must have slipped by me somehow.) > > I'm still trying to figure out _why_ this should be `default n if ARCH_X86`. I mean, if you're saying that for all current x86 boards it happens to be the best choice that may be true, but it still doesn't seem like a good idea to just tie it to that because future x86 boards may be governed by different factors. I think it would be better to tie it to something that is logically connected to the performance difference from separating the ramstage, like the compression/XIP thing (and probably also add a comment to document the reasoning for that). > > If you're saying it also makes sense for AMD then maybe that should be a separate consideration. We don't have a `CONFIG_BOOTBLOCK_IS_AUTOMATICALLY_DECOMPRESSED_BY_PLATFORM`, and this seems to be a pretty unique case so it may not be worth to add it just for this... so maybe just `default n if !NO_XIP_EARLY_STAGES || RESET_VECTOR_IN_RAM`? That works. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/63419?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c53b6fa7a3e66415c5b1c539918a6c1cd8defa1 Gerrit-Change-Number: 63419 Gerrit-PatchSet: 56 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sat, 23 Mar 2024 12:41:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Don't build a separate romstage by default in some cases
by Arthur Heymans (Code Review) 23 Mar '24

23 Mar '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Frans Hendriks, Paul Menzel, Yu-Ping Wu. Hello Andrey Petrov, Erik van den Bogaert, Frans Hendriks, Julius Werner, Paul Menzel, Sean Rhodes, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63419?usp=email to look at the new patch set (#56). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Don't build a separate romstage by default in some cases ...................................................................... Don't build a separate romstage by default in some cases When the stage executes in place without a special bootflow like normal/fallback or VBOOT or if the bootblock is decompressed into DRAM, there is no reason to use a separate romstage. Change-Id: I4c53b6fa7a3e66415c5b1c539918a6c1cd8defa1 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/Kconfig M src/soc/intel/apollolake/Kconfig 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/63419/56 -- To view, visit https://review.coreboot.org/c/coreboot/+/63419?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c53b6fa7a3e66415c5b1c539918a6c1cd8defa1 Gerrit-Change-Number: 63419 Gerrit-PatchSet: 56 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: soc/amd/noncar: Increase bootblock size from 64K to 128K
by Arthur Heymans (Code Review) 23 Mar '24

23 Mar '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Paul Menzel. Hello Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80348?usp=email to look at the new patch set (#9). Change subject: soc/amd/noncar: Increase bootblock size from 64K to 128K ...................................................................... soc/amd/noncar: Increase bootblock size from 64K to 128K When linking in page tables or romstage code, more place is needed. With Genoa POC x86_64 is the default so no conditional Kconfig values are set. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I23f176d63d3c303b13331a77ad5ac6c7a19073d3 --- M src/soc/amd/cezanne/Kconfig M src/soc/amd/genoa_poc/Kconfig M src/soc/amd/glinda/Kconfig M src/soc/amd/mendocino/Kconfig M src/soc/amd/phoenix/Kconfig M src/soc/amd/picasso/Kconfig 6 files changed, 18 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/80348/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/80348?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I23f176d63d3c303b13331a77ad5ac6c7a19073d3 Gerrit-Change-Number: 80348 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024