coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: mb/google/stout: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81478?usp=email ) Change subject: mb/google/stout: Remove blank lines before '}' and after '{' ...................................................................... mb/google/stout: Remove blank lines before '}' and after '{' Change-Id: Ia6c55c7f8a4e0de2c13d4636d5439d8aee973901 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/stout/early_init.c M src/mainboard/google/stout/ec.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/81478/1 diff --git a/src/mainboard/google/stout/early_init.c b/src/mainboard/google/stout/early_init.c index 0739f6e..e6e6227 100644 --- a/src/mainboard/google/stout/early_init.c +++ b/src/mainboard/google/stout/early_init.c @@ -63,7 +63,6 @@ if (((ec_status & 0x3) == EC_IN_RO_MODE) || ((ec_status & 0x3) == EC_IN_RECOVERY_MODE)) { - printk(BIOS_DEBUG, "EC Cold Boot Detected\n"); if (!rec_mode) { /* diff --git a/src/mainboard/google/stout/ec.c b/src/mainboard/google/stout/ec.c index 2584166..deb2bd2 100644 --- a/src/mainboard/google/stout/ec.c +++ b/src/mainboard/google/stout/ec.c @@ -11,7 +11,6 @@ void stout_ec_init(void) { - printk(BIOS_DEBUG,"%s: EC FW version %x%x\n", __func__, ec_read(EC_FW_VER), ec_read(EC_FW_VER + 1)); -- To view, visit https://review.coreboot.org/c/coreboot/+/81478?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia6c55c7f8a4e0de2c13d4636d5439d8aee973901 Gerrit-Change-Number: 81478 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/cherry: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81477?usp=email ) Change subject: mb/google/cherry: Remove blank lines before '}' and after '{' ...................................................................... mb/google/cherry: Remove blank lines before '}' and after '{' Change-Id: If68303cd59b287c8a5c982063b2ab75fd74898d6 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/cherry/chromeos.c M src/mainboard/google/cherry/regulator.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/81477/1 diff --git a/src/mainboard/google/cherry/chromeos.c b/src/mainboard/google/cherry/chromeos.c index 4a93ae2..7838c5e 100644 --- a/src/mainboard/google/cherry/chromeos.c +++ b/src/mainboard/google/cherry/chromeos.c @@ -21,7 +21,6 @@ gpio_output(GPIO_BEEP_ON, 0); else if (CONFIG(CHERRY_USE_RT1011)) gpio_output(GPIO_RST_RT1011, 0); - } void fill_lb_gpios(struct lb_gpios *gpios) diff --git a/src/mainboard/google/cherry/regulator.c b/src/mainboard/google/cherry/regulator.c index 61f53d1..83ba9ed 100644 --- a/src/mainboard/google/cherry/regulator.c +++ b/src/mainboard/google/cherry/regulator.c @@ -174,7 +174,6 @@ } return !!enabled; } - } printk(BIOS_ERR, "Invalid regulator ID: %d\n; assuming disabled", regulator); -- To view, visit https://review.coreboot.org/c/coreboot/+/81477?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If68303cd59b287c8a5c982063b2ab75fd74898d6 Gerrit-Change-Number: 81477 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/butterfly: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81476?usp=email ) Change subject: mb/google/butterfly: Remove blank lines before '}' and after '{' ...................................................................... mb/google/butterfly: Remove blank lines before '}' and after '{' Change-Id: I0132de745fd95b14c42e8478313893bf1707b2c3 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/butterfly/ec.c M src/mainboard/google/butterfly/mainboard.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/81476/1 diff --git a/src/mainboard/google/butterfly/ec.c b/src/mainboard/google/butterfly/ec.c index 4e5e422..b979bf5 100644 --- a/src/mainboard/google/butterfly/ec.c +++ b/src/mainboard/google/butterfly/ec.c @@ -18,5 +18,4 @@ /* Disable wake on USB, LAN & RTC */ /* Enable Wake from Keyboard */ ec_mem_write(EC_EC_PSW, EC_PSW_IKB); - } diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c index ac0f57b..7d4a9cf 100644 --- a/src/mainboard/google/butterfly/mainboard.c +++ b/src/mainboard/google/butterfly/mainboard.c @@ -126,7 +126,6 @@ char kbd_type = EC_KBD_EN; /* Default keyboard type is English */ if (search_length != -1) { - /* * Search for keyboard_layout identifier * The only options in the EC are Japanese or English. -- To view, visit https://review.coreboot.org/c/coreboot/+/81476?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0132de745fd95b14c42e8478313893bf1707b2c3 Gerrit-Change-Number: 81476 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/skyrim: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81475?usp=email ) Change subject: mb/google/skyrim: Remove blank lines before '}' and after '{' ...................................................................... mb/google/skyrim: Remove blank lines before '}' and after '{' Change-Id: Iab1c7ac85a817383c5d4c4090c3fd36f33715fe0 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/skyrim/bootblock.c M src/mainboard/google/skyrim/variants/markarth/gpio.c M src/mainboard/google/skyrim/variants/winterhold/gpio.c 3 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/81475/1 diff --git a/src/mainboard/google/skyrim/bootblock.c b/src/mainboard/google/skyrim/bootblock.c index d285d7f..30f300c 100644 --- a/src/mainboard/google/skyrim/bootblock.c +++ b/src/mainboard/google/skyrim/bootblock.c @@ -27,11 +27,9 @@ cmos_bit_set = (byte_value & CMOS_BITMAP_SKIP_RESET_TOGGLE) != 0; if (CONFIG(BOARD_GOOGLE_FROSTFLOW)) { - printk(BIOS_SPEW, "Checking DRAM part #\n"); if (google_chromeec_cbi_get_dram_part_num( cbi_part_number, sizeof(cbi_part_number)) == 0) { - skip_reset_toggle = strncmp(cbi_part_number, HYNIX_PART_NAME, HYNIX_PART_LEN) == 0; if (skip_reset_toggle) { printk(BIOS_SPEW, "SKIP_RESET_TOGGLE needed, checking CMOS bit is set\n"); diff --git a/src/mainboard/google/skyrim/variants/markarth/gpio.c b/src/mainboard/google/skyrim/variants/markarth/gpio.c index 9753179..c320228 100644 --- a/src/mainboard/google/skyrim/variants/markarth/gpio.c +++ b/src/mainboard/google/skyrim/variants/markarth/gpio.c @@ -5,7 +5,6 @@ /* GPIO configuration in ramstage */ static const struct soc_amd_gpio override_gpio_table[] = { - /* SOC_PEN_DETECT_ODL => Unused */ PAD_NC(GPIO_3), /* EN_PWR_FP => Unused */ diff --git a/src/mainboard/google/skyrim/variants/winterhold/gpio.c b/src/mainboard/google/skyrim/variants/winterhold/gpio.c index 340bfb6..888ba32 100644 --- a/src/mainboard/google/skyrim/variants/winterhold/gpio.c +++ b/src/mainboard/google/skyrim/variants/winterhold/gpio.c @@ -6,7 +6,6 @@ /* GPIO configuration in ramstage */ static const struct soc_amd_gpio override_gpio_table[] = { - /* SOC_PEN_DETECT_ODL */ PAD_NC(GPIO_3), -- To view, visit https://review.coreboot.org/c/coreboot/+/81475?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iab1c7ac85a817383c5d4c4090c3fd36f33715fe0 Gerrit-Change-Number: 81475 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/mistral: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81474?usp=email ) Change subject: mb/google/mistral: Remove blank lines before '}' and after '{' ...................................................................... mb/google/mistral: Remove blank lines before '}' and after '{' Change-Id: I2319df75a3e783955a7dc95517666fa0f03f2768 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/mistral/bootblock.c M src/mainboard/google/mistral/chromeos.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/81474/1 diff --git a/src/mainboard/google/mistral/bootblock.c b/src/mainboard/google/mistral/bootblock.c index 4327ccc..5dcae8c 100644 --- a/src/mainboard/google/mistral/bootblock.c +++ b/src/mainboard/google/mistral/bootblock.c @@ -4,5 +4,4 @@ void bootblock_mainboard_init(void) { - } diff --git a/src/mainboard/google/mistral/chromeos.c b/src/mainboard/google/mistral/chromeos.c index 7ffcd57..b9a190e 100644 --- a/src/mainboard/google/mistral/chromeos.c +++ b/src/mainboard/google/mistral/chromeos.c @@ -5,7 +5,6 @@ void fill_lb_gpios(struct lb_gpios *gpios) { - } int get_ec_is_trusted(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/81474?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2319df75a3e783955a7dc95517666fa0f03f2768 Gerrit-Change-Number: 81474 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/nyan: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81473?usp=email ) Change subject: mb/google/nyan: Remove blank lines before '}' and after '{' ...................................................................... mb/google/nyan: Remove blank lines before '}' and after '{' Change-Id: I259f13ff9541004fcaa382533febba13d0e5cf00 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/nyan/mainboard.c M src/mainboard/google/nyan_big/mainboard.c M src/mainboard/google/nyan_blaze/mainboard.c 3 files changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/81473/1 diff --git a/src/mainboard/google/nyan/mainboard.c b/src/mainboard/google/nyan/mainboard.c index e4e7975..ba2fe28 100644 --- a/src/mainboard/google/nyan/mainboard.c +++ b/src/mainboard/google/nyan/mainboard.c @@ -50,7 +50,6 @@ clrsetbits32(&clk_rst->clk_src_disp1, CLK_SOURCE_MASK | CLK_DIVISOR_MASK, 2 /*PLLD_OUT0 */ << CLK_SOURCE_SHIFT); - } static void setup_pinmux(void) diff --git a/src/mainboard/google/nyan_big/mainboard.c b/src/mainboard/google/nyan_big/mainboard.c index 0250b45..3a45729 100644 --- a/src/mainboard/google/nyan_big/mainboard.c +++ b/src/mainboard/google/nyan_big/mainboard.c @@ -50,7 +50,6 @@ clrsetbits32(&clk_rst->clk_src_disp1, CLK_SOURCE_MASK | CLK_DIVISOR_MASK, 2 /*PLLD_OUT0 */ << CLK_SOURCE_SHIFT); - } static void setup_pinmux(void) diff --git a/src/mainboard/google/nyan_blaze/mainboard.c b/src/mainboard/google/nyan_blaze/mainboard.c index d6aa05a..5b82208 100644 --- a/src/mainboard/google/nyan_blaze/mainboard.c +++ b/src/mainboard/google/nyan_blaze/mainboard.c @@ -50,7 +50,6 @@ clrsetbits32(&clk_rst->clk_src_disp1, CLK_SOURCE_MASK | CLK_DIVISOR_MASK, 2 /*PLLD_OUT0 */ << CLK_SOURCE_SHIFT); - } static void setup_pinmux(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/81473?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I259f13ff9541004fcaa382533febba13d0e5cf00 Gerrit-Change-Number: 81473 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/poppy: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81472?usp=email ) Change subject: mb/google/poppy: Remove blank lines before '}' and after '{' ...................................................................... mb/google/poppy: Remove blank lines before '}' and after '{' Change-Id: Iccefefecde087c8c70094527546e93467e94cf12 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/poppy/variants/nami/nhlt.c M src/mainboard/google/poppy/variants/nautilus/nhlt.c M src/mainboard/google/poppy/variants/rammus/nhlt.c 3 files changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/81472/1 diff --git a/src/mainboard/google/poppy/variants/nami/nhlt.c b/src/mainboard/google/poppy/variants/nami/nhlt.c index 343b835..5cd8e5a 100644 --- a/src/mainboard/google/poppy/variants/nami/nhlt.c +++ b/src/mainboard/google/poppy/variants/nami/nhlt.c @@ -18,7 +18,6 @@ /* MAXIM Smart Amps for left and right speakers. */ if (nhlt_soc_add_max98357(nhlt, AUDIO_LINK_SSP0)) printk(BIOS_ERR, "Couldn't add Maxim_98357 codec.\n"); - } void variant_nhlt_oem_overrides(const char **oem_id, const char **oem_table_id, diff --git a/src/mainboard/google/poppy/variants/nautilus/nhlt.c b/src/mainboard/google/poppy/variants/nautilus/nhlt.c index 267dbfc..ed44b84 100644 --- a/src/mainboard/google/poppy/variants/nautilus/nhlt.c +++ b/src/mainboard/google/poppy/variants/nautilus/nhlt.c @@ -18,7 +18,6 @@ /* MAXIM Smart Amps for left and right speakers. */ if (nhlt_soc_add_max98357(nhlt, AUDIO_LINK_SSP0)) printk(BIOS_ERR, "Couldn't add Maxim_98357 codec.\n"); - } void variant_nhlt_oem_overrides(const char **oem_id, const char **oem_table_id, diff --git a/src/mainboard/google/poppy/variants/rammus/nhlt.c b/src/mainboard/google/poppy/variants/rammus/nhlt.c index c893ee9..49a3f7a 100644 --- a/src/mainboard/google/poppy/variants/rammus/nhlt.c +++ b/src/mainboard/google/poppy/variants/rammus/nhlt.c @@ -19,7 +19,6 @@ /* Render time_slot is 0 and feedback time_slot is 2 */ if (nhlt_soc_add_max98927(nhlt, AUDIO_LINK_SSP0, 0, 2)) printk(BIOS_ERR, "Couldn't add Maxim MAX98927\n"); - } void variant_nhlt_oem_overrides(const char **oem_id, const char **oem_table_id, -- To view, visit https://review.coreboot.org/c/coreboot/+/81472?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iccefefecde087c8c70094527546e93467e94cf12 Gerrit-Change-Number: 81472 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: soc/samsung: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81471?usp=email ) Change subject: soc/samsung: Remove blank lines before '}' and after '{' ...................................................................... soc/samsung: Remove blank lines before '}' and after '{' Change-Id: If0df5d5fb7ad4b11acedc963d7658b6c9c68aca7 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/samsung/exynos5250/clock_init.c M src/soc/samsung/exynos5250/dp-reg.c M src/soc/samsung/exynos5420/dmc_init_ddr3.c M src/soc/samsung/exynos5420/dp.c 4 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/81471/1 diff --git a/src/soc/samsung/exynos5250/clock_init.c b/src/soc/samsung/exynos5250/clock_init.c index 1c13466..12fc5c6 100644 --- a/src/soc/samsung/exynos5250/clock_init.c +++ b/src/soc/samsung/exynos5250/clock_init.c @@ -411,7 +411,6 @@ clrbits32(&exynos_clock->gate_ip_cdrex, CLK_DPHY0_MASK | CLK_DPHY1_MASK | CLK_TZASC_DRBXR_MASK); - } void clock_init_dp_clock(void) diff --git a/src/soc/samsung/exynos5250/dp-reg.c b/src/soc/samsung/exynos5250/dp-reg.c index b93a9b8..7e5494d 100644 --- a/src/soc/samsung/exynos5250/dp-reg.c +++ b/src/soc/samsung/exynos5250/dp-reg.c @@ -115,7 +115,6 @@ /* Power up PLL */ if (s5p_dp_get_pll_lock_status(dp) == PLL_UNLOCKED) { - clrbits32(&base->dp_pll_ctl, DP_PLL_PD); stopwatch_init_msecs_expire(&sw, PLL_LOCK_TIMEOUT); diff --git a/src/soc/samsung/exynos5420/dmc_init_ddr3.c b/src/soc/samsung/exynos5420/dmc_init_ddr3.c index a187f6e..e716d58 100644 --- a/src/soc/samsung/exynos5420/dmc_init_ddr3.c +++ b/src/soc/samsung/exynos5420/dmc_init_ddr3.c @@ -186,7 +186,6 @@ } if (mem->gate_leveling_enable) { - write32(&exynos_phy0_control->phy_con0, PHY_CON0_RESET_VAL); write32(&exynos_phy1_control->phy_con0, PHY_CON0_RESET_VAL); diff --git a/src/soc/samsung/exynos5420/dp.c b/src/soc/samsung/exynos5420/dp.c index 13a8fef..f28c87d 100644 --- a/src/soc/samsung/exynos5420/dp.c +++ b/src/soc/samsung/exynos5420/dp.c @@ -142,7 +142,6 @@ exynos_dp_write_byte_to_dpcd(DPCD_TEST_RESPONSE, DPCD_TEST_EDID_CHECKSUM_WRITE); } - } return 0; @@ -338,7 +337,6 @@ if (ret != EXYNOS_DP_SUCCESS) { printk(BIOS_ERR, "DP write_to_dpcd failed\n"); return -1; - } return ret; -- To view, visit https://review.coreboot.org/c/coreboot/+/81471?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0df5d5fb7ad4b11acedc963d7658b6c9c68aca7 Gerrit-Change-Number: 81471 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: soc/cavium: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81470?usp=email ) Change subject: soc/cavium: Remove blank lines before '}' and after '{' ...................................................................... soc/cavium: Remove blank lines before '}' and after '{' Change-Id: Id604dc981d6ca0a8163b7477b7916210faa56a77 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/cavium/cn81xx/spi.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/81470/1 diff --git a/src/soc/cavium/cn81xx/spi.c b/src/soc/cavium/cn81xx/spi.c index a3ef567..8faa972 100644 --- a/src/soc/cavium/cn81xx/spi.c +++ b/src/soc/cavium/cn81xx/spi.c @@ -393,7 +393,6 @@ return 0; } static const struct spi_ctrlr spi_ctrlr = { - .xfer_vector = spi_ctrlr_xfer_vector, .max_xfer_size = SPI_CTRLR_DEFAULT_MAX_XFER_SIZE, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/81470?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id604dc981d6ca0a8163b7477b7916210faa56a77 Gerrit-Change-Number: 81470 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/fizz: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81469?usp=email ) Change subject: mb/google/fizz: Remove blank lines before '}' and after '{' ...................................................................... mb/google/fizz: Remove blank lines before '}' and after '{' Change-Id: If35a4b2f6f44a361fdd9e3674572b65f6f196088 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/fizz/variants/baseboard/nhlt.c M src/mainboard/google/fizz/variants/endeavour/board.c M src/mainboard/google/fizz/variants/karma/nhlt.c 3 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/81469/1 diff --git a/src/mainboard/google/fizz/variants/baseboard/nhlt.c b/src/mainboard/google/fizz/variants/baseboard/nhlt.c index 3011955..6dba2b4 100644 --- a/src/mainboard/google/fizz/variants/baseboard/nhlt.c +++ b/src/mainboard/google/fizz/variants/baseboard/nhlt.c @@ -6,11 +6,9 @@ void __weak variant_nhlt_init(struct nhlt *nhlt) { - /* RT5663 Headset codec */ if (nhlt_soc_add_rt5663(nhlt, AUDIO_LINK_SSP1)) printk(BIOS_ERR, "Couldn't add headset codec.\n"); - } void __weak variant_nhlt_oem_overrides(const char **oem_id, diff --git a/src/mainboard/google/fizz/variants/endeavour/board.c b/src/mainboard/google/fizz/variants/endeavour/board.c index 3da8f22..03716c2 100644 --- a/src/mainboard/google/fizz/variants/endeavour/board.c +++ b/src/mainboard/google/fizz/variants/endeavour/board.c @@ -15,5 +15,4 @@ void variant_chip_display_init(void) { - } diff --git a/src/mainboard/google/fizz/variants/karma/nhlt.c b/src/mainboard/google/fizz/variants/karma/nhlt.c index e237d2e..b0f4527 100644 --- a/src/mainboard/google/fizz/variants/karma/nhlt.c +++ b/src/mainboard/google/fizz/variants/karma/nhlt.c @@ -18,7 +18,6 @@ /* MAXIM Smart Amps for left and right speakers. */ if (nhlt_soc_add_max98357(nhlt, AUDIO_LINK_SSP0)) printk(BIOS_ERR, "Couldn't add Maxim_98357 codec.\n"); - } void variant_nhlt_oem_overrides(const char **oem_id, -- To view, visit https://review.coreboot.org/c/coreboot/+/81469?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If35a4b2f6f44a361fdd9e3674572b65f6f196088 Gerrit-Change-Number: 81469 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024