coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: mb/purism: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81488?usp=email ) Change subject: mb/purism: Remove blank lines before '}' and after '{' ...................................................................... mb/purism: Remove blank lines before '}' and after '{' Change-Id: I2285d1bdaa2734658ca1a0cc58ef2294d90d333e Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/purism/librem_cnl/romstage.c M src/mainboard/purism/librem_cnl/variants/librem_14/gpio.c M src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c M src/mainboard/purism/librem_jsl/gpio.h M src/mainboard/purism/librem_l1um_v2/gpio.h 5 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/81488/1 diff --git a/src/mainboard/purism/librem_cnl/romstage.c b/src/mainboard/purism/librem_cnl/romstage.c index 5d92316..e007fd3 100644 --- a/src/mainboard/purism/librem_cnl/romstage.c +++ b/src/mainboard/purism/librem_cnl/romstage.c @@ -12,7 +12,6 @@ FSP_M_CONFIG *mem_cfg = &memupd->FspmConfig; struct cnl_mb_cfg memcfg = { - /* * Rcomp resistor values. These values represent the resistance in * ohms of the three rcomp resistors attached to the DDR_COMP_0, diff --git a/src/mainboard/purism/librem_cnl/variants/librem_14/gpio.c b/src/mainboard/purism/librem_cnl/variants/librem_14/gpio.c index e5c1a6f..0ec3947 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_14/gpio.c +++ b/src/mainboard/purism/librem_cnl/variants/librem_14/gpio.c @@ -4,7 +4,6 @@ /* Pad configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = { - /* ------- GPIO Group GPP_A ------- */ /* GPP_A0 - RCIN# */ diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c b/src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c index 24ed2be..b894bcb 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c @@ -4,7 +4,6 @@ /* Pad configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = { - /* ------- GPIO Group GPP_A ------- */ /* GPP_A0 - RCIN# */ diff --git a/src/mainboard/purism/librem_jsl/gpio.h b/src/mainboard/purism/librem_jsl/gpio.h index 79148ea..5c00f6d 100644 --- a/src/mainboard/purism/librem_jsl/gpio.h +++ b/src/mainboard/purism/librem_jsl/gpio.h @@ -6,7 +6,6 @@ #include <gpio.h> static const struct pad_config gpio_table[] = { - /* ------- GPIO Community 1 ------- */ /* ------- GPIO Group GPP_G ------- */ diff --git a/src/mainboard/purism/librem_l1um_v2/gpio.h b/src/mainboard/purism/librem_l1um_v2/gpio.h index 8325b69..f6a4d0d 100644 --- a/src/mainboard/purism/librem_l1um_v2/gpio.h +++ b/src/mainboard/purism/librem_l1um_v2/gpio.h @@ -25,7 +25,6 @@ /* Pad configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = { - /* ------- GPIO Community 0 ------- */ /* ------- GPIO Group GPP_A ------- */ -- To view, visit https://review.coreboot.org/c/coreboot/+/81488?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2285d1bdaa2734658ca1a0cc58ef2294d90d333e Gerrit-Change-Number: 81488 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: mb/siemens: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81487?usp=email ) Change subject: mb/siemens: Remove blank lines before '}' and after '{' ...................................................................... mb/siemens: Remove blank lines before '}' and after '{' Change-Id: Ibcb3cbb81616fc2449303ae2477daf939cd65fb6 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/siemens/fa_ehl/variants/fa_ehl/gpio.c M src/mainboard/siemens/fa_ehl/variants/fa_ehl/memory.c M src/mainboard/siemens/mc_apl1/variants/mc_apl1/gpio.c M src/mainboard/siemens/mc_apl1/variants/mc_apl2/gpio.c M src/mainboard/siemens/mc_apl1/variants/mc_apl3/gpio.c M src/mainboard/siemens/mc_apl1/variants/mc_apl5/gpio.c M src/mainboard/siemens/mc_apl1/variants/mc_apl6/gpio.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl1/memory.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/gpio.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/memory.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl3/gpio.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl3/memory.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl4/memory.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl5/gpio.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl5/memory.c 15 files changed, 0 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/81487/1 diff --git a/src/mainboard/siemens/fa_ehl/variants/fa_ehl/gpio.c b/src/mainboard/siemens/fa_ehl/variants/fa_ehl/gpio.c index 20a89c6..e54f2aa 100644 --- a/src/mainboard/siemens/fa_ehl/variants/fa_ehl/gpio.c +++ b/src/mainboard/siemens/fa_ehl/variants/fa_ehl/gpio.c @@ -5,7 +5,6 @@ /* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = { - /* Community 0 - GpioGroup GPP_B */ PAD_CFG_NF(GPP_B2, NONE, PLTRST, NF1), /* PMC_VRALERT_N */ PAD_CFG_NF(GPP_B3, NONE, PLTRST, NF4), /* ESPI_ALERT0_N */ diff --git a/src/mainboard/siemens/fa_ehl/variants/fa_ehl/memory.c b/src/mainboard/siemens/fa_ehl/variants/fa_ehl/memory.c index b055c4d..8088857 100644 --- a/src/mainboard/siemens/fa_ehl/variants/fa_ehl/memory.c +++ b/src/mainboard/siemens/fa_ehl/variants/fa_ehl/memory.c @@ -6,7 +6,6 @@ #include <soc/romstage.h> static const struct mb_cfg fa_ehl_lpddr4x_memcfg_cfg = { - .dq_map[DDR_CH0] = { {0xf, 0xf0}, {0xf, 0xf0}, diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/gpio.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/gpio.c index 5cfacb8..4b80c66 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/gpio.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/gpio.c @@ -7,7 +7,6 @@ EDS vol 1, but some pins aren't grouped functionally in the table so those were moved for more logical grouping. */ static const struct pad_config gpio_table[] = { - /* Southwest Community */ /* PCIE_WAKE[0:3]_N */ diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/gpio.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/gpio.c index 78723c2..483a88c 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/gpio.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/gpio.c @@ -7,7 +7,6 @@ EDS vol 1, but some pins aren't grouped functionally in the table so those were moved for more logical grouping. */ static const struct pad_config gpio_table[] = { - /* Southwest Community */ /* EXT_WAKE0_1V8# */ diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/gpio.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/gpio.c index e7b9bd0..cfab8ed 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/gpio.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/gpio.c @@ -7,7 +7,6 @@ EDS vol 1, but some pins aren't grouped functionally in the table so those were moved for more logical grouping. */ static const struct pad_config gpio_table[] = { - /* Southwest Community */ /* PCIE_WAKE[0:3]_N */ diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/gpio.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/gpio.c index 593b2cd..d707b3a 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/gpio.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/gpio.c @@ -7,7 +7,6 @@ EDS vol 1, but some pins aren't grouped functionally in the table so those were moved for more logical grouping. */ static const struct pad_config gpio_table[] = { - /* Southwest Community */ /* PCIE_WAKE[0:3]_N */ diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/gpio.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/gpio.c index 5de6973..f97d1a8 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/gpio.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/gpio.c @@ -7,7 +7,6 @@ EDS vol 1, but some pins aren't grouped functionally in the table so those were moved for more logical grouping. */ static const struct pad_config gpio_table[] = { - /* Southwest Community */ /* PCIE_WAKE[0:3]_N */ diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/memory.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/memory.c index 7b7dad1..a800d30 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/memory.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/memory.c @@ -6,7 +6,6 @@ #include <soc/romstage.h> static const struct mb_cfg mc_ehl_lpddr4x_memcfg_cfg = { - .dq_map[DDR_CH0] = { {0xf, 0xf0}, {0xf, 0xf0}, diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/gpio.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/gpio.c index 20a89c6..e54f2aa 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/gpio.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/gpio.c @@ -5,7 +5,6 @@ /* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = { - /* Community 0 - GpioGroup GPP_B */ PAD_CFG_NF(GPP_B2, NONE, PLTRST, NF1), /* PMC_VRALERT_N */ PAD_CFG_NF(GPP_B3, NONE, PLTRST, NF4), /* ESPI_ALERT0_N */ diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/memory.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/memory.c index 7b7dad1..a800d30 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/memory.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/memory.c @@ -6,7 +6,6 @@ #include <soc/romstage.h> static const struct mb_cfg mc_ehl_lpddr4x_memcfg_cfg = { - .dq_map[DDR_CH0] = { {0xf, 0xf0}, {0xf, 0xf0}, diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/gpio.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/gpio.c index cb7b273..66b7f1d 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/gpio.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/gpio.c @@ -5,7 +5,6 @@ /* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = { - /* Community 0 - GpioGroup GPP_B */ PAD_CFG_NF(GPP_B2, NONE, PLTRST, NF1), /* PMC_VRALERT_N */ PAD_CFG_NF(GPP_B3, NONE, PLTRST, NF4), /* ESPI_ALERT0_N */ diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/memory.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/memory.c index 7b7dad1..a800d30 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/memory.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/memory.c @@ -6,7 +6,6 @@ #include <soc/romstage.h> static const struct mb_cfg mc_ehl_lpddr4x_memcfg_cfg = { - .dq_map[DDR_CH0] = { {0xf, 0xf0}, {0xf, 0xf0}, diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/memory.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/memory.c index f5638d5..a352f7b 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/memory.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/memory.c @@ -6,7 +6,6 @@ #include <soc/romstage.h> static const struct mb_cfg mc_ehl_lpddr4x_memcfg_cfg = { - .dq_map[DDR_CH0] = { {0xf, 0xf0}, {0xf, 0xf0}, diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl5/gpio.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl5/gpio.c index a4ae8a5..a81f88e 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl5/gpio.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl5/gpio.c @@ -5,7 +5,6 @@ /* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = { - /* Community 0 - GpioGroup GPP_B */ PAD_CFG_NF(GPP_B2, NONE, PLTRST, NF1), /* PMC_VRALERT_N */ PAD_CFG_NF(GPP_B3, NONE, PLTRST, NF4), /* ESPI_ALERT0_N */ diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl5/memory.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl5/memory.c index 7b7dad1..a800d30 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl5/memory.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl5/memory.c @@ -6,7 +6,6 @@ #include <soc/romstage.h> static const struct mb_cfg mc_ehl_lpddr4x_memcfg_cfg = { - .dq_map[DDR_CH0] = { {0xf, 0xf0}, {0xf, 0xf0}, -- To view, visit https://review.coreboot.org/c/coreboot/+/81487?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibcb3cbb81616fc2449303ae2477daf939cd65fb6 Gerrit-Change-Number: 81487 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/protectli: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81486?usp=email ) Change subject: mb/protectli: Remove blank lines before '}' and after '{' ...................................................................... mb/protectli: Remove blank lines before '}' and after '{' Change-Id: Ifa0655acda0482bb219145ba149d962e06017d9e Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/protectli/vault_bsw/gpio.c M src/mainboard/protectli/vault_cml/gpio.c M src/mainboard/protectli/vault_ehl/gpio.h 3 files changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/81486/1 diff --git a/src/mainboard/protectli/vault_bsw/gpio.c b/src/mainboard/protectli/vault_bsw/gpio.c index b748799..59e4421 100644 --- a/src/mainboard/protectli/vault_bsw/gpio.c +++ b/src/mainboard/protectli/vault_bsw/gpio.c @@ -232,6 +232,5 @@ struct soc_gpio_config *mainboard_get_gpios(void) { - return &gpio_config; } diff --git a/src/mainboard/protectli/vault_cml/gpio.c b/src/mainboard/protectli/vault_cml/gpio.c index 72faae9..940d3bd 100644 --- a/src/mainboard/protectli/vault_cml/gpio.c +++ b/src/mainboard/protectli/vault_cml/gpio.c @@ -7,7 +7,6 @@ /* Pad configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = { - /* ------- GPIO Community 0 ------- */ /* ------- GPIO Group GPP_A ------- */ diff --git a/src/mainboard/protectli/vault_ehl/gpio.h b/src/mainboard/protectli/vault_ehl/gpio.h index 8aa1224..2f1c2ec 100644 --- a/src/mainboard/protectli/vault_ehl/gpio.h +++ b/src/mainboard/protectli/vault_ehl/gpio.h @@ -15,7 +15,6 @@ /* PAD configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = { - /* ------- GPIO Community 0 ------- */ /* ------- GPIO Group GPP_B ------- */ -- To view, visit https://review.coreboot.org/c/coreboot/+/81486?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa0655acda0482bb219145ba149d962e06017d9e Gerrit-Change-Number: 81486 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/msi: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81485?usp=email ) Change subject: mb/msi: Remove blank lines before '}' and after '{' ...................................................................... mb/msi: Remove blank lines before '}' and after '{' Change-Id: I4a678b433e3e1a492e2a8e679caf75f4741317cb Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/msi/ms7d25/gpio.h M src/mainboard/msi/ms7d25/mainboard.c M src/mainboard/msi/ms7e06/gpio.h M src/mainboard/msi/ms7e06/mainboard.c 4 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/81485/1 diff --git a/src/mainboard/msi/ms7d25/gpio.h b/src/mainboard/msi/ms7d25/gpio.h index 62625c0..02b171a 100644 --- a/src/mainboard/msi/ms7d25/gpio.h +++ b/src/mainboard/msi/ms7d25/gpio.h @@ -4,7 +4,6 @@ /* Pad configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = { - /* ------- GPIO Community 0 ------- */ /* ------- GPIO Group GPP_I ------- */ diff --git a/src/mainboard/msi/ms7d25/mainboard.c b/src/mainboard/msi/ms7d25/mainboard.c index f124449..b346ac7 100644 --- a/src/mainboard/msi/ms7d25/mainboard.c +++ b/src/mainboard/msi/ms7d25/mainboard.c @@ -16,7 +16,6 @@ static void mainboard_init(void *chip_info) { - } u8 smbios_mainboard_feature_flags(void) diff --git a/src/mainboard/msi/ms7e06/gpio.h b/src/mainboard/msi/ms7e06/gpio.h index bf61dcb..413ada8 100644 --- a/src/mainboard/msi/ms7e06/gpio.h +++ b/src/mainboard/msi/ms7e06/gpio.h @@ -4,7 +4,6 @@ /* Pad configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = { - /* ------- GPIO Community 0 ------- */ /* ------- GPIO Group GPP_I ------- */ diff --git a/src/mainboard/msi/ms7e06/mainboard.c b/src/mainboard/msi/ms7e06/mainboard.c index a80b240..2645f07 100644 --- a/src/mainboard/msi/ms7e06/mainboard.c +++ b/src/mainboard/msi/ms7e06/mainboard.c @@ -17,7 +17,6 @@ static void mainboard_init(void *chip_info) { - } u8 smbios_mainboard_feature_flags(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/81485?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a678b433e3e1a492e2a8e679caf75f4741317cb Gerrit-Change-Number: 81485 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/lenovo: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81484?usp=email ) Change subject: mb/lenovo: Remove blank lines before '}' and after '{' ...................................................................... mb/lenovo: Remove blank lines before '}' and after '{' Change-Id: I6ece868184dd772fc2c3c472ae2172d1c34fb179 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/lenovo/m900_tiny/gpio.c M src/mainboard/lenovo/t400/romstage.c M src/mainboard/lenovo/thinkcentre_m710s/gpio.h 3 files changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/81484/1 diff --git a/src/mainboard/lenovo/m900_tiny/gpio.c b/src/mainboard/lenovo/m900_tiny/gpio.c index 65c9cbf..aecea41 100644 --- a/src/mainboard/lenovo/m900_tiny/gpio.c +++ b/src/mainboard/lenovo/m900_tiny/gpio.c @@ -5,7 +5,6 @@ /* Pad configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = { - /* ------- GPIO Community 0 ------- */ /* ------- GPIO Group GPP_A ------- */ diff --git a/src/mainboard/lenovo/t400/romstage.c b/src/mainboard/lenovo/t400/romstage.c index aa3462a..89afaee 100644 --- a/src/mainboard/lenovo/t400/romstage.c +++ b/src/mainboard/lenovo/t400/romstage.c @@ -37,7 +37,6 @@ } else { hybrid_graphics_init(sysinfo); } - } void mb_post_raminit_setup(void) diff --git a/src/mainboard/lenovo/thinkcentre_m710s/gpio.h b/src/mainboard/lenovo/thinkcentre_m710s/gpio.h index fcb1b91..a1acba7 100644 --- a/src/mainboard/lenovo/thinkcentre_m710s/gpio.h +++ b/src/mainboard/lenovo/thinkcentre_m710s/gpio.h @@ -6,7 +6,6 @@ #include <gpio.h> static const struct pad_config gpio_table[] = { - /* ------- GPIO Community 0 ------- */ /* ------- GPIO Group GPP_A ------- */ -- To view, visit https://review.coreboot.org/c/coreboot/+/81484?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6ece868184dd772fc2c3c472ae2172d1c34fb179 Gerrit-Change-Number: 81484 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: mb/intel: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81483?usp=email ) Change subject: mb/intel: Remove blank lines before '}' and after '{' ...................................................................... mb/intel: Remove blank lines before '}' and after '{' Change-Id: I5c713c7a83dfbf1beee1ea6b30e6245dfedc0eb1 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/intel/adlrvp/gpio.c M src/mainboard/intel/coffeelake_rvp/variants/cfl_h/hda_verb.c M src/mainboard/intel/coffeelake_rvp/variants/cfl_s/hda_verb.c M src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c M src/mainboard/intel/kblrvp/ramstage.c M src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h M src/mainboard/intel/kunimitsu/spd/spd_util.c M src/mainboard/intel/mtlrvp/fw_config.c M src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c M src/mainboard/intel/strago/gpio.c M src/mainboard/intel/tglrvp/romstage_fsp_params.c 15 files changed, 0 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/81483/1 diff --git a/src/mainboard/intel/adlrvp/gpio.c b/src/mainboard/intel/adlrvp/gpio.c index 3c43a74..d1ed7c7 100644 --- a/src/mainboard/intel/adlrvp/gpio.c +++ b/src/mainboard/intel/adlrvp/gpio.c @@ -7,7 +7,6 @@ /* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = { - /* GPIO A0-A6, A9-A10 default function is NF1 for eSPI interface when eSPI is enabled */ diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/hda_verb.c b/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/hda_verb.c index cbe8f0b..9c1759d 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/hda_verb.c +++ b/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/hda_verb.c @@ -3,7 +3,6 @@ #include <device/azalia_device.h> const u32 cim_verb_data[] = { - /* * VerbTable: CFL Display Audio Codec * Revision ID = 0xFF diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/hda_verb.c b/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/hda_verb.c index cbe8f0b..9c1759d 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/hda_verb.c +++ b/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/hda_verb.c @@ -3,7 +3,6 @@ #include <device/azalia_device.h> const u32 cim_verb_data[] = { - /* * VerbTable: CFL Display Audio Codec * Revision ID = 0xFF diff --git a/src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c b/src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c index 8a2b8f9..6b9b7ec 100644 --- a/src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c +++ b/src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c @@ -6,7 +6,6 @@ #include <soc/romstage.h> static const struct mb_cfg ehlcrb_lpddr4x_memcfg_cfg = { - .dq_map[DDR_CH0] = { {0xf, 0xf0}, {0xf, 0xf0}, diff --git a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c index eab0fe5..6a3ce3e 100644 --- a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c +++ b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c @@ -7,7 +7,6 @@ /* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = { - /* WWAN_WAKE_N */ PAD_CFG_GPI_SCI(GPP_A10, NONE, DEEP, LEVEL, INVERT), diff --git a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c index bea9cd8..618e74e 100644 --- a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c +++ b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c @@ -8,7 +8,6 @@ #include <soc/romstage.h> static const struct mb_cfg jslrvp_ddr4_memcfg_cfg = { - .dq_map[DDR_CH0] = { {0xf, 0xf0}, {0xf, 0xf0}, @@ -51,7 +50,6 @@ }; static const struct mb_cfg jslrvp_lpddr4_memcfg_cfg = { - .dq_map[DDR_CH0] = { {0xf, 0xf0}, {0xf, 0xf0}, diff --git a/src/mainboard/intel/kblrvp/ramstage.c b/src/mainboard/intel/kblrvp/ramstage.c index feccc08..c182bd7 100644 --- a/src/mainboard/intel/kblrvp/ramstage.c +++ b/src/mainboard/intel/kblrvp/ramstage.c @@ -48,7 +48,6 @@ /* Port 0 Configuration */ i2c_writeb(IO_EXPANDER_BUS, IO_EXPANDER_1_ADDR, IO_EXPANDER_P0CONF, 0x00); - } BOOT_STATE_INIT_ENTRY(BS_POST_DEVICE, BS_ON_EXIT, ioexpander_init, NULL); diff --git a/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h b/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h index 1ec4488..10c8a8f 100644 --- a/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h +++ b/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h @@ -6,7 +6,6 @@ #include <device/azalia_device.h> const u32 cim_verb_data[] = { - 0x8086280B, 0x00000000, 0x00000005, diff --git a/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h b/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h index 8f2188c..6915638 100644 --- a/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h +++ b/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h @@ -6,7 +6,6 @@ #include <device/azalia_device.h> const u32 cim_verb_data[] = { - 0x8086280B, 0x00000000, 0x00000005, diff --git a/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h b/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h index c86ecaf..493b187 100644 --- a/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h +++ b/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h @@ -6,7 +6,6 @@ #include <device/azalia_device.h> const u32 cim_verb_data[] = { - 0x8086280B, 0x00000000, 0x00000005, diff --git a/src/mainboard/intel/kunimitsu/spd/spd_util.c b/src/mainboard/intel/kunimitsu/spd/spd_util.c index 8674512..8c1407a 100644 --- a/src/mainboard/intel/kunimitsu/spd/spd_util.c +++ b/src/mainboard/intel/kunimitsu/spd/spd_util.c @@ -55,7 +55,6 @@ } else { memcpy(rcomp_strength_ptr, RcompTarget, sizeof(RcompTarget)); } - } uintptr_t mainboard_get_spd_data(void) diff --git a/src/mainboard/intel/mtlrvp/fw_config.c b/src/mainboard/intel/mtlrvp/fw_config.c index d874228..eac854c 100644 --- a/src/mainboard/intel/mtlrvp/fw_config.c +++ b/src/mainboard/intel/mtlrvp/fw_config.c @@ -96,6 +96,5 @@ printk(BIOS_INFO, "Configure GPIOs for SoundWire audio (onboard codec).\n"); gpio_configure_pads(sndw_alc711_enable_pads, ARRAY_SIZE(i2s_enable_pads)); } - } BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_ENTRY, fw_config_handle, NULL); diff --git a/src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c b/src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c index ea05b89..459fdd1 100644 --- a/src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c +++ b/src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c @@ -5,7 +5,6 @@ /* Early pad configuration in bootblock */ static const struct pad_config early_gpio_table[] = { - /* UART0 RX */ PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), /* UART0 TX */ diff --git a/src/mainboard/intel/strago/gpio.c b/src/mainboard/intel/strago/gpio.c index 0e7f88c..81db91e 100644 --- a/src/mainboard/intel/strago/gpio.c +++ b/src/mainboard/intel/strago/gpio.c @@ -241,6 +241,5 @@ struct soc_gpio_config *mainboard_get_gpios(void) { - return &gpio_config; } diff --git a/src/mainboard/intel/tglrvp/romstage_fsp_params.c b/src/mainboard/intel/tglrvp/romstage_fsp_params.c index 22859f6..3070569 100644 --- a/src/mainboard/intel/tglrvp/romstage_fsp_params.c +++ b/src/mainboard/intel/tglrvp/romstage_fsp_params.c @@ -48,5 +48,4 @@ bool half_populated = false; memcfg_init(mupd, mem_config, &spd_info, half_populated); - } -- To view, visit https://review.coreboot.org/c/coreboot/+/81483?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5c713c7a83dfbf1beee1ea6b30e6245dfedc0eb1 Gerrit-Change-Number: 81483 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/octopus: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81482?usp=email ) Change subject: mb/google/octopus: Remove blank lines before '}' and after '{' ...................................................................... mb/google/octopus: Remove blank lines before '}' and after '{' Change-Id: If54b24828d02a4937c99e9e791c3cf49e18edd5e Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/octopus/smihandler.c M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c 3 files changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/81482/1 diff --git a/src/mainboard/google/octopus/smihandler.c b/src/mainboard/google/octopus/smihandler.c index 4400342..5d07d5b 100644 --- a/src/mainboard/google/octopus/smihandler.c +++ b/src/mainboard/google/octopus/smihandler.c @@ -62,7 +62,6 @@ void power_off_lte_module(void) { - const struct gpio_with_delay lte_power_off_gpios[] = { { GPIO_161, /* AVS_I2S1_MCLK -- PLT_RST_LTE_L */ diff --git a/src/mainboard/google/octopus/variants/bloog/gpio.c b/src/mainboard/google/octopus/variants/bloog/gpio.c index f77d429..4e09297 100644 --- a/src/mainboard/google/octopus/variants/bloog/gpio.c +++ b/src/mainboard/google/octopus/variants/bloog/gpio.c @@ -5,7 +5,6 @@ #include <gpio.h> static const struct pad_config default_override_table[] = { - PAD_NC(GPIO_50, UP_20K), /* PCH_I2C_PEN_SDA -- unused */ PAD_NC(GPIO_51, UP_20K), /* PCH_I2C_PEN_SCL -- unused */ PAD_NC(GPIO_52, UP_20K), /* PCH_I2C_P_SENSOR_SDA -- unused */ diff --git a/src/mainboard/google/octopus/variants/fleex/gpio.c b/src/mainboard/google/octopus/variants/fleex/gpio.c index 0b561d8..f2e6475 100644 --- a/src/mainboard/google/octopus/variants/fleex/gpio.c +++ b/src/mainboard/google/octopus/variants/fleex/gpio.c @@ -5,7 +5,6 @@ #include <gpio.h> static const struct pad_config default_override_table[] = { - PAD_NC(GPIO_52, UP_20K), PAD_NC(GPIO_53, UP_20K), /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */ -- To view, visit https://review.coreboot.org/c/coreboot/+/81482?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If54b24828d02a4937c99e9e791c3cf49e18edd5e Gerrit-Change-Number: 81482 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: ec/starlabs: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81481?usp=email ) Change subject: ec/starlabs: Remove blank lines before '}' and after '{' ...................................................................... ec/starlabs: Remove blank lines before '}' and after '{' Change-Id: Ia80d6894cf8d20f67fa94bff92de21d917431d27 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/ec/starlabs/merlin/ite.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/81481/1 diff --git a/src/ec/starlabs/merlin/ite.c b/src/ec/starlabs/merlin/ite.c index 8acbbc7..31651d1 100644 --- a/src/ec/starlabs/merlin/ite.c +++ b/src/ec/starlabs/merlin/ite.c @@ -48,7 +48,6 @@ if (CONFIG(EC_STARLABS_MIRROR_SUPPORT) && (CONFIG(DRIVERS_INTEL_USB4_RETIMER) || get_uint_option("mirror_flag", 0)) && (ec_version != CONFIG_EC_STARLABS_MIRROR_VERSION)) { - printk(BIOS_ERR, "ITE: EC version 0x%x doesn't match coreboot version 0x%x.\n", ec_version, CONFIG_EC_STARLABS_MIRROR_VERSION); -- To view, visit https://review.coreboot.org/c/coreboot/+/81481?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia80d6894cf8d20f67fa94bff92de21d917431d27 Gerrit-Change-Number: 81481 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: ec/google/chromeec: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81480?usp=email ) Change subject: ec/google/chromeec: Remove blank lines before '}' and after '{' ...................................................................... ec/google/chromeec: Remove blank lines before '}' and after '{' Change-Id: Id7118cc716d1ad4d7272720f316da1ee65cdc51d Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/ec/google/chromeec/ec_commands.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/81480/1 diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h index b66f9d3..c9daf99 100644 --- a/src/ec/google/chromeec/ec_commands.h +++ b/src/ec/google/chromeec/ec_commands.h @@ -4282,7 +4282,6 @@ }; enum ec_host_event_mask_type { - /* Main host event copy */ EC_HOST_EVENT_MAIN, -- To view, visit https://review.coreboot.org/c/coreboot/+/81480?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id7118cc716d1ad4d7272720f316da1ee65cdc51d Gerrit-Change-Number: 81480 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/gale: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 23 Mar '24

23 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81479?usp=email ) Change subject: mb/google/gale: Remove blank lines before '}' and after '{' ...................................................................... mb/google/gale: Remove blank lines before '}' and after '{' Change-Id: Ic11b2783514b29db1208b668c722151af7ba3f02 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/gale/bootblock.c M src/mainboard/google/gale/verstage.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/81479/1 diff --git a/src/mainboard/google/gale/bootblock.c b/src/mainboard/google/gale/bootblock.c index 343fe65..d900510 100644 --- a/src/mainboard/google/gale/bootblock.c +++ b/src/mainboard/google/gale/bootblock.c @@ -39,7 +39,6 @@ /* Is maskrom parameter address set to a sensible value? */ if ((maskrom_param->start_magic != UBER_SBL_SHARED_INFO_START_MAGIC) || (maskrom_param->end_magic != UBER_SBL_SHARED_INFO_END_MAGIC)) { - printk(BIOS_INFO, "Uber-sbl: invalid magic!\n"); } else { printk(BIOS_INFO, "Uber-sbl version: %s\n", diff --git a/src/mainboard/google/gale/verstage.c b/src/mainboard/google/gale/verstage.c index 6dfc230..68a4aa4 100644 --- a/src/mainboard/google/gale/verstage.c +++ b/src/mainboard/google/gale/verstage.c @@ -8,7 +8,6 @@ static void ipq_setup_tpm(void) { - if (CONFIG(I2C_TPM)) { gpio_tlmm_config_set(TPM_RESET_GPIO, FUNC_SEL_GPIO, GPIO_PULL_UP, GPIO_6MA, 1); -- To view, visit https://review.coreboot.org/c/coreboot/+/81479?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic11b2783514b29db1208b668c722151af7ba3f02 Gerrit-Change-Number: 81479 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024