Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth.
Hello Angel Pons, Daniel Maslowski, Felix Singer, Jason Glenesk, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73158?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: Docs: Replace Recommonmark with MyST Parser
......................................................................
Docs: Replace Recommonmark with MyST Parser
Recommonmark has been deprecated since 2021 [1] and the last release was
over 3 years ago [2]. As per their announcement, Markedly Structured
Text (MyST) Parser [3] is the recommended replacement.
For the most part, the existing documentation is compatible with MyST,
as both parsers are built around the CommonMark flavor of Markdown. The
main difference that affects coreboot is how the Sphinx toctree is
generated. Recommonmark has a feature called auto_toc_tree, which
converts single level lists of references into a toctree:
* [Part 1: Starting from scratch](part1.md)
* [Part 2: Submitting a patch to coreboot.org](part2.md)
* [Part 3: Writing unit tests](part3.md)
* [Managing local additions](managing_local_additions.md)
* [Flashing firmware](flashing_firmware/index.md)
MyST Parser does not provide a replacement for this feature, meaning the
toctree must be defined manually. This is done using MyST's syntax for
Sphinx directives:
```{toctree}
:maxdepth: 1
Part 1: Starting from scratch <part1.md>
Part 2: Submitting a patch to coreboot.org <part2.md>
Part 3: Writing unit tests <part3.md>
Managing local additions <managing_local_additions.md>
Flashing firmware <flashing_firmware/index.md>
```
Internally, auto_toc_tree essentially converts lists of references into
the Sphinx toctree structure that the MyST syntax above more directly
represents.
The toctrees were converted to the MyST syntax using the following
command and Python script:
`find ./ -iname "*.md" | xargs -n 1 python conv_toctree.py`
```
import re
import sys
in_list = False
f = open(sys.argv[1])
lines = f.readlines()
f.close()
with open(sys.argv[1], "w") as f:
for line in lines:
match = re.match(r"^[-*+] \[(.*)\]\((.*)\)$", line)
if match is not None:
if not in_list:
in_list = True
f.write("```{toctree}\n")
f.write(":maxdepth: 1\n\n")
f.write(match.group(1) + " <" + match.group(2) + ">\n")
else:
if in_list:
f.write("```\n")
f.write(line)
in_list = False
if in_list:
f.write("```\n")
```
While this does add a little more work for creating the toctree, this
does give more control over exactly what goes into the toctree. For
instance, lists of links to external resources currently end up in the
toctree, but we may want to limit it to pages within coreboot.
This change does break rendering and navigation of the documentation in
applications that can render Markdown, such as Okular, Gitiles, or the
GitHub mirror. Assuming the docs are mainly intended to be viewed after
being rendered to doc.coreboot.org, this is probably not an issue in
practice.
Another difference is that MyST natively supports Markdown tables,
whereas with Recommonmark, tables had to be written in embedded rST [6].
However, MyST also supports embedded rST, so the existing tables can be
easily converted as the syntax is nearly identical.
These were converted using
`find ./ -iname "*.md" | xargs -n 1 sed -i "s/eval_rst/{eval-rst}/"`
Makefile.sphinx and conf.py were regenerated from scratch by running
`sphinx-quickstart` using the updated version of Sphinx, which removes a
lot of old commented out boilerplate. Any relevant changes coreboot had
made on top of the previous autogenerated versions of these files were
ported over to the newly generated file.
From some initial testing the generated webpages appear and function
identically to the existing documentation built with Recommonmark.
[1] https://github.com/readthedocs/recommonmark/issues/221
[2] https://pypi.org/project/recommonmark/
[3] https://myst-parser.readthedocs.io/en/latest/
[4] https://doc.coreboot.org/getting_started/writing_documentation.html
Change-Id: I0837c1722fa56d25c9441ea218e943d8f3d9b804
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M Documentation/Makefile.sphinx
M Documentation/acpi/index.md
M Documentation/acronyms.md
M Documentation/arch/index.md
M Documentation/arch/x86/index.md
M Documentation/community/index.md
M Documentation/conf.py
M Documentation/contributing/index.md
M Documentation/drivers/index.md
M Documentation/drivers/smmstore.md
M Documentation/drivers/smmstorev2.md
M Documentation/external_docs.md
M Documentation/getting_started/build_system.md
M Documentation/getting_started/gpio.md
M Documentation/getting_started/index.md
M Documentation/getting_started/kconfig.md
M Documentation/gfx/display-panel.md
M Documentation/index.md
M Documentation/infrastructure/builders.md
M Documentation/infrastructure/index.md
M Documentation/lib/index.md
M Documentation/lib/payloads/index.md
M Documentation/mainboard/acer/g43t-am3.md
M Documentation/mainboard/amd/pademelon/pademelon.md
M Documentation/mainboard/asrock/h110m-dvs.md
M Documentation/mainboard/asrock/h77pro4-m.md
M Documentation/mainboard/asrock/h81m-hds.md
M Documentation/mainboard/asus/a88xm-e.md
M Documentation/mainboard/asus/f2a85-m.md
M Documentation/mainboard/asus/p2b-ls.md
M Documentation/mainboard/asus/p3b-f.md
M Documentation/mainboard/asus/p5q.md
M Documentation/mainboard/asus/p8c_ws.md
M Documentation/mainboard/asus/p8h61-m_lx.md
M Documentation/mainboard/asus/p8h61-m_pro.md
M Documentation/mainboard/asus/p8h77-v.md
M Documentation/mainboard/asus/p8z77-m.md
M Documentation/mainboard/asus/p8z77-m_pro.md
M Documentation/mainboard/asus/p8z77-v.md
M Documentation/mainboard/asus/wifigo_v1.md
M Documentation/mainboard/cavium/cn8100_sff_evb.md
M Documentation/mainboard/clevo/n130wu/index.md
M Documentation/mainboard/dell/optiplex_9010.md
M Documentation/mainboard/facebook/fbg1701.md
M Documentation/mainboard/facebook/monolith.md
M Documentation/mainboard/foxconn/d41s.md
M Documentation/mainboard/gigabyte/ga-g41m-es2l.md
M Documentation/mainboard/gigabyte/ga-h61m-s2pv.md
M Documentation/mainboard/hp/2170p.md
M Documentation/mainboard/hp/2560p.md
M Documentation/mainboard/hp/8760w.md
M Documentation/mainboard/hp/compaq_8200_sff.md
M Documentation/mainboard/hp/compaq_8300_usdt.md
M Documentation/mainboard/hp/elitebook_820_g2.md
M Documentation/mainboard/hp/folio_9480m.md
M Documentation/mainboard/hp/z220_sff.md
M Documentation/mainboard/index.md
M Documentation/mainboard/intel/dg43gt.md
M Documentation/mainboard/intel/dq67sw.md
M Documentation/mainboard/intel/kblrvp11.md
M Documentation/mainboard/kontron/mal10.md
M Documentation/mainboard/lenovo/Ivy_Bridge_series.md
M Documentation/mainboard/lenovo/Sandy_Bridge_series.md
M Documentation/mainboard/lenovo/codenames.md
M Documentation/mainboard/lenovo/ivb_internal_flashing.md
M Documentation/mainboard/lenovo/montevina_series.md
M Documentation/mainboard/lenovo/t410.md
M Documentation/mainboard/libretrend/lt1000.md
M Documentation/mainboard/msi/ms7707/ms7707.md
M Documentation/mainboard/ocp/deltalake.md
M Documentation/mainboard/ocp/tiogapass.md
M Documentation/mainboard/opencellular/elgon.md
M Documentation/mainboard/pcengines/apu1.md
M Documentation/mainboard/pcengines/apu2.md
M Documentation/mainboard/portwell/pq7-m107.md
M Documentation/mainboard/prodrive/hermes.md
M Documentation/mainboard/protectli/fw2b_fw4b.md
M Documentation/mainboard/protectli/fw6.md
M Documentation/mainboard/protectli/vp2420.md
M Documentation/mainboard/protectli/vp46xx.md
M Documentation/mainboard/purism/librem_14.md
M Documentation/mainboard/purism/librem_mini.md
M Documentation/mainboard/starlabs/labtop_cml.md
M Documentation/mainboard/starlabs/labtop_kbl.md
M Documentation/mainboard/starlabs/lite_glk.md
M Documentation/mainboard/starlabs/lite_glkr.md
M Documentation/mainboard/starlabs/starbook_adl.md
M Documentation/mainboard/starlabs/starbook_tgl.md
M Documentation/mainboard/supermicro/x10slm-f.md
M Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md
M Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-f.md
M Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md
M Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-f.md
M Documentation/mainboard/supermicro/x11-lga1151-series/x11ssw-f/x11ssw-f.md
M Documentation/mainboard/supermicro/x9sae.md
M Documentation/mainboard/system76/addw1.md
M Documentation/mainboard/system76/addw2.md
M Documentation/mainboard/system76/addw3.md
M Documentation/mainboard/system76/bonw14.md
M Documentation/mainboard/system76/bonw15.md
M Documentation/mainboard/system76/darp6.md
M Documentation/mainboard/system76/darp7.md
M Documentation/mainboard/system76/darp8.md
M Documentation/mainboard/system76/darp9.md
M Documentation/mainboard/system76/galp4.md
M Documentation/mainboard/system76/galp5.md
M Documentation/mainboard/system76/galp6.md
M Documentation/mainboard/system76/galp7.md
M Documentation/mainboard/system76/gaze15.md
M Documentation/mainboard/system76/gaze16.md
M Documentation/mainboard/system76/gaze17.md
M Documentation/mainboard/system76/gaze18.md
M Documentation/mainboard/system76/lemp10.md
M Documentation/mainboard/system76/lemp11.md
M Documentation/mainboard/system76/lemp12.md
M Documentation/mainboard/system76/lemp9.md
M Documentation/mainboard/system76/oryp10.md
M Documentation/mainboard/system76/oryp11.md
M Documentation/mainboard/system76/oryp5.md
M Documentation/mainboard/system76/oryp6.md
M Documentation/mainboard/system76/oryp7.md
M Documentation/mainboard/system76/oryp8.md
M Documentation/mainboard/system76/oryp9.md
M Documentation/mainboard/system76/serw13.md
M Documentation/mainboard/ti/beaglebone-black.md
M Documentation/mainboard/up/squared/index.md
M Documentation/northbridge/index.md
M Documentation/northbridge/intel/haswell/index.md
M Documentation/northbridge/intel/haswell/known-issues.md
M Documentation/northbridge/intel/index.md
M Documentation/northbridge/intel/sandybridge/index.md
M Documentation/northbridge/intel/sandybridge/nri.md
M Documentation/northbridge/intel/sandybridge/nri_features.md
M Documentation/northbridge/intel/sandybridge/nri_freq.md
M Documentation/northbridge/intel/sandybridge/nri_read.md
M Documentation/northbridge/intel/sandybridge/nri_registers.md
M Documentation/releases/boards_supported_on_branches.md
M Documentation/releases/checklist.md
M Documentation/releases/coreboot-4.17-relnotes.md
M Documentation/releases/coreboot-4.19-relnotes.md
M Documentation/releases/coreboot-4.20.1-relnotes.md
M Documentation/releases/coreboot-4.21-relnotes.md
M Documentation/releases/coreboot-4.22-relnotes.md
M Documentation/releases/index.md
M Documentation/releases/templates.md
M Documentation/security/index.md
M Documentation/security/memory_clearing.md
M Documentation/security/vboot/index.md
M Documentation/soc/amd/index.md
M Documentation/soc/amd/psp_integration.md
M Documentation/soc/cavium/cn81xx/index.md
M Documentation/soc/cavium/index.md
M Documentation/soc/index.md
M Documentation/soc/intel/broadwell/index.md
M Documentation/soc/intel/code_development_model/code_development_model.md
M Documentation/soc/intel/fit.md
M Documentation/soc/intel/fsp/index.md
M Documentation/soc/intel/fsp/ppi/mp_service_ppi.md
M Documentation/soc/intel/fsp/ppi/ppi.md
M Documentation/soc/intel/index.md
M Documentation/soc/intel/mp_init/mp_init.md
M Documentation/soc/intel/xeon_sp/index.md
M Documentation/soc/qualcomm/index.md
M Documentation/superio/index.md
M Documentation/superio/nuvoton/npcd378.md
M Documentation/technotes/asan.md
M Documentation/technotes/console.md
M Documentation/technotes/index.md
M Documentation/tutorial/flashing_firmware/index.md
M Documentation/tutorial/index.md
M Documentation/tutorial/part3.md
M Documentation/util.md
M Documentation/util/cbfstool/index.md
M Documentation/util/ifdtool/index.md
M Documentation/util/ifdtool/layout.md
M Documentation/vendorcode/cavium/index.md
M Documentation/vendorcode/eltan/index.md
M Documentation/vendorcode/index.md
178 files changed, 1,259 insertions(+), 1,019 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/73158/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/73158?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0837c1722fa56d25c9441ea218e943d8f3d9b804
Gerrit-Change-Number: 73158
Gerrit-PatchSet: 9
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Martin L Roth.
Hello Felix Singer, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80312?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/docker: Update Dockerfiles for building documentation
......................................................................
util/docker: Update Dockerfiles for building documentation
Update all pip packages related to coreboot's documentation to their
latest available version, and update the doc.coreboot.org base image
to Alpine 3.19.1. Add myst-parser in preparation to switch from
Recommonmark to MyST Parser.
TEST: The documentation builds and renders properly when built using
the updated container.
Change-Id: I8df4aadabc49c0201a836333745fe138184595ac
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/docker/coreboot-jenkins-node/Dockerfile
M util/docker/doc.coreboot.org/Dockerfile
2 files changed, 10 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/80312/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80312?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8df4aadabc49c0201a836333745fe138184595ac
Gerrit-Change-Number: 80312
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80702?usp=email )
Change subject: vc/amd/opensil/genoa_poc/mpio/chip: fix typo in pcie_aspm enum name
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80702?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I60ac259d2aa0bd500063a5c841ba33e576e022f7
Gerrit-Change-Number: 80702
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 22 Feb 2024 17:10:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80699?usp=email )
Change subject: soc/amd/glinda: Use gpp_clk_setup_common function
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80699/comment/73a763ba_432310ba :
PS2, Line 9: I7d7da4bfe07
> this should be the 12 first digits of the commit hash (0452d0939e7d) and not of the change id
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80699?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0c1cda0d36de48c7f7315a1b8203b0e53f63f75
Gerrit-Change-Number: 80699
Gerrit-PatchSet: 3
Gerrit-Owner: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 22 Feb 2024 15:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Varshit Pandya.
Hello Anand Vaikar, Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80699?usp=email
to look at the new patch set (#3).
Change subject: soc/amd/glinda: Use gpp_clk_setup_common function
......................................................................
soc/amd/glinda: Use gpp_clk_setup_common function
In follow up to commit 0452d0939e7d ("soc/amd: Factor out gpp_clk_setup function") use gpp_clk_setup_common for glinda as well.
Change-Id: If0c1cda0d36de48c7f7315a1b8203b0e53f63f75
Signed-off-by: Varshit Pandya <pandyavarshit(a)gmail.com>
---
M src/soc/amd/glinda/Kconfig
M src/soc/amd/glinda/fch.c
M src/soc/amd/glinda/include/soc/southbridge.h
3 files changed, 2 insertions(+), 53 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/80699/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80699?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0c1cda0d36de48c7f7315a1b8203b0e53f63f75
Gerrit-Change-Number: 80699
Gerrit-PatchSet: 3
Gerrit-Owner: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Felix Held, Jincheng Li, Johnny Lin, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80632?usp=email )
Change subject: soc/intel/xeon_sp: Add memory type check utils
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/xeon_sp/util.c:
https://review.coreboot.org/c/coreboot/+/80632/comment/5b87f34f_b6608c9e :
PS3, Line 126: __weak bool is_memtype_processor_attached(UINT16 mem_type)
: {
: return true;
: }
:
Using a static inline for platforms where it's always true should result in better optimized code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80632?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f5f3c0f16dc50bc739146e46afce2e5fbf4f62c
Gerrit-Change-Number: 80632
Gerrit-PatchSet: 3
Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 22 Feb 2024 15:08:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment