Attention is currently required from: Yu-Ping Wu.
Hello Yu-Ping Wu,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/coreboot/+/80709?usp=email
to review the following change.
Change subject: Update vboot submodule to upstream main
......................................................................
Update vboot submodule to upstream main
Updating from commit id 3d37d2aa:
2024-01-15 06:21:04 +0000 - (Makefile: Support FIRMWARE_ARCH=mock for firmware unit tests)
to commit id 00e8c2d8:
2024-02-06 tests: Run hwcrypto RSA tests for arm64
This brings in 25 new commits:
00e8c2d8 tests: Run hwcrypto RSA tests for arm64
d3387824 firmware: Add vectorized modexp() implementation for arm64 (NEON)
8856e04b tests: Stop exporting ENABLE_HWCRYPTO_RSA_TESTS to test scripts
6abd9cc0 Makefile: Separate ${ARCH_DIR}, split arm/arm64, remove symlinks
e7f567d1 test_update: Skip ifdtool-dependent tests when not available
1a0f8df8 libvboot_host: Check for undefined symbols
c0806280 vboot_host: Expose dynamic library
2ff5784d vboot: Remove 2kernel.c from vboot_host library
6e472468 Add crdyshim keygen script and devkeys
8a711468 scripts/keygeneration: Move generate_ed25519_key to common.sh
57e2092d scripts/image_signing: Call futility instead of its symlinks
0fa2ea47 scripts/image_signing/make_dev_ssh.sh: Improve parameter removal
1d32db3b Makefile: Remove genfuzztestcases from runtestscripts prerequisites
f6ff822b README: Add 'futility sign' and 'futility verify' to useful utilities
a717c83d tests: Replace vbutil_{firmware,kernel} with 'futility sign'
94c82417 *.sh: Unify indentation with 2 spaces
23d25957 utility/dev_debug_vboot: Replace vbutil_firmware with 'futility verify'
fd20901f cgpt/futility: bundle as a subtool
dccc5a31 image_signing: Add support for signing Flexor kernel image
660b6675 futility/cmd_show: Add "::verified" summary to vblock parseable output
2fcff1e4 tests/*.sh: Replace vbutil_firmware with 'futility verify'
c6b13823 make_dev_firmware.sh: Replace vbutil_firmware with 'futility show'
d260d094 firmware: 2modpow_sse2: Clean up calculation of `mu`
2596679a Add -Wint-conversion and -Wincompatible-function-pointer-types
39fb6201 futility: update: Use ifdtool to unlock ME
f8016c2b make_keyblock: change to parsing key prefix
Change-Id: Ibc6daef30092b1b31f3dd08f3aed02ba31fd12d2
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
---
M 3rdparty/vboot
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/80709/1
diff --git a/3rdparty/vboot b/3rdparty/vboot
index 3d37d2a..00e8c2d 160000
--- a/3rdparty/vboot
+++ b/3rdparty/vboot
@@ -1 +1 @@
-Subproject commit 3d37d2aafe1f941c532def2a1fbbb58c8dd84182
+Subproject commit 00e8c2d842392f060330b848d2ae89064f0640ef
--
To view, visit https://review.coreboot.org/c/coreboot/+/80709?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibc6daef30092b1b31f3dd08f3aed02ba31fd12d2
Gerrit-Change-Number: 80709
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newchange
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/blobs/+/77130?usp=email )
Change subject: mb/starlabs/starbook/adl: Update EC firmware to 1.16
......................................................................
Abandoned
Superseded
--
To view, visit https://review.coreboot.org/c/blobs/+/77130?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I7f2dd794a4fb608e5315fc544f1edaca1961f727
Gerrit-Change-Number: 77130
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: abandon
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/blobs/+/77129?usp=email )
Change subject: mb/starlabs/starbook/rpl: Add EC firmware 1.16
......................................................................
Abandoned
Superseded
--
To view, visit https://review.coreboot.org/c/blobs/+/77129?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I7308c5759fedd539910102042bc47ae3e5262f54
Gerrit-Change-Number: 77129
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-MessageType: abandon
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/blobs/+/77131?usp=email )
Change subject: mb/starlabs/starbook/tgl: Update the EC firmware to 1.16
......................................................................
Abandoned
Superseded
--
To view, visit https://review.coreboot.org/c/blobs/+/77131?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I0e5e2ddb1912e2ed5b53442b46fa1ca0830208d8
Gerrit-Change-Number: 77131
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: abandon
Sean Rhodes has uploaded a new patch set (#5). ( https://review.coreboot.org/c/coreboot/+/80705?usp=email )
Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
......................................................................
mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
Tested using `edk2` from
`github.com/starlabsltd/edk2/tree/uefipayload_vs`:
* Windows 11
* Ubuntu 22.04
* Manjaro 22
No known issues.
https://starlabs.systems/pages/byte-specification
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
---
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/byte_adl.md
M src/ec/starlabs/merlin/acpi/battery.asl
A src/mainboard/starlabs/byte_adl/Kconfig
A src/mainboard/starlabs/byte_adl/Kconfig.name
A src/mainboard/starlabs/byte_adl/Makefile.inc
A src/mainboard/starlabs/byte_adl/acpi/ec.asl
A src/mainboard/starlabs/byte_adl/acpi/mainboard.asl
A src/mainboard/starlabs/byte_adl/acpi/sleep.asl
A src/mainboard/starlabs/byte_adl/acpi/superio.asl
A src/mainboard/starlabs/byte_adl/board_info.txt
A src/mainboard/starlabs/byte_adl/bootblock.c
A src/mainboard/starlabs/byte_adl/cmos.default
A src/mainboard/starlabs/byte_adl/cmos.layout
A src/mainboard/starlabs/byte_adl/dsdt.asl
A src/mainboard/starlabs/byte_adl/hda_verb.c
A src/mainboard/starlabs/byte_adl/include/variants.h
A src/mainboard/starlabs/byte_adl/mainboard.c
A src/mainboard/starlabs/byte_adl/smbios.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.inc
A src/mainboard/starlabs/byte_adl/variants/mk_ii/board.fmd
A src/mainboard/starlabs/byte_adl/variants/mk_ii/data.vbt
A src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb
A src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/hda_verb.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/romstage.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/vboot.fmd
A src/mainboard/starlabs/byte_adl/vboot.c
29 files changed, 1,363 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/80705/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
Gerrit-Change-Number: 80705
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Sean Rhodes has uploaded a new patch set (#4). ( https://review.coreboot.org/c/coreboot/+/80705?usp=email )
Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
......................................................................
mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
Tested using `edk2` from
`github.com/starlabsltd/edk2/tree/uefipayload_vs`:
* Windows 11
* Ubuntu 22.04
* Manjaro 22
No known issues.
https://starlabs.systems/pages/byte-specification
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
---
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/byte_adl.md
M src/ec/starlabs/merlin/acpi/battery.asl
A src/mainboard/starlabs/byte_adl/Kconfig
A src/mainboard/starlabs/byte_adl/Kconfig.name
A src/mainboard/starlabs/byte_adl/Makefile.inc
A src/mainboard/starlabs/byte_adl/acpi/ec.asl
A src/mainboard/starlabs/byte_adl/acpi/mainboard.asl
A src/mainboard/starlabs/byte_adl/acpi/sleep.asl
A src/mainboard/starlabs/byte_adl/acpi/superio.asl
A src/mainboard/starlabs/byte_adl/board_info.txt
A src/mainboard/starlabs/byte_adl/bootblock.c
A src/mainboard/starlabs/byte_adl/cmos.default
A src/mainboard/starlabs/byte_adl/cmos.layout
A src/mainboard/starlabs/byte_adl/dsdt.asl
A src/mainboard/starlabs/byte_adl/hda_verb.c
A src/mainboard/starlabs/byte_adl/include/variants.h
A src/mainboard/starlabs/byte_adl/mainboard.c
A src/mainboard/starlabs/byte_adl/smbios.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.inc
A src/mainboard/starlabs/byte_adl/variants/mk_ii/board.fmd
A src/mainboard/starlabs/byte_adl/variants/mk_ii/data.vbt
A src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb
A src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/hda_verb.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/romstage.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/vboot.fmd
A src/mainboard/starlabs/byte_adl/vboot.c
29 files changed, 1,363 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/80705/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
Gerrit-Change-Number: 80705
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Sean Rhodes has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/80705?usp=email )
Change subject: mb/starlabs/byte_adl: Add AByte Mk II
......................................................................
mb/starlabs/byte_adl: Add AByte Mk II
Tested using `edk2` from
`github.com/starlabsltd/edk2/tree/uefipayload_vs`:
* Windows 11
* Ubuntu 22.04
* Manjaro 22
No known issues.
https://starlabs.systems/pages/byte-specification
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
---
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/byte_adl.md
M src/ec/starlabs/merlin/acpi/battery.asl
A src/mainboard/starlabs/byte_adl/Kconfig
A src/mainboard/starlabs/byte_adl/Kconfig.name
A src/mainboard/starlabs/byte_adl/Makefile.inc
A src/mainboard/starlabs/byte_adl/acpi/ec.asl
A src/mainboard/starlabs/byte_adl/acpi/mainboard.asl
A src/mainboard/starlabs/byte_adl/acpi/sleep.asl
A src/mainboard/starlabs/byte_adl/acpi/superio.asl
A src/mainboard/starlabs/byte_adl/board_info.txt
A src/mainboard/starlabs/byte_adl/bootblock.c
A src/mainboard/starlabs/byte_adl/cmos.default
A src/mainboard/starlabs/byte_adl/cmos.layout
A src/mainboard/starlabs/byte_adl/dsdt.asl
A src/mainboard/starlabs/byte_adl/hda_verb.c
A src/mainboard/starlabs/byte_adl/include/variants.h
A src/mainboard/starlabs/byte_adl/mainboard.c
A src/mainboard/starlabs/byte_adl/smbios.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.inc
A src/mainboard/starlabs/byte_adl/variants/mk_ii/board.fmd
A src/mainboard/starlabs/byte_adl/variants/mk_ii/data.vbt
A src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb
A src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/hda_verb.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/romstage.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/vboot.fmd
A src/mainboard/starlabs/byte_adl/vboot.c
29 files changed, 1,363 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/80705/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
Gerrit-Change-Number: 80705
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80705?usp=email )
Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II Tested using `edk2` from `github.com/starlabsltd/edk2/tree/uefipayload_vs`: * Windows 11 * Ubuntu 22.04 * Manjaro 22
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
Gerrit-Change-Number: 80705
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 22 Feb 2024 20:12:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80700?usp=email )
Change subject: soc/amd/common/acp: use clrsetbits32p to avoid need for casts
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80700?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic29bf04866a7e1d5c831422f31803a724a41069b
Gerrit-Change-Number: 80700
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 22 Feb 2024 20:08:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Shuo Liu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80683?usp=email )
Change subject: soc/intel/xeon_sp: Refactor IOAT compiler optimization outs
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80683/comment/3f0b25b5_1b452cb1 :
PS3, Line 16: TEST=intel/archercity CRB
Is there a size and/or run-time difference? Please document that.
File src/soc/intel/xeon_sp/uncore_acpi.c:
https://review.coreboot.org/c/coreboot/+/80683/comment/b0504908_bd46208b :
PS3, Line 339: if (CONFIG(HAVE_IOAT_DOMAINS) && is_ioat_iio_stack_res(ri)) {
Is that pattern common in coreboot?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80683?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2d16c6ff5320bc9195a1033b6d55e3d997b19b88
Gerrit-Change-Number: 80683
Gerrit-PatchSet: 3
Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Comment-Date: Thu, 22 Feb 2024 19:14:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment