coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3067 discussions

[M] Change in coreboot[main]: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection
by Gwendal Grignou (Code Review) 27 Feb '24

27 Feb '24

Attention is currently required from: Paul Menzel, Paz Zcharya, Subrata Banik. Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80738?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection ...................................................................... Patch Set 7: (3 comments) File src/vendorcode/google/chromeos/tpm_factory_config.c: https://review.coreboot.org/c/coreboot/+/80738/comment/5f8a6855_968b9cfa : PS7, Line 49: * - Bits 3-0 (0x1): Must be 0x1 to signify compliance with Chromebook-Plus > > Not true: this field contains the "feature_level" that indicate the chromebook plus generation. […] To be future-proof, the test on line 61 should be `return factory_config & CHROMEBOOK_PLUS_DEVICE;` https://review.coreboot.org/c/coreboot/+/80738/comment/8b4cb17a_a1e66168 : PS7, Line 74: * requirement. > > Not true. […] I assume the design doc is at `go/cros-tiering-dd`. If this CL only applies to new chromebook that have identification in their GSC where `chassis_x_branded` and `hw_x_compliance_version` are properly set, then we don't need to read the VPD at all. Per design [see section `OS Runtime flow`], all the information we need in the GSC. https://review.coreboot.org/c/coreboot/+/80738/comment/1274f52e_2f4b0617 : PS7, Line 104: return strncmp(vpd_get_feature_device_info(), "CAI", 3) == 0; > > This is not acceptable for production code. "CAI" is not defined anywhere in the code base. […] The previous comment states "all older devices will have legacy config", so we don't need the non-GSC bit parsing logic, do we? -- To view, visit https://review.coreboot.org/c/coreboot/+/80738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Gerrit-Change-Number: 80738 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 27 Feb 2024 19:33:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: payloads/LinuxBoot: Deal with both binary and source devicetree
by Arthur Heymans (Code Review) 27 Feb '24

27 Feb '24

Attention is currently required from: Angel Pons, Christian Walter, Martin L Roth, Maximilian Brune, Patrick Rudolph, Stefan Reinauer. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78645?usp=email ) Change subject: payloads/LinuxBoot: Deal with both binary and source devicetree ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Does that mean it would work even without this change? ye -- To view, visit https://review.coreboot.org/c/coreboot/+/78645?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I04455d88f92b5f3f2aae7ac13aee98a6467d5258 Gerrit-Change-Number: 78645 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 27 Feb 2024 19:24:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: lib: Explicitly declare heap as NOLOAD
by Julius Werner (Code Review) 27 Feb '24

27 Feb '24

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80735?usp=email ) Change subject: lib: Explicitly declare heap as NOLOAD ...................................................................... Patch Set 5: (1 comment) File src/lib/program.ld: https://review.coreboot.org/c/coreboot/+/80735/comment/ab45cdf7_2bbbe4b9 : PS4, Line 120: .bss . : { > > I mean, Max is right: the BSS should also have the NOLOAD flag. […] Yes. LOAD means that bytes are loaded from the file into memory for this section. ALLOC means that this section has an area of memory allocated for it. For sections that are ALLOC but not LOAD, their memory area is implicitly zeroed (I don't think you can turn the zeroing part off, because ELF was designed for userspace programs and in that context the kernel cannot give you "uninitialized" memory anyway because it's not allowed to risk leaking data from other programs). -- To view, visit https://review.coreboot.org/c/coreboot/+/80735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ca7221d10f144f608823e0b9624533780fbf335 Gerrit-Change-Number: 80735 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Tue, 27 Feb 2024 19:24:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: payloads/LinuxBoot: Deal with both binary and source devicetree
by Maximilian Brune (Code Review) 27 Feb '24

27 Feb '24

Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, Martin L Roth, Patrick Rudolph, Stefan Reinauer. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78645?usp=email ) Change subject: payloads/LinuxBoot: Deal with both binary and source devicetree ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > It looks like dtc is happy even with a dtb as input to output a dtb again Does that mean it would work even without this change? -- To view, visit https://review.coreboot.org/c/coreboot/+/78645?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I04455d88f92b5f3f2aae7ac13aee98a6467d5258 Gerrit-Change-Number: 78645 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 27 Feb 2024 19:16:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: payloads/LinuxBoot: Build the linux kernel with -j $(CPUS)
by Maximilian Brune (Code Review) 27 Feb '24

27 Feb '24

Attention is currently required from: Arthur Heymans, Christian Walter, Martin L Roth, Stefan Reinauer. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78644?usp=email ) Change subject: payloads/LinuxBoot: Build the linux kernel with -j $(CPUS) ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78644?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie7af5aef4560b8d4dd840d9c578f8a2a4c387400 Gerrit-Change-Number: 78644 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 27 Feb 2024 19:13:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection
by Subrata Banik (Code Review) 27 Feb '24

27 Feb '24

1 0

[M] Change in coreboot[main]: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection
by Subrata Banik (Code Review) 27 Feb '24

27 Feb '24

Attention is currently required from: Gwendal Grignou, Paul Menzel, Paz Zcharya. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80738?usp=email ) Change subject: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection ...................................................................... Patch Set 7: (4 comments) File src/vendorcode/google/chromeos/tpm_factory_config.c: https://review.coreboot.org/c/coreboot/+/80738/comment/a8538106_347b0be1 : PS7, Line 49: * - Bits 3-0 (0x1): Must be 0x1 to signify compliance with Chromebook-Plus > Not true: this field contains the "feature_level" that indicate the chromebook plus generation. Today, 0 means unknown (may be soft-branded or not chromebook plus), 1 **and above** means chromebook plus. > > See go/cros-tiering-dd. The field name for [bit 0-3] is `hw_x_compliance_version`. I'm using that as a reference ``` hw_x_compliance_version Values: 0x0 : Not CBX compliant 0x1 : Compliant with CBX v1 other: invalid ``` I don't follow what is missing here ? marking it resolved unless u see something needs to be done. https://review.coreboot.org/c/coreboot/+/80738/comment/89071c0a_d89384a3 : PS7, Line 74: * requirement. > Not true. A soft branded CBX (crota for instance) will not have any bit set in its GSC but be a CBX (soft branded) device (unless is it re-manufactured). See a crota360, soft branded: > > ``` > crossystem hwid > CROTA360-QYFB D5B-E6Q-D4D-B5M-W9Q-A5A-A9V > > gsctool -ay > raw value: 0000000000000000 > chassis_x_branded: false > hw_x_compliance_version: 00 > > feature_check --feature_level > 1 > ``` crota360 is a legacy device (manufactured before H2'23) hence, we don't select CONFIG_FW_SPLASH_SCREEN config rather we asked those devices to select below config ``` CONFIG_BMP_LOGO=y CONFIG_FSP2_0_LOGO_FILE ``` please refer to the design doc. this code is not even applicable for legacy devices. marking this comment resolve. https://review.coreboot.org/c/coreboot/+/80738/comment/889a3228_7ea7cf1c : PS7, Line 97: if (!chromeos_device_plus_hw_compliant()) > Most/All soft branded CBX device will not get the proper splash screen with this logic. note, this logic is only applicable for modern devices (manufactured after H2'23), all older devices will have legacy config enabled hence, this code flow is not applicable for those devices. All modern devices will be able to meet this requirement. https://review.coreboot.org/c/coreboot/+/80738/comment/1ca63a2f_0c692bc6 : PS7, Line 104: return strncmp(vpd_get_feature_device_info(), "CAI", 3) == 0; > This is not acceptable for production code. "CAI" is not defined anywhere in the code base. > The proper way is to decode the content of the key with `base64decode()`, convert protobuf defined at https://chromium.googlesource.com/chromiumos/platform/feature-management/+/… and read the `feature_level` field. softbranded CBX is a time being solution and not something that is long term. GSC bit parsing is a more long term solution hence, CAI still solves the purpose of being able to decode the device branding for those soft-branded devices. Parsing the protobuf is too much for coreboot like minimalist boot-firmware and not worthy because anyway if protobuf changes in future then eventually we can bring the new string checker alongside `CAI` in future. > > Also, after the power wash, the VPD entry is wiped out, so at first boot, the user on soft branded CBX will see the regular `cb_logo.bmp' instead of the expected CBX logo. Note: this logic is only for soft-branded CBX devices and to my understanding on the first boot (after powerwash, or normal<>dev switch) the plus screens won't appear,but subsequent boots should be fine. This is WAI for the SB devices and no relation with this CL. marking this resolved as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/80738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Gerrit-Change-Number: 80738 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Comment-Date: Tue, 27 Feb 2024 18:51:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/amd/birman_plus: Add glinda SOC option for Birman+
by Fred Reitberger (Code Review) 27 Feb '24

27 Feb '24

Attention is currently required from: Anand Vaikar, Felix Held, Martin L Roth. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80770?usp=email ) Change subject: mb/amd/birman_plus: Add glinda SOC option for Birman+ ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/80770?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1efeb7cf1dca31e2a7e17f483f8882925b55e7ea Gerrit-Change-Number: 80770 Gerrit-PatchSet: 4 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 27 Feb 2024 18:50:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection
by Gwendal Grignou (Code Review) 27 Feb '24

27 Feb '24

Attention is currently required from: Paul Menzel, Paz Zcharya, Subrata Banik. Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80738?usp=email ) Change subject: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection ...................................................................... Patch Set 7: Code-Review-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/80738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Gerrit-Change-Number: 80738 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 27 Feb 2024 18:20:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection
by Gwendal Grignou (Code Review) 27 Feb '24

27 Feb '24

Attention is currently required from: Paul Menzel, Paz Zcharya, Subrata Banik. Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80738?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection ...................................................................... Patch Set 7: (5 comments) Patchset: PS7: Have we consider to always display the regular logo in firmware, and change the splash screen to CBX (when needed) when user space starts? File src/vendorcode/google/chromeos/tpm_factory_config.c: https://review.coreboot.org/c/coreboot/+/80738/comment/d8b19982_593d16b0 : PS7, Line 49: * - Bits 3-0 (0x1): Must be 0x1 to signify compliance with Chromebook-Plus Not true: this field contains the "feature_level" that indicate the chromebook plus generation. Today, 0 means unknown (may be soft-branded or not chromebook plus), 1 **and above** means chromebook plus. See go/cros-tiering-dd. https://review.coreboot.org/c/coreboot/+/80738/comment/8197000e_8d235ff0 : PS7, Line 74: * requirement. Not true. A soft branded CBX (crota for instance) will not have any bit set in its GSC but be a CBX (soft branded) device (unless is it re-manufactured). See a crota360, soft branded: ``` crossystem hwid CROTA360-QYFB D5B-E6Q-D4D-B5M-W9Q-A5A-A9V gsctool -ay raw value: 0000000000000000 chassis_x_branded: false hw_x_compliance_version: 00 feature_check --feature_level 1 ``` https://review.coreboot.org/c/coreboot/+/80738/comment/37031340_9e3cd516 : PS7, Line 97: if (!chromeos_device_plus_hw_compliant()) Most/All soft branded CBX device will not get the proper splash screen with this logic. https://review.coreboot.org/c/coreboot/+/80738/comment/5a4fd79e_0a6bffa8 : PS7, Line 104: return strncmp(vpd_get_feature_device_info(), "CAI", 3) == 0; This is not acceptable for production code. "CAI" is not defined anywhere in the code base. The proper way is to decode the content of the key with `base64decode()`, convert protobuf defined at https://chromium.googlesource.com/chromiumos/platform/feature-management/+/… and read the `feature_level` field. Also, after the power wash, the VPD entry is wiped out, so at first boot, the user on soft branded CBX will see the regular `cb_logo.bmp' instead of the expected CBX logo. -- To view, visit https://review.coreboot.org/c/coreboot/+/80738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Gerrit-Change-Number: 80738 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 27 Feb 2024 18:19:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024