Attention is currently required from: Felix Held, Fred Reitberger, Martin L Roth.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80770?usp=email )
Change subject: mb/amd/birman_plus: Add glinda SOC option for Birman+
......................................................................
Patch Set 4:
(3 comments)
File src/mainboard/amd/birman_plus/Kconfig:
https://review.coreboot.org/c/coreboot/+/80770/comment/33856331_6f8d6a15 :
PS3, Line 82: # This is a Birmanplus_Phoenix-specific override of soc/amd/(phoenix | glinda)/Kconfig
> `Birmanplus_Phoenix` or just `birmanplus`?
Done
File src/mainboard/amd/birman_plus/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/80770/comment/daa4b756_f78f2f43 :
PS3, Line 7: bool "-> Birmanplus for Glinda SoC"
> Inconsistent capitalization - should this match the `BirmanPlus` for phoenix?
Done
File src/mainboard/amd/birman_plus/port_descriptors_phoenix.c:
https://review.coreboot.org/c/coreboot/+/80770/comment/3e98938b_d49a4797 :
PS3, Line 7: //#include <soc/soc_util.h>
> dead code
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80770?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1efeb7cf1dca31e2a7e17f483f8882925b55e7ea
Gerrit-Change-Number: 80770
Gerrit-PatchSet: 4
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 27 Feb 2024 14:35:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Anand Vaikar, Felix Held, Martin L Roth.
Hello Felix Held, Fred Reitberger, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80770?usp=email
to look at the new patch set (#4).
Change subject: mb/amd/birman_plus: Add glinda SOC option for Birman+
......................................................................
mb/amd/birman_plus: Add glinda SOC option for Birman+
Change-Id: I1efeb7cf1dca31e2a7e17f483f8882925b55e7ea
Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com>
---
M src/mainboard/amd/birman_plus/Kconfig
M src/mainboard/amd/birman_plus/Kconfig.name
M src/mainboard/amd/birman_plus/Makefile.mk
A src/mainboard/amd/birman_plus/board_glinda.fmd
A src/mainboard/amd/birman_plus/chromeos_glinda.fmd
A src/mainboard/amd/birman_plus/devicetree_glinda.cb
M src/mainboard/amd/birman_plus/devicetree_phoenix.cb
M src/mainboard/amd/birman_plus/mainboard.c
A src/mainboard/amd/birman_plus/port_descriptors_glinda.c
R src/mainboard/amd/birman_plus/port_descriptors_phoenix.c
10 files changed, 421 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/80770/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/80770?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1efeb7cf1dca31e2a7e17f483f8882925b55e7ea
Gerrit-Change-Number: 80770
Gerrit-PatchSet: 4
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Paul Menzel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80348?usp=email )
Change subject: soc/amd/noncar: Increase bootblock size from 64K to 128K
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80348/comment/4c672ce3_1e411419 :
PS3, Line 7: Increase bootblock size
> If you could add the size, that’d be great: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80348?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I23f176d63d3c303b13331a77ad5ac6c7a19073d3
Gerrit-Change-Number: 80348
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 27 Feb 2024 14:31:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Anand Vaikar, Felix Held, Martin L Roth.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80770?usp=email )
Change subject: mb/amd/birman_plus: Add glinda SOC option for Birman+
......................................................................
Patch Set 3:
(3 comments)
File src/mainboard/amd/birman_plus/Kconfig:
https://review.coreboot.org/c/coreboot/+/80770/comment/5791816f_a5fd12e2 :
PS3, Line 82: # This is a Birmanplus_Phoenix-specific override of soc/amd/(phoenix | glinda)/Kconfig
`Birmanplus_Phoenix` or just `birmanplus`?
File src/mainboard/amd/birman_plus/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/80770/comment/9dc22310_b9be0de5 :
PS3, Line 7: bool "-> Birmanplus for Glinda SoC"
Inconsistent capitalization - should this match the `BirmanPlus` for phoenix?
File src/mainboard/amd/birman_plus/port_descriptors_phoenix.c:
https://review.coreboot.org/c/coreboot/+/80770/comment/d2e23e3c_594fa5cf :
PS3, Line 7: //#include <soc/soc_util.h>
dead code
--
To view, visit https://review.coreboot.org/c/coreboot/+/80770?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1efeb7cf1dca31e2a7e17f483f8882925b55e7ea
Gerrit-Change-Number: 80770
Gerrit-PatchSet: 3
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 27 Feb 2024 13:52:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Martin L Roth.
Hello Felix Held, Fred Reitberger, Martin L Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80770?usp=email
to look at the new patch set (#3).
Change subject: mb/amd/birman_plus: Add glinda SOC option for Birman+
......................................................................
mb/amd/birman_plus: Add glinda SOC option for Birman+
Change-Id: I1efeb7cf1dca31e2a7e17f483f8882925b55e7ea
Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com>
---
M src/mainboard/amd/birman_plus/Kconfig
M src/mainboard/amd/birman_plus/Kconfig.name
M src/mainboard/amd/birman_plus/Makefile.mk
A src/mainboard/amd/birman_plus/board_glinda.fmd
A src/mainboard/amd/birman_plus/chromeos_glinda.fmd
A src/mainboard/amd/birman_plus/devicetree_glinda.cb
M src/mainboard/amd/birman_plus/devicetree_phoenix.cb
M src/mainboard/amd/birman_plus/mainboard.c
A src/mainboard/amd/birman_plus/port_descriptors_glinda.c
R src/mainboard/amd/birman_plus/port_descriptors_phoenix.c
10 files changed, 422 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/80770/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80770?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1efeb7cf1dca31e2a7e17f483f8882925b55e7ea
Gerrit-Change-Number: 80770
Gerrit-PatchSet: 3
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk.
Hello Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80348?usp=email
to look at the new patch set (#6).
Change subject: soc/amd/noncar: Increase bootblock size from 64K to 128K
......................................................................
soc/amd/noncar: Increase bootblock size from 64K to 128K
When linking in page tables or romstage code, more place is needed.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: I23f176d63d3c303b13331a77ad5ac6c7a19073d3
---
M src/soc/amd/cezanne/Kconfig
M src/soc/amd/genoa_poc/Kconfig
M src/soc/amd/glinda/Kconfig
M src/soc/amd/mendocino/Kconfig
M src/soc/amd/phoenix/Kconfig
M src/soc/amd/picasso/Kconfig
6 files changed, 18 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/80348/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/80348?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I23f176d63d3c303b13331a77ad5ac6c7a19073d3
Gerrit-Change-Number: 80348
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held, Fred Reitberger, Martin L Roth.
Hello Felix Held, Fred Reitberger, Martin L Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80770?usp=email
to look at the new patch set (#2).
Change subject: mb/amd/birman_plus: Add glinda SOC option for Birman+
......................................................................
mb/amd/birman_plus: Add glinda SOC option for Birman+
Change-Id: I1efeb7cf1dca31e2a7e17f483f8882925b55e7ea
Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com>
---
M src/mainboard/amd/birman_plus/Kconfig
M src/mainboard/amd/birman_plus/Kconfig.name
M src/mainboard/amd/birman_plus/Makefile.mk
A src/mainboard/amd/birman_plus/board_glinda.fmd
A src/mainboard/amd/birman_plus/chromeos_glinda.fmd
A src/mainboard/amd/birman_plus/devicetree_glinda.cb
M src/mainboard/amd/birman_plus/devicetree_phoenix.cb
M src/mainboard/amd/birman_plus/mainboard.c
A src/mainboard/amd/birman_plus/port_descriptors_glinda.c
R src/mainboard/amd/birman_plus/port_descriptors_phoenix.c
10 files changed, 422 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/80770/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80770?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1efeb7cf1dca31e2a7e17f483f8882925b55e7ea
Gerrit-Change-Number: 80770
Gerrit-PatchSet: 2
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset