coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3067 discussions

[S] Change in coreboot[main]: brox: Handle GPI_INT pin value lower to GPI_WAKE
by Ashish Kumar Mishra (Code Review) 04 Feb '24

04 Feb '24

Attention is currently required from: Bora Guvendik, Karthik Ramasubramanian, Shelley Chen. Ashish Kumar Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80334?usp=email ) Change subject: brox: Handle GPI_INT pin value lower to GPI_WAKE ...................................................................... Patch Set 1: (4 comments) Patchset: PS1: > Oh also, is this a restriction that we need to adhere to for future devices (INT pin needs to be hig […] yes, this patch is applicable for such case. PS1: > Thank you Ashish for debugging this issue! […] We use find_free_unique_irq() to get available irqs to assign to pins, where it looks for pins available in a range upto available irq limit. This limit is set by set_ioapic_used(). In case of this: https://review.coreboot.org/c/coreboot/+/79886 the limit was available upto irq 45 instead of 44. Also, the set_ioapic_used() was only called for WAKE pins, hence added the flag PAD_CFG0_ROUTE_SWAPPED for cases where INT < WAKE case. File src/soc/intel/common/block/gpio/gpio.c: https://review.coreboot.org/c/coreboot/+/80334/comment/c276a295_5d009a61 : PS1, Line 292: !(cfg->pad_config[0] & PAD_CFG0_ROUTE_SWAPPED) > Why does polarity config applicable only for non-swapped IRQ pins? Polarity is only applicable in case of wake pins, not interrupt pins. https://review.coreboot.org/c/coreboot/+/80334/comment/e859a3cc_1613dceb : PS1, Line 354: > Nit: Extraneous line Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/80334?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c3d557e888b8d0ceac203f49b702910fba26d6d Gerrit-Change-Number: 80334 Gerrit-PatchSet: 1 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 03:53:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/yaviks: Enable USE_MTCL for YAVIKS
by Eric Lai (Code Review) 04 Feb '24

04 Feb '24

Attention is currently required from: David Ruth, Kapil Porwal, Nick Vaccaro. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80305?usp=email ) Change subject: mb/google/nissa/var/yaviks: Enable USE_MTCL for YAVIKS ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80305?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec54fc582d68b443665fceda47187c28f1a9216c Gerrit-Change-Number: 80305 Gerrit-PatchSet: 3 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Ruth <druth(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 05 Feb 2024 01:53:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/wifi: Add MTCL function to ACPI SSDT
by Eric Lai (Code Review) 04 Feb '24

04 Feb '24

Attention is currently required from: Arthur Heymans, Cliff Huang, David Ruth, Lance Zhao, Nick Vaccaro, Paul Menzel, Subrata Banik, Tim Wawrzynczak. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80170?usp=email ) Change subject: drivers/wifi: Add MTCL function to ACPI SSDT ...................................................................... Patch Set 19: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80170?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9b5e7312a44e114270e664b983626faa6cfee350 Gerrit-Change-Number: 80170 Gerrit-PatchSet: 19 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: David Ruth <druth(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Feb 2024 01:53:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/wifi: Use depends instead of if in Kconfig
by Eric Lai (Code Review) 04 Feb '24

04 Feb '24

Attention is currently required from: David Ruth, David Ruth. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80307?usp=email ) Change subject: drivers/wifi: Use depends instead of if in Kconfig ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3604b394f999b28de4723337b3b6b4e21139c83b Gerrit-Change-Number: 80307 Gerrit-PatchSet: 2 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: David Ruth <druth(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Ruth <druth(a)chromium.org> Gerrit-Attention: David Ruth <druth(a)google.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 01:52:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/google/brya/var/xol: Update Kconfig and devicetree
by SH Kim (Code Review) 04 Feb '24

04 Feb '24

Attention is currently required from: Kapil Porwal, Nick Vaccaro. SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80324?usp=email ) Change subject: mb/google/brya/var/xol: Update Kconfig and devicetree ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/80324/comment/82c25016_90bb0ba9 : PS5, Line 480: select INTEL_GMA_HAVE_VBT Is data.vbt necessary for all variants? Builder indicated there is no data.vbt file for xol, and just realized we should put the vbt file if we add this config. -- To view, visit https://review.coreboot.org/c/coreboot/+/80324?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I411932eb4872d77993394a290e8afdd1a0038faf Gerrit-Change-Number: 80324 Gerrit-PatchSet: 5 Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 05 Feb 2024 00:30:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: device/azalia: Separate codec checking and initialization
by Nicholas Sudsgaard (Code Review) 04 Feb '24

04 Feb '24

Attention is currently required from: Elyes Haouas, Nicholas Sudsgaard, Nico Huber, Paul Menzel. Hello Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80332?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: device/azalia: Separate codec checking and initialization ...................................................................... device/azalia: Separate codec checking and initialization This also changes how debug messages will be printed. I focused on reducing clutter on the screen and made the style of the messages consistent. Before: azalia_audio: Initializing codec #5 codec not ready. azalia_audio: Initializing codec #4 codec not valid. azalia_audio: Initializing codec #3 azalia_audio: viddid: ffffffff azalia_audio: verb_size: 4 azalia_audio: verb loaded. After: azalia_audio: codec #5 not ready azalia_audio: codec #4 not valid azalia_audio: initializing codec #3... azalia_audio: - vendor/device id: 0xffffffff azalia_audio: - verb size: 4 azalia_audio: - verb loaded Change-Id: I92b6d184abccdbe0e1bfce98a2c959a97a618a29 Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> --- M src/device/azalia_device.c M src/include/device/azalia_device.h 2 files changed, 43 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/80332/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/80332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92b6d184abccdbe0e1bfce98a2c959a97a618a29 Gerrit-Change-Number: 80332 Gerrit-PatchSet: 8 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: device/azalia: Separate codec checking and initialization
by Nicholas Sudsgaard (Code Review) 04 Feb '24

04 Feb '24

Attention is currently required from: Elyes Haouas, Nico Huber, Paul Menzel. Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80332?usp=email ) Change subject: device/azalia: Separate codec checking and initialization ...................................................................... Patch Set 6: (3 comments) File src/device/azalia_device.c: https://review.coreboot.org/c/coreboot/+/80332/comment/f797a50a_3b04f4c5 : PS6, Line 259: load_verb > Maybe rather `load_verb_table`. I got a bit confused because we have […] I can see how the separation is a bit overdone with `get_verb()` and `load_verb()`. I will put those 2 back into `azalia_codec_init()`. 👍 https://review.coreboot.org/c/coreboot/+/80332/comment/e505752f_9b65ee02 : PS6, Line 272: size > It's more of a `count'. But maybe that's something to take care of later. Maybe it's just me but I have a feeling that the naming is a bit confusing here in general (e.g. `u32 *verb` feels like it should be plural). File src/include/device/azalia_device.h: https://review.coreboot.org/c/coreboot/+/80332/comment/01ad8308_f36cdf83 : PS5, Line 13: > It's common to indent the bit definitions. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92b6d184abccdbe0e1bfce98a2c959a97a618a29 Gerrit-Change-Number: 80332 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 04 Feb 2024 23:29:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: device/azalia: Separate codec checking and initialization
by Nicholas Sudsgaard (Code Review) 04 Feb '24

04 Feb '24

Attention is currently required from: Elyes Haouas, Nicholas Sudsgaard, Nico Huber, Paul Menzel. Hello Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80332?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by Nico Huber, Verified+1 by build bot (Jenkins) Change subject: device/azalia: Separate codec checking and initialization ...................................................................... device/azalia: Separate codec checking and initialization This also changes how debug messages will be printed. I focused on reducing clutter on the screen and made the style of the messages consistent. Before: azalia_audio: Initializing codec #5 codec not ready. azalia_audio: Initializing codec #4 codec not valid. azalia_audio: Initializing codec #3 azalia_audio: viddid: ffffffff azalia_audio: verb_size: 4 azalia_audio: verb loaded. After: azalia_audio: codec #5 not ready azalia_audio: codec #4 not valid azalia_audio: initializing codec #3... azalia_audio: - vendor/device id: 0xffffffff azalia_audio: - verb size: 4 azalia_audio: - verb loaded Change-Id: I92b6d184abccdbe0e1bfce98a2c959a97a618a29 Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> --- M src/device/azalia_device.c M src/include/device/azalia_device.h 2 files changed, 43 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/80332/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/80332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92b6d184abccdbe0e1bfce98a2c959a97a618a29 Gerrit-Change-Number: 80332 Gerrit-PatchSet: 7 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: device/azalia: Clean up codec initialization code
by Nico Huber (Code Review) 04 Feb '24

04 Feb '24

Attention is currently required from: Elyes Haouas, Nicholas Sudsgaard, Paul Menzel. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80332?usp=email ) Change subject: device/azalia: Clean up codec initialization code ...................................................................... Patch Set 6: Code-Review+1 (3 comments) File src/device/azalia_device.c: https://review.coreboot.org/c/coreboot/+/80332/comment/35bba7c9_1ed7dc98 : PS6, Line 259: load_verb Maybe rather `load_verb_table`. I got a bit confused because we have azalia_write_verb() and load_verb(), one refers to a single verb command and the other to the table. Though, IMO, the separation looks a bit overdone. Personally, I would keep the error handling inline in azalia_codec_init(). But I leave that to you. https://review.coreboot.org/c/coreboot/+/80332/comment/684fd323_0deadd57 : PS6, Line 272: size It's more of a `count'. But maybe that's something to take care of later. File src/include/device/azalia_device.h: https://review.coreboot.org/c/coreboot/+/80332/comment/90af9545_677722fd : PS5, Line 13: > Hmmm, I think I see the intention here, do you think it would be better keeping this? I would be lea […] It's common to indent the bit definitions. -- To view, visit https://review.coreboot.org/c/coreboot/+/80332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92b6d184abccdbe0e1bfce98a2c959a97a618a29 Gerrit-Change-Number: 80332 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 04 Feb 2024 18:07:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: libpayload: Switch to commonlib ipchksum() algorithm
by Nico Huber (Code Review) 04 Feb '24

04 Feb '24

Attention is currently required from: Julius Werner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80253?usp=email ) Change subject: libpayload: Switch to commonlib ipchksum() algorithm ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > FILO fails to build now, I believe: […] Let's just drop the old implementation in FILO? -- To view, visit https://review.coreboot.org/c/coreboot/+/80253?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8d323ce9f8d946758619761b4b22d54bce222b6 Gerrit-Change-Number: 80253 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sun, 04 Feb 2024 17:44:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024