coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3066 discussions

[XS] Change in coreboot[main]: mb/google/volteer: Fix S0i3 regression
by Arthur Heymans (Code Review) 18 Feb '24

18 Feb '24

Attention is currently required from: Matt DeVillier, Nick Vaccaro. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80612?usp=email ) Change subject: mb/google/volteer: Fix S0i3 regression ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80612?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I644e42388c0f6127512bf52e774b79721601ecc9 Gerrit-Change-Number: 80612 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Sun, 18 Feb 2024 19:11:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/lenovo/m900_tiny: add board
by Arthur Heymans (Code Review) 18 Feb '24

18 Feb '24

Attention is currently required from: Alexander Couzens, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80610?usp=email ) Change subject: mb/lenovo/m900_tiny: add board ...................................................................... Patch Set 3: -Code-Review (1 comment) File src/mainboard/lenovo/m900_tiny/board.fmd: https://review.coreboot.org/c/coreboot/+/80610/comment/92f24fb8_21a49c3d : PS3, Line 1: LASH 16M { Is this file used somewhere? -- To view, visit https://review.coreboot.org/c/coreboot/+/80610?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f Gerrit-Change-Number: 80610 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 18 Feb 2024 19:10:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/lenovo/m900_tiny: add board
by Arthur Heymans (Code Review) 18 Feb '24

18 Feb '24

Attention is currently required from: Alexander Couzens, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80610?usp=email ) Change subject: mb/lenovo/m900_tiny: add board ...................................................................... Patch Set 3: (2 comments) File src/mainboard/lenovo/m900_tiny/include/gpio.h: https://review.coreboot.org/c/coreboot/+/80610/comment/533c86da_bb773504 : PS1, Line 9: st > Sure, done Done https://review.coreboot.org/c/coreboot/+/80610/comment/437264e2_3ca41aef : PS1, Line 17: static const struct pad_config gpio_table[] = { > Done Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80610?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f Gerrit-Change-Number: 80610 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 18 Feb 2024 19:09:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/lenovo/m900_tiny: add board
by Arthur Heymans (Code Review) 18 Feb '24

18 Feb '24

Attention is currently required from: Alexander Couzens, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80610?usp=email ) Change subject: mb/lenovo/m900_tiny: add board ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80610?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f Gerrit-Change-Number: 80610 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 18 Feb 2024 19:09:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: device: Add a helper function to add a downstream bus
by Arthur Heymans (Code Review) 18 Feb '24

18 Feb '24

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80210?usp=email ) Change subject: device: Add a helper function to add a downstream bus ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I am sorry, but this commit touches both ./src/device/ and ./src/soc/intel/xeon_sp/ - should have been split into two separate commits (inconvenient to merge/revert because of this spread) gerrit uses a cherry-pick approach, so that makes it easier to review patches that introduces functions and the ones that uses it, since it's easy to loose track if you have to review multiple patches to see what's going on. Making revert/merge a bit harder is a consequence of that. Doing it manually shouldn't be too hard in this case. -- To view, visit https://review.coreboot.org/c/coreboot/+/80210?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic898189b92997b93304fcbf47c73e2bb5ec09023 Gerrit-Change-Number: 80210 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Comment-Date: Sun, 18 Feb 2024 19:07:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mike Banon <mikebdp2(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/xeon_sp: Allocate resources above 4G
by Arthur Heymans (Code Review) 18 Feb '24

18 Feb '24

Attention is currently required from: Chen, Gang C, Christian Walter, Jincheng Li, Johnny Lin, Lean Sheng Tan, Nico Huber, Shuo Liu, Tim Chu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79058?usp=email ) Change subject: soc/intel/xeon_sp: Allocate resources above 4G ...................................................................... Patch Set 13: (1 comment) Patchset: PS13: > Unfortunately this has not been resolved yet... The type is defined in device/Kconfig. I'm not seeing your problem. -- To view, visit https://review.coreboot.org/c/coreboot/+/79058?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I27d4f9ce91c12ed4ab3b2f18f2a92b742115d275 Gerrit-Change-Number: 79058 Gerrit-PatchSet: 13 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mike Banon <mikebdp2(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sun, 18 Feb 2024 18:56:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mike Banon <mikebdp2(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/lenovo/m900_tiny: add board
by Michał Kopeć (Code Review) 18 Feb '24

18 Feb '24

Attention is currently required from: Alexander Couzens, Arthur Heymans, Krystian Hebel, Maciej Pijanowski, Michał Żygowski. Hello Alexander Couzens, Krystian Hebel, Maciej Pijanowski, Michał Żygowski, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80610?usp=email to look at the new patch set (#3). Change subject: mb/lenovo/m900_tiny: add board ...................................................................... mb/lenovo/m900_tiny: add board Add Lenovo ThinkCentre M700 / M900 Tiny mainboard. The M700 / M900 Tiny boards are USFF PCs that come with Skylake LGA1151 processors. M700 comes with B150 chipset, M900 comes with Q170 and is vPro capable. There is an onboard discrete TPM 1.2. Intel PTT fTPM can also be enabled in vendor FW, but for now it's not used here. An ME_DIS header (FDOPSS) can be set to disable the ME. This is also recommended since the ME can get stuck in a disabled state from which coreboot can't re-enable it, causing a bootloop. Tested unit is M900 with i5-6500T. Boots to Fedora 38 w/ kernel 6.5.5 and Windows 11. Tested and working: - Serial port (via optional module) - Rear DisplayPort connectors - Graphics w/ libgfxinit - Ethernet - SATA - NVMe - Internal speaker, front combo jack, rear line-out - Discrete TPM 1.2 - USB ports (Port 1 untested, apparently broken on my unit) - M.2 2230 Wi-Fi slot (needs ASPM L1s disabled) - S3 suspend Untested: - Front mic input - Optional expansion headers: DisplayPort, USB, PS/2, SATA / PCIe Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- A src/mainboard/lenovo/m900_tiny/Kconfig A src/mainboard/lenovo/m900_tiny/Kconfig.name A src/mainboard/lenovo/m900_tiny/Makefile.mk A src/mainboard/lenovo/m900_tiny/acpi/ec.asl A src/mainboard/lenovo/m900_tiny/acpi/superio.asl A src/mainboard/lenovo/m900_tiny/board.fmd A src/mainboard/lenovo/m900_tiny/board_info.txt A src/mainboard/lenovo/m900_tiny/bootblock.c A src/mainboard/lenovo/m900_tiny/cmos.default A src/mainboard/lenovo/m900_tiny/cmos.layout A src/mainboard/lenovo/m900_tiny/data.vbt A src/mainboard/lenovo/m900_tiny/devicetree.cb A src/mainboard/lenovo/m900_tiny/dsdt.asl A src/mainboard/lenovo/m900_tiny/gma-mainboard.ads A src/mainboard/lenovo/m900_tiny/gpio.c A src/mainboard/lenovo/m900_tiny/gpio_early.c A src/mainboard/lenovo/m900_tiny/hda_verb.c A src/mainboard/lenovo/m900_tiny/include/mainboard/gpio.h A src/mainboard/lenovo/m900_tiny/ramstage.c A src/mainboard/lenovo/m900_tiny/romstage.c 20 files changed, 880 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/80610/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/80610?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f Gerrit-Change-Number: 80610 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/volteer: Fix S0i3 regression
by Matt DeVillier (Code Review) 18 Feb '24

18 Feb '24

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80612?usp=email ) Change subject: mb/google/volteer: Fix S0i3 regression ...................................................................... mb/google/volteer: Fix S0i3 regression Keeping the PM timer enabled will disqualify an ADL system from entering S0i3, and will also cause an increase in power during suspend states. The PM timer is not required for brya boards, therefore disabling it. Fixes: 0e90580 (soc/intel: transition full control over PM Timer from FSP to coreboot) This mirrors an identical commit for google/brya: 1ce0f3aab72d ("mb/google/brya: Fix S0i3 regression") TEST=Boot Linx on google/drobit, verify S0i3 counter incrementing after exiting S0ix suspend states. Change-Id: I644e42388c0f6127512bf52e774b79721601ecc9 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/volteer/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/80612/1 diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index f4914c7..bc5ee6c 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -243,4 +243,7 @@ bool default n +config USE_PM_ACPI_TIMER + default n + endif # BOARD_GOOGLE_BASEBOARD_VOLTEER -- To view, visit https://review.coreboot.org/c/coreboot/+/80612?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I644e42388c0f6127512bf52e774b79721601ecc9 Gerrit-Change-Number: 80612 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[main]: mb/lenovo/m900_tiny: add board
by Michał Kopeć (Code Review) 18 Feb '24

18 Feb '24

Attention is currently required from: Alexander Couzens, Arthur Heymans, Krystian Hebel, Maciej Pijanowski, Michał Żygowski. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80610?usp=email ) Change subject: mb/lenovo/m900_tiny: add board ...................................................................... Patch Set 2: (2 comments) File src/mainboard/lenovo/m900_tiny/include/gpio.h: https://review.coreboot.org/c/coreboot/+/80610/comment/ab575dd6_7dfa7a49 : PS1, Line 9: st > I know it's a common pattern in other skylake boards, but can you move this to a . […] Sure, done https://review.coreboot.org/c/coreboot/+/80610/comment/1890ae82_e2e9d80b : PS1, Line 17: static const struct pad_config gpio_table[] = { > Same Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80610?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f Gerrit-Change-Number: 80610 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 18 Feb 2024 18:26:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/lenovo/m900_tiny: add board
by Michał Kopeć (Code Review) 18 Feb '24

18 Feb '24

Attention is currently required from: Alexander Couzens, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski. Hello Alexander Couzens, Krystian Hebel, Maciej Pijanowski, Michał Żygowski, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80610?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/lenovo/m900_tiny: add board ...................................................................... mb/lenovo/m900_tiny: add board Add Lenovo ThinkCentre M700 / M900 Tiny mainboard. The M700 / M900 Tiny boards are USFF PCs that come with Skylake LGA1151 processors. M700 comes with B150 chipset, M900 comes with Q170 and is vPro capable. There is an onboard discrete TPM 1.2. Intel PTT fTPM can also be enabled in vendor FW, but for now it's not used here. An ME_DIS header (FDOPSS) can be set to disable the ME. This is also recommended since the ME can get stuck in a disabled state from which coreboot can't re-enable it, causing a bootloop. Tested unit is M900 with i5-6500T. Boots to Fedora 38 w/ kernel 6.5.5 and Windows 11. Tested and working: - Serial port (via optional module) - Rear DisplayPort connectors - Graphics w/ libgfxinit - Ethernet - SATA - NVMe - Internal speaker, front combo jack, rear line-out - Discrete TPM 1.2 - USB ports (Port 1 untested, apparently broken on my unit) - M.2 2230 Wi-Fi slot (needs ASPM L1s disabled) - S3 suspend Untested: - Front mic input - Optional expansion headers: DisplayPort, USB, PS/2, SATA / PCIe Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- A src/mainboard/lenovo/m900_tiny/Kconfig A src/mainboard/lenovo/m900_tiny/Kconfig.name A src/mainboard/lenovo/m900_tiny/Makefile.inc A src/mainboard/lenovo/m900_tiny/acpi/ec.asl A src/mainboard/lenovo/m900_tiny/acpi/superio.asl A src/mainboard/lenovo/m900_tiny/board.fmd A src/mainboard/lenovo/m900_tiny/board_info.txt A src/mainboard/lenovo/m900_tiny/bootblock.c A src/mainboard/lenovo/m900_tiny/cmos.default A src/mainboard/lenovo/m900_tiny/cmos.layout A src/mainboard/lenovo/m900_tiny/data.vbt A src/mainboard/lenovo/m900_tiny/devicetree.cb A src/mainboard/lenovo/m900_tiny/dsdt.asl A src/mainboard/lenovo/m900_tiny/gma-mainboard.ads A src/mainboard/lenovo/m900_tiny/gpio.c A src/mainboard/lenovo/m900_tiny/gpio_early.c A src/mainboard/lenovo/m900_tiny/hda_verb.c A src/mainboard/lenovo/m900_tiny/include/mainboard/gpio.h A src/mainboard/lenovo/m900_tiny/ramstage.c A src/mainboard/lenovo/m900_tiny/romstage.c 20 files changed, 880 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/80610/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80610?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f Gerrit-Change-Number: 80610 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024