Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Tim Chu.
Shuo Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80629?usp=email )
Change subject: soc/intel/xeon_sp: Put SRAT util macros into Xeon-SP ACPI header
......................................................................
soc/intel/xeon_sp: Put SRAT util macros into Xeon-SP ACPI header
Macros MAX_ACPI_MEMORY_AFFINITY_COUNT and MAX_SRAT_MEM_ENTRIES_PER_IMC
are ACPI table specific, and could be used across Xeon-SP SoCs.
This patch moves their definition from FSP header to Xeon-SP layer
ACPI header.
TEST=intel/archercity CRB
Signed-off-by: Shuo Liu <shuo.liu(a)intel.com>
Change-Id: I6c3a84b04a452bc8d4217947a7d12f050c94b56b
---
M src/soc/intel/xeon_sp/include/soc/acpi.h
M src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/hob_memmap.h
2 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/80629/1
diff --git a/src/soc/intel/xeon_sp/include/soc/acpi.h b/src/soc/intel/xeon_sp/include/soc/acpi.h
index f9c55ab..c6d4f5a 100644
--- a/src/soc/intel/xeon_sp/include/soc/acpi.h
+++ b/src/soc/intel/xeon_sp/include/soc/acpi.h
@@ -26,4 +26,10 @@
unsigned long acpi_fill_hmat(unsigned long current);
unsigned long cxl_fill_srat(unsigned long current);
+#define MAX_SRAT_MEM_ENTRIES_PER_IMC 8
+
+#define MAX_ACPI_MEMORY_AFFINITY_COUNT ( \
+ MAX_SOCKET * MAX_IMC * MAX_SRAT_MEM_ENTRIES_PER_IMC \
+ )
+
#endif /* _SOC_ACPI_H_ */
diff --git a/src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/hob_memmap.h b/src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/hob_memmap.h
index 0cf1f86..040414b 100644
--- a/src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/hob_memmap.h
+++ b/src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/hob_memmap.h
@@ -40,11 +40,7 @@
}
#define MAX_IMC_PER_SOCKET MAX_IMC
-#define MAX_SRAT_MEM_ENTRIES_PER_IMC 8
#define MAX_SMB_INSTANCE 2
-#define MAX_ACPI_MEMORY_AFFINITY_COUNT ( \
- MAX_SOCKET * MAX_IMC_PER_SOCKET * MAX_SRAT_MEM_ENTRIES_PER_IMC \
- )
#define AMT_MAX_NODE ((MAX_AMT)*(MAX_SOCKET)) // Max abstract memory target for all sockets
#endif // _HOB_MEMMAP_H_
--
To view, visit https://review.coreboot.org/c/coreboot/+/80629?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6c3a84b04a452bc8d4217947a7d12f050c94b56b
Gerrit-Change-Number: 80629
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newchange
Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu.
Hello Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Tim Chu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80578?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Arthur Heymans, Verified+1 by build bot (Jenkins)
Change subject: soc/intel/xeon_sp: Add support for is_ioat_iio_stack_res
......................................................................
soc/intel/xeon_sp: Add support for is_ioat_iio_stack_res
IOAT is the term for the on-chip accelerator technology of
Xeon-SP. In CPX and SPR, IOAT stack is also named as DINO stack.
Different SoC has different check criteria for IOAT stacks,
this patch introduces an util function to abstract these differences
as well as cleaning up the usage of names.
TEST=intel/archercity CRB
Change-Id: I376928ad89b68b294734000678dad6f070d3c97d
Signed-off-by: Shuo Liu <shuo.liu(a)intel.com>
---
M src/soc/intel/xeon_sp/cpx/soc_util.c
M src/soc/intel/xeon_sp/include/soc/util.h
M src/soc/intel/xeon_sp/spr/ioat.c
M src/soc/intel/xeon_sp/spr/soc_acpi.c
M src/soc/intel/xeon_sp/spr/soc_util.c
M src/soc/intel/xeon_sp/uncore_acpi.c
6 files changed, 28 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80578/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80578?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I376928ad89b68b294734000678dad6f070d3c97d
Gerrit-Change-Number: 80578
Gerrit-PatchSet: 2
Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Jincheng Li, Lean Sheng Tan, Patrick Rudolph, Srinidhi N Kaushik, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80360?usp=email )
Change subject: soc/intel/xeon-sp: Hook up public FSP bin and headers
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS1:
> I cannot boot with an fsp that's been applied with TOCTOU W/A, either. […]
Yup I verified that the public EGS FSP can boot up Linux with UEFI payload.
But seeing log "0 Installed DIMMs found" and there's no SMBIOS type 17, it's likely the issue of incompatible memory hob struct header files reported by https://github.com/intel/FSP/issues/102
Nevertheless, it still provides a way for open source coreboot dev for EGS.
My steps of building UEFI payload on Linux:
clone edk2 github (at commit 85f37ab Idaville FSP - New UPDs for SSC)
cd edk2; git submodule update --init --recursive
make -C BaseTools; source edksetup.sh
build -p UefiPayloadPkg/UefiPayloadPkg.dsc -a IA32 -a X64 -t GCC5 -D BOOTLOADER=COREBOOT
--
To view, visit https://review.coreboot.org/c/coreboot/+/80360?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I778d3535c273dff653330518653bdefcb45e66f4
Gerrit-Change-Number: 80360
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 01:54:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Julius Werner, Martin L Roth.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77968?usp=email )
Change subject: treewide: Move list.h to commonlib
......................................................................
Patch Set 9:
(1 comment)
File payloads/libpayload/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/77968/comment/cbdf885f_b99c2565 :
PS8, Line 73: INCLUDES += -I$(coreboottop)/src/commonlib/include
> Sorry for not noticing this earlier, but I think we also want this wrapped in `ifeq ($(CONFIG_LP_GPL […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/77968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I16eb7b743fb1d36301f0eda563a62364e7a9cfec
Gerrit-Change-Number: 77968
Gerrit-PatchSet: 9
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Sun, 18 Feb 2024 23:17:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Martin L Roth, Maximilian Brune.
Hello Jakub Czapiga, Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/77968?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: treewide: Move list.h to commonlib
......................................................................
treewide: Move list.h to commonlib
It is needed in order to move device_tree.c into commonlib in a
subsequent commit.
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Change-Id: I16eb7b743fb1d36301f0eda563a62364e7a9cfec
---
M payloads/libpayload/Makefile.mk
M payloads/libpayload/libc/Makefile.mk
M src/commonlib/Makefile.mk
R src/commonlib/include/commonlib/list.h
R src/commonlib/list.c
M src/include/device_tree.h
M src/include/fit.h
M src/lib/Makefile.mk
M src/lib/cbfs.c
M src/lib/edid_fill_fb.c
M tests/commonlib/Makefile.mk
R tests/commonlib/list-test.c
M tests/lib/Makefile.mk
13 files changed, 23 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/77968/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/77968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I16eb7b743fb1d36301f0eda563a62364e7a9cfec
Gerrit-Change-Number: 77968
Gerrit-PatchSet: 9
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens, Arthur Heymans, Krystian Hebel, Maciej Pijanowski, Michał Żygowski.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80610?usp=email )
Change subject: mb/lenovo/m900_tiny: add board
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/lenovo/m900_tiny/board.fmd:
https://review.coreboot.org/c/coreboot/+/80610/comment/141bdeb0_cab0375d :
PS3, Line 1: LASH 16M {
> Is this file used somewhere?
I recall using it at one point, but it's not needed anymore indeed. Removed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80610?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f
Gerrit-Change-Number: 80610
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sun, 18 Feb 2024 19:57:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski.
Hello Alexander Couzens, Arthur Heymans, Krystian Hebel, Maciej Pijanowski, Michał Żygowski, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80610?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/lenovo/m900_tiny: add board
......................................................................
mb/lenovo/m900_tiny: add board
Add Lenovo ThinkCentre M700 / M900 Tiny mainboard.
The M700 / M900 Tiny boards are USFF PCs that come with Skylake LGA1151
processors. M700 comes with B150 chipset, M900 comes with Q170 and is
vPro capable.
There is an onboard discrete TPM 1.2. Intel PTT fTPM can also be enabled
in vendor FW, but for now it's not used here.
An ME_DIS header (FDOPSS) can be set to disable the ME. This is also
recommended since the ME can get stuck in a disabled state from which
coreboot can't re-enable it, causing a bootloop.
Tested unit is M900 with i5-6500T. Boots to Fedora 38 w/ kernel 6.5.5
and Windows 11.
Tested and working:
- Serial port (via optional module)
- Rear DisplayPort connectors
- Graphics w/ libgfxinit
- Ethernet
- SATA
- NVMe
- Internal speaker, front combo jack, rear line-out
- Discrete TPM 1.2
- USB ports (Port 1 untested, apparently broken on my unit)
- M.2 2230 Wi-Fi slot (needs ASPM L1s disabled)
- S3 suspend
Untested:
- Front mic input
- Optional expansion headers: DisplayPort, USB, PS/2, SATA / PCIe
Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
---
A src/mainboard/lenovo/m900_tiny/Kconfig
A src/mainboard/lenovo/m900_tiny/Kconfig.name
A src/mainboard/lenovo/m900_tiny/Makefile.mk
A src/mainboard/lenovo/m900_tiny/acpi/ec.asl
A src/mainboard/lenovo/m900_tiny/acpi/superio.asl
A src/mainboard/lenovo/m900_tiny/board_info.txt
A src/mainboard/lenovo/m900_tiny/bootblock.c
A src/mainboard/lenovo/m900_tiny/cmos.default
A src/mainboard/lenovo/m900_tiny/cmos.layout
A src/mainboard/lenovo/m900_tiny/data.vbt
A src/mainboard/lenovo/m900_tiny/devicetree.cb
A src/mainboard/lenovo/m900_tiny/dsdt.asl
A src/mainboard/lenovo/m900_tiny/gma-mainboard.ads
A src/mainboard/lenovo/m900_tiny/gpio.c
A src/mainboard/lenovo/m900_tiny/gpio_early.c
A src/mainboard/lenovo/m900_tiny/hda_verb.c
A src/mainboard/lenovo/m900_tiny/include/mainboard/gpio.h
A src/mainboard/lenovo/m900_tiny/ramstage.c
A src/mainboard/lenovo/m900_tiny/romstage.c
19 files changed, 866 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/80610/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/80610?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f
Gerrit-Change-Number: 80610
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens.
Echo Nar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950?usp=email )
Change subject: mb/lenovo/x230: introduce EDP variant
......................................................................
Patch Set 27:
(1 comment)
File src/mainboard/lenovo/x230/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/28950/comment/06e0e7c7_b14dfb09 :
PS22, Line 11: bool "ThinkPad X230 eDP Mod (2K/FHD)"
> With all the different mods out there, maybe it's even worth a documentation page. […]
I'd agree that it's probably worth having a documentation page. From what I have gathered there only seems to be 3 types of mods; Nitrocaster, eDP Only, and a.gain. Due to to the fact they all attach pretty much the same way, from a display standpoint, I wouldn't expect any issues regarding a specific mod kit to this patch set but it never hurts to have the info. I compiled a bit of information regarding some of the kits on github: https://github.com/lethedata/x220_x230-Mod_Kits
The Nitrocaster is the only one that I have seen that uses the native LVDS cable to receive the brightness signals while others implement it via other methods.
--
To view, visit https://review.coreboot.org/c/coreboot/+/28950?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 27
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexei Sorokin <sor.alexei(a)meowr.ru>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Aleksei Kharlamov <dh(a)devass.club>
Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com>
Gerrit-CC: Christian Herzog
Gerrit-CC: Echo Nar <echo(a)lethedata.com>
Gerrit-CC: Heiki Lõhmus <h(a)lohmus.me>
Gerrit-CC: Holger Levsen <holger(a)layer-acht.org>
Gerrit-CC: Ivan V <ivv(a)i1v.org>
Gerrit-CC: MartiniMoe
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me>
Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com>
Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com>
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: Xue Yao <xueyao(a)xyte.ch>
Gerrit-CC: clayton craft
Gerrit-CC: insurgo(a)riseup.net
Gerrit-CC: nullmark <nullmark(a)googlemail.com>
Gerrit-CC: slact
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sun, 18 Feb 2024 19:33:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Ivan V <ivv(a)i1v.org>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Alexei Sorokin <sor.alexei(a)meowr.ru>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment