Attention is currently required from: Felix Singer.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80545?usp=email )
Change subject: util/liveiso/nixos: Install lm_sensors package
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80545?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b027ed39d3ee81878e069142c2d7212f3dc0a6f
Gerrit-Change-Number: 80545
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Mon, 19 Feb 2024 14:46:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Daniel Peng, Eric Lai, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80636?usp=email )
Change subject: mb/google/brya: Create glassway variant
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80636?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I597666a5be6f71b82c7baddbe343da3d5117dd1c
Gerrit-Change-Number: 80636
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 14:13:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Anand Vaikar, Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Paul Menzel.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80353?usp=email )
Change subject: mb/amd/birman: Add Birman+ board support for Phoenix SOC
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS6:
> Birman and Birman+ are both FP8 platforms and hence Birman+ is added as a variant and not as a separ […]
created a separate mainboard for birman+
--
To view, visit https://review.coreboot.org/c/coreboot/+/80353?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I075dcf0214f8dc8b33b0e429d83d270b2f0952e1
Gerrit-Change-Number: 80353
Gerrit-PatchSet: 8
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 19 Feb 2024 14:08:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Comment-In-Reply-To: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Paul Menzel.
Hello Felix Held, Fred Reitberger, Jason Glenesk, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80353?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/amd/birman: Add Birman+ board support for Phoenix SOC
......................................................................
mb/amd/birman: Add Birman+ board support for Phoenix SOC
1) Initial commit for upstreaming Birmanplus mainboard changes.
2) Add the DXIO descriptors for Birmanplus mainboard.
Change-Id: I075dcf0214f8dc8b33b0e429d83d270b2f0952e1
Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com>
---
M src/mainboard/amd/birman/Kconfig
A src/mainboard/amd/birman_plus/Kconfig
A src/mainboard/amd/birman_plus/Kconfig.name
A src/mainboard/amd/birman_plus/Makefile.mk
A src/mainboard/amd/birman_plus/board_info.txt
A src/mainboard/amd/birman_plus/board_phoenix.fmd
A src/mainboard/amd/birman_plus/bootblock.c
A src/mainboard/amd/birman_plus/chromeos.c
A src/mainboard/amd/birman_plus/chromeos_phoenix.fmd
A src/mainboard/amd/birman_plus/devicetree_phoenix.cb
A src/mainboard/amd/birman_plus/dsdt.asl
A src/mainboard/amd/birman_plus/early_gpio.c
A src/mainboard/amd/birman_plus/ec.c
A src/mainboard/amd/birman_plus/ec.h
A src/mainboard/amd/birman_plus/gpio.c
A src/mainboard/amd/birman_plus/gpio.h
A src/mainboard/amd/birman_plus/mainboard.c
A src/mainboard/amd/birman_plus/port_descriptors.c
18 files changed, 1,315 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/80353/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/80353?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I075dcf0214f8dc8b33b0e429d83d270b2f0952e1
Gerrit-Change-Number: 80353
Gerrit-PatchSet: 8
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80616?usp=email )
Change subject: [TEST] drivers/intel/gma: Allow SPARK function with side effects
......................................................................
[TEST] drivers/intel/gma: Allow SPARK function with side effects
Change-Id: I1eb879f57437587dc11d879fcc4042a70d384786
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M src/drivers/intel/gma/gma.ads
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/80616/1
diff --git a/src/drivers/intel/gma/gma.ads b/src/drivers/intel/gma/gma.ads
index d264960..55fe973 100644
--- a/src/drivers/intel/gma/gma.ads
+++ b/src/drivers/intel/gma/gma.ads
@@ -6,11 +6,14 @@
package GMA is
+ pragma Warnings
+ (GNAT, Off, """Side_Effects"" is not a valid aspect identifier",
+ Reason => """Side_Effects"" is new and needed for toolchain transition.");
function read_edid
(raw_edid : out HW.GFX.EDID.Raw_EDID_Data;
port : in Interfaces.C.int)
return Interfaces.C.int
with
- Export, Convention => C, External_Name => "gma_read_edid";
+ Side_Effects, Export, Convention => C, External_Name => "gma_read_edid";
end GMA;
--
To view, visit https://review.coreboot.org/c/coreboot/+/80616?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1eb879f57437587dc11d879fcc4042a70d384786
Gerrit-Change-Number: 80616
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: newchange
Kapil Porwal has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78649?usp=email )
Change subject: mb/google/rex: Enable sending EOP from payload
......................................................................
Abandoned
Not planning to land it for Rex
--
To view, visit https://review.coreboot.org/c/coreboot/+/78649?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie97ce50bbfd642fd6578b6ea54add9cf0641cabb
Gerrit-Change-Number: 78649
Gerrit-PatchSet: 4
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: abandon
Attention is currently required from: Nicholas Sudsgaard.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80577?usp=email )
Change subject: include/device/azalia.h: Add enum for misc field
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Maybe we should unify the enums in `azalia.h` and `azalia_device. […]
Yeah, see my earlier comment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80577?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iff9d146fe8fbff3d11655ddfcc415b1a2c582ccf
Gerrit-Change-Number: 80577
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 13:54:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Hello Lean Sheng Tan, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80615?usp=email
to look at the new patch set (#2).
Change subject: 3rdparty/fsp: Update submodule to upstream master
......................................................................
3rdparty/fsp: Update submodule to upstream master
Updating from commit id 507ef01:
2024-01-11 10:49:14 +0800 - (IoT ADL-S MR6 (4115_09) FSP)
to commit id dd98487:
2024-02-16 17:16:05 -0800 - (Fix EagleStreamFspBinPkg Path)
This brings in 6 new commits:
dd98487 Fix EagleStreamFspBinPkg Path
fcf623b Fix MAX_VMD_STACKS_PER_SOCKET
e07f875 Fix EagleStream BSF File
85f37ab Idaville FSP - New UPDs for SSC
98e497f IoT RPL-P MR1 (4445_03) FSP
fc5e3c9 IoT RPL-P MR1 (4445_03) FSP
Change-Id: If7d852e1a92d8409a5161797c0aa3a55a71c8b49
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M 3rdparty/fsp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/80615/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80615?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7d852e1a92d8409a5161797c0aa3a55a71c8b49
Gerrit-Change-Number: 80615
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nicholas Sudsgaard.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80577?usp=email )
Change subject: include/device/azalia.h: Add enum for misc field
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think it would be better to just drop this file. It serves the same purpose as azalia_device.h which is far more common throughout the tree, so dropping this one would reduce maintenance burden.
The only file that currently uses `azalia.h` is `siemens/chili`, and when I search for all commits that had those `AZALIA_PINCFG_*` enums in their diff using `git log --oneline -G "AZALIA_PINCFG" --all` I only get 10 commits, 4 of which are dropping boards that used those enums.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80577?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iff9d146fe8fbff3d11655ddfcc415b1a2c582ccf
Gerrit-Change-Number: 80577
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 13:50:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment