Attention is currently required from: Balázs Vinarz, Vlado Ilic.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79838?usp=email )
Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS4:
> Agreed with Balazs, although i can't help with coding, i have "asus a88xm-e (fm2+)" board with "carr […]
Please tell, what "carrizo" cpu you are using with A88XM-E and have you got it working with coreboot? (if yes, how?) I thought that a newer AGESA for A10-7*** CPUs is really blobbed and so the latest CPUs that could be used with coreboot - are A10-6800K / A10-6700 ; am I wrong here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Gerrit-Change-Number: 79838
Gerrit-PatchSet: 6
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-CC: awokd(a)danwin1210.me
Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Attention: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 19:52:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Andrey Petrov, Arthur Heymans, Chen, Gang C, Christian Walter, Jincheng Li, Johnny Lin, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Tim Chu.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80579?usp=email )
Change subject: drivers/intel/fsp: Work around multi socket Xeon-SP pipe init bug
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80579?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I38a4f4b7470556e528a1672044c31f8bd92887d4
Gerrit-Change-Number: 80579
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 19:48:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Balázs Vinarz.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79838?usp=email )
Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS4:
> At least need to upgrade their code to become compatible with resource allocator V4 - more info here […]
Forgot to say: I tried to fix the resource allocator V4 for our boards here - https://review.coreboot.org/c/coreboot/+/41431 - but not all the boards were booting. Maybe you could do something like this?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Gerrit-Change-Number: 79838
Gerrit-PatchSet: 6
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-CC: awokd(a)danwin1210.me
Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 19:48:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Balázs Vinarz <vinibali1(a)gmail.com>
Comment-In-Reply-To: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Matt DeVillier, Nick Vaccaro, Paul Menzel.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80612?usp=email )
Change subject: mb/google/volteer: Disable PM ACPI timer to fix S0i3 regression
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80612?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I644e42388c0f6127512bf52e774b79721601ecc9
Gerrit-Change-Number: 80612
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Mon, 19 Feb 2024 19:38:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Yu-Ping Wu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80580?usp=email )
Change subject: Kconfig: Allow other Kconfig files to override the default
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80580/comment/0f2d9e31_22d4eb7b :
PS1, Line 7: Kconfig: Allow other Kconfig files to override the default
The patch is specific to `config SEPARATE_ROMSTAGE`, right?
Not sure how to squeeze it in there, but I think it's worth
to mention. Maybe
```
Kconfig: Allow to override SEPARATE_ROMSTAGE default
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/80580?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I09ab5f8c79917bf93c9d5c9dfd157c652478b186
Gerrit-Change-Number: 80580
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 19:32:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Balázs Vinarz, Mike Banon.
Hello Balázs Vinarz, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79838?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+1 by Balázs Vinarz, Code-Review+1 by Mike Banon, Verified+1 by build bot (Jenkins)
Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................
util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
restore_agesa.sh reverts the opensource AGESA AMD boards removal
that happened after 5e8e911b7caee021faff96c4e82a77a42544ea62
commit (0 point of history, or 0 PoH) - by git-reverting:
1) the "bad commits" (marked as "CBF" = coreboot build failure)
- that either remove or break a code needed for our boards
2) the "unlucky commits" (marked as "GRF" = git revert failure)
- that are a roadblock for git-reverting the "bad commits"
Right now at be23f04ce7ccad902c92766b29abd1577482ec61 (5923 PoH),
it takes 48 CBF git reverts - just 1% of 5923 commits since the
OSS AGESA removal! - making this removal look questionable and
the idea of opensource AGESA AMD boards restoration viable.
SUCCESSFUL BOOT TESTS for the opensource AGESA boards which I own
(Lenovo G505S - fam15 laptop, ASUS A88XM-E - fam15 desktop,
ASUS AM1I-A - fam16 desktop) :
be23f04ce7ccad902c92766b29abd1577482ec61 (5923 PoH) for Lenovo G505S
69ffebf5ccf123bc0b3fb28b485985af0597761d (3698 PoH) for ASUS A88XM-E
Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
---
A restore_agesa.sh
1 file changed, 340 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/79838/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/79838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Gerrit-Change-Number: 79838
Gerrit-PatchSet: 6
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-CC: awokd(a)danwin1210.me
Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Balázs Vinarz.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79838?usp=email )
Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
> I really appreciate your diligence, but I'm afraid nobody will merge this ever. […]
At least need to upgrade their code to become compatible with resource allocator V4 - more info here https://doc.coreboot.org/releases/coreboot-4.18-relnotes.html#plans-for-cod…
--
To view, visit https://review.coreboot.org/c/coreboot/+/79838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Gerrit-Change-Number: 79838
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-CC: awokd(a)danwin1210.me
Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 19:18:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Alper Nebi Yasak, Martin L Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80368?usp=email )
Change subject: mb/qemu/fw_cfg: Move fw_cfg driver to drivers/emulation/qemu
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
> Instead of moving things to src/mb/emulation/qemu and src/include, maybe create src/mb/emulation/qem […]
The header files could also be included with their full path, e.g.
```
#include <mainboard/emulation/qemu_common/fw_cfg.h>
```
or
```
#include <drivers/emulation/qemu/fw_cfg.h>
```
That's sometimes more convenient than adding a directory for only a few files.
File src/drivers/emulation/qemu/Kconfig:
https://review.coreboot.org/c/coreboot/+/80368/comment/dc03c442_63c8d7cd :
PS1, Line 29: bool "QEMU firmware configuration driver"
> So just use `bool` instead of `bool "prompt"` - that way it won't show up as user configurable.
Yes, thanks for eloborating.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80368?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0348bb2fa3a4cc1ef6561206a5dd02feb16ae869
Gerrit-Change-Number: 80368
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 19:16:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Jonathon Hall, Matt DeVillier.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80601?usp=email )
Change subject: mb/purism/librem_cnl/var/librem_mini: Set RTC register defaults
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80601/comment/b7bcd7c7_73c8317d :
PS2, Line 154: io 0x60 = 0x070
> it's unused, so I could set it to 0. […]
I'm not sure if 0 isn't just a valid value for coreboot. Looking at the
generated `static.c` devicetree, it would have the `IORESOURCE_ASSIGNED`
flag and maybe that's enough to make the message disappear. (Don't know
if the hw likes that, but there are already a few cases like this in the
tree.)
--
To view, visit https://review.coreboot.org/c/coreboot/+/80601?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I310a834a1fa7b8428879fbc160e4aae0a519e063
Gerrit-Change-Number: 80601
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Comment-Date: Mon, 19 Feb 2024 19:04:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jérémy Compostella, Patrick Rudolph, Tim Chu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80172?usp=email )
Change subject: soc/intel/xeon_sp: Drop 1st Gen Xeon-SP
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> It seems like a lot of work has been done on this lately. Let's discuss in the leadership meeting.
I think it's OK to remove the SKX code from the main branch (same comment as in CB:80171). AFAIK almost all work in the last two years or so has been on newer generations, namely Cooper Lake, Sapphire Rapids, and Granite Rapids.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80172?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I12b092f00386cb71fac02d8d0b10375d3241abb3
Gerrit-Change-Number: 80172
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-CC: Martin Roth <coreboot.org(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 18:53:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <coreboot.org(a)gmail.com>
Gerrit-MessageType: comment