Attention is currently required from: Balázs Vinarz, Mike Banon.
Vlado Ilic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79838?usp=email )
Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Sorry for the confusion, i have Athlon X4 750K (Trinity) and Athlon X4 845 (Carrizo), both normal CPUs (not APUs). I don't have coreboot on either of them, but i can flash and test builds if needed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Gerrit-Change-Number: 79838
Gerrit-PatchSet: 6
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-CC: awokd(a)danwin1210.me
Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 20:05:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80618?usp=email )
Change subject: Documentation: Add 24.05 release notes template
......................................................................
Documentation: Add 24.05 release notes template
In preparation for the upcoming release, add the template for the
24.05 release and update index.md.
Change-Id: Ic8fdf82519ffa4001bcc06bdd808eaebdde18a1e
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
---
A Documentation/releases/coreboot-24.05-relnotes.md
M Documentation/releases/index.md
2 files changed, 98 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/80618/1
diff --git a/Documentation/releases/coreboot-24.05-relnotes.md b/Documentation/releases/coreboot-24.05-relnotes.md
new file mode 100644
index 0000000..da7e014
--- /dev/null
+++ b/Documentation/releases/coreboot-24.05-relnotes.md
@@ -0,0 +1,95 @@
+Upcoming release - coreboot 24.05
+========================================================================
+
+The 24.05 release is scheduled for Mid May, 2024
+
+
+Update this document with changes that should be in the release notes.
+
+* Please use Markdown.
+* See the past few release notes for the general format.
+* The chip and board additions and removals will be updated right
+ before the release, so those do not need to be added.
+* Note that all changes before the release are done are marked upcoming.
+ A final version of the notes are done after the release.
+
+
+
+Significant or interesting changes
+----------------------------------
+
+* Add changes that need a full description here
+
+* This section should have full descriptions and can or should have
+ a link to the referenced commits.
+
+
+
+Additional coreboot changes
+---------------------------
+
+The following are changes across a number of patches, or changes worth
+noting, but not needing a full description.
+
+* Changes that only need a line or two of description go here.
+
+
+
+Changes to external resources
+-----------------------------
+
+### Toolchain updates
+
+
+### Git submodule pointers
+
+
+### External payloads
+
+
+
+Platform Updates
+----------------
+
+### Added mainboards:
+* To be filled in immediately before the release by the release team
+
+
+### Removed Mainboards
+* To be filled in immediately before the release by the release team
+
+
+### Updated SoCs
+* To be filled in immediately before the release by the release team
+
+
+
+Plans to move platform support to a branch
+------------------------------------------
+* To be filled in immediately before the release by the release team
+
+
+
+Statistics from the 4.22 to the 24.02 release
+--------------------------------------------
+* To be filled in immediately before the release by the release team
+
+
+
+Significant Known and Open Issues
+---------------------------------
+
+Issues from the coreboot bugtracker: https://ticket.coreboot.org/
+* To be filled in immediately before the release by the release team
+
+
+
+coreboot Links and Contact Information
+--------------------------------------
+
+* Main Web site: https://www.coreboot.org
+* Downloads: https://coreboot.org/downloads.html
+* Source control: https://review.coreboot.org
+* Documentation: https://doc.coreboot.org
+* Issue tracker: https://ticket.coreboot.org/projects/coreboot
+* Donations: https://coreboot.org/donate.html
diff --git a/Documentation/releases/index.md b/Documentation/releases/index.md
index 74968d3..17a9462 100644
--- a/Documentation/releases/index.md
+++ b/Documentation/releases/index.md
@@ -3,7 +3,7 @@
## Upcoming release
Please add to the release notes as changes are added:
-* [24.02 - February 2024](coreboot-24.02-relnotes.md)
+* [24.05 - May 2024](coreboot-24.05-relnotes.md)
The [checklist] contains instructions to ensure that a release covers all
important things and provides a reliable format for tarballs, branch
@@ -15,7 +15,8 @@
## Previous releases
-* [4.22 - November 2023](coreboot-4.22-relnotes.md)
+* [24.02 - February 2024](coreboot-24.02-relnotes.md)
+* [4.22 - November 2023](coreboot-4.22-relnotes.md)
* [4.21 - August 2023](coreboot-4.21-relnotes.md)
* [4.20.1 - May 2023](coreboot-4.20.1-relnotes.md)
* [4.19 - January 2023](coreboot-4.19-relnotes.md)
--
To view, visit https://review.coreboot.org/c/coreboot/+/80618?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8fdf82519ffa4001bcc06bdd808eaebdde18a1e
Gerrit-Change-Number: 80618
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80613?usp=email )
Change subject: mb/intel/adlrvp: Remove ADLRVP_M mainboard
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/80613?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icc853a9df44a4a770db76e119644f0b4c7fcc2c8
Gerrit-Change-Number: 80613
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 19 Feb 2024 20:02:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80614?usp=email )
Change subject: soc/intel/alderlake: Remove Alder Lake M SKU
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/80614?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If769989f7a0434e32ebbcc8eac9b965b70ca71ed
Gerrit-Change-Number: 80614
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 19 Feb 2024 20:02:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/77460?usp=email )
Change subject: soc/intel/meteorlake: Guard the write TD3C
......................................................................
Abandoned
Not common enough...
--
To view, visit https://review.coreboot.org/c/coreboot/+/77460?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I52b23299006d42e3856126934384d480e1990ad2
Gerrit-Change-Number: 77460
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: abandon
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/77459?usp=email )
Change subject: soc/intel/{alderlake,meteorlake}: Add the mailbox code
......................................................................
Abandoned
Not common enough...
--
To view, visit https://review.coreboot.org/c/coreboot/+/77459?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If4bf0cc6ecd17386a901b62caf69f1fa73a66c40
Gerrit-Change-Number: 77459
Gerrit-PatchSet: 10
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: abandon
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/77458?usp=email )
Change subject: soc/intel/meteorlake: Add the IOMA Method
......................................................................
Abandoned
Not common enough...
--
To view, visit https://review.coreboot.org/c/coreboot/+/77458?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib2e9335eea1a4c115c6404e2357fef78aa3c2ce8
Gerrit-Change-Number: 77458
Gerrit-PatchSet: 10
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: abandon
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80617?usp=email )
Change subject: Documentation: Release notes for the 24.02 release
......................................................................
Documentation: Release notes for the 24.02 release
These will be updated and finalized after the release to capture any
final changes, remove "upcoming release", and finalize all stats.
Change-Id: Idc224c43f2459faabf91a9ef282bb9eaeba42240
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
---
M Documentation/releases/coreboot-24.02-relnotes.md
1 file changed, 194 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/80617/1
diff --git a/Documentation/releases/coreboot-24.02-relnotes.md b/Documentation/releases/coreboot-24.02-relnotes.md
index 40350ec..2f3c0a4 100644
--- a/Documentation/releases/coreboot-24.02-relnotes.md
+++ b/Documentation/releases/coreboot-24.02-relnotes.md
@@ -1,17 +1,19 @@
Upcoming release - coreboot 24.02
========================================================================
-The 24.02 release is scheduled for Mid February, 2024
+The 24.02 release is scheduled for February 19, 2024. The next release,
+which will be 24.05, is scheduled for mid-May.
+The coreboot project is happy to announce our next release for February
+2024. Over the past three months, our contributors have focused on
+refining the coreboot codebase, generally prioritizing cleanup and
+quality enhancements. While this release may not introduce many major
+functionality changes, the continuous improvement is crucial for the
+stability and efficiency of the project. We extend our gratitude to all
+the contributors who have dedicated their time and expertise. Thank you
+for your invaluable contributions to this vital phase of maintenance and
+optimization.
-Update this document with changes that should be in the release notes.
-
-* Please use Markdown.
-* See the past few release notes for the general format.
-* The chip and board additions and removals will be updated right
- before the release, so those do not need to be added.
-* Note that all changes before the release are done are marked upcoming.
- A final version of the notes are done after the release.
### Release number format update
@@ -19,72 +21,233 @@
name scheme. For this and future releases, coreboot has switched to a
Year.Month.Sub-version naming scheme. As such, the next release,
scheduled for May of 2024 will be numbered 24.05, with the sub-version
-of 00 implied. If we need to do a fix or incremental release, we’ll
+of 00 implied. If we need to do a fix or incremental release, we'll
append the values .01, .02 and so on to the initial release value.
+### The master branch being deleted
+
+The coreboot project changed from master to main roughly 6 months ago,
+and has been keeping the two branches in sync since then to ease the
+transition. As of this release, we are getting rid of the master branch
+completely. Please make sure any scripts you're using that reference the
+'master' branch have been switched to 'main'.
+
+
+
Significant or interesting changes
----------------------------------
-* Add changes that need a full description here
+### acpi: Add Arm IO Remapping Table structures
-* This section should have full descriptions and can or should have
- a link to the referenced commits.
+Input Output Remapping Table (IORT) represents the IO topology of an Arm
+based system.
+
+Document number: ARM DEN 0049E.e, Sep 2022
+
+
+### acpi: Add PPTT support
+
+This patch adds code to generate Processor Properties Topology Tables
+(PPTT) compliant to the ACPI 6.4 specification.
+
+ - The 'acpi_get_pptt_topology' hook is mandatory once ACPI_PPTT is
+ selected. Its purpose is to return a pointer to a topology tree,
+ which describes the relationship between CPUs and caches. The hook
+ can be provided by, for example, mainboard code.
+
+Background: We are currently working on mainboard code for qemu-sbsa and
+Neoverse N2. Both require a valid PPTT table. Patch was tested against
+the qemu-sbsa board.
+
+
+### acpi: Add support for WDAT table
+
+This commit lays the groundwork for implementing the ACPI WDAT (Watchdog
+Action Table) table specification. The WDAT is a special ACPI table
+introduced by Microsoft that describes the watchdog for the OS.
+
+Platforms that need to implement the WDAT table must describe the
+hardware watchdog management operations as described in the
+specification. See “Links to ACPI-Related Documents”
+(http://uefi.org/acpi) under the heading “Watchdog Action Table”.
+
+### lib/jpeg: Replace decoder with Wuffs' implementation
+
+To quote its repo[0]: Wuffs is a memory-safe programming language (and a
+standard library written in that language) for Wrangling Untrusted File
+Formats Safely. Wrangling includes parsing, decoding and encoding.
+
+It compiles its library, written in its own language, to a C/C++ source
+file that can then be used independently without needing support for the
+language. That library is now imported to src/vendorcode/wuffs/.
+
+This change modifies our linters to ignore that directory because it's
+supposed to contain the wuffs compiler's result verbatim.
+
+Nigel Tao provided an initial wrapper around wuffs' jpeg decoder that
+implements our JPEG API. I further changed it a bit regarding data
+placement, dropped stuff from our API that wasn't ever used, or isn't
+used anymore, and generally made it fit coreboot a bit better. Features
+are Nigel's, bugs are mine.
+
+This commit also adapts our jpeg fuzz test to work with the modified
+API. After limiting it to deal only with approximately screen sized
+inputs, it fuzzed for 25 hours CPU time without a single hang or crash.
+This is a notable improvement over running the test with our old decoder
+which crashes within a minute.
+
+Finally, I tried the new parser with a pretty-much-random JPEG file I
+got from the internet, and it just showed it (once the resolution
+matched), which is also a notable improvement over the old decoder which
+is very particular about the subset of JPEG it supports.
+
+In terms of code size, a QEmu build's ramstage increases
+from 128060 bytes decompressed (64121 bytes after LZMA)
+ to 172304 bytes decompressed (82734 bytes after LZMA).
+
+[0] https://github.com/google/wuffs
Additional coreboot changes
---------------------------
-The following are changes across a number of patches, or changes worth
-noting, but not needing a full description.
+* Rename Makefiles from .inc to .mk to better identify them
+* SPI: Add GD25LQ255E and IS25WP256D chip support
+* device: Add support for multiple PCI segment groups
+* device: Drop unused multiple downstream link support
+* device: Rename bus and link_list to upstream and downstream
+* Updated devicetree files for modern Intel platforms to use chipset.cb
-* Changes that only need a line or two of description go here.
Changes to external resources
-----------------------------
### Toolchain updates
-
+* Add buildgcc support for Apple M1/M2 devices
+* crossgcc: Upgrade GCC from 11.4.0 to 13.2.0
+* util/crossgcc: Update CMake from 3.26.4 to 3.27.7
+* util/kconfig: Uprev to Linux 6.7 kconfig
### Git submodule pointers
+* /3rdparty/amd_blobs: Update from commit id e4519efca7 to 64cdd7c8ef
+ (5 commits)
+* /3rdparty/arm-trusted-firmware: Update from commit id 88b2d81345 to
+ 17bef2248d (701 commits)
+* /3rdparty/fsp: Update from commit id 481ea7cf0b to 507ef01cce (16 commits)
+* /3rdparty/intel-microcode: Update from commit id 6788bb07eb to
+ ece0d294a2 (1 commits)
+* /3rdparty/vboot: Update from commit id 24cb127a5e to 3d37d2aafe (121
+ commits)
+
### External payloads
+* payload/grub2: Update from 2.06 to 2.12
+* payload/seabios: Update from 1.16.2 to 1.16.3
+
Platform Updates
----------------
### Added mainboards:
-* To be filled in immediately before the release by the release team
-
+* Google: Dita
+* Google: Xol
+* Lenovo: ThinkPad X230 eDP Mod (2K/FHD)
### Removed Mainboards
-* To be filled in immediately before the release by the release team
+* Google -> Primus4ES
-### Updated SoCs
-* To be filled in immediately before the release by the release team
-
-
-Plans to move platform support to a branch
-------------------------------------------
-* To be filled in immediately before the release by the release team
-
Statistics from the 4.22 to the 24.02 release
--------------------------------------------
-* To be filled in immediately before the release by the release team
+
+* Total Commits: 814
+* Average Commits per day: 8.65
+* Total lines added: 105203
+* Average lines added per commit: 129.24
+* Number of patches adding more than 100 lines: 46
+* Average lines added per small commit: 41.34
+* Total lines removed: 16505
+* Average lines removed per commit: 20.28
+* Total difference between added and removed: 88698
+* Total authors: 111
+* New authors: 19
Significant Known and Open Issues
---------------------------------
-Issues from the coreboot bugtracker: https://ticket.coreboot.org/
-* To be filled in immediately before the release by the release team
+* AMD chromebooks will not currently work with the signed vboot.
+
+
+## Issues from the coreboot bugtracker: https://ticket.coreboot.org/
+
+### Payload-specific issues
+
+```eval_rst
++-----+-----------------------------------------------------------------+
+| # | Subject |
++=====+=================================================================+
+| 499 | edk2 boot fails with RESOURCE_ALLOCATION_TOP_DOWN enabled |
++-----+-----------------------------------------------------------------+
+| 496 | Missing malloc check in libpayload |
++-----+-----------------------------------------------------------------+
+| 484 | No USB keyboard support with secondary payloads |
++-----+-----------------------------------------------------------------+
+| 414 | X9SAE-V: No USB keyboard init on SeaBIOS using Radeon RX 6800XT |
++-----+-----------------------------------------------------------------+
+```
+
+
+### Platform-specific issues
+
+```eval_rst
++-----+-----------------------------------------------------------------+
+| # | Subject |
++=====+=================================================================+
+| 509 | SD Card hotplug not working on Apollo Lake |
++-----+-----------------------------------------------------------------+
+| 507 | Windows GPU driver fails on Google guybrush & skyrim boards |
++-----+-----------------------------------------------------------------+
+| 506 | APL/GML don't boot OS when CPU microcode included "from tree" |
++-----+-----------------------------------------------------------------+
+| 505 | Harcuvar CRB - 15 of 16 cores present in the operating system |
++-----+-----------------------------------------------------------------+
+| 499 | T440p - EDK2 fails with RESOURCE_ALLOCATION_TOP_DOWN enabled |
++-----+-----------------------------------------------------------------+
+| 495 | Stoney Chromebooks not booting PSPSecureOS |
++-----+-----------------------------------------------------------------+
+| 478 | X200 booting Linux takes a long time with TSC |
++-----+-----------------------------------------------------------------+
+| 474 | X200s crashes after graphic init with 8GB RAM |
++-----+-----------------------------------------------------------------+
+| 457 | Haswell (t440p): CAR mem region conflicts with CBFS_SIZE > 8mb |
++-----+-----------------------------------------------------------------+
+| 453 | Intel HDMI / DP Audio not present in Windows after libgfxinit |
++-----+-----------------------------------------------------------------+
+| 449 | ThinkPad T440p fail to start, continuous beeping & LED blinking |
++-----+-----------------------------------------------------------------+
+| 448 | Thinkpad T440P ACPI Battery Value Issues |
++-----+-----------------------------------------------------------------+
+| 446 | Optiplex 9010 No Post |
++-----+-----------------------------------------------------------------+
+| 439 | Lenovo X201 Turbo Boost not working (stuck on 2,4GHz) |
++-----+-----------------------------------------------------------------+
+| 427 | x200: Two battery charging issues |
++-----+-----------------------------------------------------------------+
+| 412 | x230 reboots on suspend |
++-----+-----------------------------------------------------------------+
+| 393 | T500 restarts rather than waking up from suspend |
++-----+-----------------------------------------------------------------+
+| 350 | I225 PCIe device not detected on Harcuvar |
++-----+-----------------------------------------------------------------+
+```
--
To view, visit https://review.coreboot.org/c/coreboot/+/80617?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idc224c43f2459faabf91a9ef282bb9eaeba42240
Gerrit-Change-Number: 80617
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Held, Matt DeVillier, Paul Menzel.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80179?usp=email )
Change subject: i2c/drivers/generic: Add support for including a rotation matrix
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/i2c/generic/chip.h:
https://review.coreboot.org/c/coreboot/+/80179/comment/9b990828_62ed5c9f :
PS4, Line 81: int
> using bool would make it more obvious that this is a boolean option and not an integer
I copied `detect` - should that be a bool?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80179?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id4a940d999a0e300a6fe21269f18bab6e3c0523c
Gerrit-Change-Number: 80179
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 19 Feb 2024 19:57:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Paul Menzel, Sean Rhodes.
Hello Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80179?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+2 by Matt DeVillier, Verified+1 by build bot (Jenkins)
Change subject: i2c/drivers/generic: Add support for including a rotation matrix
......................................................................
i2c/drivers/generic: Add support for including a rotation matrix
The Rotation Matrix allows the specification of a 3x3 matrix
representing the orientation of devices, such as accelerometers.
Each value in the matrix can be one of -1, 0, or 1, indicating the
transformation applied to the device's axes.
It is expected by Linux and required for the OS to interpret
the data from the device correctly. It is used by various drivers,
mainly in `iio/accel`.
It was tested on Ubuntu, by rotating the device and verifying the
orientation was correct.
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Id4a940d999a0e300a6fe21269f18bab6e3c0523c
---
M src/drivers/i2c/generic/chip.h
M src/drivers/i2c/generic/generic.c
2 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/80179/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/80179?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id4a940d999a0e300a6fe21269f18bab6e3c0523c
Gerrit-Change-Number: 80179
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset