Attention is currently required from: Andy Hsu, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/85763?usp=email )
Change subject: soc/mediatek/mt8196: Add GPUEB firmware v1.0
......................................................................
Patch Set 4:
(4 comments)
File soc/mediatek/mt8196/README.md:
https://review.coreboot.org/c/blobs/+/85763/comment/be17e14e_4b9f71ef?usp=e… :
PS1, Line 203: `tinysys-gpueb-RV33_A.mkpt_fw.img` to the SRAM of GPUEB.
> move to the next line
Done
https://review.coreboot.org/c/blobs/+/85763/comment/7fdcd54d_2645d8b1?usp=e… :
PS1, Line 203: . It will copy `tinysys-gpueb-RV33_A.mkpt_fw.img` to the SRAM of GPUEB.
> `, parse it, and copy the resulting image to the SRAM of GPUEB`
Done
https://review.coreboot.org/c/blobs/+/85763/comment/b7cb12b2_5968a4a0?usp=e… :
PS1, Line 207: reset to trigger GPUEB.
> move to the next line
Done
File soc/mediatek/mt8196/tinysys-gpueb-RV33_A.mkpt_fw.img:
PS1:
> Can we have a shorter file name please (such as `gpueb. […]
Done
--
To view, visit https://review.coreboot.org/c/blobs/+/85763?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I470f1575beea481cac2dcb5f3eb77587739ff2dc
Gerrit-Change-Number: 85763
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Andy Hsu <andy.hsu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Andy Hsu <andy.hsu(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Tue, 31 Dec 2024 02:43:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Andy Hsu, Jarried Lin, Yidi Lin.
Hello Andy Hsu, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/85763?usp=email
to look at the new patch set (#4).
Change subject: soc/mediatek/mt8196: Add GPUEB firmware v1.0
......................................................................
soc/mediatek/mt8196: Add GPUEB firmware v1.0
Add initial GPUEB firmware.
TEST=Build pass
BUG=b:317009620
Change-Id: I470f1575beea481cac2dcb5f3eb77587739ff2dc
Signed-off-by: Andy.Hsu <andy.hsu(a)mediatek.corp-partner.google.com>
---
M soc/mediatek/mt8196/README.md
A soc/mediatek/mt8196/gpueb_fw.img
A soc/mediatek/mt8196/gpueb_fw.img.md5
A soc/mediatek/mt8196/gpueb_release_notes.txt
4 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/63/85763/4
--
To view, visit https://review.coreboot.org/c/blobs/+/85763?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I470f1575beea481cac2dcb5f3eb77587739ff2dc
Gerrit-Change-Number: 85763
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Andy Hsu <andy.hsu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Andy Hsu <andy.hsu(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Attention is currently required from: Andy Hsu, Jarried Lin, Yidi Lin.
Hello Andy Hsu, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/85763?usp=email
to look at the new patch set (#3).
Change subject: soc/mediatek/mt8196: Add GPUEB firmware v1.0
......................................................................
soc/mediatek/mt8196: Add GPUEB firmware v1.0
Add initial GPUEB firmware.
TEST=Build pass
BUG=b:317009620
Change-Id: I470f1575beea481cac2dcb5f3eb77587739ff2dc
Signed-off-by: Andy.Hsu <andy.hsu(a)mediatek.corp-partner.google.com>
---
M soc/mediatek/mt8196/README.md
A soc/mediatek/mt8196/gpueb_fw.img
A soc/mediatek/mt8196/gpueb_fw.img.md5
A soc/mediatek/mt8196/gpueb_release_notes.txt
4 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/63/85763/3
--
To view, visit https://review.coreboot.org/c/blobs/+/85763?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I470f1575beea481cac2dcb5f3eb77587739ff2dc
Gerrit-Change-Number: 85763
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Andy Hsu <andy.hsu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Andy Hsu <andy.hsu(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Attention is currently required from: Andy Hsu, Jarried Lin, Yidi Lin.
Hello Andy Hsu, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/85763?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Yidi Lin
Change subject: soc/mediatek/mt8196: Add GPUEB firmware v1.0
......................................................................
soc/mediatek/mt8196: Add GPUEB firmware v1.0
Add initial GPUEB firmware.
TEST=Build pass
BUG=b:317009620
Change-Id: I470f1575beea481cac2dcb5f3eb77587739ff2dc
Signed-off-by: Andy.Hsu <andy.hsu(a)mediatek.corp-partner.google.com>
---
M soc/mediatek/mt8196/README.md
A soc/mediatek/mt8196/gpueb_fw.img
A soc/mediatek/mt8196/gpueb_fw.img.md5
A soc/mediatek/mt8196/gpueb_release_notes.txt
4 files changed, 28 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/63/85763/2
--
To view, visit https://review.coreboot.org/c/blobs/+/85763?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I470f1575beea481cac2dcb5f3eb77587739ff2dc
Gerrit-Change-Number: 85763
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Andy Hsu <andy.hsu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Andy Hsu <andy.hsu(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>