Attention is currently required from: Dinesh Gehlot, Elyes Haouas, Eran Mitrani, Jakub Czapiga, Jason Nien, Jayvik Desai, Kapil Porwal, Martin Roth, Nick Vaccaro, Pranava Y N, Subrata Banik, Tarun.
Eric Lai has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/85813?usp=email )
Change subject: tree: Use "true", "false" for has_power_resource
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85813?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I25b86ef577e072cfe3ef5dc2447113f11c51f747
Gerrit-Change-Number: 85813
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 31 Dec 2024 02:31:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Elyes Haouas, Pranava Y N.
Subrata Banik has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84809?usp=email )
Change subject: mb/google/fatcat: Remove unused <stdio.h>
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84809?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icc83efdd673390794fc443531ae7cc6834076383
Gerrit-Change-Number: 84809
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 31 Dec 2024 02:13:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Ian Feng.
Dtrain Hsu has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/85736?usp=email )
Change subject: mb/google/fatcat/var/francka: Fix early pad configuration for TPM
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Could we merge this CL? Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85736?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id08575d28f6f3bced74c0b301756fc8239cfd190
Gerrit-Change-Number: 85736
Gerrit-PatchSet: 4
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 31 Dec 2024 01:58:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Angel Pons.
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85772?usp=email
to look at the new patch set (#10).
Change subject: mb/asrock: Add Z77 Extreme4
......................................................................
mb/asrock: Add Z77 Extreme4
New port based on logs extracted from a board running OEM firmware.
VBT extracted from a running system with "intelvbttool --inlegacy".
Tested:
- i7-3770K CPU (native raminit)
- 2x8GB: G.skill F3-1600C9-8GAR (@1600MHz)
- 4x8GB: Corsair CMY16GX3M2A2400C (@1333MHz)
- libgfxinit txtmode with onboard HDMI, DVI and VGA
- Gigabit Ethernet
- CPU fan
- PS/2 keyboard or mouse (but not at the same time)
- SeaBIOS 1.16.3 booting to Devuan and Void Linux
- All internal SATA ports
- Rear USB ports
- Line out
- me_cleaner
- PCIe x16 slots, including automatic bifurcation (x8/x8)
- PCI slots
- Suspend and resume (S3)
- Serial port header COM1 (including coreboot output)
Untested:
- Intel VBIOS
- USB headers
- Other fans
- LED headers
- eSATA, SPDIF
- PCIe x1 slots
Change-Id: Idf028c6d411bd501b73a3c526240d0b1d6ecaa0c
Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com>
---
A src/mainboard/asrock/z77_extreme4/Kconfig
A src/mainboard/asrock/z77_extreme4/Kconfig.name
A src/mainboard/asrock/z77_extreme4/Makefile.mk
A src/mainboard/asrock/z77_extreme4/acpi/ec.asl
A src/mainboard/asrock/z77_extreme4/acpi/platform.asl
A src/mainboard/asrock/z77_extreme4/acpi/superio.asl
A src/mainboard/asrock/z77_extreme4/board_info.txt
A src/mainboard/asrock/z77_extreme4/cmos.default
A src/mainboard/asrock/z77_extreme4/cmos.layout
A src/mainboard/asrock/z77_extreme4/data.vbt
A src/mainboard/asrock/z77_extreme4/devicetree.cb
A src/mainboard/asrock/z77_extreme4/dsdt.asl
A src/mainboard/asrock/z77_extreme4/early_init.c
A src/mainboard/asrock/z77_extreme4/gma-mainboard.ads
A src/mainboard/asrock/z77_extreme4/gpio.c
A src/mainboard/asrock/z77_extreme4/hda_verb.c
A src/mainboard/asrock/z77_extreme4/mainboard.c
17 files changed, 633 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/85772/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/85772?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idf028c6d411bd501b73a3c526240d0b1d6ecaa0c
Gerrit-Change-Number: 85772
Gerrit-PatchSet: 10
Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Angel Pons.
Riku Viitanen has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85772?usp=email )
Change subject: mb/asrock: Add Z77 Extreme4
......................................................................
Patch Set 9:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85772?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idf028c6d411bd501b73a3c526240d0b1d6ecaa0c
Gerrit-Change-Number: 85772
Gerrit-PatchSet: 9
Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 31 Dec 2024 01:50:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Riku Viitanen.
Nicholas Chin has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85815?usp=email )
Change subject: mb/hp/snb_ivb_desktops/variants: Remove unused includes
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Not directly related to the comment in CB:79583, but `compaq_elite_8300_usdt/early_init.c` includes Nuvoton SuperIO headers but doesn't use them to enable the serial port like the other variants.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85815?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4082a2589441b1d257db622380733e2825b27c2
Gerrit-Change-Number: 85815
Gerrit-PatchSet: 2
Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Comment-Date: Tue, 31 Dec 2024 01:48:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kun Liu, Nick Vaccaro, Rui Zhou, Subrata Banik.
Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kun Liu, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85798?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by Eric Lai, Code-Review+2 by Jayvik Desai, Code-Review+2 by Kapil Porwal, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins)
Change subject: mb/google/nissa/var/rull: Configure Acoustic noise mitigation
......................................................................
mb/google/nissa/var/rull: Configure Acoustic noise mitigation
Follow the power team’s recommendation:
- Enable Acoustic noise mitigation
- Set slow slew rate VCCIA and VCCGT to SLEW_FAST_8
- Set FastPkgCRampDisable VCCIA and VCCGT to "true"
BUG=b:380384127
TEST=built firmware and verified by power team, and noise pass
Change-Id: Ib7f60f1248c6b46f4f9bac1731be4f0396766ae2
Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/rull/overridetree.cb
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/85798/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85798?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib7f60f1248c6b46f4f9bac1731be4f0396766ae2
Gerrit-Change-Number: 85798
Gerrit-PatchSet: 2
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>