coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[S] Change in coreboot[main]: mb/hp/snb_ivb_desktops/z220*: Remove leftover old usb configurations
by Nicholas Chin (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Riku Viitanen. Nicholas Chin has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85817?usp=email ) Change subject: mb/hp/snb_ivb_desktops/z220*: Remove leftover old usb configurations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85817?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f478625ad4928cf23bbb8ac2689004010bbdd4b Gerrit-Change-Number: 85817 Gerrit-PatchSet: 1 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Comment-Date: Tue, 31 Dec 2024 01:43:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/hp/snb_ivb_desktops/variants: Remove unused includes
by Nicholas Chin (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Riku Viitanen. Nicholas Chin has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85815?usp=email ) Change subject: mb/hp/snb_ivb_desktops/variants: Remove unused includes ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85815/comment/bb24b992_12295c7b?us… : PS2, Line 9: CB:79583 Since this is merged, please use the commit hash. Perhaps: "As pointed out after commit 7e05377f16bd ("mb/hp/snb_ivb_desktops: Add 8200 USDT variant") was merged," -- To view, visit https://review.coreboot.org/c/coreboot/+/85815?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4082a2589441b1d257db622380733e2825b27c2 Gerrit-Change-Number: 85815 Gerrit-PatchSet: 2 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Comment-Date: Tue, 31 Dec 2024 01:42:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Remove unused <stdio.h>
by Nicholas Chin (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Elyes Haouas, Pranava Y N, Subrata Banik. Nicholas Chin has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84809?usp=email ) Change subject: mb/google/fatcat: Remove unused <stdio.h> ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84809?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icc83efdd673390794fc443531ae7cc6834076383 Gerrit-Change-Number: 84809 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 31 Dec 2024 01:37:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: drivers/asmedia: Enable AHCI for ASM1061
by Nicholas Chin (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Angel Pons. Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85816?usp=email ) Change subject: drivers/asmedia: Enable AHCI for ASM1061 ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > There also seems to be some existing board ports where the ASM1061 ports work without this patch, li […] Took a closer look at the original commits and it seems like they generally work once booted into the OS, but can't be booted from. Perhaps differences in the distros used to test the boards is causing different drivers to be loaded when the ASM1061 is being reported as not working at all vs working only in Linux. -- To view, visit https://review.coreboot.org/c/coreboot/+/85816?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a1470894261c7d14fadccdcade968f87f78fe23 Gerrit-Change-Number: 85816 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 31 Dec 2024 01:05:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z77 Extreme4
by Riku Viitanen (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Angel Pons. Hello Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85772?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/asrock: Add Z77 Extreme4 ...................................................................... mb/asrock: Add Z77 Extreme4 New port based on logs extracted from a board running OEM firmware. VBT extracted from a running system with "intelvbttool --inlegacy". Tested: - i7-3770K CPU (native raminit) - 2x8GB: G.skill F3-1600C9-8GAR (@1600MHz) - 4x8GB: Corsair CMY16GX3M2A2400C (@1333MHz) - libgfxinit txtmode with onboard HDMI, DVI and VGA - Gigabit Ethernet - CPU fan - PS/2 keyboard or mouse (but not at the same time) - SeaBIOS 1.16.3 booting to Devuan and Void Linux - All internal SATA ports - Rear USB ports - Line out - me_cleaner - PCIe x16 slots, including automatic bifurcation (x8/x8) - PCI slots - Suspend and resume (S3) - Dr. Debug (shows post codes during boot) - Serial port header COM1 (including coreboot output) Untested: - Intel VBIOS - USB headers - Other fans - LED headers - eSATA, SPDIF - PCIe x1 slots Change-Id: Idf028c6d411bd501b73a3c526240d0b1d6ecaa0c Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> --- A src/mainboard/asrock/z77_extreme4/Kconfig A src/mainboard/asrock/z77_extreme4/Kconfig.name A src/mainboard/asrock/z77_extreme4/Makefile.mk A src/mainboard/asrock/z77_extreme4/acpi/ec.asl A src/mainboard/asrock/z77_extreme4/acpi/platform.asl A src/mainboard/asrock/z77_extreme4/acpi/superio.asl A src/mainboard/asrock/z77_extreme4/board_info.txt A src/mainboard/asrock/z77_extreme4/cmos.default A src/mainboard/asrock/z77_extreme4/cmos.layout A src/mainboard/asrock/z77_extreme4/data.vbt A src/mainboard/asrock/z77_extreme4/devicetree.cb A src/mainboard/asrock/z77_extreme4/dsdt.asl A src/mainboard/asrock/z77_extreme4/early_init.c A src/mainboard/asrock/z77_extreme4/gma-mainboard.ads A src/mainboard/asrock/z77_extreme4/gpio.c A src/mainboard/asrock/z77_extreme4/hda_verb.c A src/mainboard/asrock/z77_extreme4/mainboard.c 17 files changed, 633 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/85772/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/85772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idf028c6d411bd501b73a3c526240d0b1d6ecaa0c Gerrit-Change-Number: 85772 Gerrit-PatchSet: 8 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[M] Change in coreboot[main]: drivers/asmedia: Enable AHCI for ASM1061
by Nicholas Chin (Code Review) 30 Dec '24

30 Dec '24

Attention is currently required from: Angel Pons. Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85816?usp=email ) Change subject: drivers/asmedia: Enable AHCI for ASM1061 ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: There also seems to be some existing board ports where the ASM1061 ports work without this patch, like the ASRock H77 Pro4-M and the ASUS P8Z77-M Pro. Not sure exactly why that is. It does seem like the ASM1061 supports a 64K SPI flash for option ROM support; perhaps those boards have an option ROM onboard that SeaBIOS is perhaps running? -- To view, visit https://review.coreboot.org/c/coreboot/+/85816?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a1470894261c7d14fadccdcade968f87f78fe23 Gerrit-Change-Number: 85816 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 30 Dec 2024 23:41:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: drivers/asmedia: Enable AHCI for ASM1061
by Jan Philipp Groß (Code Review) 30 Dec '24

30 Dec '24

Attention is currently required from: Angel Pons, Nicholas Chin. Jan Philipp Groß has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85816?usp=email ) Change subject: drivers/asmedia: Enable AHCI for ASM1061 ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > I'm not sure I understand what you mean I assume Angel is talking about those: https://www.ebay.de/itm/404650966945 ? -- To view, visit https://review.coreboot.org/c/coreboot/+/85816?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a1470894261c7d14fadccdcade968f87f78fe23 Gerrit-Change-Number: 85816 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 30 Dec 2024 23:06:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[S] Change in coreboot[main]: mb/hp/snb_ivb_desktops/z220*: Remove leftover old usb configurations
by Riku Viitanen (Code Review) 30 Dec '24

30 Dec '24

Riku Viitanen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85817?usp=email ) Change subject: mb/hp/snb_ivb_desktops/z220*: Remove leftover old usb configurations ...................................................................... mb/hp/snb_ivb_desktops/z220*: Remove leftover old usb configurations Since all USB configurations are read from the southbridge devicetree, these configurations aren't used anymore. TEST=Built Z220 CMT with BUILD_TIMELESS=1, output ROMs are identical. Change-Id: I8f478625ad4928cf23bbb8ac2689004010bbdd4b Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> --- M src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/early_init.c M src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/early_init.c 2 files changed, 0 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/85817/1 diff --git a/src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/early_init.c b/src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/early_init.c index 74a6462..aace18d 100644 --- a/src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/early_init.c +++ b/src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/early_init.c @@ -3,27 +3,9 @@ #include <bootblock_common.h> #include <superio/nuvoton/npcd378/npcd378.h> #include <superio/nuvoton/common/nuvoton.h> -#include <southbridge/intel/bd82x6x/pch.h> #define SERIAL_DEV PNP_DEV(0x2e, NPCD378_SP2) -const struct southbridge_usb_port mainboard_usb_ports[] = { - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 1, 5 }, - { 1, 0, 5 }, - { 1, 0, 5 }, - { 1, 0, 5 }, - { 1, 0, 7 }, - { 1, 0, 7 }, -}; - void bootblock_mainboard_early_init(void) { if (CONFIG(CONSOLE_SERIAL)) diff --git a/src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/early_init.c b/src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/early_init.c index 74a6462..aace18d 100644 --- a/src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/early_init.c +++ b/src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/early_init.c @@ -3,27 +3,9 @@ #include <bootblock_common.h> #include <superio/nuvoton/npcd378/npcd378.h> #include <superio/nuvoton/common/nuvoton.h> -#include <southbridge/intel/bd82x6x/pch.h> #define SERIAL_DEV PNP_DEV(0x2e, NPCD378_SP2) -const struct southbridge_usb_port mainboard_usb_ports[] = { - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 1, 5 }, - { 1, 0, 5 }, - { 1, 0, 5 }, - { 1, 0, 5 }, - { 1, 0, 7 }, - { 1, 0, 7 }, -}; - void bootblock_mainboard_early_init(void) { if (CONFIG(CONSOLE_SERIAL)) -- To view, visit https://review.coreboot.org/c/coreboot/+/85817?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f478625ad4928cf23bbb8ac2689004010bbdd4b Gerrit-Change-Number: 85817 Gerrit-PatchSet: 1 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com>

1 0

[M] Change in coreboot[main]: drivers/asmedia: Enable AHCI for ASM1061
by Nicholas Chin (Code Review) 30 Dec '24

30 Dec '24

Attention is currently required from: Angel Pons, Jan Philipp Groß. Hello Angel Pons, Jan Philipp Groß, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85816?usp=email to look at the new patch set (#4). Change subject: drivers/asmedia: Enable AHCI for ASM1061 ...................................................................... drivers/asmedia: Enable AHCI for ASM1061 The ASMedia ASM1061 seems to default to IDE mode, preventing SATA drives from working properly in Linux as it tries to load the AHCI driver for it. From the behaviour of vendor firmware on the ASRock Z87 Extreme 4, the mode can be changed by setting the PCI Subclass register to either 0x06 (SATA controller) or 0x01 (IDE controller). This register seems to be read only, but can be unlocked for writing by setting bit 2 at offset 0xEC in the PCI config space. Since the ASMEDIA_ASPM_BLACKLIST driver already existed and only matched the ASM1061, rename it to ASMEDIA_ASM1061 and add the AHCI mode setting code to it. Tested on the ASUS Maximus VI Gene. Change-Id: I7a1470894261c7d14fadccdcade968f87f78fe23 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M src/drivers/asmedia/Kconfig M src/drivers/asmedia/Makefile.mk A src/drivers/asmedia/asm1061.c D src/drivers/asmedia/aspm_blacklist.c M src/mainboard/asrock/b75pro3-m/Kconfig M src/mainboard/asrock/fatal1ty_z87_professional/Kconfig M src/mainboard/asrock/h77pro4-m/Kconfig M src/mainboard/asus/h61-series/Kconfig M src/mainboard/asus/p8x7x-series/Kconfig 9 files changed, 49 insertions(+), 39 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/85816/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85816?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a1470894261c7d14fadccdcade968f87f78fe23 Gerrit-Change-Number: 85816 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[M] Change in coreboot[main]: drivers/asmedia: Enable AHCI for ASM1061
by Nicholas Chin (Code Review) 30 Dec '24

30 Dec '24

Attention is currently required from: Angel Pons, Jan Philipp Groß. Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85816?usp=email ) Change subject: drivers/asmedia: Enable AHCI for ASM1061 ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > There are PCIe cards with this chip, does it make sense to keep the Kconfig? I'm not sure I understand what you mean -- To view, visit https://review.coreboot.org/c/coreboot/+/85816?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a1470894261c7d14fadccdcade968f87f78fe23 Gerrit-Change-Number: 85816 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 30 Dec 2024 23:01:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
302
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024