coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XS] Change in coreboot[main]: mb/google/rex/var/kanix: Add Synaptics touchpad
by Kenneth Chan (Code Review) 26 Dec '24

26 Dec '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Kenneth Chan, Subrata Banik, Tarun, Tyler Wang. Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, Tyler Wang, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85776?usp=email to look at the new patch set (#2). Change subject: mb/google/rex/var/kanix: Add Synaptics touchpad ...................................................................... mb/google/rex/var/kanix: Add Synaptics touchpad Add Synaptics touchpad for kanix. BUG=None TEST=1. emerge-rex coreboot 2. check touchpad function is working properly. Change-Id: I89b9e24f98c1e7af571507283469411fd389431a Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/kanix/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/85776/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I89b9e24f98c1e7af571507283469411fd389431a Gerrit-Change-Number: 85776 Gerrit-PatchSet: 2 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/kanix: Add Synaptics touchpad
by Kenneth Chan (Code Review) 26 Dec '24

26 Dec '24

Kenneth Chan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85776?usp=email ) Change subject: mb/google/rex/var/kanix: Add Synaptics touchpad ...................................................................... mb/google/rex/var/kanix: Add Synaptics touchpad Add Synaptics touchpad for kanix. BUG=None TEST=emerge-rex coreboot and check touchpad function is working properly. Change-Id: I89b9e24f98c1e7af571507283469411fd389431a Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/kanix/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/85776/1 diff --git a/src/mainboard/google/rex/variants/kanix/overridetree.cb b/src/mainboard/google/rex/variants/kanix/overridetree.cb index 244f974..b3a40f0 100644 --- a/src/mainboard/google/rex/variants/kanix/overridetree.cb +++ b/src/mainboard/google/rex/variants/kanix/overridetree.cb @@ -450,6 +450,15 @@ register "hid_desc_reg_offset" = "0x20" device i2c 68 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_B00_IRQ)" + register "generic.wake" = "GPE0_DW0_00" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end end device ref i2c4 on chip drivers/i2c/tpm -- To view, visit https://review.coreboot.org/c/coreboot/+/85776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I89b9e24f98c1e7af571507283469411fd389431a Gerrit-Change-Number: 85776 Gerrit-PatchSet: 1 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Modify interrupt GPIO for LPSS I2C touchpad
by Kapil Porwal (Code Review) 26 Dec '24

26 Dec '24

Attention is currently required from: Pranava Y N. Kapil Porwal has posted comments on this change by Pranava Y N. ( https://review.coreboot.org/c/coreboot/+/85754?usp=email ) Change subject: mb/google/fatcat/var/fatcat: Modify interrupt GPIO for LPSS I2C touchpad ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85754?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I37a9d3aae67883f9eb4f47d76b4f48ac6ebb6d16 Gerrit-Change-Number: 85754 Gerrit-PatchSet: 2 Gerrit-Owner: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Thu, 26 Dec 2024 11:53:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: lib/{fit,fit_payload}.c: Enhance support for FIT images
by Lean Sheng Tan (Code Review) 26 Dec '24

26 Dec '24

Attention is currently required from: Benjamin Doron, Felix Held, Julius Werner, Matt DeVillier, Maximilian Brune, Philipp Hug, ron minnich. Lean Sheng Tan has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/84796?usp=email ) Change subject: lib/{fit,fit_payload}.c: Enhance support for FIT images ...................................................................... Patch Set 9: (1 comment) File src/lib/fit.c: https://review.coreboot.org/c/coreboot/+/84796/comment/fbf3d0ba_efa616e5?us… : PS4, Line 523: } > True, and the current solution runs into the issue of how images could have clashing load addresses, […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/84796?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6a21954c0dc5fd820d135e8cd0599ce87903a1c0 Gerrit-Change-Number: 84796 Gerrit-PatchSet: 9 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 26 Dec 2024 10:49:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[S] Change in coreboot[main]: soc/intel/xeon_sp/spr/acpi: Fix regression
by Lean Sheng Tan (Code Review) 26 Dec '24

26 Dec '24

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85562?usp=email ) Change subject: soc/intel/xeon_sp/spr/acpi: Fix regression ...................................................................... soc/intel/xeon_sp/spr/acpi: Fix regression Fix regression introduced in commit 177bb5e9b9789cc830f504815e711973190def4e ("soc/intel/xeon_sp: Revise IIO domain ACPI name encoding"). Ensure domain ACPI names in the DSDT are in sync with SSDT ACPI names. Fixes PCI devices not discovered on socket 1-3. TEST: Booted in ibm/sbp1 and found all PCI devices working, no errors in dmesg are shown. Change-Id: Ice168bdebc46dc0cfb9c63c78c46a5d9ff2b7658 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85562 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Shuo Liu <shuo.liu(a)intel.com> --- M src/soc/intel/xeon_sp/spr/acpi/cxl_resource.asl M src/soc/intel/xeon_sp/spr/acpi/pci_resource.asl M src/soc/intel/xeon_sp/spr/acpi/uncore.asl 3 files changed, 12 insertions(+), 4 deletions(-) Approvals: Shuo Liu: Looks good to me, approved Angel Pons: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/soc/intel/xeon_sp/spr/acpi/cxl_resource.asl b/src/soc/intel/xeon_sp/spr/acpi/cxl_resource.asl index 553ca9d..7676a3f 100644 --- a/src/soc/intel/xeon_sp/spr/acpi/cxl_resource.asl +++ b/src/soc/intel/xeon_sp/spr/acpi/cxl_resource.asl @@ -8,7 +8,7 @@ #define _IIO_DEVICE_UID(str, skt, stk) STR(str##skt##stk) #define IIO_DEVICE_UID(str, skt, stk) _IIO_DEVICE_UID(str, skt, stk) -Device (IIO_DEVICE_NAME(DEVPREFIX, SOCKET, STACK)) +Device (IIO_DEVICE_NAME(DEVPREFIX, SOCKET_NAME, STACK)) { Name (_HID, "ACPI0017") /* CXL */ Name (_CID, Package (0x02) @@ -16,7 +16,7 @@ EisaId ("PNP0A08") /* PCI Express Bus */, EisaId ("PNP0A03") /* PCI Bus */ }) - Name (_UID, IIO_DEVICE_UID(DEVPREFIX, SOCKET, STACK)) + Name (_UID, IIO_DEVICE_UID(DEVPREFIX, SOCKET_NAME, STACK)) Method (_STA, 0, NotSerialized) { /* diff --git a/src/soc/intel/xeon_sp/spr/acpi/pci_resource.asl b/src/soc/intel/xeon_sp/spr/acpi/pci_resource.asl index fdb599e..a2cc03f 100644 --- a/src/soc/intel/xeon_sp/spr/acpi/pci_resource.asl +++ b/src/soc/intel/xeon_sp/spr/acpi/pci_resource.asl @@ -8,11 +8,11 @@ #define _IIO_DEVICE_UID(str, skt, stk) STR(str##skt##stk) #define IIO_DEVICE_UID(str, skt, stk) _IIO_DEVICE_UID(str, skt, stk) -Device (IIO_DEVICE_NAME(DEVPREFIX, SOCKET, STACK)) +Device (IIO_DEVICE_NAME(DEVPREFIX, SOCKET_NAME, STACK)) { Name (_HID, EisaId ("PNP0A08") /* PCI Express Bus */) Name (_CID, EisaId ("PNP0A03") /* PCI Bus */) - Name (_UID, IIO_DEVICE_UID(DEVPREFIX, SOCKET, STACK)) + Name (_UID, IIO_DEVICE_UID(DEVPREFIX, SOCKET_NAME, STACK)) Method (_STA, 0, NotSerialized) { /* diff --git a/src/soc/intel/xeon_sp/spr/acpi/uncore.asl b/src/soc/intel/xeon_sp/spr/acpi/uncore.asl index c1b8bdc..f6fbe96 100644 --- a/src/soc/intel/xeon_sp/spr/acpi/uncore.asl +++ b/src/soc/intel/xeon_sp/spr/acpi/uncore.asl @@ -10,7 +10,9 @@ { #include "uncore_irq.asl" + // Keep in sync with iio_domain_set_acpi_name()! #define SOCKET 0 + #define SOCKET_NAME 0 #include "iiostack.asl" #undef SOCKET @@ -24,19 +26,25 @@ #endif #if (CONFIG_MAX_SOCKET > 1) + // Keep in sync with iio_domain_set_acpi_name()! #define SOCKET 1 + #define SOCKET_NAME 2 #include "iiostack.asl" #undef SOCKET #endif #if (CONFIG_MAX_SOCKET > 2) + // Keep in sync with iio_domain_set_acpi_name()! #define SOCKET 2 + #define SOCKET_NAME 4 #include "iiostack.asl" #undef SOCKET #endif #if (CONFIG_MAX_SOCKET > 3) + // Keep in sync with iio_domain_set_acpi_name()! #define SOCKET 3 + #define SOCKET_NAME 6 #include "iiostack.asl" #undef SOCKET #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/85562?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ice168bdebc46dc0cfb9c63c78c46a5d9ff2b7658 Gerrit-Change-Number: 85562 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/francka: Use RAM ID 2 for MT62F2G32D4DS-020 WT:F
by Dtrain Hsu (Code Review) 26 Dec '24

26 Dec '24

Attention is currently required from: Amanda Hwang, Pranava Y N. Dtrain Hsu has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/85775?usp=email ) Change subject: mb/google/fatcat/var/francka: Use RAM ID 2 for MT62F2G32D4DS-020 WT:F ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia486d892fca0ed2a9e3e869b97b43af617ef17ac Gerrit-Change-Number: 85775 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Thu, 26 Dec 2024 08:52:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/francka: Use RAM ID 2 for MT62F2G32D4DS-020 WT:F
by Subrata Banik (Code Review) 26 Dec '24

26 Dec '24

Attention is currently required from: Amanda Hwang, Pranava Y N. Subrata Banik has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/85775?usp=email ) Change subject: mb/google/fatcat/var/francka: Use RAM ID 2 for MT62F2G32D4DS-020 WT:F ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia486d892fca0ed2a9e3e869b97b43af617ef17ac Gerrit-Change-Number: 85775 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Thu, 26 Dec 2024 07:53:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/francka: Use RAM ID 2 for MT62F2G32D4DS-020 WT:F
by Amanda Hwang (Code Review) 26 Dec '24

26 Dec '24

Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85775?usp=email ) Change subject: mb/google/fatcat/var/francka: Use RAM ID 2 for MT62F2G32D4DS-020 WT:F ...................................................................... mb/google/fatcat/var/francka: Use RAM ID 2 for MT62F2G32D4DS-020 WT:F Change the ram_id to 2 for MT62F2G32D4DS-020 WT:F based on the hardware schematic MB_SCH_1224A. BUG=b:372395010 TEST=Run part_id_gen tool and check the generated files. Change-Id: Ia486d892fca0ed2a9e3e869b97b43af617ef17ac Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com> --- M src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk M src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt M src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt 3 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/85775/1 diff --git a/src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk b/src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk index 310ef55..b18b9c4 100644 --- a/src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk +++ b/src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk @@ -5,4 +5,5 @@ SPD_SOURCES = SPD_SOURCES += spd/lp5/set-0/spd-empty.hex # ID = 0(0b0000) -SPD_SOURCES += spd/lp5/set-0/spd-10.hex # ID = 1(0b0001) Parts = MT62F2G32D4DS-020 WT:F +SPD_SOURCES += spd/lp5/set-0/spd-empty.hex # ID = 1(0b0001) +SPD_SOURCES += spd/lp5/set-0/spd-10.hex # ID = 2(0b0010) Parts = MT62F2G32D4DS-020 WT:F diff --git a/src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt b/src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt index dcb790a..3d31714 100644 --- a/src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt +++ b/src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt @@ -4,4 +4,4 @@ # util/spd_tools/bin/part_id_gen PTL lp5 src/mainboard/google/fatcat/variants/francka/memory src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt DRAM Part Name ID to assign -MT62F2G32D4DS-020 WT:F 1 (0001) +MT62F2G32D4DS-020 WT:F 2 (0010) diff --git a/src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt b/src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt index 9b80035..09d6e0b 100644 --- a/src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt +++ b/src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt @@ -9,4 +9,4 @@ # See util/spd_tools/README.md for more details and instructions. # Part Name -MT62F2G32D4DS-020 WT:F,1 +MT62F2G32D4DS-020 WT:F,2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia486d892fca0ed2a9e3e869b97b43af617ef17ac Gerrit-Change-Number: 85775 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>

1 0

[M] Change in coreboot[main]: soc/intel/alderlake: Add function to force disable memory channels
by Jayvik Desai (Code Review) 26 Dec '24

26 Dec '24

Attention is currently required from: Angel Pons, Christian Walter, Eric Lai, Jamie Chen, Jeremy Soller, Kapil Porwal, Lean Sheng Tan, Michał Kopeć, Michał Żygowski, Nick Vaccaro, Paul Menzel, Piotr Król, Sean Rhodes, Tim Crawford. Jayvik Desai has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/85529?usp=email ) Change subject: soc/intel/alderlake: Add function to force disable memory channels ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibfeca4509cb3d88bc1bac2ac2d480e665d895bc5 Gerrit-Change-Number: 85529 Gerrit-PatchSet: 11 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Comment-Date: Thu, 26 Dec 2024 07:40:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: util/intelp2m: Rework platforms and fields packages
by Maxim (Code Review) 26 Dec '24

26 Dec '24

Attention is currently required from: Daniel Maslowski, David Hendricks. Hello Daniel Maslowski, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71167?usp=email to look at the new patch set (#23). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/intelp2m: Rework platforms and fields packages ...................................................................... util/intelp2m: Rework platforms and fields packages - embed the base platform and redefine its methods if they differ; - separate the macro structures from the platform; - move more functions to common; - undo use of a single global instance of the microstructure. TEST: 1) 'make test' = PASS 2) './intelp2m -p cnl -iiii -file inteltool.log' = gpio.h before and after the commit is the same. Change-Id: I2e0aa56efa2430ac6524c6977f8b6fd13113edf9 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/intelp2m/fields/cb/cb.go M util/intelp2m/fields/cb/cb_test.go M util/intelp2m/fields/fields.go M util/intelp2m/fields/fsp/fsp.go M util/intelp2m/fields/fsp/fsp_test.go M util/intelp2m/fields/raw/raw.go M util/intelp2m/fields/raw/raw_test.go M util/intelp2m/fields/test/suite.go M util/intelp2m/parser/parser.go M util/intelp2m/platforms/adl/adl_test.go M util/intelp2m/platforms/adl/macro.go M util/intelp2m/platforms/adl/template.go M util/intelp2m/platforms/apl/apl_test.go M util/intelp2m/platforms/apl/macro.go M util/intelp2m/platforms/apl/template.go M util/intelp2m/platforms/cnl/cnl_test.go M util/intelp2m/platforms/cnl/macro.go M util/intelp2m/platforms/cnl/template.go A util/intelp2m/platforms/common/common.go M util/intelp2m/platforms/common/macro.go A util/intelp2m/platforms/common/register/helper.go M util/intelp2m/platforms/ebg/ebg_test.go M util/intelp2m/platforms/ebg/macro.go M util/intelp2m/platforms/ebg/template.go D util/intelp2m/platforms/interfaces.go M util/intelp2m/platforms/jsl/jsl_test.go M util/intelp2m/platforms/jsl/macro.go M util/intelp2m/platforms/jsl/template.go M util/intelp2m/platforms/lbg/lbg_test.go M util/intelp2m/platforms/lbg/macro.go M util/intelp2m/platforms/lbg/template.go M util/intelp2m/platforms/mtl/macro.go M util/intelp2m/platforms/mtl/mtl_test.go M util/intelp2m/platforms/mtl/template.go A util/intelp2m/platforms/platforms.go M util/intelp2m/platforms/snr/macro.go M util/intelp2m/platforms/snr/snr_test.go M util/intelp2m/platforms/snr/template.go M util/intelp2m/platforms/test/suite.go M util/intelp2m/platforms/tgl/macro.go M util/intelp2m/platforms/tgl/template.go M util/intelp2m/platforms/tgl/tgl_test.go 42 files changed, 1,126 insertions(+), 1,569 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/71167/23 -- To view, visit https://review.coreboot.org/c/coreboot/+/71167?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e0aa56efa2430ac6524c6977f8b6fd13113edf9 Gerrit-Change-Number: 71167 Gerrit-PatchSet: 23 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024