coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[S] Change in coreboot[main]: ec/google/chromeec: Add function to detect barrel charger
by Subrata Banik (Code Review) 26 Dec '24

26 Dec '24

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jérémy Compostella, Pranava Y N. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85765?usp=email ) Change subject: ec/google/chromeec: Add function to detect barrel charger ...................................................................... Patch Set 1: (3 comments) File src/ec/google/chromeec/ec.h: https://review.coreboot.org/c/coreboot/+/85765/comment/4cd092c6_7e49deb7?us… : PS1, Line 154: * @return true: if the barrel_charger is present > s/barrel_charger/barrel charger/ Acknowledged File src/ec/google/chromeec/ec.c: https://review.coreboot.org/c/coreboot/+/85765/comment/c00186fc_8ebff9d7?us… : PS1, Line 1024: /* > A few minor suggestions: […] Acknowledged https://review.coreboot.org/c/coreboot/+/85765/comment/d3a77b8b_32954da0?us… : PS1, Line 1029: */ > considering these variables are boolean, I would suggest to use boolean test operator like `!`: […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/85765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9644f0dec057f95bb0a22cdc18edc1a0234ee3a9 Gerrit-Change-Number: 85765 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Thu, 26 Dec 2024 19:20:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add API to check if a USB PD charger is attached
by Subrata Banik (Code Review) 26 Dec '24

26 Dec '24

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jérémy Compostella, Kapil Porwal, Pranava Y N. Hello Boris Mittelberg, Caveh Jalali, Kapil Porwal, Pranava Y N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85743?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by Kapil Porwal, Verified+1 by build bot (Jenkins) Change subject: ec/google/chromeec: Add API to check if a USB PD charger is attached ...................................................................... ec/google/chromeec: Add API to check if a USB PD charger is attached This change introduces a new API, `google_chromeec_is_usb_pd_attached()` which checks the current status of the USB-C port and returns whether a USB Power Delivery (PD) charger is currently connected. This API is useful for determining if the system is currently being powered by a PD charger. BUG=b:377798581 TEST=Able to read the PD status correctly while booting google/fatcat. Change-Id: I47c934ee8a7563d4ba5124bff5613e61dd66e923 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/85743/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I47c934ee8a7563d4ba5124bff5613e61dd66e923 Gerrit-Change-Number: 85743 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add API to check if a USB PD charger is attached
by Subrata Banik (Code Review) 26 Dec '24

26 Dec '24

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jérémy Compostella, Pranava Y N. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85743?usp=email ) Change subject: ec/google/chromeec: Add API to check if a USB PD charger is attached ...................................................................... Patch Set 3: (1 comment) File src/ec/google/chromeec/ec.c: https://review.coreboot.org/c/coreboot/+/85743/comment/48bb7c6d_028ee382?us… : PS3, Line 985: if (resp.type == USB_CHG_TYPE_PD) > Could be `return resp. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/85743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I47c934ee8a7563d4ba5124bff5613e61dd66e923 Gerrit-Change-Number: 85743 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Thu, 26 Dec 2024 19:06:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add API to check if charger is present
by Jérémy Compostella (Code Review) 26 Dec '24

26 Dec '24

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add API to check if a USB PD charger is attached
by Jérémy Compostella (Code Review) 26 Dec '24

26 Dec '24

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add API to check if battery is critically low
by Jérémy Compostella (Code Review) 26 Dec '24

26 Dec '24

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add function to detect barrel charger
by Jérémy Compostella (Code Review) 26 Dec '24

26 Dec '24

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Pranava Y N, Subrata Banik. Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85765?usp=email ) Change subject: ec/google/chromeec: Add function to detect barrel charger ...................................................................... Patch Set 1: (3 comments) File src/ec/google/chromeec/ec.h: https://review.coreboot.org/c/coreboot/+/85765/comment/830aa741_fafa5b96?us… : PS1, Line 154: * @return true: if the barrel_charger is present s/barrel_charger/barrel charger/ File src/ec/google/chromeec/ec.c: https://review.coreboot.org/c/coreboot/+/85765/comment/e2c7317e_4bd5775d?us… : PS1, Line 1024: /* A few minor suggestions: If both barrel charger and USB-C PD are present at once, the barrelcharger takes precedence over USB-C PD. As a result, `google_chromeec_is_usb_pd_attached()` will return `false`. This logic can then be used to deterministically determine if a barrel charger is present, even when both a barrel charger and USB-C PD are attached. https://review.coreboot.org/c/coreboot/+/85765/comment/36dde893_07e7545d?us… : PS1, Line 1029: */ considering these variables are boolean, I would suggest to use boolean test operator like `!`: ``` if (ac_charger_present && !usb_pd_present == false) ``` A simple return be even better actually: ``` return ac_charger_present && !usb_pd_present; ``` You may not even need intermediate variable as function names are self explanatory. -- To view, visit https://review.coreboot.org/c/coreboot/+/85765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9644f0dec057f95bb0a22cdc18edc1a0234ee3a9 Gerrit-Change-Number: 85765 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Thu, 26 Dec 2024 18:37:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: util/intelp2m/platforms: Add support for Elkhart Lake
by Maxim Polyakov (Code Review) 26 Dec '24

26 Dec '24

Attention is currently required from: Alexander Couzens. Maxim Polyakov has uploaded a new patch set (#8) to the change originally created by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/84191?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/intelp2m/platforms: Add support for Elkhart Lake ...................................................................... util/intelp2m/platforms: Add support for Elkhart Lake TEST: - 'make test' = PASS; - 'intelp2m -p ehl -file parser/testlog/inteltool_test.log' = no errors. Change-Id: I0f60d182bc5cc3d0d1d1177fbda0cfe8e2279e46 Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M Documentation/util/intelp2m/index.md M util/intelp2m/cli/options.go M util/intelp2m/config/p2m/config.go A util/intelp2m/platforms/ehl/ehl.go A util/intelp2m/platforms/ehl/ehl_test.go M util/intelp2m/platforms/platforms.go M util/intelp2m/version.txt 7 files changed, 166 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/84191/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/84191?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0f60d182bc5cc3d0d1d1177fbda0cfe8e2279e46 Gerrit-Change-Number: 84191 Gerrit-PatchSet: 8 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z77 Extreme4
by Riku Viitanen (Code Review) 26 Dec '24

26 Dec '24

Riku Viitanen has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85772?usp=email ) Change subject: mb/asrock: Add Z77 Extreme4 ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/85772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idf028c6d411bd501b73a3c526240d0b1d6ecaa0c Gerrit-Change-Number: 85772 Gerrit-PatchSet: 3 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Dec 2024 16:03:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: qualcomm/common: Remove dead code
by Ariel Otilibili (Code Review) 26 Dec '24

26 Dec '24

Ariel Otilibili has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85778?usp=email ) Change subject: qualcomm/common: Remove dead code ...................................................................... qualcomm/common: Remove dead code fb_off is set to zero, meaning the else branch is never called. Coverity-ID: 1469336 Fixes: 3b4c45efa2 ("sc7180: Add display hardware pipe line initialization") Cc: Jonathon Hall <jonathon.hall(a)puri.sm> Cc: Yidi Lin <yidilin(a)google.com> Cc: Varshit Pandya <pandyavarshit(a)gmail.com> Cc: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I40cffcf3714decfc54f2bbce9d4a867a9313d72e Signed-off-by: Ariel Otilibili <otilibil(a)eurecom.fr> --- M src/soc/qualcomm/common/display/mdss.c 1 file changed, 2 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/85778/1 diff --git a/src/soc/qualcomm/common/display/mdss.c b/src/soc/qualcomm/common/display/mdss.c index a1c13ee..0a7a29d 100644 --- a/src/soc/qualcomm/common/display/mdss.c +++ b/src/soc/qualcomm/common/display/mdss.c @@ -21,13 +21,8 @@ out_size = img_size; stride = (edid->mode.ha * edid->framebuffer_bits_per_pixel/8); - if (!fb_off) { /* left */ - dst_xy = (edid->mode.vborder << 16) | edid->mode.hborder; - src_xy = dst_xy; - } else { /* right */ - dst_xy = (edid->mode.vborder << 16); - src_xy = (edid->mode.vborder << 16) | fb_off; - } + dst_xy = (edid->mode.vborder << 16) | edid->mode.hborder; + src_xy = dst_xy; printk(BIOS_INFO, "%s: src=%x fb_off=%x src_xy=%x dst_xy=%x\n", __func__, out_size, fb_off, src_xy, dst_xy); -- To view, visit https://review.coreboot.org/c/coreboot/+/85778?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40cffcf3714decfc54f2bbce9d4a867a9313d72e Gerrit-Change-Number: 85778 Gerrit-PatchSet: 1 Gerrit-Owner: Ariel Otilibili Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-CC: Yidi Lin <yidilin(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024