coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIF and PMIC driver support
by Hope Wang (Code Review) 05 Dec '24

05 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu. Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85126?usp=email ) Change subject: soc/mediatek/mt8196: Add PMIF and PMIC driver support ...................................................................... Patch Set 14: (7 comments) File src/soc/mediatek/mt8196/include/soc/pmif.h: https://review.coreboot.org/c/coreboot/+/85126/comment/05612f2d_4b19ce36?us… : PS12, Line 142: > Just one tab. Done https://review.coreboot.org/c/coreboot/+/85126/comment/910c8eef_0e9f4a3b?us… : PS12, Line 142: + > Space around `+` Done https://review.coreboot.org/c/coreboot/+/85126/comment/a8e60b8f_2bb7ca69?us… : PS12, Line 142: #define SPMI_SCL_M_PD_ADDR (IOCFG_LM2_BASE+0x80) : #define SPMI_SDA_M_PD_ADDR (IOCFG_LM2_BASE+0x80) : #define SPMI_SCL_P_PD_ADDR (IOCFG_LM2_BASE+0x80) : #define SPMI_SDA_P_PD_ADDR (IOCFG_LM2_BASE+0x80) > Why do we need 4 macros, if their values are all the same? Done https://review.coreboot.org/c/coreboot/+/85126/comment/92929032_6200c0c7?us… : PS12, Line 147: ) > remove Done File src/soc/mediatek/mt8196/pmif_clk.c: https://review.coreboot.org/c/coreboot/+/85126/comment/d7292a7a_7476e36b?us… : PS6, Line 188: ret |= pmif_check_vlpck_freq(PMIF_VLPCK_TARGET_FREQ_MHZ); > extra space after = Done File src/soc/mediatek/mt8196/pmif_spmi.c: https://review.coreboot.org/c/coreboot/+/85126/comment/4a13e57b_6152896e?us… : PS12, Line 164: IOCFG_LM2_BASE + 0x4 > Define macros for `IOCFG_LM2_BASE + 0x4` and `IOCFG_LM2_BASE + 0x8`, respecitvely, just like `SPMI_S […] Done https://review.coreboot.org/c/coreboot/+/85126/comment/890f6cab_0dd7c793?us… : PS12, Line 221: ( > remove Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85126?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I232015f45735ee5278b09d0352410617a1565177 Gerrit-Change-Number: 85126 Gerrit-PatchSet: 14 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 05 Dec 2024 05:44:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/fatcat: Update flash layout
by Pranava Y N (Code Review) 05 Dec '24

05 Dec '24

Attention is currently required from: Kapil Porwal, Subrata Banik. Pranava Y N has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85497?usp=email ) Change subject: mb/google/fatcat: Update flash layout ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85497?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I716fae09dee0c05b8b840dc80647d7959aa03a50 Gerrit-Change-Number: 85497 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 05 Dec 2024 05:10:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: MAINTAINERS: Add Kapil for mb/google/fatcat
by Pranava Y N (Code Review) 05 Dec '24

05 Dec '24

Attention is currently required from: Kapil Porwal. Pranava Y N has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/85504?usp=email ) Change subject: MAINTAINERS: Add Kapil for mb/google/fatcat ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85504?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6a11746d018465d3f89e718714622355eb6e7461 Gerrit-Change-Number: 85504 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 05 Dec 2024 05:08:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: util/crossgcc: Update LLVM from 18.1.8 to 19.1.3
by Elyes Haouas (Code Review) 05 Dec '24

05 Dec '24

Attention is currently required from: Felix Singer, Martin L Roth. Elyes Haouas has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/85169?usp=email ) Change subject: util/crossgcc: Update LLVM from 18.1.8 to 19.1.3 ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > "19.1.5 in two weeks" […] Please upgrad to 19.1.5 & rebase on 85168 -- To view, visit https://review.coreboot.org/c/coreboot/+/85169?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a392b472b7450685343e1343c7b84c78b0cad3d Gerrit-Change-Number: 85169 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Dec 2024 04:56:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver
by Yidi Lin (Code Review) 05 Dec '24

05 Dec '24

Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email ) Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver ...................................................................... Patch Set 17: (3 comments) File src/soc/mediatek/common/mt6363_sdmadc.c: https://review.coreboot.org/c/coreboot/+/85128/comment/ac4d05cd_f0d7aae6?us… : PS17, Line 62: "Wrong array size for mt6363_sdmadc_chan_specs"); > `please, no spaces at the start of a line` Please fix. https://review.coreboot.org/c/coreboot/+/85128/comment/4cf04482_840ec653?us… : PS17, Line 62: "Wrong array size for mt6363_sdmadc_chan_specs"); > `code indent should use tabs where possible` Please fix. https://review.coreboot.org/c/coreboot/+/85128/comment/71d42617_6aa32af3?us… : PS17, Line 76: Add ``` mt6363_init_pmif_arb(); ``` BTW, does it required `mt6363_init()` to be called before reading ADC value ? -- To view, visit https://review.coreboot.org/c/coreboot/+/85128?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ice3c286cd207e445392d5f0126a07ce4f40dcf8a Gerrit-Change-Number: 85128 Gerrit-PatchSet: 17 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Thu, 05 Dec 2024 04:54:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: util/crossgcc: Update CMake from 3.30.2 to 3.31.0
by Elyes Haouas (Code Review) 05 Dec '24

05 Dec '24

Attention is currently required from: Felix Singer, Martin L Roth. Elyes Haouas has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/85168?usp=email ) Change subject: util/crossgcc: Update CMake from 3.30.2 to 3.31.0 ...................................................................... Patch Set 4: -Code-Review (1 comment) Patchset: PS4: 3.31.1 is released -- To view, visit https://review.coreboot.org/c/coreboot/+/85168?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I573dace3b752a0d3c4614ece9c0845f8334e2857 Gerrit-Change-Number: 85168 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Dec 2024 04:52:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: drivers/ipmi/ocp: Add missing include
by Elyes Haouas (Code Review) 05 Dec '24

05 Dec '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85317?usp=email ) Change subject: drivers/ipmi/ocp: Add missing include ...................................................................... drivers/ipmi/ocp: Add missing include Include stddef.h to fix the compiler error when using ipmi_ocp.h: src/drivers/ipmi/ocp/ipmi_ocp.h:199:44: error: unknown type name 'size_t' Change-Id: Iccd131295263460a4939e51e12ece87ea22c417c Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85317 Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/drivers/ipmi/ocp/ipmi_ocp.h 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved Lean Sheng Tan: Looks good to me, approved diff --git a/src/drivers/ipmi/ocp/ipmi_ocp.h b/src/drivers/ipmi/ocp/ipmi_ocp.h index d02eb35..83b8ba3 100644 --- a/src/drivers/ipmi/ocp/ipmi_ocp.h +++ b/src/drivers/ipmi/ocp/ipmi_ocp.h @@ -5,6 +5,7 @@ #include <commonlib/bsd/cb_err.h> #include <device/pci_type.h> +#include <stddef.h> #define IPMI_NETFN_OEM 0x30 #define IPMI_OEM_SET_PPIN 0x77 -- To view, visit https://review.coreboot.org/c/coreboot/+/85317?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iccd131295263460a4939e51e12ece87ea22c417c Gerrit-Change-Number: 85317 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6363 driver
by Yidi Lin (Code Review) 05 Dec '24

05 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85127?usp=email ) Change subject: soc/mediatek/mt8196: Add PMIC MT6363 driver ...................................................................... Patch Set 16: (1 comment) File src/soc/mediatek/mt8196/mt6363.c: https://review.coreboot.org/c/coreboot/+/85127/comment/90427422_b628222b?us… : PS16, Line 385: /* > `trailing whitespace` Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/85127?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaf493b802522deba575d98c2ed69a93e94ce3d4e Gerrit-Change-Number: 85127 Gerrit-PatchSet: 16 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Thu, 05 Dec 2024 04:42:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Enable ARM Trusted Firmware integration
by Yidi Lin (Code Review) 05 Dec '24

05 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85503?usp=email ) Change subject: soc/mediatek/mt8196: Enable ARM Trusted Firmware integration ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: defer this patch until the ATF git submodule is updated. -- To view, visit https://review.coreboot.org/c/coreboot/+/85503?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I516e648f78b74cc5ea82f52084d5b9dbaeb6f7f0 Gerrit-Change-Number: 85503 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 05 Dec 2024 04:37:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Update DRAM blob to 0.4.0
by Yidi Lin (Code Review) 05 Dec '24

05 Dec '24

Attention is currently required from: Crystal Guo, Hung-Te Lin, Jarried Lin. Yidi Lin has posted comments on this change by Crystal Guo. ( https://review.coreboot.org/c/blobs/+/85501?usp=email ) Change subject: soc/mediatek/mt8196: Update DRAM blob to 0.4.0 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/85501?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I2ac90c1b7272455a62cf3651de05589224842fea Gerrit-Change-Number: 85501 Gerrit-PatchSet: 3 Gerrit-Owner: Crystal Guo <crystal.guo(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Crystal Guo <crystal.guo(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Crystal Guo <crystal.guo(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Thu, 05 Dec 2024 04:32:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024