coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[S] Change in coreboot[main]: mb/google/fatcat/var/felino: Add ALC712 codec to devicetree
by Weimin Wu (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Paul Menzel, Pranava Y N, Subrata Banik. Weimin Wu has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/85572?usp=email ) Change subject: mb/google/fatcat/var/felino: Add ALC712 codec to devicetree ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85572/comment/cfee3c6b_bdd15d00?us… : PS2, Line 7: Modify devicetree for ALC712 codec > Maybe: […] Done https://review.coreboot.org/c/coreboot/+/85572/comment/4cd2416a_57f26dcb?us… : PS2, Line 10: > Please add, where you got the devicetree values, like `bus_frequency_configs`, from. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85572?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5c38462cd1ab39d4aebc324d5151cb4337051df Gerrit-Change-Number: 85572 Gerrit-PatchSet: 3 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 13 Dec 2024 01:24:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: mb/google/fatcat/var/felino: Add ALC712 codec to devicetree
by Weimin Wu (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Pranava Y N, Subrata Banik, Weimin Wu. Hello Pranava Y N, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85572?usp=email to look at the new patch set (#3). Change subject: mb/google/fatcat/var/felino: Add ALC712 codec to devicetree ...................................................................... mb/google/fatcat/var/felino: Add ALC712 codec to devicetree Update device tree to support Realtek ALC712 codec. reference datasheet: Realtek ALC712-VB-CG Rev. 0.24 BUG=b:378629979 TEST=emerge-fatcat coreboot Change-Id: Ic5c38462cd1ab39d4aebc324d5151cb4337051df Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/fatcat/variants/felino/overridetree.cb 1 file changed, 42 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/85572/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85572?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5c38462cd1ab39d4aebc324d5151cb4337051df Gerrit-Change-Number: 85572 Gerrit-PatchSet: 3 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[S] Change in coreboot[main]: drivers/soundwire: Support Realtek ALC712 codec
by Tongtong Pan (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Pranava Y N, Subrata Banik, Weimin Wu. Tongtong Pan has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/85571?usp=email ) Change subject: drivers/soundwire: Support Realtek ALC712 codec ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85571?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib79896a9fe23f2f66d6ee3a24f5a62bfa0f7a649 Gerrit-Change-Number: 85571 Gerrit-PatchSet: 2 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 13 Dec 2024 01:23:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: Add support for MiTAC Computing Whitestone-2 mainboard
by Mark Chang (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Angel Pons, Angel Pons, Arthur Heymans, Christian Walter, Jincheng Li, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, yuchi.chen(a)intel.com. Hello Angel Pons, Angel Pons, Arthur Heymans, Christian Walter, Jincheng Li, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, build bot (Jenkins), yuchi.chen(a)intel.com, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85532?usp=email to look at the new patch set (#3). Change subject: Add support for MiTAC Computing Whitestone-2 mainboard ...................................................................... Add support for MiTAC Computing Whitestone-2 mainboard The MiTAC Computing Whitestone2 O-RAN CU/DU Edge Server is a compact and highly efficient 1U rackmount solution designed for edge computing in O-RAN (Open Radio Access Network) environments. Featuring support for the 4th Gen Intel® Xeon® Scalable Processor Edge Enhanced Product Family, it delivers robust performance with a single socket (LGA-4677) that supports up to 205W TDP. The server provides excellent memory capabilities with 8 DDR5 RDIMM slots supporting 4400 MHz speeds across 8 channels per CPU. Working: - All eight DIMM slots - Serial port to emit spam - POST code display - Front USB 2.0 port - Front Intel E810 CAM1 (25Gbps x 4) - Front Intel E810 CAM2 (25Gbps x 4 / 10Gbps x 8) - M.2 2280/22110 slot x 2 (Gen3 x4) - Flashing internally with flashrom Untested for now (i.e. should work, will eventually test): - Riser PCIe Gen.4 x16 slots x 2 (FHHL) Others: - The board boots to Ubuntu 22.04.2 (5.15.0-1032-realtime) with all 40 cores (Intel 5433n) available. - FlexRAN 23.11 + DPDK 22.11.1 + ACC200 O-RU + O-DU long-run test pass. Change-Id: Icf625cf8e9c76ef08411614c15ee43d0c459b905 Signed-off-by: Mark Chang <mark.chang(a)mitaccomputing.com> --- A configs/config.mitaccomputing_ws_2 A src/mainboard/mitaccomputing/Kconfig A src/mainboard/mitaccomputing/Kconfig.name A src/mainboard/mitaccomputing/whitestone-2/Kconfig A src/mainboard/mitaccomputing/whitestone-2/Kconfig.name A src/mainboard/mitaccomputing/whitestone-2/Makefile.mk A src/mainboard/mitaccomputing/whitestone-2/acpi/platform.asl A src/mainboard/mitaccomputing/whitestone-2/board.fmd A src/mainboard/mitaccomputing/whitestone-2/board_info.txt A src/mainboard/mitaccomputing/whitestone-2/bootblock.c A src/mainboard/mitaccomputing/whitestone-2/devicetree.cb A src/mainboard/mitaccomputing/whitestone-2/dsdt.asl A src/mainboard/mitaccomputing/whitestone-2/include/smbios_onboard.h A src/mainboard/mitaccomputing/whitestone-2/include/spr_ws_2_gpio.h A src/mainboard/mitaccomputing/whitestone-2/include/sprsp_ws_2_iio.h A src/mainboard/mitaccomputing/whitestone-2/mainboard.c A src/mainboard/mitaccomputing/whitestone-2/ramstage.c A src/mainboard/mitaccomputing/whitestone-2/romstage.c 18 files changed, 739 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/85532/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85532?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icf625cf8e9c76ef08411614c15ee43d0c459b905 Gerrit-Change-Number: 85532 Gerrit-PatchSet: 3 Gerrit-Owner: Mark Chang <mark.chang(a)mitaccomputing.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yuchi.chen(a)intel.com Gerrit-CC: Wilson-MiTACComputing <wilson.chien(a)mitaccomputing.com> Gerrit-Attention: yuchi.chen(a)intel.com Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com>

1 0

[L] Change in coreboot[main]: Add support for MiTAC Computing Whitestone-2 mainboard
by Mark Chang (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Angel Pons, Angel Pons, Arthur Heymans, Christian Walter, Jincheng Li, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, yuchi.chen(a)intel.com. Hello Angel Pons, Angel Pons, Arthur Heymans, Christian Walter, Jincheng Li, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, build bot (Jenkins), yuchi.chen(a)intel.com, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85532?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Angel Pons, Code-Review+1 by Shuo Liu, Verified+1 by build bot (Jenkins) Change subject: Add support for MiTAC Computing Whitestone-2 mainboard ...................................................................... Add support for MiTAC Computing Whitestone-2 mainboard The MiTAC Computing Whitestone2 O-RAN CU/DU Edge Server is a compact and highly efficient 1U rackmount solution designed for edge computing in O-RAN (Open Radio Access Network) environments. Featuring support for the 4th Gen Intel® Xeon® Scalable Processor Edge Enhanced Product Family, it delivers robust performance with a single socket (LGA-4677) that supports up to 205W TDP. The server provides excellent memory capabilities with 8 DDR5 RDIMM slots supporting 4400 MHz speeds across 8 channels per CPU. Working: - All eight DIMM slots - Serial port to emit spam - POST code display - Front USB 2.0 port - Front Intel E810 CAM1 (25Gbps x 4) - Front Intel E810 CAM2 (25Gbps x 4 / 25Gbps x 2 + 10Gbps x 4 / 10Gbps x 8) - M.2 2280/22110 slot x 2 (Gen3 x4) - Flashing internally with flashrom Untested for now (i.e. should work, will eventually test): - Riser PCIe Gen.4 x16 slots x 2 (FHHL) Others: - The board boots to Ubuntu 22.04.2 (5.15.0-1032-realtime) with all 40 cores (Intel 5433n) available. - It's ready for FlexRAN 23.11 + DPDK 22.11.1 + ACC200 O-RU + O-DU test. Change-Id: Icf625cf8e9c76ef08411614c15ee43d0c459b905 Signed-off-by: Mark Chang <mark.chang(a)mitaccomputing.com> --- A configs/config.mitaccomputing_ws_2 A src/mainboard/mitaccomputing/Kconfig A src/mainboard/mitaccomputing/Kconfig.name A src/mainboard/mitaccomputing/whitestone-2/Kconfig A src/mainboard/mitaccomputing/whitestone-2/Kconfig.name A src/mainboard/mitaccomputing/whitestone-2/Makefile.mk A src/mainboard/mitaccomputing/whitestone-2/acpi/platform.asl A src/mainboard/mitaccomputing/whitestone-2/board.fmd A src/mainboard/mitaccomputing/whitestone-2/board_info.txt A src/mainboard/mitaccomputing/whitestone-2/bootblock.c A src/mainboard/mitaccomputing/whitestone-2/devicetree.cb A src/mainboard/mitaccomputing/whitestone-2/dsdt.asl A src/mainboard/mitaccomputing/whitestone-2/include/smbios_onboard.h A src/mainboard/mitaccomputing/whitestone-2/include/spr_ws_2_gpio.h A src/mainboard/mitaccomputing/whitestone-2/include/sprsp_ws_2_iio.h A src/mainboard/mitaccomputing/whitestone-2/mainboard.c A src/mainboard/mitaccomputing/whitestone-2/ramstage.c A src/mainboard/mitaccomputing/whitestone-2/romstage.c 18 files changed, 739 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/85532/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85532?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icf625cf8e9c76ef08411614c15ee43d0c459b905 Gerrit-Change-Number: 85532 Gerrit-PatchSet: 2 Gerrit-Owner: Mark Chang <mark.chang(a)mitaccomputing.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yuchi.chen(a)intel.com Gerrit-CC: Wilson-MiTACComputing <wilson.chien(a)mitaccomputing.com> Gerrit-Attention: yuchi.chen(a)intel.com Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com>

1 0

[L] Change in coreboot[main]: Add support for MiTAC Computing Whitestone-2 mainboard
by Mark Chang (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Angel Pons, Angel Pons, Arthur Heymans, Christian Walter, Jincheng Li, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, yuchi.chen(a)intel.com. Mark Chang has posted comments on this change by Mark Chang. ( https://review.coreboot.org/c/coreboot/+/85532?usp=email ) Change subject: Add support for MiTAC Computing Whitestone-2 mainboard ...................................................................... Patch Set 1: (15 comments) Patchset: PS1: Done Commit Message: https://review.coreboot.org/c/coreboot/+/85532/comment/6030a655_1a626e6b?us… : PS1, Line 8: > Could you please add a body to the commit message? I would suggest describing the board (looks like […] Done File configs/config.mitaccomputing_ws_2: PS1: > I see references to site-local here. […] Done https://review.coreboot.org/c/coreboot/+/85532/comment/7aed971b_66f03b1a?us… : PS1, Line 15: CONFIG_X2APIC_LATE_WORKAROUND=y > We only verified Intel 5433N on our Whitestone-2. Done File src/mainboard/mitaccomputing/whitestone-2/acpi/platform.asl: https://review.coreboot.org/c/coreboot/+/85532/comment/b9c5812e_17b40d03?us… : PS1, Line 4: #include <soc/intel/common/acpi/acpi_wake_source.asl> > Will remove it. Done https://review.coreboot.org/c/coreboot/+/85532/comment/0dc71faa_69780f1b?us… : PS1, Line 13: } > Add "#include <arch/x86/acpi/post.asl> will trigger build error. Done https://review.coreboot.org/c/coreboot/+/85532/comment/0b3963a9_10c79976?us… : PS1, Line 30: > We will remove it. Done File src/mainboard/mitaccomputing/whitestone-2/board_info.txt: PS1: > Update ROM package: SOIC-16 Done File src/mainboard/mitaccomputing/whitestone-2/bootblock.c: https://review.coreboot.org/c/coreboot/+/85532/comment/56525091_3609d9e1?us… : PS1, Line 18: static void enable_espi_lpc_io_windows(void) > We could use below APIs to update it. […] Done https://review.coreboot.org/c/coreboot/+/85532/comment/a6cc5493_58dfc7db?us… : PS1, Line 23: * For that end it is wired into BMC virtual port. > The Whitestone-2 only use SUART1. […] Done File src/mainboard/mitaccomputing/whitestone-2/dsdt.asl: https://review.coreboot.org/c/coreboot/+/85532/comment/109db048_a96b6272?us… : PS1, Line 10: 0x20110725 // OEM revision > Remove it Done File src/mainboard/mitaccomputing/whitestone-2/mainboard.c: https://review.coreboot.org/c/coreboot/+/85532/comment/0757fa01_ea724e1b?us… : PS1, Line 46: } > These E810 devices are Ethernet NICs. […] Done https://review.coreboot.org/c/coreboot/+/85532/comment/aabc2f92_1971a347?us… : PS1, Line 71: } > Will this duplicate with smbios_generate_type41_from_devtree? Done https://review.coreboot.org/c/coreboot/+/85532/comment/d512eef5_dadf05bf?us… : PS1, Line 80: }; > Angel, you're right, it's invoked automatically. Done File src/mainboard/mitaccomputing/whitestone-2/romstage.c: https://review.coreboot.org/c/coreboot/+/85532/comment/da7d0696_e3a68e0e?us… : PS1, Line 18: Protocl > resolved Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85532?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icf625cf8e9c76ef08411614c15ee43d0c459b905 Gerrit-Change-Number: 85532 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Chang <mark.chang(a)mitaccomputing.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yuchi.chen(a)intel.com Gerrit-CC: Wilson-MiTACComputing <wilson.chien(a)mitaccomputing.com> Gerrit-Attention: yuchi.chen(a)intel.com Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Fri, 13 Dec 2024 00:46:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: yuchi.chen(a)intel.com Comment-In-Reply-To: Mark Chang <mark.chang(a)mitaccomputing.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com>

1 0

[S] Change in coreboot[main]: mb/google/brya/var/marasov: Enable GPP_F9 GPIO for early panel power-on
by Dinesh Gehlot (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Dinesh Gehlot has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85574?usp=email ) Change subject: mb/google/brya/var/marasov: Enable GPP_F9 GPIO for early panel power-on ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85574?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I727a72d9583575b2bbebe2c3b75c980170dd36b9 Gerrit-Change-Number: 85574 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 13 Dec 2024 00:13:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: cpu/x86/topology: Add module_id to CPU topology
by Jérémy Compostella (Code Review) 12 Dec '24

12 Dec '24

Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85577?usp=email ) Change subject: cpu/x86/topology: Add module_id to CPU topology ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/85577?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1c8a76dce48c0539a3f36015674553a2461dec27 Gerrit-Change-Number: 85577 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Thu, 12 Dec 2024 22:08:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: cpu/x86/topology: Simplify CPU topology initialization
by Jérémy Compostella (Code Review) 12 Dec '24

12 Dec '24

Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85576?usp=email ) Change subject: cpu/x86/topology: Simplify CPU topology initialization ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85576?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9424559f895af69e79c36b919e80af803861148 Gerrit-Change-Number: 85576 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Thu, 12 Dec 2024 22:07:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: config GPP_F23 as ISH gpio pin
by Jérémy Compostella (Code Review) 12 Dec '24

12 Dec '24

Jérémy Compostella has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85464?usp=email ) Change subject: mb/google/fatcat: config GPP_F23 as ISH gpio pin ...................................................................... mb/google/fatcat: config GPP_F23 as ISH gpio pin The GPP_F23/ISH_GP_9A pin receives the lid open/close signal from SMC_LID. This pin is not utilized in the AP firmware stack; however the ISH firmware requires this signal for its tablet mode support. Therefore, we configure this pin as an ISH GPIO. BUG=b:370984186 TEST=Build and flash CB; run ISH main firmware; read this pin and verified it returned the correct value. fatcat-rev257 ~ # ectool --name=cros_ish gpioget lid_open GPIO lid_open = 1 Change-Id: I19a4d6967acf96aefe2f38d628f898811d8a6e6d Signed-off-by: Li Feng <li1.feng(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85464 Reviewed-by: Subrata Banik <subratabanik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/fatcat/variants/fatcat/fw_config.c M src/mainboard/google/fatcat/variants/fatcat/gpio.c 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/fatcat/variants/fatcat/fw_config.c b/src/mainboard/google/fatcat/variants/fatcat/fw_config.c index fe23993..b061f7c 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/fw_config.c +++ b/src/mainboard/google/fatcat/variants/fatcat/fw_config.c @@ -459,6 +459,8 @@ PAD_NC(GPP_D06, NONE), /* GPP_E05: NC */ PAD_NC(GPP_E05, NONE), + /* GPP_F23: NC */ + PAD_NC(GPP_F23, NONE), }; static const struct pad_config ish_enable_pads[] = { @@ -468,6 +470,8 @@ PAD_CFG_NF(GPP_D06, NONE, DEEP, NF2), /* GPP_E05: ISH_GP_7_SNSR_HDR */ PAD_CFG_NF(GPP_E05, NONE, DEEP, NF4), + /* GPP_F23: ISH_GP_9A */ + PAD_CFG_NF(GPP_F23, NONE, DEEP, NF8), }; void fw_config_configure_pre_mem_gpio(void) diff --git a/src/mainboard/google/fatcat/variants/fatcat/gpio.c b/src/mainboard/google/fatcat/variants/fatcat/gpio.c index 5705179..47a5c3a 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/gpio.c +++ b/src/mainboard/google/fatcat/variants/fatcat/gpio.c @@ -293,8 +293,6 @@ PAD_CFG_GPO(GPP_F20, 0, PLTRST), /* GPP_F22: THC1_SPI2_DSYNC */ PAD_CFG_NF(GPP_F22, NONE, DEEP, NF3), - /* GPP_F23: SMC_LID */ - PAD_CFG_GPI_SCI_LOW(GPP_F23, NONE, DEEP, LEVEL), /* GPP_H00: Not used */ PAD_NC(GPP_H00, NONE), -- To view, visit https://review.coreboot.org/c/coreboot/+/85464?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I19a4d6967acf96aefe2f38d628f898811d8a6e6d Gerrit-Change-Number: 85464 Gerrit-PatchSet: 7 Gerrit-Owner: Li1 Feng <li1.feng(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024