coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XS] Change in coreboot[main]: commonlib: Add ELOG_TYPE_FW_CSE_SYNC eventLog type
by Dinesh Gehlot (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Kapil Porwal, Karthik Ramasubramanian, Subrata Banik. Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/85217?usp=email ) Change subject: commonlib: Add ELOG_TYPE_FW_CSE_SYNC eventLog type ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85217/comment/9b2aba69_21fa4d8c?us… : PS1, Line 10: notify the user about the > Nit: Since event logs are purely for debugging purposes and not to notify the user, I would rephrase […] Acknowledged File src/commonlib/bsd/include/commonlib/bsd/elog.h: https://review.coreboot.org/c/coreboot/+/85217/comment/fb47db1a_62e86450?us… : PS1, Line 394: ELOG_FW_ROMSTAGE_CSE_SYNC > ELOG_FW_EARLY_CSE_SYNC Acknowledged https://review.coreboot.org/c/coreboot/+/85217/comment/8d1ae533_1b1ededb?us… : PS1, Line 395: ELOG_FW_RAMSTAGE_CSE_SYNC > ELOG_FW_LATE_CSE_SYNC Acknowledged https://review.coreboot.org/c/coreboot/+/85217/comment/23289538_70794366?us… : PS1, Line 396: ELOG_FW_PAYLOAD_CSE_SYNC > ELOG_FW_CSE_SYNC_AT_PAYLOAD Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/85217?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id73fa3a77e5fbbae5c61dfb30ae26b4ba3dca6ab Gerrit-Change-Number: 85217 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 13 Dec 2024 13:11:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[XS] Change in coreboot[main]: src/soc/intel/cmn/blk/cse: Log cse sync information
by Dinesh Gehlot (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Paul Menzel. Hello Kapil Porwal, Karthik Ramasubramanian, Paul Menzel, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85219?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Paul Menzel, Verified+1 by build bot (Jenkins) Change subject: src/soc/intel/cmn/blk/cse: Log cse sync information ...................................................................... src/soc/intel/cmn/blk/cse: Log cse sync information This patch adds an event log entry for successful CSE synchronization, along with the boot stage where the synchronization occurred, either early or late. BUG=b:379585294 TEST=elog verified on rex0 and rex64 Rex0: ``` rex-rev3 ~ # /media/usb/elogtool list 3 | 2024-01-01 22:25:59-0800 | Firmware CSE sync | Late CSE Sync ``` Rex64: ``` rex64-rev3 ~ # /media/usb/elogtool list 8 | 2024-01-01 22:51:00-0800 | Firmware CSE sync | CSE Sync at Payload ``` Change-Id: Idece841c2b069d7688afc258470667ed2851a282 Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> --- M src/soc/intel/common/block/cse/cse_lite.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/85219/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85219?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idece841c2b069d7688afc258470667ed2851a282 Gerrit-Change-Number: 85219 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>

1 0

[S] Change in coreboot[main]: soc/intel: Log CSE Sync Early Sign of Life event from a better place
by Dinesh Gehlot (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun. Dinesh Gehlot has uploaded a new patch set (#4) to the change originally created by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/85111?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) Change subject: soc/intel: Log CSE Sync Early Sign of Life event from a better place ...................................................................... soc/intel: Log CSE Sync Early Sign of Life event from a better place CSE Sync Early Sign of Life (ESOL) event is logged as soon as the CSE FW update is complete. This happens irrespective of whether Early Sign of Life screen is enabled or not. Move CSE Sync ESOL event right before displaying the ESOL screen. BUG=b:378458829, b:379585294 TEST=Build Brox BIOS image and boot to OS. Ensure that the ESOL event for CSE Sync is logged. Change-Id: Iaa0dbb87ddde69dc3f4a9e058fc6bed8711b29e7 Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M src/soc/intel/alderlake/romstage/fsp_params.c M src/soc/intel/alderlake/romstage/romstage.c M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/meteorlake/romstage/fsp_params.c 4 files changed, 9 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/85111/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85111?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaa0dbb87ddde69dc3f4a9e058fc6bed8711b29e7 Gerrit-Change-Number: 85111 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[S] Change in coreboot[main]: util/cbfstool: Add eventLog support for ELOG_TYPE_FW_CSE_SYNC
by Dinesh Gehlot (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal. Hello Kapil Porwal, Karthik Ramasubramanian, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85218?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/cbfstool: Add eventLog support for ELOG_TYPE_FW_CSE_SYNC ...................................................................... util/cbfstool: Add eventLog support for ELOG_TYPE_FW_CSE_SYNC This patch introduces logging for the ELOG_TYPE_FW_CSE_SYNC event. This event logs data related to CSE synchronization, along with the relevant boot stage information. BUG=b:305898363 TEST=boot verified on google/rex0 and google/rex64 Change-Id: I4d6d3c4e07ab8677feb6a8acf8d4c6604ab704b8 Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> --- M util/cbfstool/eventlog.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/85218/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4d6d3c4e07ab8677feb6a8acf8d4c6604ab704b8 Gerrit-Change-Number: 85218 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>

1 0

[XS] Change in coreboot[main]: commonlib: Add ELOG_TYPE_FW_CSE_SYNC eventLog type
by Dinesh Gehlot (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal. Hello Kapil Porwal, Karthik Ramasubramanian, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85217?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: commonlib: Add ELOG_TYPE_FW_CSE_SYNC eventLog type ...................................................................... commonlib: Add ELOG_TYPE_FW_CSE_SYNC eventLog type This patch adds a new event log type, ELOG_TYPE_FW_CSE_SYNC. The purpose of this event type is to log successful completion of CSE synchronization. BUG=b:379585294 TEST=boot verified on google/rex0 and google/rex64 Change-Id: Id73fa3a77e5fbbae5c61dfb30ae26b4ba3dca6ab Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> --- M src/commonlib/bsd/include/commonlib/bsd/elog.h 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/85217/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85217?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id73fa3a77e5fbbae5c61dfb30ae26b4ba3dca6ab Gerrit-Change-Number: 85217 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Add MMinfra driver support
by Jarried Lin (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85188?usp=email ) Change subject: soc/mediatek/mt8196: Add MMinfra driver support ...................................................................... Patch Set 23: (5 comments) File src/soc/mediatek/mt8196/bootblock.c: https://review.coreboot.org/c/coreboot/+/85188/comment/4792f99c_c459adea?us… : PS5, Line 19: mm_pre_init > Why is this called `pre_init`? This only registers callbacks for 3 IDs. […] Done File src/soc/mediatek/mt8196/include/soc/mminfra.h: https://review.coreboot.org/c/coreboot/+/85188/comment/67990d20_0d6b510f?us… : PS5, Line 33: mm > mminfra Done File src/soc/mediatek/mt8196/mminfra_pd.c: PS5: > If there's no other `mminfra_*.c` files, can we rename this to `mminfra. […] Done https://review.coreboot.org/c/coreboot/+/85188/comment/8d3e4e4a_295d76a2?us… : PS5, Line 35: while (read32p(MMINFRA_MM0_GALS_PROT_TX_RDY) != 0xff) : ; > You can implement a common function and pass register address and expected value to that function. […] Done https://review.coreboot.org/c/coreboot/+/85188/comment/4c7e933b_7d20bf30?us… : PS5, Line 66: static int pd_mm_infra_ao_pre_on(void) : { : return 0; : } : : static int pd_mm_infra_ao_post_on(void) : { : return 0; : } : : static int pd_mm_infra_ao_pre_off(void) : { : return 0; : } : : static int pd_mm_infra_ao_post_off(void) : { : return 0; : } > Just remove if not used. `mtcmos_callback` will check if the callback is existed. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85188?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie86f141a0957fc60d4973875c0dbcbdb57be1f75 Gerrit-Change-Number: 85188 Gerrit-PatchSet: 23 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 13 Dec 2024 12:36:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Add MMinfra driver support
by Jarried Lin (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85188?usp=email to look at the new patch set (#23). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/mediatek/mt8196: Add MMinfra driver support ...................................................................... soc/mediatek/mt8196: Add MMinfra driver support MMinfra is the Multimedia Infrastructure. All the Multimedia modules depend on it. This file adds some initial settings for MMinfra. Test=Build pass BUG=b:317009620 Signed-off-by: Xueqi Zhang <xueqi.zhang(a)mediatek.corp-partner.google.com> Change-Id: Ie86f141a0957fc60d4973875c0dbcbdb57be1f75 --- M src/soc/mediatek/mt8196/Makefile.mk M src/soc/mediatek/mt8196/bootblock.c M src/soc/mediatek/mt8196/include/soc/addressmap.h A src/soc/mediatek/mt8196/include/soc/mminfra.h A src/soc/mediatek/mt8196/mminfra.c 5 files changed, 166 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/85188/23 -- To view, visit https://review.coreboot.org/c/coreboot/+/85188?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie86f141a0957fc60d4973875c0dbcbdb57be1f75 Gerrit-Change-Number: 85188 Gerrit-PatchSet: 23 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[L] Change in coreboot[main]: Add support for MiTAC Computing Whitestone-2 mainboard
by Mark Chang (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, Jincheng Li, Lean Sheng Tan, Patrick Rudolph, yuchi.chen(a)intel.com. Mark Chang has posted comments on this change by Mark Chang. ( https://review.coreboot.org/c/coreboot/+/85532?usp=email ) Change subject: Add support for MiTAC Computing Whitestone-2 mainboard ...................................................................... Patch Set 4: (1 comment) File src/mainboard/mitaccomputing/whitestone-2/include/sprsp_ws_2_iio.h: https://review.coreboot.org/c/coreboot/+/85532/comment/97529459_b61477ce?us… : PS4, Line 98: IIO_BIFURCATE_xxxxxx16, : IIO_BIFURCATE_xxx8xxx8, : IIO_BIFURCATE_xxxxxx16, : IIO_BIFURCATE_xxxxxx16, : IIO_BIFURCATE_xxxxxx16, > With the `CFG_UPD_PCIE_PORT_DISABLED` macro, it's easy to see how IIO bifurcation correlates to PCIe […] Yes, it's a good idea to know the PCIe port settings. -- To view, visit https://review.coreboot.org/c/coreboot/+/85532?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icf625cf8e9c76ef08411614c15ee43d0c459b905 Gerrit-Change-Number: 85532 Gerrit-PatchSet: 4 Gerrit-Owner: Mark Chang <mark.chang(a)mitaccomputing.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yuchi.chen(a)intel.com Gerrit-CC: Wilson-MiTACComputing <wilson.chien(a)mitaccomputing.com> Gerrit-Attention: yuchi.chen(a)intel.com Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Fri, 13 Dec 2024 12:23:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[M] Change in coreboot[main]: mb/google/rauru: Implement regulator interface
by Yidi Lin (Code Review) 13 Dec '24

13 Dec '24

Yidi Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85563?usp=email ) Change subject: mb/google/rauru: Implement regulator interface ...................................................................... mb/google/rauru: Implement regulator interface Control regulator more easily with regulator interface. TEST=build pass BUG=b:317009620 Change-Id: I3cad68dbb2c5873c4e00066da18b1593b88ff499 Signed-off-by: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85563 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yidi Lin <yidilin(a)google.com> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M src/mainboard/google/rauru/Makefile.mk A src/mainboard/google/rauru/regulator.c 2 files changed, 89 insertions(+), 0 deletions(-) Approvals: Yu-Ping Wu: Looks good to me, approved Yidi Lin: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/rauru/Makefile.mk b/src/mainboard/google/rauru/Makefile.mk index d5eb8af..d383629 100644 --- a/src/mainboard/google/rauru/Makefile.mk +++ b/src/mainboard/google/rauru/Makefile.mk @@ -9,3 +9,4 @@ romstage-y += romstage.c ramstage-y += mainboard.c +ramstage-y += regulator.c diff --git a/src/mainboard/google/rauru/regulator.c b/src/mainboard/google/rauru/regulator.c new file mode 100644 index 0000000..f9fb90f --- /dev/null +++ b/src/mainboard/google/rauru/regulator.c @@ -0,0 +1,88 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ + +#include <console/console.h> +#include <soc/mt6373.h> +#include <soc/regulator.h> + +#define MTK_REGULATOR_INVALID -1 + +static int get_mt6373_regulator_id(enum mtk_regulator regulator) +{ + switch (regulator) { + case MTK_REGULATOR_VMCH: + return MT6373_VMCH; + case MTK_REGULATOR_VMC: + return MT6373_VMC; + default: + return MTK_REGULATOR_INVALID; + } +} + +void mainboard_set_regulator_voltage(enum mtk_regulator regulator, uint32_t voltage_uv) +{ + int id; + + id = get_mt6373_regulator_id(regulator); + if (id < 0) { + printk(BIOS_ERR, "Invalid regulator ID: %d\n", regulator); + return; + } + + switch (id) { + case MT6373_VMCH: + mt6373_set_vmch_voltage(voltage_uv); + break; + case MT6373_VMC: + mt6373_set_vmc_voltage(voltage_uv); + break; + default: + printk(BIOS_ERR, "Regulator ID %d: not supported\n", regulator); + break; + } +} + +uint32_t mainboard_get_regulator_voltage(enum mtk_regulator regulator) +{ + int id; + + id = get_mt6373_regulator_id(regulator); + if (id < 0) { + printk(BIOS_ERR, "Invalid regulator ID: %d\n", regulator); + return 0; + } + + switch (id) { + case MT6373_VMCH: + return mt6373_get_vmch_voltage(); + case MT6373_VMC: + return mt6373_get_vmc_voltage(); + default: + printk(BIOS_ERR, "Regulator ID %d: not supported\n", regulator); + return 0; + } +} + +int mainboard_enable_regulator(enum mtk_regulator regulator, bool enable) +{ + int id; + + id = get_mt6373_regulator_id(regulator); + if (id < 0) { + printk(BIOS_ERR, "Invalid regulator ID: %d\n", regulator); + return -1; + } + + switch (id) { + case MT6373_VMCH: + mt6373_enable_vmch(enable); + break; + case MT6373_VMC: + mt6373_enable_vmc(enable); + break; + default: + printk(BIOS_ERR, "Regulator ID %d: not supported\n", regulator); + break; + } + + return 0; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/85563?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3cad68dbb2c5873c4e00066da18b1593b88ff499 Gerrit-Change-Number: 85563 Gerrit-PatchSet: 5 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: mb/google/rauru: Implement regulator interface
by Jarried Lin (Code Review) 13 Dec '24

13 Dec '24

Attention is currently required from: Hope Wang, Hung-Te Lin. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85563?usp=email ) Change subject: mb/google/rauru: Implement regulator interface ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/rauru/regulator.c: https://review.coreboot.org/c/coreboot/+/85563/comment/6c217a95_05a7b720?us… : PS4, Line 26: if (id < 0) { : printk(BIOS_ERR, "Invalid regulator ID: %d\n", regulator); : return; : } > The logic was supposed to support the power rails from multiple PMICs. […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/85563?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3cad68dbb2c5873c4e00066da18b1593b88ff499 Gerrit-Change-Number: 85563 Gerrit-PatchSet: 4 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 13 Dec 2024 11:02:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024