Attention is currently required from: Hung-Te Lin, Yidi Lin.
Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85598?usp=email )
Change subject: util/mtkheader: Add GFH header for mt8189 bootblock code
......................................................................
Patch Set 1:
(1 comment)
File util/mtkheader/gen-bl-img.py:
https://review.coreboot.org/c/coreboot/+/85598/comment/179b636b_0e7405d0?us… :
PS1, Line 27: 'mt8189': 0x02001000,
: 'mt8196': 0x02001000,
> can we reuse mt8196's entry ?
I don't think reuse mt8196's entry would be a good idea, as it would mean we need to rewrite src/soc/mediatek/mt8189/Makefile.mk as follows:
```
./util/mtkheader/gen-bl-img.py mt8196 sf $< $@
```
Although the result is the same, it doesn't make sense in terms of readability.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I47078272880a89e81c851ede307cdc306b1c79ac
Gerrit-Change-Number: 85598
Gerrit-PatchSet: 1
Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Mon, 16 Dec 2024 01:42:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kyle Lin, Nick Vaccaro, Subrata Banik.
Yunlong Jia has posted comments on this change by Yunlong Jia. ( https://review.coreboot.org/c/coreboot/+/85512?usp=email )
Change subject: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and touchpanel
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/brya/variants/gothrax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85512/comment/1b0d4c7c_882aa7a5?us… :
PS1, Line 6: option DB_A 3
> Please rename DB_A to something like DB_A_HDMI_LTE
Because DB_A is also used in non-HDMI situations.
https://review.coreboot.org/c/coreboot/+/85512/comment/b0f9883d_b938ab9f?us… :
PS1, Line 268: probe TOUCH_PANEL TOUCH_PANEL_DISABLE
> Are there two elan touchpanels with the same address? Why using TOUCH_PANEL_DISABLE here?
One for i2c and another for i2c-hid.
In order not to affect old projects, TOUCH_PANEL_DISABLE and TOUCH_PANEL_ENABLE each represent a method.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85512?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1900658f7c2e09180287a4e61f02e04be203b6e9
Gerrit-Change-Number: 85512
Gerrit-PatchSet: 1
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyle Lin <kylelinck(a)google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kyle Lin <kylelinck(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Mon, 16 Dec 2024 01:42:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyle Lin <kylelinck(a)google.com>
Attention is currently required from: Hung-Te Lin, Vince Liu.
Yu-Ping Wu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85598?usp=email )
Change subject: util/mtkheader: Add GFH header for mt8189 bootblock code
......................................................................
Patch Set 1:
(1 comment)
File util/mtkheader/gen-bl-img.py:
https://review.coreboot.org/c/coreboot/+/85598/comment/e8362394_ee8cfdf2?us… :
PS1, Line 27: 'mt8189': 0x02001000,
: 'mt8196': 0x02001000,
> can we reuse mt8196's entry ?
Yes we can (mt8186 also re-uses mt8183's entry), but I think the Makefile would confuse people because it'd look like a typo. Also, it doesn't hurt to add an entry here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I47078272880a89e81c851ede307cdc306b1c79ac
Gerrit-Change-Number: 85598
Gerrit-PatchSet: 1
Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 16 Dec 2024 01:40:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: David Wu, Karthik Ramasubramanian, Marx Wang, Subrata Banik.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/85580?usp=email )
Change subject: mb/google/brox: Apply ISH_FW_VERSION in Kconfig
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/85580/comment/0d07e615_47a8b253?us… :
PS1, Line 89: select SOC_INTEL_STORE_ISH_FW_VERSION if DRIVERS_INTEL_ISH
> update the config on
update the config on "BOARD_GOOGLE_BROX_COMMON"
--
To view, visit https://review.coreboot.org/c/coreboot/+/85580?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I31db0925a81b6ec68ee6afcb262e540ba7db206a
Gerrit-Change-Number: 85580
Gerrit-PatchSet: 4
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 16 Dec 2024 01:35:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Attention is currently required from: David Wu, Karthik Ramasubramanian, Marx Wang, Subrata Banik.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/85580?usp=email )
Change subject: mb/google/brox: Apply ISH_FW_VERSION in Kconfig
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85580/comment/fd271284_1afee40d?us… :
PS2, Line 16: form
> Nit: from
updated
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/85580/comment/3e810e11_95c99fb2?us… :
PS1, Line 89: select SOC_INTEL_STORE_ISH_FW_VERSION if DRIVERS_INTEL_ISH
> thanks for your remind. […]
update the config on
--
To view, visit https://review.coreboot.org/c/coreboot/+/85580?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I31db0925a81b6ec68ee6afcb262e540ba7db206a
Gerrit-Change-Number: 85580
Gerrit-PatchSet: 4
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 16 Dec 2024 01:34:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: David Wu, Karthik Ramasubramanian, Marx Wang, Subrata Banik.
Hello David Wu, Karthik Ramasubramanian, Marx Wang, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85580?usp=email
to look at the new patch set (#4).
Change subject: mb/google/brox: Apply ISH_FW_VERSION in Kconfig
......................................................................
mb/google/brox: Apply ISH_FW_VERSION in Kconfig
Apply ISH_FW_VERSION in Kconfig to improve boot time.
It won't do some ISH init task without the config on UFS sku and
cause boot to kernel time over 1.55 sec from G3 boot.
BUG=b:364971947
BRANCH=firmware-brox-16080.B
TEST=cbmem -c | grep "ISH version" -> ISH version: 5.4.2.7780
Boot to OS on jubilant, run bootperf test of G3 boot.
Confirm the test result is pass.
Change-Id: I31db0925a81b6ec68ee6afcb262e540ba7db206a
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/85580/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/85580?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I31db0925a81b6ec68ee6afcb262e540ba7db206a
Gerrit-Change-Number: 85580
Gerrit-PatchSet: 4
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: David Wu, Karthik Ramasubramanian, Marx Wang, Subrata Banik.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/85580?usp=email )
Change subject: mb/google/brox/var/jubilant: Apply ISH_FW_VERSION in Kconfig
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/85580/comment/1a15374e_e4a8014d?us… :
PS1, Line 89: select SOC_INTEL_STORE_ISH_FW_VERSION if DRIVERS_INTEL_ISH
> do you mind following the alphabetic order ?>
thanks for your remind.
fixed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85580?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I31db0925a81b6ec68ee6afcb262e540ba7db206a
Gerrit-Change-Number: 85580
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 16 Dec 2024 01:23:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: David Wu, Karthik Ramasubramanian, Marx Wang, Subrata Banik.
Hello David Wu, Karthik Ramasubramanian, Marx Wang, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85580?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/brox/var/jubilant: Apply ISH_FW_VERSION in Kconfig
......................................................................
mb/google/brox/var/jubilant: Apply ISH_FW_VERSION in Kconfig
Apply the ISH_FW_VERSION Kconfig to fix boot time over spec issue.
It won't do some ISH init task without the config on UFS sku and
cause boot to kernel time over 1.55 sec from G3 boot.
BUG=b:364971947
BRANCH=firmware-brox-16080.B
TEST=cbmem -c | grep "ISH version" -> ISH version: 5.4.2.7780
Boot to OS on jubilant, run bootperf test of G3 boot.
Confirm the test result is pass.
Change-Id: I31db0925a81b6ec68ee6afcb262e540ba7db206a
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/85580/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/85580?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I31db0925a81b6ec68ee6afcb262e540ba7db206a
Gerrit-Change-Number: 85580
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Hung-Te Lin, Vince Liu, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85598?usp=email )
Change subject: util/mtkheader: Add GFH header for mt8189 bootblock code
......................................................................
Patch Set 1:
(1 comment)
File util/mtkheader/gen-bl-img.py:
https://review.coreboot.org/c/coreboot/+/85598/comment/79db7832_a25e4d98?us… :
PS1, Line 27: 'mt8189': 0x02001000,
: 'mt8196': 0x02001000,
can we reuse mt8196's entry ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/85598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I47078272880a89e81c851ede307cdc306b1c79ac
Gerrit-Change-Number: 85598
Gerrit-PatchSet: 1
Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 16 Dec 2024 01:09:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No