coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[M] Change in coreboot[main]: mb/trulo/var/uldrenite: Enable eMMC and DLL tuning parameters
by John Su (Code Review) 15 Dec '24

15 Dec '24

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. John Su has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/85579?usp=email ) Change subject: mb/trulo/var/uldrenite: Enable eMMC and DLL tuning parameters ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/uldrenite/overridetree.cb: https://review.coreboot.org/c/coreboot/+/85579/comment/0955e664_2abdfe43?us… : PS1, Line 135: device ref shared_sram on end > Move it to another CL. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85579?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5f0fdb31ce4eaad5537df36c4165c404239a7bd4 Gerrit-Change-Number: 85579 Gerrit-PatchSet: 2 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Sun, 15 Dec 2024 14:58:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>

1 0

[M] Change in coreboot[main]: mb/trulo/var/uldrenite: Enable eMMC and DLL tuning parameters
by John Su (Code Review) 15 Dec '24

15 Dec '24

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, John Su, Nick Vaccaro, Subrata Banik. Hello Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85579?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/trulo/var/uldrenite: Enable eMMC and DLL tuning parameters ...................................................................... mb/trulo/var/uldrenite: Enable eMMC and DLL tuning parameters Enable eMMC and add DLL tuning parameters. BUG=b:380789023 TEST=emerge-nissa coreboot Change-Id: I5f0fdb31ce4eaad5537df36c4165c404239a7bd4 Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/uldrenite/overridetree.cb 1 file changed, 50 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/85579/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85579?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5f0fdb31ce4eaad5537df36c4165c404239a7bd4 Gerrit-Change-Number: 85579 Gerrit-PatchSet: 2 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[M] Change in coreboot[main]: mb/trulo/var/uldrenite: Enable DPTF, S0ix and configure FIVR setting
by John Su (Code Review) 15 Dec '24

15 Dec '24

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik. John Su has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/85578?usp=email ) Change subject: mb/trulo/var/uldrenite: Enable DPTF, S0ix and configure FIVR setting ...................................................................... Patch Set 3: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85578/comment/3c06e490_1921743f?us… : PS2, Line 7: Power management and external Settings > Please make it a statement. For example: […] Done https://review.coreboot.org/c/coreboot/+/85578/comment/21e64a4e_d53dbb5a?us… : PS2, Line 9: dptf > DPTF Done https://review.coreboot.org/c/coreboot/+/85578/comment/aa779f3d_1b1dcf8f?us… : PS2, Line 10: s0ix > S0ix Done https://review.coreboot.org/c/coreboot/+/85578/comment/f3ff74e5_037dae33?us… : PS2, Line 9: 1. Enable dptf : 2. Enable s0ix : 3. Configure external fivr setting > Enumerating items is always a good indicator, that the commit should be split up in smaller pieces. Acknowledged https://review.coreboot.org/c/coreboot/+/85578/comment/f77f76d6_f6861a77?us… : PS2, Line 14: TEST=emerge-nissa coreboot > Do you have access to the device already? Not yet, these are initial value settings based on the reference design and the experience of our other teams. File src/mainboard/google/brya/variants/uldrenite/overridetree.cb: https://review.coreboot.org/c/coreboot/+/85578/comment/a4156c55_d2220271?us… : PS2, Line 85: #DPTF > Add a space after #? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85578?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id7777b7560b40c1427df9645d991240c027e58e4 Gerrit-Change-Number: 85578 Gerrit-PatchSet: 3 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Sun, 15 Dec 2024 14:55:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: mb/trulo/var/uldrenite: Enable DPTF, S0ix and configure FIVR setting
by John Su (Code Review) 15 Dec '24

15 Dec '24

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85578?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/trulo/var/uldrenite: Enable DPTF, S0ix and configure FIVR setting ...................................................................... mb/trulo/var/uldrenite: Enable DPTF, S0ix and configure FIVR setting 1. Enable DPTF 2. Enable S0ix 3. Configure external fivr setting BUG=b:380789023 TEST=emerge-nissa coreboot Change-Id: Id7777b7560b40c1427df9645d991240c027e58e4 Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/uldrenite/overridetree.cb 1 file changed, 83 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/85578/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85578?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id7777b7560b40c1427df9645d991240c027e58e4 Gerrit-Change-Number: 85578 Gerrit-PatchSet: 3 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[S] Change in coreboot[main]: amdfwtool: Add function to check A/B recovery capability
by Bao Zheng (Code Review) 15 Dec '24

15 Dec '24

Attention is currently required from: Bao Zheng, Zheng Bao. Hello Zheng Bao, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84534?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: amdfwtool: Add function to check A/B recovery capability ...................................................................... amdfwtool: Add function to check A/B recovery capability Change-Id: I491d106bac94698419cbb5ec269e51421250e3a6 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h 2 files changed, 23 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/84534/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/84534?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I491d106bac94698419cbb5ec269e51421250e3a6 Gerrit-Change-Number: 84534 Gerrit-PatchSet: 9 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao

1 0

[M] Change in coreboot[main]: amdfwtool: Split the A/B level 2 with PSP level 1
by Bao Zheng (Code Review) 15 Dec '24

15 Dec '24

Attention is currently required from: Bao Zheng, Zheng Bao. Hello Zheng Bao, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85467?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: amdfwtool: Split the A/B level 2 with PSP level 1 ...................................................................... amdfwtool: Split the A/B level 2 with PSP level 1 For later A/B recovery support, we put the A and B into seperated regions. The ROMSIG and PSP L2 table are in another region. Then, We split one amdfw.rom into three parts. Change-Id: Ie9230e333dc5b1eca5beee1d3a57e815764c3cf3 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/handle_file.c M util/amdfwtool/opts.c 4 files changed, 64 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/85467/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85467?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9230e333dc5b1eca5beee1d3a57e815764c3cf3 Gerrit-Change-Number: 85467 Gerrit-PatchSet: 3 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao

1 0

[S] Change in coreboot[main]: amdfwtool: Add injection corruption to call if necessary
by Bao Zheng (Code Review) 15 Dec '24

15 Dec '24

Attention is currently required from: Bao Zheng, Zheng Bao. Hello Zheng Bao, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84579?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: amdfwtool: Add injection corruption to call if necessary ...................................................................... amdfwtool: Add injection corruption to call if necessary Change-Id: I5be9456ad8b76c1b6b3975248ea18306acfa3e99 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c 1 file changed, 31 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/84579/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/84579?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5be9456ad8b76c1b6b3975248ea18306acfa3e99 Gerrit-Change-Number: 84579 Gerrit-PatchSet: 8 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao

1 0

[XS] Change in coreboot[main]: [test] add some warnings to Makefile
by Elyes Haouas (Code Review) 15 Dec '24

15 Dec '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/85596?usp=email ) Change subject: [test] add some warnings to Makefile ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/85596?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2cc91d0b8b8ef0cc44954b4712dde8c486787467 Gerrit-Change-Number: 85596 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: [test] add some warnings to Makefile
by Elyes Haouas (Code Review) 15 Dec '24

15 Dec '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85596?usp=email ) Change subject: [test] add some warnings to Makefile ...................................................................... [test] add some warnings to Makefile Change-Id: I2cc91d0b8b8ef0cc44954b4712dde8c486787467 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/85596/1 diff --git a/Makefile.mk b/Makefile.mk index ca79d05..51dc3bd 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -534,7 +534,7 @@ CFLAGS_common += -Wstring-compare ifeq ($(CONFIG_COMPILER_GCC),y) CFLAGS_common += -Wold-style-declaration -CFLAGS_common += -Wcast-function-type +CFLAGS_common += -Wcast-function-type -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations # Don't add these GCC specific flags when running scan-build ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),) CFLAGS_common += -Wno-packed-not-aligned -- To view, visit https://review.coreboot.org/c/coreboot/+/85596?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2cc91d0b8b8ef0cc44954b4712dde8c486787467 Gerrit-Change-Number: 85596 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Keep image clock configuration enable
by Paul Menzel (Code Review) 15 Dec '24

15 Dec '24

Paul Menzel has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85588?usp=email ) Change subject: soc/intel/pantherlake: Keep image clock configuration enable ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85588/comment/de78b3a8_57a4cc4a?us… : PS2, Line 7: soc/intel/pantherlake: Keep image clock configuration enable enabled? -- To view, visit https://review.coreboot.org/c/coreboot/+/85588?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ieb022e6dc0b64106ff30f56cd17f9f219276785f Gerrit-Change-Number: 85588 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 15 Dec 2024 04:43:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024